Refactor reportable_url helper to focus on just the title choices.

[rails.git] / app / helpers / issues_helper.rb

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 7e9e233df064eea7faf89bf64759ed250a7340ea..456507d4caa1856963c2e391c9795cef653cc6a1 100644 (file)
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -1,25 +1,48 @@
 module IssuesHelper
+  def reportable_url(reportable)
+    class_name = reportable.class.name
+    case class_name
+    when "DiaryEntry"
+      link_to reportable.title, :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.user.display_name, :id => reportable.id
+    when "User"
+      link_to reportable.display_name.to_s, :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.display_name
+    when "DiaryComment"
+      link_to "#{reportable.diary_entry.title}, Comment id ##{reportable.id}", :controller => reportable.diary_entry.class.name.underscore, :action => :view, :display_name => reportable.diary_entry.user.display_name, :id => reportable.diary_entry.id, :anchor => "comment#{reportable.id}"
+    when "Changeset"
+      link_to "Changeset ##{reportable.id}", :controller => :browse, :action => :changeset, :id => reportable.id
+    when "Note"
+      link_to "Note ##{reportable.id}", :controller => :browse, :action => :note, :id => reportable.id
+    end
+  end
 
-       def reportable_url(reportable)
-               class_name = reportable.class.name
-               case class_name
-               when "DiaryEntry"
-                       link_to reportable.title,       :controller => reportable.class.name.underscore,
-                                                                                                                               :action => :view,
-                                                                                                                               :display_name => reportable.user.display_name,
-                                                                                                                               :id => reportable.id
-               when "User"
-                       link_to reportable.display_name,        :controller => reportable.class.name.underscore,
-                                                                                                                                                               :action => "view",
-                                                                                                                                                               :display_name => reportable.diary_entry.user.display_name
-               when "DiaryComment"
-                       link_to "#{reportable.diary_entry.title} Comment id ##{reportable.id}", :controller => reportable.diary_entry.class.name.underscore,
-                                                                                                               :action => :view,
-                                                                                                               :display_name => reportable.diary_entry.user.display_name,
-                                                                                                               :id => reportable.id
+  def reportable_title(reportable)
+    case reportable
+    when DiaryEntry
+      reportable.title
+    when User
+      reportable.display_name
+    when DiaryComment
+      "#{reportable.diary_entry.title}, Comment id ##{reportable.id}"
+    when Changeset
+      "Changeset ##{reportable.id}"
+    when Note
+      "Note ##{reportable.id}"
+    end
+  end
 
-               else
-                       nil
-               end
-       end
+  def instance_url(reportable)
+    class_name = reportable.class.name
+    case class_name
+    when "DiaryEntry"
+      link_to "Show Instance", :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.user.display_name, :id => reportable.id
+    when "User"
+      link_to "Show Instance", :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.display_name
+    when "DiaryComment"
+      link_to "Show Instance", :controller => reportable.diary_entry.class.name.underscore, :action => :view, :display_name => reportable.diary_entry.user.display_name, :id => reportable.diary_entry.id, :anchor => "comment#{reportable.id}"
+    when "Changeset"
+      link_to "Show Instance", :controller => :browse, :action => :changeset, :id => reportable.id
+    when "Note"
+      link_to "Show Instance", :controller => :browse, :action => :note, :id => reportable.id
+    end
+  end
 end