Fix the CrossSiteScripting warnings from Brakeman

[rails.git] / lib / osm.rb

diff --git a/lib/osm.rb b/lib/osm.rb
index bc3eb48c5bcaf71034ff670d36546fb27c67a353..1d3700cd925edb69aefeadfef236049926a9565a 100644 (file)
--- a/lib/osm.rb
+++ b/lib/osm.rb
@@ -513,15 +513,8 @@ module OSM
   def self.ip_to_country(ip_address)
     ipinfo = maxmind_database.lookup(ip_address) if Settings.key?(:maxmind_database)
 
-    if ipinfo.found?
-      country = ipinfo.country.iso_code
-    else
-      country = http_client.get("https://api.hostip.info/country.php?ip=#{ip_address}").body
-      country = "GB" if country == "UK"
-    end
+    return ipinfo.country.iso_code if ipinfo&.found?
 
-    country
-  rescue StandardError
     nil
   end
 
@@ -567,7 +560,7 @@ module OSM
   def self.legal_text_for_country(country_code)
     file_name = Rails.root.join("config", "legales", country_code.to_s + ".yml")
     file_name = Rails.root.join("config", "legales", Settings.default_legale + ".yml") unless File.exist? file_name
-    YAML.load_file(file_name)
+    YAML.load_file(file_name).transform_values!(&:html_safe)
   end
 
   # Return the HTTP client to use