Tidy up the note model a bit

[rails.git] / app / models / note.rb

diff --git a/app/models/note.rb b/app/models/note.rb
index e36884ec16d32bd3bb6f1f59f6385b5d9fdd9c76..0512639e15c5ac4ebf75ff123517013991a7bd79 100644 (file)
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -12,21 +12,26 @@ class Note < ActiveRecord::Base
   validates_numericality_of :longitude, :only_integer => true
   validates_presence_of :closed_at if :status == "closed"
   validates_inclusion_of :status, :in => ["open", "closed", "hidden"]
   validates_numericality_of :longitude, :only_integer => true
   validates_presence_of :closed_at if :status == "closed"
   validates_inclusion_of :status, :in => ["open", "closed", "hidden"]

+  validate :validate_position

 
 

-  def self.create_bug(lat, lon)
-    note = Note.new(:lat => lat, :lon => lon, :status => "open")
-    raise OSM::APIBadUserInput.new("The note is outside this world") unless note.in_world?
+  # Sanity check the latitude and longitude and add an error if it's broken
+  def validate_position
+    errors.add_to_base("Note is not in the world") unless in_world?
+  end

 
 

-    return note
+  # Fill in default values for new notes
+  def after_initialize
+    self.status = "open" unless self.attribute_present?(:status)

   end
 
   end
 

+  # Close a note

   def close
     self.status = "closed"
     self.closed_at = Time.now.getutc
   def close
     self.status = "closed"
     self.closed_at = Time.now.getutc

-

     self.save
   end
 
     self.save
   end
 

+  # Return a flattened version of the comments for a note

   def flatten_comment(separator_char, upto_timestamp = :nil)
     resp = ""
     comment_no = 1
   def flatten_comment(separator_char, upto_timestamp = :nil)
     resp = ""
     comment_no = 1


@@ -43,22 +48,27 @@ class Note < ActiveRecord::Base
     return resp
   end
 
     return resp
   end
 

-  def visible
+  # Check if a note is visible
+  def visible?

     return status != "hidden"
   end
 
     return status != "hidden"
   end
 

+  # Return the author object, derived from the first comment

   def author
     self.comments.first.author
   end
 
   def author
     self.comments.first.author
   end
 

+  # Return the author IP address, derived from the first comment

   def author_ip
     self.comments.first.author_ip
   end
 
   def author_ip
     self.comments.first.author_ip
   end
 

+  # Return the author id, derived from the first comment

   def author_id
     self.comments.first.author_id
   end
 
   def author_id
     self.comments.first.author_id
   end
 

+  # Return the author name, derived from the first comment

   def author_name
     self.comments.first.author_name
   end
   def author_name
     self.comments.first.author_name
   end