Remove unnecessary appendTo() that is undone by append() right away

[rails.git] / app / assets / javascripts / leaflet.share.js

diff --git a/app/assets/javascripts/leaflet.share.js b/app/assets/javascripts/leaflet.share.js
index c4a5d026580df296205c3c2bb86799bd292b773e..e941a70f41ae2a492e522b7c689dbfa4557244bf 100644 (file)
--- a/app/assets/javascripts/leaflet.share.js
+++ b/app/assets/javascripts/leaflet.share.js
@@ -1,38 +1,12 @@
 L.OSM.share = function (options) {
-  var control = L.control(options),
+  var control = L.OSM.sidebarPane(options, "share", "javascripts.share.title", "javascripts.share.title"),
       marker = L.marker([0, 0], { draggable: true }),
       locationFilter = new L.LocationFilter({
         enableButton: false,
         adjustButton: false
       });
 
-  control.onAdd = function (map) {
-    var $container = $("<div>")
-      .attr("class", "control-share");
-
-    var button = $("<a>")
-      .attr("class", "control-button")
-      .attr("href", "#")
-      .attr("title", I18n.t("javascripts.share.title"))
-      .html("<span class=\"icon share\"></span>")
-      .on("click", toggle)
-      .appendTo($container);
-
-    var $ui = $("<div>")
-      .attr("class", "share-ui");
-
-    $("<div>")
-      .attr("class", "sidebar_heading")
-      .appendTo($ui)
-      .append(
-        $("<span>")
-          .text(I18n.t("javascripts.close"))
-          .attr("class", "icon close")
-          .bind("click", toggle))
-      .append(
-        $("<h4>")
-          .text(I18n.t("javascripts.share.title")));
-
+  control.onAddPane = function (map, button, $ui) {
     // Link / Embed
 
     var $linkSection = $("<div>")
@@ -44,19 +18,20 @@ L.OSM.share = function (options) {
       .appendTo($linkSection);
 
     var $form = $("<form>")
-      .attr("class", "standard-form")
       .appendTo($linkSection);
 
     $("<div>")
-      .attr("class", "standard-form-row")
+      .attr("class", "form-check mb-3")
       .appendTo($form)
       .append(
         $("<label>")
           .attr("for", "link_marker")
+          .attr("class", "form-check-label")
           .append(
             $("<input>")
               .attr("id", "link_marker")
               .attr("type", "checkbox")
+              .attr("class", "form-check-input")
               .bind("change", toggleMarker))
           .append(I18n.t("javascripts.share.include_marker")));
 
@@ -91,7 +66,7 @@ L.OSM.share = function (options) {
       });
 
     $("<div>")
-      .attr("class", "standard-form-row share-tab")
+      .attr("class", "share-tab")
       .css("display", "block")
       .appendTo($form)
       .append($("<input>")
@@ -100,7 +75,7 @@ L.OSM.share = function (options) {
         .on("click", select));
 
     $("<div>")
-      .attr("class", "standard-form-row share-tab")
+      .attr("class", "share-tab")
       .appendTo($form)
       .append($("<input>")
         .attr("id", "short_input")
@@ -108,7 +83,7 @@ L.OSM.share = function (options) {
         .on("click", select));
 
     $("<div>")
-      .attr("class", "standard-form-row share-tab")
+      .attr("class", "share-tab")
       .appendTo($form)
       .append(
         $("<textarea>")
@@ -117,8 +92,7 @@ L.OSM.share = function (options) {
       .append(
         $("<p>")
           .attr("class", "text-muted")
-          .text(I18n.t("javascripts.share.paste_html"))
-          .appendTo($linkSection));
+          .text(I18n.t("javascripts.share.paste_html")));
 
     // Geo URI
 
@@ -153,26 +127,26 @@ L.OSM.share = function (options) {
 
     $form = $("<form>")
       .attr("id", "export-image")
-      .attr("class", "standard-form")
       .attr("action", "/export/finish")
       .attr("method", "post")
       .appendTo($imageSection);
 
     $("<div>")
-      .attr("class", "standard-form-row")
+      .attr("class", "mb-3 form-check")
       .appendTo($form)
       .append(
         $("<label>")
           .attr("for", "image_filter")
+          .attr("class", "form-check-label")
           .append(
             $("<input>")
               .attr("id", "image_filter")
               .attr("type", "checkbox")
+              .attr("class", "form-check-input")
               .bind("change", toggleFilter))
           .append(I18n.t("javascripts.share.custom_dimensions")));
 
     $("<div>")
-      .attr("class", "standard-form-row")
       .appendTo($form)
       .append(
         $("<label>")
@@ -187,7 +161,6 @@ L.OSM.share = function (options) {
         .append($("<option>").val("pdf").text("PDF")));
 
     $("<div>")
-      .attr("class", "standard-form-row")
       .appendTo($form)
       .append($("<label>")
         .attr("for", "mapnik_scale")
@@ -222,13 +195,19 @@ L.OSM.share = function (options) {
       .attr("type", "hidden")
       .appendTo($form);
 
+    var args = {
+      width: "<span id=\"mapnik_image_width\"></span>",
+      height: "<span id=\"mapnik_image_height\"></span>"
+    };
+
     $("<p>")
       .attr("class", "text-muted")
-      .html(I18n.t("javascripts.share.image_size") + " <span id=\"mapnik_image_width\"></span> x <span id=\"mapnik_image_height\"></span>")
+      .html(I18n.t("javascripts.share.image_dimensions", args))
       .appendTo($form);
 
     $("<input>")
       .attr("type", "submit")
+      .attr("class", "btn btn-primary")
       .attr("value", I18n.t("javascripts.share.download"))
       .appendTo($form);
 
@@ -240,11 +219,15 @@ L.OSM.share = function (options) {
     map.on("move", movedMap);
     map.on("moveend layeradd layerremove", update);
 
-    options.sidebar.addPane($ui);
-
     $ui
+      .on("show", shown)
       .on("hide", hidden);
 
+    function shown() {
+      $("#mapnik_scale").val(getScale());
+      update();
+    }
+
     function hidden() {
       map.removeLayer(marker);
       map.options.scrollWheelZoom = map.options.doubleClickZoom = true;
@@ -252,18 +235,6 @@ L.OSM.share = function (options) {
       update();
     }
 
-    function toggle(e) {
-      e.stopPropagation();
-      e.preventDefault();
-
-      $("#mapnik_scale").val(getScale());
-      marker.setLatLng(map.getCenter());
-
-      update();
-      options.sidebar.togglePane($ui, button);
-      $(".leaflet-control .control-button").tooltip("hide");
-    }
-
     function toggleMarker() {
       if ($(this).is(":checked")) {
         marker.setLatLng(map.getCenter());
@@ -408,8 +379,6 @@ L.OSM.share = function (options) {
       var precision = 5 * Math.pow(10, Math.floor(Math.LOG10E * Math.log(scale)) - 2);
       return precision * Math.ceil(scale / precision);
     }
-
-    return $container[0];
   };
 
   return control;