Merge pull request #3700 from AntonKhorev/about

[rails.git] / app / models / client_application.rb

diff --git a/app/models/client_application.rb b/app/models/client_application.rb
index 90523a2655ebb60dc45d93e6cff85f330e93191d..d9d6b2df8ca60d11ecfe404d1bc6ef94cfe7178f 100644 (file)
--- a/app/models/client_application.rb
+++ b/app/models/client_application.rb
@@ -30,10 +30,8 @@
 #  client_applications_user_id_fkey  (user_id => users.id)
 #
 
 #  client_applications_user_id_fkey  (user_id => users.id)
 #
 

-require "oauth"
-
-class ClientApplication < ActiveRecord::Base
-  belongs_to :user
+class ClientApplication < ApplicationRecord
+  belongs_to :user, :optional => true

   has_many :tokens, :class_name => "OauthToken", :dependent => :delete_all
   has_many :access_tokens
   has_many :oauth2_verifiers
   has_many :tokens, :class_name => "OauthToken", :dependent => :delete_all
   has_many :access_tokens
   has_many :oauth2_verifiers


@@ -41,9 +39,9 @@ class ClientApplication < ActiveRecord::Base
 
   validates :key, :presence => true, :uniqueness => true
   validates :name, :url, :secret, :presence => true
 
   validates :key, :presence => true, :uniqueness => true
   validates :name, :url, :secret, :presence => true

-  validates :url, :format => %r{\Ahttp(s?)://(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(/|/([\w#!:.?+=&%@!\-/]))?}i
-  validates :support_url, :allow_blank => true, :format => %r{\Ahttp(s?)://(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(/|/([\w#!:.?+=&%@!\-/]))?}i
-  validates :callback_url, :allow_blank => true, :format => %r{\A[a-z][a-z0-9.+-]*://(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(/|/([\w#!:.?+=&%@!\-/]))?}i
+  validates :url, :format => /\A#{URI::DEFAULT_PARSER.make_regexp(%w[http https])}\z/
+  validates :support_url, :allow_blank => true, :format => /\A#{URI::DEFAULT_PARSER.make_regexp(%w[http https])}\z/
+  validates :callback_url, :allow_blank => true, :format => /\A#{URI::DEFAULT_PARSER.make_regexp}\z/

 
   before_validation :generate_keys, :on => :create
 
 
   before_validation :generate_keys, :on => :create
 


@@ -51,31 +49,31 @@ class ClientApplication < ActiveRecord::Base
 
   def self.find_token(token_key)
     token = OauthToken.includes(:client_application).find_by(:token => token_key)
 
   def self.find_token(token_key)
     token = OauthToken.includes(:client_application).find_by(:token => token_key)

-    token if token && token.authorized?
+    token if token&.authorized?

   end
 
   def self.verify_request(request, options = {}, &block)
     signature = OAuth::Signature.build(request, options, &block)
     return false unless OauthNonce.remember(signature.request.nonce, signature.request.timestamp)
   end
 
   def self.verify_request(request, options = {}, &block)
     signature = OAuth::Signature.build(request, options, &block)
     return false unless OauthNonce.remember(signature.request.nonce, signature.request.timestamp)

-    value = signature.verify
-    value
+
+    signature.verify

   rescue OAuth::Signature::UnknownSignatureMethod
     false
   end
 
   def self.all_permissions
   rescue OAuth::Signature::UnknownSignatureMethod
     false
   end
 
   def self.all_permissions

-    PERMISSIONS
+    Oauth.scopes.collect { |s| :"allow_#{s.name}" }

   end
 
   def oauth_server
   end
 
   def oauth_server

-    @oauth_server ||= OAuth::Server.new("http://" + SERVER_URL)
+    @oauth_server ||= OAuth::Server.new("https://#{Settings.server_url}")

   end
 
   def credentials
   end
 
   def credentials

-    @oauth_client ||= OAuth::Consumer.new(key, secret)
+    @credentials ||= OAuth::Consumer.new(key, secret)

   end
 
   end
 

-  def create_request_token(params = {})
+  def create_request_token(_params = {})

     params = { :client_application => self, :callback_url => token_callback_url }
     permissions.each do |p|
       params[p] = true
     params = { :client_application => self, :callback_url => token_callback_url }
     permissions.each do |p|
       params[p] = true


@@ -104,11 +102,6 @@ class ClientApplication < ActiveRecord::Base
 
   protected
 
 
   protected
 

-  # this is the set of permissions that the client can ask for. clients
-  # have to say up-front what permissions they want and when users sign up they
-  # can agree or not agree to each of them.
-  PERMISSIONS = [:allow_read_prefs, :allow_write_prefs, :allow_write_diary, :allow_write_api, :allow_read_gpx, :allow_write_gpx, :allow_write_notes].freeze
-

   def generate_keys
     self.key = OAuth::Helper.generate_key(40)[0, 40]
     self.secret = OAuth::Helper.generate_key(40)[0, 40]
   def generate_keys
     self.key = OAuth::Helper.generate_key(40)[0, 40]
     self.secret = OAuth::Helper.generate_key(40)[0, 40]