end
def test_read_changeset_hidden_comments
- create_list(:changeset_comment, 3)
- create(:changeset_comment, :visible => false)
+ changeset = create(:changeset)
+ create_list(:changeset_comment, 3, :changeset => changeset)
+ create(:changeset_comment, :visible => false, :changeset => changeset)
- browse_check "changeset", changesets(:normal_user_closed_change).id, "browse/changeset"
+ browse_check "changeset", changeset.id, "browse/changeset"
assert_select "div.changeset-comments ul li", :count => 3
session[:user] = create(:moderator_user).id
- browse_check "changeset", changesets(:normal_user_closed_change).id, "browse/changeset"
+ browse_check "changeset", changeset.id, "browse/changeset"
assert_select "div.changeset-comments ul li", :count => 4
end
sequence(:body) { |n| "Changeset comment #{n}" }
visible true
- # FIXME: needs changeset factory
- changeset_id 3
+ changeset
association :author, :factory => :user
end
--- /dev/null
+FactoryGirl.define do
+ factory :changeset do
+ created_at Time.now.utc
+ closed_at Time.now.utc + 1.day
+
+ user
+ end
+end
latitude 1 * GeoRecord::SCALE
longitude 1 * GeoRecord::SCALE
- # FIXME: needs changeset factory
- changeset_id 1
+ changeset
# FIXME: needs node factory
node_id 1000
require "test_helper"
class ChangesetHelperTest < ActionView::TestCase
- fixtures :changesets, :users
-
def test_changeset_user_link
- assert_equal "<a href=\"/user/test2\">test2</a>", changeset_user_link(changesets(:public_user_first_change))
- assert_equal "anonymous", changeset_user_link(changesets(:normal_user_first_change))
- assert_equal "deleted", changeset_user_link(changesets(:deleted_user_first_change))
+ changeset = create(:changeset)
+ assert_equal %(<a href="/user/#{URI.encode(changeset.user.display_name)}">#{changeset.user.display_name}</a>), changeset_user_link(changeset)
+
+ changeset = create(:changeset, :user => create(:user, :data_public => false))
+ assert_equal "anonymous", changeset_user_link(changeset)
+
+ changeset = create(:changeset, :user => create(:user, :deleted))
+ assert_equal "deleted", changeset_user_link(changeset)
end
def test_changeset_details
- assert_match %r{^Created <abbr title='Mon, 01 Jan 2007 00:00:00 \+0000'>.*</abbr> by anonymous$}, changeset_details(changesets(:normal_user_first_change))
- assert_match %r{^Closed <abbr title='Created: Mon, 01 Jan 2007 00:00:00 \+0000 Closed: Tue, 02 Jan 2007 00:00:00 \+0000'>.*</abbr> by <a href="/user/test2">test2</a>$}, changeset_details(changesets(:public_user_closed_change))
+ changeset = create(:changeset, :created_at => Time.utc(2007, 1, 1, 0, 0, 0), :user => create(:user, :data_public => false))
+ # We need to explicitly reset the closed_at to some point in the future, and avoid the before_save callback
+ changeset.update_column(:closed_at, Time.now.utc + 1.day) # rubocop:disable Rails/SkipsModelValidations
+
+ assert_match %r{^Created <abbr title='Mon, 01 Jan 2007 00:00:00 \+0000'>.*</abbr> by anonymous$}, changeset_details(changeset)
+
+ changeset = create(:changeset, :created_at => Time.utc(2007, 1, 1, 0, 0, 0), :closed_at => Time.utc(2007, 1, 2, 0, 0, 0))
+ user_link = %(<a href="/user/#{URI.encode(changeset.user.display_name)}">#{changeset.user.display_name}</a>)
+
+ assert_match %r{^Closed <abbr title='Created: Mon, 01 Jan 2007 00:00:00 \+0000 Closed: Tue, 02 Jan 2007 00:00:00 \+0000'>.*</abbr> by #{user_link}$}, changeset_details(changeset)
end
end
end
def test_comments_of_changeset_count
- create_list(:changeset_comment, 3, :changeset_id => changesets(:normal_user_closed_change).id)
- assert_equal 3, Changeset.find(changesets(:normal_user_closed_change).id).comments.count
+ changeset = create(:changeset)
+ create_list(:changeset_comment, 3, :changeset_id => changeset.id)
+ assert_equal 3, Changeset.find(changeset.id).comments.count
end
def test_body_valid
require "test_helper"
class ChangesetTest < ActiveSupport::TestCase
- api_fixtures
-
- def test_changeset_count
- assert_equal 9, Changeset.count
- end
-
def test_from_xml_no_text
no_text = ""
message_create = assert_raise(OSM::APIBadXMLError) do
# Check that you can create a node and store it
def test_create
+ changeset = create(:changeset)
node_template = Node.new(
:latitude => 12.3456,
:longitude => 65.4321,
- :changeset_id => changesets(:normal_user_first_change).id,
+ :changeset_id => changeset.id,
:visible => 1,
:version => 1
)
- assert node_template.create_with_history(changesets(:normal_user_first_change).user)
+ assert node_template.create_with_history(changeset.user)
node = Node.find(node_template.id)
assert_not_nil node