Use join to construct tag strings instead of mucking around counting

position in the string.

diff --git a/app/views/trace/_trace.html.erb b/app/views/trace/_trace.html.erb
index d38fa2f4c74fee873560a4bff508148c96d507ee..4cd40352a456849e1ad91a4da5776dd99e194255 100644 (file)
--- a/app/views/trace/_trace.html.erb
+++ b/app/views/trace/_trace.html.erb
@@ -27,9 +27,7 @@
     <%= t'trace.trace.by' %> <%=link_to h(trace.user.display_name), {:controller => 'user', :action => 'view', :display_name => trace.user.display_name} %>
     <% if !trace.tags.empty? %>
       <%= t'trace.trace.in' %> 
-      <% trace.tags.each_with_index do |tag, index| %>
-        <%= link_to_tag tag.tag %><%=', ' if index+1 < trace.tags.count %>
-      <% end %>
+      <%= trace.tags.collect { |tag| link_to_tag tag.tag }.join(", ") %>
     <% end %>
   </td>
 </tr>

diff --git a/app/views/trace/view.html.erb b/app/views/trace/view.html.erb
index 1001cadf9fdf241564523cc91d263a8cb400ff23..4ab46bd3ef5de04b7dda87d5d27fc1589af83090 100644 (file)
--- a/app/views/trace/view.html.erb
+++ b/app/views/trace/view.html.erb
@@ -36,9 +36,7 @@
     <td><%= t'trace.view.tags' %></td>
     <td>
     <% unless @trace.tags.empty? %>
-      <% @trace.tags.each_with_index do |tag, index| %>
-        <%= link_to tag.tag, { :controller => 'trace', :action => 'list', :tag => tag.tag, :id => nil } %><%=', ' if index+1 < @trace.tags.count %>
-      <% end %>
+      <%= @trace.tags.collect { |tag| link_to tag.tag, { :controller => 'trace', :action => 'list', :tag => tag.tag, :id => nil } }.join(", ") %>
     <% else %>
       <i><%= t'trace.view.none' %></i>
     <% end %>