Mark account suspended flash message as HTML safe

Fixes #1590

diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index 82373c90a791a7507977626967c25e1b2f2e5940..f80df8623623cf3e4693d8d33217542149c64e7a 100644 (file)
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -547,7 +547,7 @@ class UserController < ApplicationController
         when "active", "confirmed" then
           successful_login(user, request.env["omniauth.params"]["referer"])
         when "suspended" then
         when "active", "confirmed" then
           successful_login(user, request.env["omniauth.params"]["referer"])
         when "suspended" then

-          failed_login t("user.login.account is suspended", :webmaster => "mailto:#{SUPPORT_EMAIL}")
+          failed_login t("user.login.account is suspended", :webmaster => "mailto:#{SUPPORT_EMAIL}").html_safe

         else
           failed_login t("user.login.auth failure")
         end
         else
           failed_login t("user.login.auth failure")
         end


@@ -575,7 +575,7 @@ class UserController < ApplicationController
     elsif user = User.authenticate(:username => username, :password => password, :pending => true)
       unconfirmed_login(user)
     elsif User.authenticate(:username => username, :password => password, :suspended => true)
     elsif user = User.authenticate(:username => username, :password => password, :pending => true)
       unconfirmed_login(user)
     elsif User.authenticate(:username => username, :password => password, :suspended => true)

-      failed_login t("user.login.account is suspended", :webmaster => "mailto:#{SUPPORT_EMAIL}"), username
+      failed_login t("user.login.account is suspended", :webmaster => "mailto:#{SUPPORT_EMAIL}").html_safe, username

     else
       failed_login t("user.login.auth failure"), username
     end
     else
       failed_login t("user.login.auth failure"), username
     end

diff --git a/test/integration/user_login_test.rb b/test/integration/user_login_test.rb
index 538c039993135975eeb3d2a228f2f153081e93fe..2c3e61be67aeef01a5e88752bcc03789d9726bed 100644 (file)
--- a/test/integration/user_login_test.rb
+++ b/test/integration/user_login_test.rb
@@ -113,7 +113,9 @@ class UserLoginTest < ActionDispatch::IntegrationTest
 
     assert_template "login"
     assert_select "span.username", false
 
     assert_template "login"
     assert_select "span.username", false

-    assert_select "div.flash.error", /your account has been suspended/
+    assert_select "div.flash.error", /your account has been suspended/ do
+      assert_select "a[href='mailto:openstreetmap@example.com']", "webmaster"
+    end

   end
 
   def test_login_email_password_suspended_upcase
   end
 
   def test_login_email_password_suspended_upcase


@@ -123,7 +125,9 @@ class UserLoginTest < ActionDispatch::IntegrationTest
 
     assert_template "login"
     assert_select "span.username", false
 
     assert_template "login"
     assert_select "span.username", false

-    assert_select "div.flash.error", /your account has been suspended/
+    assert_select "div.flash.error", /your account has been suspended/ do
+      assert_select "a[href='mailto:openstreetmap@example.com']", "webmaster"
+    end

   end
 
   def test_login_email_password_suspended_titlecase
   end
 
   def test_login_email_password_suspended_titlecase


@@ -133,7 +137,9 @@ class UserLoginTest < ActionDispatch::IntegrationTest
 
     assert_template "login"
     assert_select "span.username", false
 
     assert_template "login"
     assert_select "span.username", false

-    assert_select "div.flash.error", /your account has been suspended/
+    assert_select "div.flash.error", /your account has been suspended/ do
+      assert_select "a[href='mailto:openstreetmap@example.com']", "webmaster"
+    end

   end
 
   def test_login_email_password_blocked
   end
 
   def test_login_email_password_blocked


@@ -264,7 +270,9 @@ class UserLoginTest < ActionDispatch::IntegrationTest
 
     assert_template "login"
     assert_select "span.username", false
 
     assert_template "login"
     assert_select "span.username", false

-    assert_select "div.flash.error", /your account has been suspended/
+    assert_select "div.flash.error", /your account has been suspended/ do
+      assert_select "a[href='mailto:openstreetmap@example.com']", "webmaster"
+    end

   end
 
   def test_login_username_password_suspended_upcase
   end
 
   def test_login_username_password_suspended_upcase


@@ -274,7 +282,9 @@ class UserLoginTest < ActionDispatch::IntegrationTest
 
     assert_template "login"
     assert_select "span.username", false
 
     assert_template "login"
     assert_select "span.username", false

-    assert_select "div.flash.error", /your account has been suspended/
+    assert_select "div.flash.error", /your account has been suspended/ do
+      assert_select "a[href='mailto:openstreetmap@example.com']", "webmaster"
+    end

   end
 
   def test_login_username_password_suspended_downcase
   end
 
   def test_login_username_password_suspended_downcase


@@ -284,7 +294,9 @@ class UserLoginTest < ActionDispatch::IntegrationTest
 
     assert_template "login"
     assert_select "span.username", false
 
     assert_template "login"
     assert_select "span.username", false

-    assert_select "div.flash.error", /your account has been suspended/
+    assert_select "div.flash.error", /your account has been suspended/ do
+      assert_select "a[href='mailto:openstreetmap@example.com']", "webmaster"
+    end

   end
 
   def test_login_username_password_blocked
   end
 
   def test_login_username_password_blocked