Don't bother deleting points which don't exist before importing a
authorTom Hughes <tom@compton.nu>
Tue, 4 Sep 2007 16:22:03 +0000 (16:22 +0000)
committerTom Hughes <tom@compton.nu>
Tue, 4 Sep 2007 16:22:03 +0000 (16:22 +0000)
trace - this avoids locking the table in the common case where there
are no points to delete.

app/models/trace.rb

index c189c035ec8fb3e4812c52d2d07d659c9a615b92..a2bebf1dd691565bcdf893cd67b450572f0838e3 100644 (file)
@@ -175,7 +175,12 @@ class Trace < ActiveRecord::Base
       f_lon = 0
       first = true
 
-      Tracepoint.delete_all(['gpx_id = ?', self.id])
+      # If there are any existing points for this trace then delete
+      # them - we check for existing points first to avoid locking
+      # the table in the common case where there aren't any.
+      if Tracepoint.exists?(['gpx_id = ?', self.id])
+        Tracepoint.delete_all(['gpx_id = ?', self.id])
+      end
 
       gpx.points do |point|
         if first