Makr author/author_ip tests more consistent
authorTom Hughes <tom@compton.nu>
Mon, 10 Oct 2016 12:54:58 +0000 (13:54 +0100)
committerTom Hughes <tom@compton.nu>
Mon, 10 Oct 2016 12:54:58 +0000 (13:54 +0100)
test/models/note_test.rb

index 441f52eb6b8a0036c3fc1a60a8b263c912785d87..6525ee5f61ec39a3914d27e4ac45434f57e3111c 100644 (file)
@@ -51,16 +51,18 @@ class NoteTest < ActiveSupport::TestCase
   end
 
   def test_author
-    anonymous_comment = create(:note_comment)
-    assert_nil anonymous_comment.note.author
+    comment = create(:note_comment)
+    assert_nil comment.note.author
+
     comment = create(:note_comment, :author_id => users(:normal_user).id)
     assert_equal users(:normal_user), comment.note.author
   end
 
   def test_author_ip
+    comment = create(:note_comment)
+    assert_nil comment.note.author_ip
+
     comment = create(:note_comment, :author_ip => IPAddr.new("192.168.1.1"))
     assert_equal IPAddr.new("192.168.1.1"), comment.note.author_ip
-    comment = create(:note_comment, :author_ip => nil)
-    assert_nil comment.note.author_ip
   end
 end