]> git.openstreetmap.org Git - rails.git/commitdiff
Redirect to the reportable after creating a report.
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 14 Mar 2018 09:24:41 +0000 (17:24 +0800)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 14 Mar 2018 09:24:41 +0000 (17:24 +0800)
app/controllers/reports_controller.rb
test/controllers/reports_controller_test.rb

index 4d2220a26c21541bdb667d6e9538b4303a754232..21c717581fb979b3f86aec62008e80c69541c172 100644 (file)
@@ -20,7 +20,7 @@ class ReportsController < ApplicationController
     if @report.save
       @report.issue.save
       @report.issue.reopen! unless @report.issue.open?
-      redirect_to root_path, :notice => t("issues.create.successful_report")
+      redirect_to helpers.reportable_url(@report.issue.reportable), :notice => t("issues.create.successful_report")
     else
       redirect_to new_report_path(:reportable_type => @report.issue.reportable_type, :reportable_id => @report.issue.reportable_id), :notice => t("issues.create.provide_details")
     end
index 206958ab88486c568444b90a5d7dee2d50235486..d9bc190d8b1d9a5495177c2dd5f1cfa318ad6f09 100644 (file)
@@ -32,7 +32,7 @@ class ReportsControllerTest < ActionController::TestCase
     end
     assert_equal 1, Issue.count
     assert_response :redirect
-    assert_redirected_to root_path
+    assert_redirected_to user_path(target_user.display_name)
   end
 
   def test_new_report_with_incomplete_details
@@ -61,7 +61,7 @@ class ReportsControllerTest < ActionController::TestCase
     end
     assert_equal 1, Issue.count
     assert_response :redirect
-    assert_redirected_to root_path
+    assert_redirected_to user_path(target_user.display_name)
 
     get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
     assert_response :success
@@ -107,7 +107,7 @@ class ReportsControllerTest < ActionController::TestCase
     end
     assert_equal 1, Issue.count
     assert_response :redirect
-    assert_redirected_to root_path
+    assert_redirected_to user_path(target_user.display_name)
 
     # Create a report for an existing Issue
     get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }