Fix rubucop errors
authorJ Guthrie <jamie.guthrie@gmail.com>
Sun, 4 Nov 2018 16:40:01 +0000 (16:40 +0000)
committerJ Guthrie <jamie.guthrie@gmail.com>
Mon, 5 Nov 2018 14:24:29 +0000 (14:24 +0000)
app/models/user.rb

index 795ddc1..04524e6 100644 (file)
@@ -88,18 +88,18 @@ class User < ActiveRecord::Base
                     :default_url => "/assets/:class/:attachment/:style.png",
                     :styles => { :large => "100x100>", :small => "50x50>" }
 
-  INVALID_ASCII_CHARS = "/;.,?%#"
-  INVALID_NON_ASCII_CHARS = "\x00-\x1f\x7f\ufffe\uffff"
+  INVALID_ASCII_CHARS = "/;.,?%#".freeze
+  INVALID_NON_ASCII_CHARS = "\x00-\x1f\x7f\ufffe\uffff".freeze
 
   validates :display_name, :presence => true, :allow_nil => true, :length => 3..255,
                            :exclusion => %w[new terms save confirm confirm-email go_public reset-password forgot-password suspended]
   validates :display_name, :if => proc { |u| u.display_name_changed? },
                            :uniqueness => { :case_sensitive => false }
   validates :display_name, :if => proc { |u| u.display_name_changed? },
-                           :format => { :with => %r{\A[^#{INVALID_NON_ASCII_CHARS}]*\z} }
+                           :format => { :with => /\A[^#{INVALID_NON_ASCII_CHARS}]*\z/ }
   validates :display_name, :if => proc { |u| u.display_name_changed? },
-                           :format => { :with => %r{\A[^#{INVALID_ASCII_CHARS}]*\z},
-                                        :message => I18n.t("users.account.invalid chars", invalid_chars: INVALID_ASCII_CHARS) }
+                           :format => { :with => /\A[^#{INVALID_ASCII_CHARS}]*\z/,
+                                        :message => I18n.t("users.account.invalid chars", :invalid_chars => INVALID_ASCII_CHARS) }
   validates :display_name, :if => proc { |u| u.display_name_changed? },
                            :format => { :with => /\A\S/, :message => I18n.t("users.account.leading whitespace") }
   validates :display_name, :if => proc { |u| u.display_name_changed? },