erblint: avoid dynamic find_by methods
authorTom Hughes <tom@compton.nu>
Wed, 27 Mar 2019 19:14:16 +0000 (19:14 +0000)
committerTom Hughes <tom@compton.nu>
Wed, 27 Mar 2019 19:14:16 +0000 (19:14 +0000)
.erb-lint.yml
app/views/site/_potlatch.html.erb
app/views/site/_potlatch2.html.erb

index d0ccb0c..3cca030 100644 (file)
@@ -25,8 +25,6 @@ linters:
         Enabled: false
       Rails/OutputSafety:
         Enabled: false
-      Rails/DynamicFindBy:
-        Enabled: false # TODO
       Layout/LeadingBlankLines:
         Enabled: false # TODO
 exclude:
index 745fb20..3ebcf7f 100644 (file)
@@ -1,7 +1,7 @@
 <%= javascript_include_tag "edit/potlatch" %>
 
 <div id="map">
-  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by_token(session[:token]) -%>
+  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by(:token => session[:token]) -%>
   <% data = { :token => session[:token] } -%>
   <% data[:lat] = @lat if @lat -%>
   <% data[:lon] = @lon if @lon -%>
index bb6d3f8..11519c2 100644 (file)
@@ -1,7 +1,7 @@
 <%= javascript_include_tag "edit/potlatch2" %>
 
 <div id="map">
-  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by_token(session[:token]) -%>
+  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by(:token => session[:token]) -%>
   <% data = { :token => session[:token] } -%>
   <% data[:lat] = @lat if @lat -%>
   <% data[:lon] = @lon if @lon -%>