Avoid dragging ActionView::Helpers::TextHelper into RichText objects

Dragging in TextHelper gets us a truncate method which hides the one
we inherited from String and which we want.

diff --git a/lib/rich_text.rb b/lib/rich_text.rb
index 92be8903b03028d44483f24ba31fa5d96d331710..2b7e310094058cd7f22670743b2681510057ccd3 100644 (file)
--- a/lib/rich_text.rb
+++ b/lib/rich_text.rb
@@ -8,7 +8,17 @@ module RichText
     end
   end
 
+  class SimpleFormat
+    include ActionView::Helpers::TextHelper
+
+    def sanitize(text)
+      Sanitize.clean(text, Sanitize::Config::OSM).html_safe
+    end
+  end
+
   class Base < String
+    include ActionView::Helpers::TagHelper
+
     def spam_score
       link_count = 0
       link_size = 0
@@ -31,6 +41,10 @@ module RichText
 
   protected
 
+    def simple_format(text)
+      SimpleFormat.new.simple_format(text)
+    end
+
     def linkify(text)
       if text.html_safe?
         Rinku.auto_link(text, :urls, tag_options(:rel => "nofollow")).html_safe
@@ -41,15 +55,12 @@ module RichText
   end
 
   class HTML < Base
-    include ActionView::Helpers::TextHelper
-    include ActionView::Helpers::TagHelper
-
     def to_html
       linkify(sanitize(simple_format(self)))
     end
 
     def to_text
-      self
+      self.to_s
     end
 
   private
@@ -65,7 +76,7 @@ module RichText
     end
 
     def to_text
-      self
+      self.to_s
     end
 
   private
@@ -95,14 +106,12 @@ module RichText
   end
 
   class Text < Base
-    include ActionView::Helpers::TextHelper
-
     def to_html
       linkify(simple_format(ERB::Util.html_escape(self)))
     end
 
     def to_text
-      self
+      self.to_s
     end
   end
 end