Ignore the block length of the routes
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 5 Jun 2019 14:29:54 +0000 (16:29 +0200)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 5 Jun 2019 14:29:54 +0000 (16:29 +0200)
Since the routes are more of a dsl than code, we've been happy to
repeatedly bump up this number. But then that hides other code which
has over-long block lengths hiding behind.

So instead let's exclude the routes from this metric.

.rubocop.yml
.rubocop_todo.yml

index 5bf565c..7d2df04 100644 (file)
@@ -19,6 +19,10 @@ Lint/PercentStringArray:
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/site_controller.rb'
 
+Metrics/BlockLength:
+  Exclude:
+    - 'config/routes.rb'
+
 Naming/FileName:
   Exclude:
     - 'script/deliver-message'
index 76a4cad..26b5aa6 100644 (file)
@@ -40,7 +40,7 @@ Metrics/AbcSize:
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 263
+  Max: 71
 
 # Offense count: 15
 # Configuration parameters: CountBlocks.