Fixed copy-n-paste bug in querying for closed changesets and added a test for it.
authorMatt Amos <zerebubuth@gmail.com>
Sat, 26 Dec 2009 21:29:43 +0000 (21:29 +0000)
committerMatt Amos <zerebubuth@gmail.com>
Sat, 26 Dec 2009 21:29:43 +0000 (21:29 +0000)
app/controllers/changeset_controller.rb
test/functional/changeset_controller_test.rb

index 83ee16f53fe23fefcc0e49636e0d96764c7750fa..79000c6852598a212b79661757ee87932a1380f8 100644 (file)
@@ -427,7 +427,7 @@ private
   # query changesets which are closed
   # ('closed at' time has passed or changes limit is hit)
   def conditions_closed(closed)
-    return closed.nil? ? nil : ['closed_at < ? and num_changes > ?', 
+    return closed.nil? ? nil : ['closed_at < ? or num_changes > ?', 
                                 Time.now.getutc, Changeset::MAX_ELEMENTS]
   end
 
index 76ec0866adcf9899df439126009147ef95b583cd..befa8192a6b6d842e1321fa92e736bd52f135eda 100644 (file)
@@ -1382,6 +1382,10 @@ EOF
     get :query, :open => 'true'
     assert_response :success, "can't get changesets by open-ness"
     assert_changesets [1,2,4]
+
+    get :query, :closed => 'true'
+    assert_response :success, "can't get changesets by closed-ness"
+    assert_changesets [3,5,6,7]
   end
 
   ##