Potlatch 0.10e
authorRichard Fairhurst <richard@systemed.net>
Sun, 12 Oct 2008 23:11:37 +0000 (23:11 +0000)
committerRichard Fairhurst <richard@systemed.net>
Sun, 12 Oct 2008 23:11:37 +0000 (23:11 +0000)
app/controllers/amf_controller.rb
config/potlatch/presets.txt
config/routes.rb
public/potlatch/potlatch.swf

index 70f8f427d74e53d276a9a9a1918f57c76893fd01..306b3dec84dd5be3ead36befaef87019ca18b8be 100644 (file)
 #
 # == General structure
 #
-# Apart from the talk method (which distributes the requests from the
-# AMF message), each method generally takes arguments in the order they were 
-# sent by the Potlatch SWF. Do not assume typing has been preserved. Methods 
-# all return an array to the SWF.
+# Apart from the amf_read and amf_write methods (which distribute the requests
+# from the AMF message), each method generally takes arguments in the order 
+# they were sent by the Potlatch SWF. Do not assume typing has been preserved. 
+# Methods all return an array to the SWF.
 # 
 # == Debugging
 # 
@@ -31,16 +31,15 @@ class AmfController < ApplicationController
   session :off
   before_filter :check_write_availability
 
-  # Main AMF handler: processes the raw AMF string (using AMF library) and
+  # Main AMF handlers: process the raw AMF string (using AMF library) and
   # calls each action (private method) accordingly.
+  # ** FIXME: refactor to reduce duplication of code across read/write
   
-  def talk
-       req=StringIO.new(request.raw_post+0.chr)        # Get POST data as request
-                                                                                               # (cf http://www.ruby-forum.com/topic/122163)
-       req.read(2)                                                                     # Skip version indicator and client ID
-       results={}                                                                      # Results of each body
-       renumberednodes={}                                                      # Shared across repeated putways
-       renumberedways={}                                                       # Shared across repeated putways
+  def amf_read
+       req=StringIO.new(request.raw_post+0.chr)# Get POST data as request
+                                                                                       # (cf http://www.ruby-forum.com/topic/122163)
+       req.read(2)                                                             # Skip version indicator and client ID
+       results={}                                                              # Results of each body
 
        # Parse request
 
@@ -69,6 +68,36 @@ class AmfController < ApplicationController
                when 'getway_old';                      results[index]=AMF.putdata(index,getway_old(args[0].to_i,args[1].to_i))
                when 'getway_history';          results[index]=AMF.putdata(index,getway_history(args[0].to_i))
                when 'getnode_history';         results[index]=AMF.putdata(index,getnode_history(args[0].to_i))
+               when 'findrelations';           results[index]=AMF.putdata(index,findrelations(*args))
+               when 'getpoi';                          results[index]=AMF.putdata(index,getpoi(*args))
+         end
+       end
+    sendresponse(results)
+  end
+
+  def amf_write
+       req=StringIO.new(request.raw_post+0.chr)
+       req.read(2)
+       results={}
+       renumberednodes={}                                              # Shared across repeated putways
+       renumberedways={}                                               # Shared across repeated putways
+
+       headers=AMF.getint(req)                                 # Read number of headers
+       headers.times do                                                # Read each header
+         name=AMF.getstring(req)                               #  |
+         req.getc                                                              #  | skip boolean
+         value=AMF.getvalue(req)                               #  |
+         header["name"]=value                                  #  |
+       end
+
+       bodies=AMF.getint(req)                                  # Read number of bodies
+       bodies.times do                                                 # Read each body
+         message=AMF.getstring(req)                    #  | get message name
+         index=AMF.getstring(req)                              #  | get index in response sequence
+         bytes=AMF.getlong(req)                                #  | get total size in bytes
+         args=AMF.getvalue(req)                                #  | get response (probably an array)
+
+         case message
                when 'putway';                          r=putway(renumberednodes,*args)
                                                                        renumberednodes=r[3]
                                                                        if r[1] != r[2]
@@ -76,22 +105,11 @@ class AmfController < ApplicationController
                                                                        end
                                                                        results[index]=AMF.putdata(index,r)
                when 'putrelation';                     results[index]=AMF.putdata(index,putrelation(renumberednodes, renumberedways, *args))
-               when 'findrelations';           results[index]=AMF.putdata(index,findrelations(*args))
                when 'deleteway';                       results[index]=AMF.putdata(index,deleteway(args[0],args[1].to_i))
                when 'putpoi';                          results[index]=AMF.putdata(index,putpoi(*args))
-               when 'getpoi';                          results[index]=AMF.putdata(index,getpoi(*args))
          end
        end
-
-       # Write out response
-
-       a,b=results.length.divmod(256)
-       render :content_type => "application/x-amf", :text => proc { |response, output| 
-         output.write 0.chr+0.chr+0.chr+0.chr+a.chr+b.chr
-         results.each do |k,v|
-               output.write(v)
-         end
-       }
+    sendresponse(results)
   end
 
   private
@@ -275,11 +293,10 @@ class AmfController < ApplicationController
          if mid < 0
                mid = renumberednodes[mid] if m[0] == 'node'
                mid = renumberedways[mid] if m[0] == 'way'
-               if mid < 0
-                 return -2, "Negative ID unresolved"
+               if mid
+                 typedmembers << [m[0], mid, m[2]]
                end
          end
-         typedmembers << [m[0], mid, m[2]]
        end
 
        # assign new contents
@@ -523,6 +540,18 @@ class AmfController < ApplicationController
        return ((a/0.0000001).round==(b/0.0000001).round)
   end
 
+  # Send AMF response
+  
+  def sendresponse(results)
+       a,b=results.length.divmod(256)
+       render :content_type => "application/x-amf", :text => proc { |response, output| 
+         output.write 0.chr+0.chr+0.chr+0.chr+a.chr+b.chr
+         results.each do |k,v|
+               output.write(v)
+         end
+       }
+  end
+
 
   # ====================================================================
   # Alternative SQL queries for getway/whichways
index ecca87d724f7bc5f8ba40aa29fcedf92bf462871..464204edb4e721bfe0e7c1a9fa46b0a1895f250f 100644 (file)
@@ -62,7 +62,7 @@ winding hole: place=,waterway=turning_point
 mooring: place=,waterway=mooring
 
 point/railway
-station: place=,railway=station
+station: place=,railway=station,name=(type name here)
 viaduct: place=,railway=viaduct
 level crossing: place=,railway=crossing
 
index f040e1c1d791820e6b53d2cd9879eccb8664be13..b7d570980de7876f3f344848e215527a289e74b2 100644 (file)
@@ -54,7 +54,8 @@ ActionController::Routing::Routes.draw do |map|
   
   # Potlatch API
   
-  map.connect "api/#{API_VERSION}/amf", :controller =>'amf', :action =>'talk'
+  map.connect "api/#{API_VERSION}/amf/read", :controller =>'amf', :action =>'amf_read'
+  map.connect "api/#{API_VERSION}/amf/write", :controller =>'amf', :action =>'amf_write'
   map.connect "api/#{API_VERSION}/swf/trackpoints", :controller =>'swf', :action =>'trackpoints'
   
   # Data browsing
index 4d2dc0b2e91582de6a64674be44a6db3d6502892..c5ef661de286e21936941670e616ffc488187f68 100755 (executable)
Binary files a/public/potlatch/potlatch.swf and b/public/potlatch/potlatch.swf differ