Merge branch 'pull/843' into titles
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 22 Nov 2017 14:42:16 +0000 (14:42 +0000)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 22 Nov 2017 14:42:16 +0000 (14:42 +0000)
app/helpers/title_helper.rb
test/helpers/title_helper_test.rb

index ebe5c3a2631ca27f314d64835c400d35daa25812..88a5a2a74ae3a42a6970fdd94239d11d9efcf9c9 100644 (file)
@@ -8,7 +8,7 @@ module TitleHelper
   def set_title(title = nil)
     if title
       @title = TitleHelper.coder.decode(title.gsub("<bdi>", "\u202a").gsub("</bdi>", "\u202c"))
-      response.headers["X-Page-Title"] = ERB::Util.u(t("layouts.project_name.title") + " | " + @title)
+      response.headers["X-Page-Title"] = ERB::Util.u(@title + " | " + t("layouts.project_name.title"))
     else
       @title = title
       response.headers["X-Page-Title"] = ERB::Util.u(t("layouts.project_name.title"))
index 25486f7991227bcf0adb2b529ec2beb1b1676d98..c30f793d3f603f079da6199ac9ddd531b1bd4dd2 100644 (file)
@@ -12,15 +12,15 @@ class TitleHelperTest < ActionView::TestCase
     assert_nil @title
 
     set_title("Test Title")
-    assert_equal "OpenStreetMap%20%7C%20Test%20Title", response.header["X-Page-Title"]
+    assert_equal "Test%20Title%20%7C%20OpenStreetMap", response.header["X-Page-Title"]
     assert_equal "Test Title", @title
 
     set_title("Test & Title")
-    assert_equal "OpenStreetMap%20%7C%20Test%20%26%20Title", response.header["X-Page-Title"]
+    assert_equal "Test%20%26%20Title%20%7C%20OpenStreetMap", response.header["X-Page-Title"]
     assert_equal "Test & Title", @title
 
     set_title("Tést & Tïtlè")
-    assert_equal "OpenStreetMap%20%7C%20T%C3%A9st%20%26%20T%C3%AFtl%C3%A8", response.header["X-Page-Title"]
+    assert_equal "T%C3%A9st%20%26%20T%C3%AFtl%C3%A8%20%7C%20OpenStreetMap", response.header["X-Page-Title"]
     assert_equal "Tést & Tïtlè", @title
   end
 end