Refactored the code to invoke the message body partial layout, as suggested in the PR

diff --git a/app/helpers/notifier_helper.rb b/app/helpers/notifier_helper.rb
index 62801ed82394ce45ab7aa9f20784b0aa4f8c3eb9..0510ae0a89280dc97d5bb3ef0c2eb2e21d54ea36 100644 (file)
--- a/app/helpers/notifier_helper.rb
+++ b/app/helpers/notifier_helper.rb
@@ -11,4 +11,11 @@ module NotifierHelper
       :style => "text-decoration: none; color: #222; font-weight: bold"
     )
   end
+
+  def message_body(&block)
+    render(
+      partial: "message_body",
+      locals: { body: capture(&block) }
+    )
+  end
 end

diff --git a/app/views/notifier/_user_message_table.html.erb b/app/views/notifier/_message_body.html.erb
similarity index 96%
rename from app/views/notifier/_user_message_table.html.erb
rename to app/views/notifier/_message_body.html.erb
index 1b33e082b6bc335b45693b59a59d2972047706f1..29ecf9ea89f7fb4252f5a6cb0f4df54acefb656c 100644 (file)
--- a/app/views/notifier/_user_message_table.html.erb
+++ b/app/views/notifier/_message_body.html.erb
@@ -12,7 +12,7 @@
       ) %>
     </td>
     <td style="text-align: left; vertical-align: top; padding-right: 10px">
-      <%= captured %>
+      <%= body %>
     </td>
   </tr>
 </table>

diff --git a/app/views/notifier/changeset_comment_notification.html.erb b/app/views/notifier/changeset_comment_notification.html.erb
index cb2748f4acd5d1ccf82a57291350911f6f41f3a8..bbcd0614ebf248e5a14220390dc95e0b47eee567 100644 (file)
--- a/app/views/notifier/changeset_comment_notification.html.erb
+++ b/app/views/notifier/changeset_comment_notification.html.erb
@@ -11,9 +11,9 @@
   <% end %>
 </p>
 
-<%= render "notifier/user_message_table", :captured => capture { %>
+<%= message_body do %>
   <%= @comment.to_html %>
-<% } %>
+<% end %>
 
 <p>
   <%= raw t 'notifier.changeset_comment_notification.details', :url => content_tag("nobr", link_to(@changeset_url, @changeset_url)) %>

diff --git a/app/views/notifier/diary_comment_notification.html.erb b/app/views/notifier/diary_comment_notification.html.erb
index 4b7c6310528260de9924dd756035ae33ccedbe23..73bfe9a33d655b6c117cd3ddcb69e6cd2b53a758 100644 (file)
--- a/app/views/notifier/diary_comment_notification.html.erb
+++ b/app/views/notifier/diary_comment_notification.html.erb
@@ -5,9 +5,9 @@
   <%= raw t'notifier.diary_comment_notification.header', :from_user => link_to_user(@from_user), :subject => content_tag("em", @title) %>
 </p>
 
-<%= render "notifier/user_message_table", :captured => capture { %>
+<%= message_body do %>
   <%= @text.to_html %>
-<% } %>
+<% end %>
 
 <% content_for :footer do %>
   <p><%= raw t'notifier.diary_comment_notification.footer',

diff --git a/app/views/notifier/friend_notification.html.erb b/app/views/notifier/friend_notification.html.erb
index 356aca0aae4cbbabf2ab0733df5b50f670433aa6..cfea971958452e8e7a69dfebd1b3a8a56390ee51 100644 (file)
--- a/app/views/notifier/friend_notification.html.erb
+++ b/app/views/notifier/friend_notification.html.erb
@@ -1,9 +1,9 @@
 <p><%= t 'notifier.friend_notification.had_added_you', :user => @friend.befriender.display_name %></p>
 
-<%= render "notifier/user_message_table", :captured => capture { %>
+<%= message_body do %>
   <p><%= raw t 'notifier.friend_notification.see_their_profile', :userurl => link_to(@viewurl, @viewurl) %></p>
 
   <% unless @friend.befriendee.is_friends_with?(@friend.befriender) -%>
   <p><%= raw t 'notifier.friend_notification.befriend_them', :befriendurl => link_to(@friendurl, @friendurl) %></p>
   <% end -%>
-<% } %>
+<% end %>

diff --git a/app/views/notifier/message_notification.html.erb b/app/views/notifier/message_notification.html.erb
index d3871f03092b0b019f5a6c6d0011708328a1542f..97a352a499e7f51385c620f90385762d6097f90e 100644 (file)
--- a/app/views/notifier/message_notification.html.erb
+++ b/app/views/notifier/message_notification.html.erb
@@ -8,9 +8,9 @@
   %>
 </p>
 
-<%= render "notifier/user_message_table", :captured => capture { %>
+<%= message_body do %>
   <%= @text.to_html %>
-<% } %>
+<% end %>
 
 <% content_for :footer do %>
   <p>

diff --git a/app/views/notifier/note_comment_notification.html.erb b/app/views/notifier/note_comment_notification.html.erb
index 7492985317db950619621a3fa94c9c1a6c83e29e..ecaff81dc54c193be45c922cb832e10209035049 100644 (file)
--- a/app/views/notifier/note_comment_notification.html.erb
+++ b/app/views/notifier/note_comment_notification.html.erb
@@ -6,8 +6,8 @@
   <p><%= raw t "notifier.note_comment_notification.#{@event}.commented_note", :commenter => link_to_user(@commenter), :place => @place %></p>
 <% end %>
 
-<%= render "notifier/user_message_table", :captured => capture { %>
+<%= message_body do %>
   <%= @comment.to_html %>
-<% } %>
+<% end %>
 
 <p><%= raw t 'notifier.note_comment_notification.details', :url => link_to(@noteurl, @noteurl) %></p>