Removed bogus attempt to look up the previous version
authorTom Hughes <tom@compton.nu>
Sat, 10 Dec 2011 16:24:57 +0000 (16:24 +0000)
committerTom Hughes <tom@compton.nu>
Sat, 10 Dec 2011 16:24:57 +0000 (16:24 +0000)
This lookup wasn't actually doing what the comment said it was doing
and I don't see any reason to output the previous details of the object
for a delete action.

app/controllers/changeset_controller.rb

index f92293fde852530c175197a5efc80251b4e1804e..9fc2bc320315ce06e2c31bffbc80f2c929c075aa 100644 (file)
@@ -174,16 +174,12 @@ class ChangesetController < ApplicationController
           created = XML::Node.new "create"
           created << elt.to_xml_node
         else
-          # get the previous version from the element history
-          prev_elt = elt.class.find([elt.id, elt.version])
           unless elt.visible
-            # if the element isn't visible then it must have been deleted, so
-            # output the *previous* XML
+            # if the element isn't visible then it must have been deleted
             deleted = XML::Node.new "delete"
-            deleted << prev_elt.to_xml_node
+            deleted << elt.to_xml_node
           else
-            # must be a modify, for which we don't need the previous version
-            # yet...
+            # must be a modify
             modified = XML::Node.new "modify"
             modified << elt.to_xml_node
           end