Merge pull request #4111 from AntonKhorev/hidden-welcome-banner

Hide/show welcome banner with hidden attribute

diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js
index 38c4981696f5d37aacc066769169cd136c61a179..783c4da8d2597fdac9ecff064087155eb7836e0f 100644 (file)
--- a/app/assets/javascripts/index.js
+++ b/app/assets/javascripts/index.js
@@ -192,11 +192,11 @@ $(document).ready(function () {
   });
 
   if (Cookies.get("_osm_welcome") !== "hide") {
-    $(".welcome").addClass("visible");
+    $(".welcome").removeAttr("hidden");
   }
 
   $(".welcome .btn-close").on("click", function () {
-    $(".welcome").removeClass("visible");
+    $(".welcome").hide();
     Cookies.set("_osm_welcome", "hide", { secure: true, expires: expiry, path: "/", samesite: "lax" });
   });
 

diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss
index 34f2ada7388f9fcc6c6542ecf2298a096a52f076..d74ece45a66a2b6f323f1b07acc452aa7ed0b483 100644 (file)
--- a/app/assets/stylesheets/common.scss
+++ b/app/assets/stylesheets/common.scss
@@ -317,7 +317,7 @@ body.small-nav {
     display: inline-block;
   }
 
-  .overlay-sidebar #sidebar .welcome.visible {
+  .overlay-sidebar #sidebar .welcome {
     display: none;
   }
 
@@ -436,11 +436,7 @@ body.small-nav {
     }
 
     .welcome {
-      display: none;
-
-      &.visible {
-        display: block;
-      }
+      display: block;
     }
 
     #sidebar_content {

diff --git a/app/views/layouts/map.html.erb b/app/views/layouts/map.html.erb
index b3c85d918343a8bda723390035b5c0411be012f6..6d983d30ea153454ed225068d3baa97f79cd5c66 100644 (file)
--- a/app/views/layouts/map.html.erb
+++ b/app/views/layouts/map.html.erb
@@ -41,7 +41,7 @@
     </div>
 
     <% unless current_user %>
-      <div class="welcome p-3">
+      <div class="welcome p-3" hidden>
         <%= render "sidebar_header", :title => t("layouts.intro_header") %>
         <div>
           <p><%= t "layouts.intro_text" %></p>