Move some helper functions to better homes
authorTom Hughes <tom@compton.nu>
Sun, 12 Aug 2012 15:14:35 +0000 (16:14 +0100)
committerTom Hughes <tom@compton.nu>
Sun, 12 Aug 2012 15:14:35 +0000 (16:14 +0100)
app/helpers/application_helper.rb
app/helpers/geocoder_helper.rb
app/helpers/user_helper.rb

index 37dcf90..3213c5e 100644 (file)
@@ -75,38 +75,6 @@ module ApplicationHelper
     content_tag(tag, capture(&block), :class => "hide_unless_administrator")
   end
 
-  def describe_location(lat, lon, zoom = nil, language = nil)
-    zoom = zoom || 14
-    language = language || request.user_preferred_languages.join(',')
-    url = "http://nominatim.openstreetmap.org/reverse?lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{language}"
-
-    begin
-      response = OSM::Timer.timeout(4) do
-        REXML::Document.new(Net::HTTP.get(URI.parse(url)))
-      end
-    rescue Exception
-      response = nil
-    end
-
-    if response and result = response.get_text("reversegeocode/result")
-      result.to_s
-    else
-      "#{number_with_precision(lat, :precision => 3)}, #{number_with_precision(lon, :precision => 3)}"
-    end
-  end
-
-  def user_image(user, options = {})
-    options[:class] ||= "user_image"
-
-    image_tag user.image.url(:large), options
-  end
-
-  def user_thumbnail(user, options = {})
-    options[:class] ||= "user_thumbnail"
-
-    image_tag user.image.url(:small), options
-  end
-
   def preferred_editor
     if params[:editor]
       params[:editor]
index 4c58d54..f5519dd 100644 (file)
@@ -20,4 +20,24 @@ module GeocoderHelper
 
     return raw(html)
   end
+
+  def describe_location(lat, lon, zoom = nil, language = nil)
+    zoom = zoom || 14
+    language = language || request.user_preferred_languages.join(',')
+    url = "http://nominatim.openstreetmap.org/reverse?lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{language}"
+
+    begin
+      response = OSM::Timer.timeout(4) do
+        REXML::Document.new(Net::HTTP.get(URI.parse(url)))
+      end
+    rescue Exception
+      response = nil
+    end
+
+    if response and result = response.get_text("reversegeocode/result")
+      result.to_s
+    else
+      "#{number_with_precision(lat, :precision => 3)}, #{number_with_precision(lon, :precision => 3)}"
+    end
+  end
 end
index acaecff..6a239df 100644 (file)
@@ -1,4 +1,16 @@
 module UserHelper
+  def user_image(user, options = {})
+    options[:class] ||= "user_image"
+
+    image_tag user.image.url(:large), options
+  end
+
+  def user_thumbnail(user, options = {})
+    options[:class] ||= "user_thumbnail"
+
+    image_tag user.image.url(:small), options
+  end
+
   def openid_logo
     image_tag "openid_small.png", :alt => t('user.login.openid_logo_alt'), :class => "openid_logo"
   end