Yet more rubucop cleanups

[chef.git] / cookbooks / mediawiki / definitions / mediawiki_extension.rb

diff --git a/cookbooks/mediawiki/definitions/mediawiki_extension.rb b/cookbooks/mediawiki/definitions/mediawiki_extension.rb
index 37c93e41d3ca383379f3b339017a49e158197a99..c5d1ec856ac53021242c05dcb38d680014955123 100644 (file)
--- a/cookbooks/mediawiki/definitions/mediawiki_extension.rb
+++ b/cookbooks/mediawiki/definitions/mediawiki_extension.rb
@@ -17,10 +17,9 @@
 # limitations under the License.
 #
 
-define :mediawiki_extension, :action => [ :enable ], :variables => {} do
+define :mediawiki_extension, :action => [:enable], :variables => {} do
   name = params[:name]
   site = params[:site]
-  site_directory = node[:mediawiki][:sites][site][:site_directory]
   mediawiki_directory = node[:mediawiki][:sites][site][:directory]
   extension_directory = "#{mediawiki_directory}/extensions/#{name}"
   source = params[:source]
@@ -52,7 +51,7 @@ define :mediawiki_extension, :action => [ :enable ], :variables => {} do
       action :sync
       repository repository
       reference reference
-      #depth 1
+      # depth 1
       enable_submodules true
       user node[:mediawiki][:user]
       group node[:mediawiki][:group]
@@ -79,7 +78,7 @@ define :mediawiki_extension, :action => [ :enable ], :variables => {} do
     group node[:mediawiki][:group]
     mode 0664
     content "<?php require_once('#{extension_directory}/#{name}.php');\n"
-    only_if do File.exist?("#{extension_directory}/#{name}.php") end
-    notifies :create, resources(:template => "#{mediawiki_directory}/LocalSettings.php")  
+    only_if { File.exist?("#{extension_directory}/#{name}.php") }
+    notifies :create, resources(:template => "#{mediawiki_directory}/LocalSettings.php")
   end
 end