Qualify property access

[chef.git] / cookbooks / mediawiki / providers / skin.rb

diff --git a/cookbooks/mediawiki/providers/skin.rb b/cookbooks/mediawiki/providers/skin.rb
index 2ee0504c747d39b499e5066697a86792bea0623a..59bd21b3e370392418841c1ce693ecf77c45daf0 100644 (file)
--- a/cookbooks/mediawiki/providers/skin.rb
+++ b/cookbooks/mediawiki/providers/skin.rb
@@ -30,23 +30,19 @@ action :create do
       source new_resource.source
       owner node[:mediawiki][:user]
       group node[:mediawiki][:group]
-      mode 0755
+      mode 0o755
       files_owner node[:mediawiki][:user]
       files_group node[:mediawiki][:group]
-      files_mode 0755
+      files_mode 0o755
     end
   else
     skin_repository = new_resource.repository || default_repository
-    skin_reference = if new_resource.tag
-                       "refs/tags/#{new_resource.tag}"
-                     else
-                       "REL#{skin_version}".tr(".", "_")
-                     end
+    skin_revision = new_resource.revision || "REL#{skin_version}".tr(".", "_")
 
     git skin_directory do
       action :sync
       repository skin_repository
-      reference skin_reference
+      revision skin_revision
       enable_submodules true
       user node[:mediawiki][:user]
       group node[:mediawiki][:group]
@@ -60,18 +56,17 @@ action :create do
       source new_resource.template
       user node[:mediawiki][:user]
       group node[:mediawiki][:group]
-      mode 0664
+      mode 0o664
       variables new_resource.variables
     end
   else
     skin_script = "#{skin_directory}/#{new_resource.name}.php"
 
     file "#{mediawiki_directory}/LocalSettings.d/Skin-#{new_resource.name}.inc.php" do
-      action :create
       content "<?php require_once('#{skin_script}');\n"
       user node[:mediawiki][:user]
       group node[:mediawiki][:group]
-      mode 0664
+      mode 0o664
       only_if { ::File.exist?(skin_script) }
     end
   end