Rework deletion of old rails test sites
authorTom Hughes <tom@compton.nu>
Mon, 19 Jan 2015 09:23:07 +0000 (09:23 +0000)
committerTom Hughes <tom@compton.nu>
Mon, 19 Jan 2015 09:26:36 +0000 (09:26 +0000)
cookbooks/dev/recipes/default.rb

index 3dd8473af02632483303f044b818470ba13a0b74..d660718e6ca35910dd94e0a58e2feae0576b8d98 100644 (file)
@@ -135,59 +135,52 @@ if node[:postgresql][:clusters][:"9.1/main"]
   node[:dev][:rails].each do |name,details|
     database_name = details[:database] || "apis_#{name}"
     site_name = "#{name}.apis.dev.openstreetmap.org"
-    site_aliases = details[:aliases] || []
     rails_directory = "/srv/#{name}.apis.dev.openstreetmap.org"
-    secret_key_base = details[:secret_key_base] || SecureRandom.base64(96)
 
-    node.set[:dev][:rails][name][:secret_key_base] = secret_key_base
+    if details[:repository]
+      site_aliases = details[:aliases] || []
+      secret_key_base = details[:secret_key_base] || SecureRandom.base64(96)
 
-    postgresql_database database_name do
-      cluster "9.3/main"
-      owner "apis"
-    end
-
-    postgresql_extension "#{database_name}_btree_gist" do
-      cluster "9.3/main"
-      database database_name
-      extension "btree_gist"
-    end
-
-    rails_port site_name do
-      ruby node[:passenger][:ruby_version]
-      directory rails_directory
-      user "apis"
-      group "apis"
-      repository details[:repository]
-      revision details[:revision]
-      database_port node[:postgresql][:clusters][:"9.3/main"][:port]
-      database_name database_name
-      database_username "apis"
-      run_migrations true
-    end
+      node.normal[:dev][:rails][name][:secret_key_base] = secret_key_base
 
-    template "#{rails_directory}/config/initializers/setup.rb" do
-      source "rails.setup.rb.erb"
-      owner "apis"
-      group "apis"
-      mode 0644
-      variables :site => site_name
-      notifies :touch, "file[#{rails_directory}/tmp/restart.txt]"
-    end
+      postgresql_database database_name do
+        cluster "9.3/main"
+        owner "apis"
+      end
 
-    apache_site site_name do
-      template "apache.rails.erb"
-      variables :name => site_name, :aliases => site_aliases, :secret_key_base => secret_key_base
-    end
-  end
+      postgresql_extension "#{database_name}_btree_gist" do
+        cluster "9.3/main"
+        database database_name
+        extension "btree_gist"
+      end
 
-  Dir.glob("/srv/*.apis.dev.openstreetmap.org").each do |rails_directory|
-    name = File.basename(rails_directory, ".apis.dev.openstreetmap.org")
+      rails_port site_name do
+        ruby node[:passenger][:ruby_version]
+        directory rails_directory
+        user "apis"
+        group "apis"
+        repository details[:repository]
+        revision details[:revision]
+        database_port node[:postgresql][:clusters][:"9.3/main"][:port]
+        database_name database_name
+        database_username "apis"
+        run_migrations true
+      end
 
-    unless node[:dev][:rails].include?(name) and node[:dev][:rails][name].include?(:repository)
-      database_config = YAML.load_file("#{rails_directory}/config/database.yml")
-      database_name = database_config["production"]["database"]
-      site_name = "#{name}.apis.dev.openstreetmap.org"
+      template "#{rails_directory}/config/initializers/setup.rb" do
+        source "rails.setup.rb.erb"
+        owner "apis"
+        group "apis"
+        mode 0644
+        variables :site => site_name
+        notifies :touch, "file[#{rails_directory}/tmp/restart.txt]"
+      end
 
+      apache_site site_name do
+        template "apache.rails.erb"
+        variables :name => site_name, :aliases => site_aliases, :secret_key_base => secret_key_base
+      end
+    else
       apache_site site_name do
         action [ :delete ]
       end
@@ -206,7 +199,7 @@ if node[:postgresql][:clusters][:"9.1/main"]
         cluster "9.3/main"
       end
 
-      node.set[:dev][:rails][name].delete(:secret_key_base)
+      node.normal[:dev][:rails].delete(name)
     end
   end