Avoid including Chef::Mixin::ShellOut in resources
authorTom Hughes <tom@compton.nu>
Mon, 9 Sep 2019 19:00:53 +0000 (20:00 +0100)
committerTom Hughes <tom@compton.nu>
Mon, 9 Sep 2019 19:00:53 +0000 (20:00 +0100)
.rubocop_todo.yml
cookbooks/nodejs/resources/package.rb

index c273a91..9456105 100644 (file)
@@ -25,14 +25,6 @@ ChefCorrectness/NodeNormalUnless:
     - 'cookbooks/mediawiki/resources/site.rb'
     - 'cookbooks/wordpress/resources/site.rb'
 
     - 'cookbooks/mediawiki/resources/site.rb'
     - 'cookbooks/wordpress/resources/site.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-# Include: **/resources/*.rb, **/providers/*.rb
-ChefModernize/IncludingMixinShelloutInResources:
-  Exclude:
-    - 'cookbooks/nodejs/resources/package.rb'
-
 # Offense count: 947
 # Cop supports --auto-correct.
 # Configuration parameters: .
 # Offense count: 947
 # Cop supports --auto-correct.
 # Configuration parameters: .
index 23b9414..9d30c16 100644 (file)
@@ -17,7 +17,6 @@
 # limitations under the License.
 #
 
 # limitations under the License.
 #
 
-require "chef/mixin/shell_out"
 require "json"
 
 default_action :install
 require "json"
 
 default_action :install
@@ -61,8 +60,6 @@ action :remove do
 end
 
 action_class do
 end
 
 action_class do
-  include Chef::Mixin::ShellOut
-
   def current_version
     @current_version ||= JSON.parse(shell_out("npm list --global --json").stdout)
                              .dig("dependencies", new_resource.package, "version")
   def current_version
     @current_version ||= JSON.parse(shell_out("npm list --global --json").stdout)
                              .dig("dependencies", new_resource.package, "version")