Avoid including Chef::Mixin::ShellOut in resources

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c273a91992744b3c5e5e0c5051a91304d04c5702..945610536933264131e009da5aee1778d7d59f8d 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -25,14 +25,6 @@ ChefCorrectness/NodeNormalUnless:
     - 'cookbooks/mediawiki/resources/site.rb'
     - 'cookbooks/wordpress/resources/site.rb'
 
     - 'cookbooks/mediawiki/resources/site.rb'
     - 'cookbooks/wordpress/resources/site.rb'
 

-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-# Include: **/resources/*.rb, **/providers/*.rb
-ChefModernize/IncludingMixinShelloutInResources:
-  Exclude:
-    - 'cookbooks/nodejs/resources/package.rb'
-

 # Offense count: 947
 # Cop supports --auto-correct.
 # Configuration parameters: .
 # Offense count: 947
 # Cop supports --auto-correct.
 # Configuration parameters: .

diff --git a/cookbooks/nodejs/resources/package.rb b/cookbooks/nodejs/resources/package.rb
index 23b9414ea28eecabd16066e6e58babc0fef4e71c..9d30c164fcb032f6ba00b1861496ff86d5d81d5f 100644 (file)
--- a/cookbooks/nodejs/resources/package.rb
+++ b/cookbooks/nodejs/resources/package.rb
@@ -17,7 +17,6 @@
 # limitations under the License.
 #
 
 # limitations under the License.
 #
 

-require "chef/mixin/shell_out"

 require "json"
 
 default_action :install
 require "json"
 
 default_action :install


@@ -61,8 +60,6 @@ action :remove do
 end
 
 action_class do
 end
 
 action_class do

-  include Chef::Mixin::ShellOut
-

   def current_version
     @current_version ||= JSON.parse(shell_out("npm list --global --json").stdout)
                              .dig("dependencies", new_resource.package, "version")
   def current_version
     @current_version ||= JSON.parse(shell_out("npm list --global --json").stdout)
                              .dig("dependencies", new_resource.package, "version")