]> git.openstreetmap.org Git - chef.git/commitdiff
Fix rubocop warnings
authorTom Hughes <tom@compton.nu>
Thu, 29 Dec 2022 19:53:16 +0000 (19:53 +0000)
committerTom Hughes <tom@compton.nu>
Thu, 29 Dec 2022 19:53:48 +0000 (19:53 +0000)
cookbooks/planet/files/default/replication-bin/replicate-changesets

index 77dc83312e946354415b09112f1952ebffa550d7..103be397a452922f99d09b84bbda69f4330e7ec7 100755 (executable)
@@ -216,9 +216,7 @@ class Replicator
     Zlib::GzipWriter.open(tmp_data) do |fh|
       fh.write(changeset_dump(changesets))
     end
-    File.open(tmp_state, "w") do |fh|
-      fh.write(YAML.dump(@state))
-    end
+    File.write(tmp_state, YAML.dump(@state))
 
     # fsync the files in their old locations.
     fsync(tmp_data)
@@ -267,7 +265,7 @@ class Replicator
       # of processes queueing on the lock and causing weirdness if/when they
       # get woken up in a random order.
       got_lock = fl.flock(File::LOCK_EX | File::LOCK_NB)
-      return unless got_lock
+      break unless got_lock
 
       # try and write the files to tmp locations and then
       # move them into place later, to avoid in-progress