Fix some foodcritic complaints

diff --git a/cookbooks/apache/providers/conf.rb b/cookbooks/apache/providers/conf.rb
index da339b955098f9d74b87e2e3c97c0e0322d10f17..489be8b84f4dee7ef5c3790b03b37f67dbaa9cd9 100644 (file)
--- a/cookbooks/apache/providers/conf.rb
+++ b/cookbooks/apache/providers/conf.rb
@@ -21,13 +21,13 @@ def whyrun_supported?
   true
 end
 
-action :create do
+action :create do # ~FC017
   if node[:lsb][:release].to_f >= 14.04
     create_conf
   end
 end
 
-action :enable do
+action :enable do # ~FC017
   if node[:lsb][:release].to_f >= 14.04
     enable_conf
   else
@@ -35,7 +35,7 @@ action :enable do
   end
 end
 
-action :disable do
+action :disable do # ~FC017
   if node[:lsb][:release].to_f >= 14.04
     disable_conf
   else
@@ -43,7 +43,7 @@ action :disable do
   end
 end
 
-action :delete do
+action :delete do # ~FC017
   if node[:lsb][:release].to_f >= 14.04
     delete_conf
   end

diff --git a/cookbooks/exim/recipes/default.rb b/cookbooks/exim/recipes/default.rb
index da8ba5c9cb981a3aabe96ba30f5a901bfd50355d..099e047c6cc1b821a8f13816a53455aeae3ef291 100644 (file)
--- a/cookbooks/exim/recipes/default.rb
+++ b/cookbooks/exim/recipes/default.rb
@@ -144,12 +144,11 @@ else
   end
 end
 
-if node[:exim][:smarthost_via]
-  firewall_rule "deny-outbound-smtp" do
-    action :reject
-    source "fw"
-    dest "net"
-    proto "tcp:syn"
-    dest_ports "smtp"
-  end
+firewall_rule "deny-outbound-smtp" do
+  action :reject
+  source "fw"
+  dest "net"
+  proto "tcp:syn"
+  dest_ports "smtp"
+  only_if { node[:exim][:smarthost_via] }
 end

diff --git a/cookbooks/forum/metadata.rb b/cookbooks/forum/metadata.rb
index 5e4be143f09feeff0130188196a1de75525cebd6..797c0cb8c5c4c170b37261664e5db6bc4e881ffe 100644 (file)
--- a/cookbooks/forum/metadata.rb
+++ b/cookbooks/forum/metadata.rb
@@ -6,4 +6,5 @@ description       "Installs and configures a roundup server"
 long_description  IO.read(File.join(File.dirname(__FILE__), 'README.md'))
 version           "1.0.0"
 depends           "apache"
+depends           "git"
 depends           "mysql"

diff --git a/cookbooks/hardware/attributes/default.rb b/cookbooks/hardware/attributes/default.rb
index c0a805b26600a3fdd6533c6dd065c4f1be98533a..54c8956a3b502c600714ffa9eb6ef5d1f3886079 100644 (file)
--- a/cookbooks/hardware/attributes/default.rb
+++ b/cookbooks/hardware/attributes/default.rb
@@ -8,7 +8,7 @@ if node[:dmi] && node[:dmi][:system]
 
     case dmi.system.product_name
     when "ProLiant DL360 G6", "ProLiant DL360 G7"
-      default[:hardware][:sensors]["power_meter-*"][:power]["power1"] = { :ignore => true }
+      default[:hardware][:sensors][:"power_meter-*"][:power][:"power1"] = { :ignore => true }
     end
   end
 end
@@ -16,7 +16,7 @@ end
 if Chef::Util.compare_versions(node[:kernel][:release], [3, 3]) < 0
   default[:hardware][:modules] |= ["microcode"]
 
-  if node[:cpu]["0"][:vendor_id] == "GenuineIntel"
+  if node[:cpu][:"0"][:vendor_id] == "GenuineIntel"
     default[:hardware][:modules] |= ["coretemp"]
   end
 end

diff --git a/cookbooks/mediawiki/README.md b/cookbooks/mediawiki/README.md
new file mode 100644 (file)
index 0000000..2057391
--- /dev/null
+++ b/cookbooks/mediawiki/README.md
@@ -0,0 +1,34 @@
+Cookbook
+========
+TODO: Enter the cookbook description here.
+
+e.g.
+This cookbook makes your favorite breakfast sandwich.
+
+Requirements
+------------
+TODO: List your cookbook requirements. Be sure to include any requirements this cookbook has on platforms, libraries, other cookbooks, packages, operating systems, etc.
+
+Attributes
+----------
+TODO: List you cookbook attributes here.
+
+Usage
+-----
+TODO: Write usage instructions for each cookbook.
+
+Contributing
+------------
+TODO: (optional) If this is a public cookbook, detail the process for contributing. If this is a private cookbook, remove this section.
+
+e.g.
+1. Fork the repository on Github
+2. Create a named feature branch (like `add_component_x`)
+3. Write your change
+4. Write tests for your change (if applicable)
+5. Run the tests, ensuring they all pass
+6. Submit a Pull Request using Github
+
+License and Authors
+-------------------
+Authors: TODO: List authors

diff --git a/cookbooks/mediawiki/README.rdoc b/cookbooks/mediawiki/README.rdoc
deleted file mode 100644 (file)
index 3de2ec7..0000000
--- a/cookbooks/mediawiki/README.rdoc
+++ /dev/null
@@ -1,8 +0,0 @@
-= DESCRIPTION:
-
-= REQUIREMENTS:
-
-= ATTRIBUTES:
-
-= USAGE:
-

diff --git a/cookbooks/mediawiki/definitions/mediawiki_extension.rb b/cookbooks/mediawiki/definitions/mediawiki_extension.rb
index c5d1ec856ac53021242c05dcb38d680014955123..764a5983208da9ef9edf102591fb58b321e771c3 100644 (file)
--- a/cookbooks/mediawiki/definitions/mediawiki_extension.rb
+++ b/cookbooks/mediawiki/definitions/mediawiki_extension.rb
@@ -56,11 +56,11 @@ define :mediawiki_extension, :action => [:enable], :variables => {} do
       user node[:mediawiki][:user]
       group node[:mediawiki][:group]
       ignore_failure repository.start_with?("git://github.com/wikimedia/mediawiki-extensions")
-      notifies :run, resources(:execute => "#{mediawiki_directory}/maintenance/update.php")
+      notifies :run, "execute[#{mediawiki_directory}/maintenance/update.php]"
     end
   end
 
-  if template
+  if template # ~FC023
     template "#{mediawiki_directory}/LocalSettings.d/Ext-#{name}.inc.php" do
       cookbook "mediawiki"
       source template
@@ -68,7 +68,7 @@ define :mediawiki_extension, :action => [:enable], :variables => {} do
       group node[:mediawiki][:group]
       mode 0664
       variables template_variables
-      notifies :create, resources(:template => "#{mediawiki_directory}/LocalSettings.php")
+      notifies :create, "template[#{mediawiki_directory}/LocalSettings.php]"
     end
   end
 
@@ -79,6 +79,6 @@ define :mediawiki_extension, :action => [:enable], :variables => {} do
     mode 0664
     content "<?php require_once('#{extension_directory}/#{name}.php');\n"
     only_if { File.exist?("#{extension_directory}/#{name}.php") }
-    notifies :create, resources(:template => "#{mediawiki_directory}/LocalSettings.php")
+    notifies :create, "template[#{mediawiki_directory}/LocalSettings.php]"
   end
 end

diff --git a/cookbooks/mediawiki/definitions/mediawiki_site.rb b/cookbooks/mediawiki/definitions/mediawiki_site.rb
index d565bed6453251ddd55ab8552741d9718e44a800..017d77b30cf1ac52f1bf046428dab2145fc15aff 100644 (file)
--- a/cookbooks/mediawiki/definitions/mediawiki_site.rb
+++ b/cookbooks/mediawiki/definitions/mediawiki_site.rb
@@ -106,27 +106,27 @@ define :mediawiki_site, :action => [:create, :enable] do
     group node[:mediawiki][:group]
   end
 
-  directory "#{site_directory}" do
+  directory site_directory do
     owner node[:mediawiki][:user]
     group node[:mediawiki][:group]
     mode 0775
   end
 
-  directory "#{mediawiki[:directory]}" do
+  directory mediawiki[:directory] do
     owner node[:mediawiki][:user]
     group node[:mediawiki][:group]
     mode 0775
   end
 
-  git "#{mediawiki[:directory]}" do
+  git mediawiki[:directory] do
     action :sync
     repository mediawiki_repository
     reference mediawiki_reference
     # depth 1
     user node[:mediawiki][:user]
     group node[:mediawiki][:group]
-    notifies :run, resources(:execute => "#{mediawiki[:directory]}/maintenance/install.php"), :immediately
-    notifies :run, resources(:execute => "#{mediawiki[:directory]}/maintenance/update.php")
+    notifies :run, "execute[#{mediawiki[:directory]}/maintenance/install.php]", :immediately
+    notifies :run, "execute[#{mediawiki[:directory]}/maintenance/update.php]"
   end
 
   # Safety catch if git doesn't update but install.php hasn't run
@@ -137,7 +137,7 @@ define :mediawiki_site, :action => [:create, :enable] do
     not_if do
       File.exist?("#{mediawiki[:directory]}/LocalSettings-install.php")
     end
-    notifies :run, resources(:execute => "#{mediawiki[:directory]}/maintenance/install.php"), :immediately
+    notifies :run, "execute[#{mediawiki[:directory]}/maintenance/install.php]", :immediately
     action :create
   end
 
@@ -166,7 +166,7 @@ define :mediawiki_site, :action => [:create, :enable] do
     group node[:mediawiki][:group]
     mode 0664
     variables :name => name, :database_params => database_params, :mediawiki => mediawiki
-    notifies :run, resources(:execute => "#{mediawiki[:directory]}/maintenance/update.php")
+    notifies :run, "execute[#{mediawiki[:directory]}/maintenance/update.php]"
   end
 
   template "/etc/cron.d/mediawiki-#{cron_name}" do

diff --git a/cookbooks/mediawiki/metadata.rb b/cookbooks/mediawiki/metadata.rb
index 53b069d01e0acd4b0aa261fbced6c18257163c4c..602db82c92deece4c54c24e75234fc252aa36e6d 100644 (file)
--- a/cookbooks/mediawiki/metadata.rb
+++ b/cookbooks/mediawiki/metadata.rb
@@ -1,9 +1,11 @@
+name              "mediawiki"
 maintainer        "OpenStreetMap Administrators"
 maintainer_email  "admins@openstreetmap.org"
 license           "Apache 2.0"
 description       "Installs and configures mediawiki"
-long_description  IO.read(File.join(File.dirname(__FILE__), 'README.rdoc'))
+long_description  IO.read(File.join(File.dirname(__FILE__), 'README.md'))
 version           "1.0.0"
-depends           "git"
 depends           "memcached"
+depends           "apache"
 depends           "mysql"
+depends           "git"

diff --git a/cookbooks/memcached/recipes/default.rb b/cookbooks/memcached/recipes/default.rb
index 8ef4cec1f3d8cb7e2e12b1446a25462f46d3455e..875985733e13158db221bb5be2a9d1ec2e76881a 100644 (file)
--- a/cookbooks/memcached/recipes/default.rb
+++ b/cookbooks/memcached/recipes/default.rb
@@ -36,26 +36,8 @@ munin_plugin_conf "memcached_multi" do
   template "munin.erb"
 end
 
-munin_plugin "memcached_multi_bytes" do
-  target "memcached_multi_"
-end
-
-munin_plugin "memcached_multi_commands" do
-  target "memcached_multi_"
-end
-
-munin_plugin "memcached_multi_conns" do
-  target "memcached_multi_"
-end
-
-munin_plugin "memcached_multi_evictions" do
-  target "memcached_multi_"
-end
-
-munin_plugin "memcached_multi_items" do
-  target "memcached_multi_"
-end
-
-munin_plugin "memcached_multi_memory" do
-  target "memcached_multi_"
+%w(bytes commands conns evictions items memory).each do |stat|
+  munin_plugin "memcached_multi_#{stat}" do
+    target "memcached_multi_"
+  end
 end

diff --git a/cookbooks/munin/recipes/default.rb b/cookbooks/munin/recipes/default.rb
index 79c58df5800f5123ab21bd622e6a79405f371490..28c05006b0dad7a7404581f4f3875fe19e92ef48 100644 (file)
--- a/cookbooks/munin/recipes/default.rb
+++ b/cookbooks/munin/recipes/default.rb
@@ -33,16 +33,14 @@ servers = search(:node, "recipes:munin\\:\\:server")
 
 servers.each do |server|
   server.interfaces(:role => :external) do |interface|
-    if interface[:zone]
-      firewall_rule "accept-munin-#{server}" do
-        action :accept
-        family interface[:family]
-        source "#{interface[:zone]}:#{interface[:address]}"
-        dest "fw"
-        proto "tcp:syn"
-        dest_ports "munin"
-        source_ports "1024:"
-      end
+    firewall_rule "accept-munin-#{server}" do
+      action :accept
+      family interface[:family]
+      source "#{interface[:zone]}:#{interface[:address]}"
+      dest "fw"
+      proto "tcp:syn"
+      dest_ports "munin"
+      source_ports "1024:"
     end
   end
 end
@@ -160,7 +158,7 @@ else
   end
 end
 
-munin_plugin "hpasmcli_temp" do
+munin_plugin "hpasmcli_temp" do # ~FC005
   action :delete
 end
 

diff --git a/cookbooks/mysql/recipes/default.rb b/cookbooks/mysql/recipes/default.rb
index 063526fdc663ebd9d0762f2ba17c0b787824a7aa..5ef61b82597f4efabd4904c65a19e77787575905 100644 (file)
--- a/cookbooks/mysql/recipes/default.rb
+++ b/cookbooks/mysql/recipes/default.rb
@@ -36,94 +36,14 @@ end
 package "libdbd-mysql-perl"
 package "libcache-cache-perl"
 
-munin_plugin "mysql_bin_relay_log" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_commands" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_connections" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_files_tables" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_bpool" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_bpool_act" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_insert_buf" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_io" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_io_pend" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_log" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_rows" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_semaphores" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_innodb_tnx" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_myisam_indexes" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_network_traffic" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_qcache" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_qcache_mem" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_replication" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_select_types" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_slow" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_sorts" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_table_locks" do
-  target "mysql_"
-end
-
-munin_plugin "mysql_tmp_tables" do
-  target "mysql_"
+%w(
+  bin_relay_log commands connections files_tables innodb_bpool
+  innodb_bpool_act innodb_insert_buf innodb_io innodb_io_pend
+  innodb_log innodb_rows innodb_semaphores innodb_tnx myisam_indexes
+  network_traffic qcache qcache_mem replication select_types slow
+  sorts table_locks tmp_tables
+).each do |stat|
+  munin_plugin "mysql_#{stat}" do
+    target "mysql_"
+  end
 end

diff --git a/cookbooks/networking/recipes/default.rb b/cookbooks/networking/recipes/default.rb
index 50fa35cfb6bcafcfbdff420c939cabb7dfe257f4..2fc170b801d258453d0acbaedd6d094ad931c2b2 100644 (file)
--- a/cookbooks/networking/recipes/default.rb
+++ b/cookbooks/networking/recipes/default.rb
@@ -86,7 +86,7 @@ node.interfaces(:role => :internal) do |interface|
       next unless gateway[:openvpn]
 
       gateway[:openvpn][:tunnels].each_value do |tunnel|
-        if tunnel[:peer][:address]
+        if tunnel[:peer][:address] # ~FC023
           route tunnel[:peer][:address] do
             netmask "255.255.255.255"
             gateway interface[:gateway]

diff --git a/cookbooks/openssh/recipes/default.rb b/cookbooks/openssh/recipes/default.rb
index fce68dbdd62836f6270fa46cbc55f4a54fb26fd2..a8af1dece79ad0fc3be8232f7a4aefbf24d277d6 100644 (file)
--- a/cookbooks/openssh/recipes/default.rb
+++ b/cookbooks/openssh/recipes/default.rb
@@ -44,14 +44,14 @@ hosts = search(:node, "networking:interfaces").sort_by { |n| n[:hostname] }.coll
   end
 
   keys = {
-    "rsa" => node[:keys][:ssh][:host_rsa_public],
-    "dsa" => node[:keys][:ssh][:host_dsa_public]
+    "rsa" => node[:keys][:ssh][:host_rsa_public],            # ~FC039
+    "dsa" => node[:keys][:ssh][:host_dsa_public]             # ~FC039
   }
 
-  if node[:keys][:ssh][:host_ecdsa_public]
-    ecdsa_type = node[:keys][:ssh][:host_ecdsa_type]
+  if node[:keys][:ssh][:host_ecdsa_public]                   # ~FC039
+    ecdsa_type = node[:keys][:ssh][:host_ecdsa_type]         # ~FC039
 
-    keys[ecdsa_type] = node[:keys][:ssh][:host_ecdsa_public]
+    keys[ecdsa_type] = node[:keys][:ssh][:host_ecdsa_public] # ~FC039
   end
 
   Hash[

diff --git a/cookbooks/otrs/recipes/default.rb b/cookbooks/otrs/recipes/default.rb
index a3ebf21f431d2c0351b6c7229305b0d7fcf8632c..18b0c2ea613d1ce875f980a7e43f6aa0aec51ae9 100644 (file)
--- a/cookbooks/otrs/recipes/default.rb
+++ b/cookbooks/otrs/recipes/default.rb
@@ -47,13 +47,13 @@ database_user = node[:otrs][:database_user]
 database_password = passwords[node[:otrs][:database_password]]
 site = node[:otrs][:site]
 
-remote_file "/tmp/otrs-#{version}.tar.bz2" do
+remote_file "#{Chef::Config[:file_cache_path]}/otrs-#{version}.tar.bz2" do
   source "http://ftp.otrs.org/pub/otrs/otrs-#{version}.tar.bz2"
   not_if { File.exist?("/opt/otrs-#{version}") }
 end
 
 execute "untar-otrs-#{version}" do
-  command "tar jxf /tmp/otrs-#{version}.tar.bz2"
+  command "tar jxf #{Chef::Config[:file_cache_path]}/otrs-#{version}.tar.bz2"
   cwd "/opt"
   user "root"
   group "root"

diff --git a/cookbooks/piwik/recipes/default.rb b/cookbooks/piwik/recipes/default.rb
index d711930a1e019be0c2811a7eb02cf9f2127674f1..a3eb24ad8ebda0d4892d695b99ea0611d21ccd21 100644 (file)
--- a/cookbooks/piwik/recipes/default.rb
+++ b/cookbooks/piwik/recipes/default.rb
@@ -43,13 +43,13 @@ directory "/opt/piwik-#{version}" do
   mode "0755"
 end
 
-remote_file "/tmp/piwik-#{version}.zip" do
+remote_file "#{Chef::Config[:file_cache_path]}/piwik-#{version}.zip" do
   source "http://builds.piwik.org/piwik-#{version}.zip"
   not_if { File.exist?("/opt/piwik-#{version}/piwik") }
 end
 
 execute "unzip-piwik-#{version}" do
-  command "unzip -q /tmp/piwik-#{version}.zip"
+  command "unzip -q #{Chef::Config[:file_cache_path]}/piwik-#{version}.zip"
   cwd "/opt/piwik-#{version}"
   user "root"
   group "root"

diff --git a/cookbooks/taginfo/recipes/default.rb b/cookbooks/taginfo/recipes/default.rb
index f1d5bb86934906e8ca18a2b3042b885ced64d196..0416e2e5b7e9cb76de0dc0442e86c85f55339837 100644 (file)
--- a/cookbooks/taginfo/recipes/default.rb
+++ b/cookbooks/taginfo/recipes/default.rb
@@ -145,40 +145,12 @@ node[:taginfo][:sites].each do |site|
     notifies :restart, "service[apache2]"
   end
 
-  directory "#{directory}/taginfo/web/tmp" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
-  directory "#{directory}/data" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
-  directory "#{directory}/data/old" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
-  directory "#{directory}/download" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
-  directory "#{directory}/sources" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
-  directory "#{directory}/planet" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
+  %w(taginfo/web/tmp bin data data/old download sources planet planet/log planet/replication).each do |dir|
+    directory "#{directory}/#{dir}" do
+      owner "taginfo"
+      group "taginfo"
+      mode 0755
+    end
   end
 
   remote_file "#{directory}/planet/planet.pbf" do
@@ -189,18 +161,6 @@ node[:taginfo][:sites].each do |site|
     mode 0644
   end
 
-  directory "#{directory}/planet/log" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
-  directory "#{directory}/planet/replication" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
   template "#{directory}/planet/replication/configuration.txt" do
     source "configuration.txt.erb"
     owner "taginfo"
@@ -214,12 +174,6 @@ node[:taginfo][:sites].each do |site|
     mode 0644
   end
 
-  directory "#{directory}/bin" do
-    owner "taginfo"
-    group "taginfo"
-    mode 0755
-  end
-
   template "#{directory}/bin/update-planet" do
     source "update-planet.erb"
     owner "taginfo"

diff --git a/cookbooks/tilecache/recipes/default.rb b/cookbooks/tilecache/recipes/default.rb
index ce4819ad098a21621f162de63ef6a76707adb55c..19c99b0ce9482752f154cb950dfc726a00af1709 100644 (file)
--- a/cookbooks/tilecache/recipes/default.rb
+++ b/cookbooks/tilecache/recipes/default.rb
@@ -84,7 +84,7 @@ nginx_site "default" do
 end
 
 resolvers = node[:networking][:nameservers].map do |resolver|
-  IPAddr.new(resolver).ipv6? ? "[#{resolver}]" : "#{resolver}"
+  IPAddr.new(resolver).ipv6? ? "[#{resolver}]" : resolver
 end
 
 nginx_site "tile-ssl" do

diff --git a/cookbooks/wiki/README.md b/cookbooks/wiki/README.md
new file mode 100644 (file)
index 0000000..2057391
--- /dev/null
+++ b/cookbooks/wiki/README.md
@@ -0,0 +1,34 @@
+Cookbook
+========
+TODO: Enter the cookbook description here.
+
+e.g.
+This cookbook makes your favorite breakfast sandwich.
+
+Requirements
+------------
+TODO: List your cookbook requirements. Be sure to include any requirements this cookbook has on platforms, libraries, other cookbooks, packages, operating systems, etc.
+
+Attributes
+----------
+TODO: List you cookbook attributes here.
+
+Usage
+-----
+TODO: Write usage instructions for each cookbook.
+
+Contributing
+------------
+TODO: (optional) If this is a public cookbook, detail the process for contributing. If this is a private cookbook, remove this section.
+
+e.g.
+1. Fork the repository on Github
+2. Create a named feature branch (like `add_component_x`)
+3. Write your change
+4. Write tests for your change (if applicable)
+5. Run the tests, ensuring they all pass
+6. Submit a Pull Request using Github
+
+License and Authors
+-------------------
+Authors: TODO: List authors

diff --git a/cookbooks/wiki/README.rdoc b/cookbooks/wiki/README.rdoc
deleted file mode 100644 (file)
index 3de2ec7..0000000
--- a/cookbooks/wiki/README.rdoc
+++ /dev/null
@@ -1,8 +0,0 @@
-= DESCRIPTION:
-
-= REQUIREMENTS:
-
-= ATTRIBUTES:
-
-= USAGE:
-

diff --git a/cookbooks/wiki/metadata.rb b/cookbooks/wiki/metadata.rb
index e3f9063be59ecf71eaceb99b61669619577be270..b93706b8efaa3b4c14b3b0b9110413cde4cc2459 100644 (file)
--- a/cookbooks/wiki/metadata.rb
+++ b/cookbooks/wiki/metadata.rb
@@ -1,8 +1,9 @@
+name              "wiki"
 maintainer        "OpenStreetMap Administrators"
 maintainer_email  "admins@openstreetmap.org"
 license           "Apache 2.0"
 description       "Installs and configures servers for wiki.openstreetmap.org"
-long_description  IO.read(File.join(File.dirname(__FILE__), 'README.rdoc'))
+long_description  IO.read(File.join(File.dirname(__FILE__), 'README.md'))
 version           "1.0.0"
 depends           "mediawiki"
 depends           "squid"