convert functon creation to python

[nominatim.git] / test / python / test_config.py

diff --git a/test/python/test_config.py b/test/python/test_config.py
index 03e4a800afa07eafe46d415ba51c0b5b415d891c..064f71ba38c816b1eaccb8615d5fa8bbfc9d0a55 100644 (file)
--- a/test/python/test_config.py
+++ b/test/python/test_config.py
@@ -3,7 +3,6 @@ Test for loading dotenv configuration.
 """
 from pathlib import Path
 import tempfile
-import os
 
 import pytest
 
@@ -16,6 +15,7 @@ def test_no_project_dir():
 
     assert config.DATABASE_WEBUSER == 'www-data'
 
+
 def test_prefer_project_setting_over_default():
     with tempfile.TemporaryDirectory() as project_dir:
         with open(project_dir + '/.env', 'w') as envfile:
@@ -25,32 +25,71 @@ def test_prefer_project_setting_over_default():
 
         assert config.DATABASE_WEBUSER == 'apache'
 
-def test_prefer_os_environ_over_project_setting():
+
+def test_prefer_os_environ_over_project_setting(monkeypatch):
     with tempfile.TemporaryDirectory() as project_dir:
         with open(project_dir + '/.env', 'w') as envfile:
             envfile.write('NOMINATIM_DATABASE_WEBUSER=apache\n')
 
-        os.environ['NOMINATIM_DATABASE_WEBUSER'] = 'nobody'
+        monkeypatch.setenv('NOMINATIM_DATABASE_WEBUSER', 'nobody')
 
         config = Configuration(Path(project_dir), DEFCFG_DIR)
 
         assert config.DATABASE_WEBUSER == 'nobody'
 
-        del os.environ['NOMINATIM_DATABASE_WEBUSER']
 
-def test_get_os_env_add_defaults():
+def test_get_os_env_add_defaults(monkeypatch):
     config = Configuration(None, DEFCFG_DIR)
 
-    if 'NOMINATIM_DATABASE_WEBUSER' in os.environ:
-        del os.environ['NOMINATIM_DATABASE_WEBUSER']
+    monkeypatch.delenv('NOMINATIM_DATABASE_WEBUSER', raising=False)
 
     assert config.get_os_env()['NOMINATIM_DATABASE_WEBUSER'] == 'www-data'
 
-def test_get_os_env_prefer_os_environ():
+
+def test_get_os_env_prefer_os_environ(monkeypatch):
     config = Configuration(None, DEFCFG_DIR)
 
-    os.environ['NOMINATIM_DATABASE_WEBUSER'] = 'nobody'
+    monkeypatch.setenv('NOMINATIM_DATABASE_WEBUSER', 'nobody')
 
     assert config.get_os_env()['NOMINATIM_DATABASE_WEBUSER'] == 'nobody'
 
-    del os.environ['NOMINATIM_DATABASE_WEBUSER']
+
+def test_get_libpq_dsn_convert_default():
+    config = Configuration(None, DEFCFG_DIR)
+
+    assert config.get_libpq_dsn() == 'dbname=nominatim'
+
+
+def test_get_libpq_dsn_convert_php(monkeypatch):
+    config = Configuration(None, DEFCFG_DIR)
+
+    monkeypatch.setenv('NOMINATIM_DATABASE_DSN',
+                       'pgsql:dbname=gis;password=foo;host=localhost')
+
+    assert config.get_libpq_dsn() == 'dbname=gis password=foo host=localhost'
+
+
+def test_get_libpq_dsn_convert_libpq(monkeypatch):
+    config = Configuration(None, DEFCFG_DIR)
+
+    monkeypatch.setenv('NOMINATIM_DATABASE_DSN', 
+                       'host=localhost dbname=gis password=foo')
+
+    assert config.get_libpq_dsn() == 'host=localhost dbname=gis password=foo'
+
+
+@pytest.mark.parametrize("value,result",
+                         [(x, True) for x in ('1', 'true', 'True', 'yes', 'YES')] +
+                         [(x, False) for x in ('0', 'false', 'no', 'NO', 'x')])
+def test_get_bool(monkeypatch, value, result):
+    config = Configuration(None, DEFCFG_DIR)
+
+    monkeypatch.setenv('NOMINATIM_FOOBAR', value)
+
+    assert config.get_bool('FOOBAR') == result
+
+def test_get_bool_empty():
+    config = Configuration(None, DEFCFG_DIR)
+
+    assert config.DATABASE_MODULE_PATH == ''
+    assert config.get_bool('DATABASE_MODULE_PATH') == False