1 # frozen_string_literal: true
5 class TracesControllerTest < ActionDispatch::IntegrationTest
7 # test all routes which lead to this controller
10 { :path => "/traces", :method => :get },
11 { :controller => "traces", :action => "index" }
14 { :path => "/traces/tag/tagname", :method => :get },
15 { :controller => "traces", :action => "index", :tag => "tagname" }
18 { :path => "/user/username/traces", :method => :get },
19 { :controller => "traces", :action => "index", :display_name => "username" }
22 { :path => "/user/username/traces/tag/tagname", :method => :get },
23 { :controller => "traces", :action => "index", :display_name => "username", :tag => "tagname" }
27 { :path => "/traces/mine", :method => :get },
28 { :controller => "traces", :action => "mine" }
31 { :path => "/traces/mine/tag/tagname", :method => :get },
32 { :controller => "traces", :action => "mine", :tag => "tagname" }
36 { :path => "/user/username/traces/1", :method => :get },
37 { :controller => "traces", :action => "show", :display_name => "username", :id => "1" }
41 { :path => "/traces/new", :method => :get },
42 { :controller => "traces", :action => "new" }
45 { :path => "/traces", :method => :post },
46 { :controller => "traces", :action => "create" }
49 { :path => "/traces/1/edit", :method => :get },
50 { :controller => "traces", :action => "edit", :id => "1" }
53 { :path => "/traces/1", :method => :put },
54 { :controller => "traces", :action => "update", :id => "1" }
57 { :path => "/traces/1", :method => :delete },
58 { :controller => "traces", :action => "destroy", :id => "1" }
62 assert_redirected_to "/traces"
64 get "/traces/tag/tagname/page/1"
65 assert_redirected_to "/traces/tag/tagname"
67 get "/user/username/traces/page/1"
68 assert_redirected_to "/user/username/traces"
70 get "/user/username/traces/tag/tagname/page/1"
71 assert_redirected_to "/user/username/traces/tag/tagname"
73 get "/traces/mine/page/1"
74 assert_redirected_to "/traces/mine"
76 get "/traces/mine/tag/tagname/page/1"
77 assert_redirected_to "/traces/mine/tag/tagname"
80 # Check that the index of traces is displayed
83 # The fourth test below is surprisingly sensitive to timestamp ordering when the timestamps are equal.
84 trace_a = create(:trace, :visibility => "identifiable", :timestamp => 4.seconds.ago) do |trace|
85 create(:tracetag, :trace => trace, :tag => "London")
87 trace_b = create(:trace, :visibility => "identifiable", :timestamp => 3.seconds.ago) do |trace|
88 create(:tracetag, :trace => trace, :tag => "Birmingham")
90 trace_c = create(:trace, :visibility => "trackable", :user => user, :timestamp => 2.seconds.ago) do |trace|
91 create(:tracetag, :trace => trace, :tag => "London")
93 trace_d = create(:trace, :visibility => "trackable", :user => user, :timestamp => 1.second.ago) do |trace|
94 create(:tracetag, :trace => trace, :tag => "Birmingham")
97 # First with the public index
99 check_trace_index [trace_b, trace_a]
101 # Restrict traces to those with a given tag
102 get traces_path(:tag => "London")
103 check_trace_index [trace_a]
107 # Should see more when we are logged in
109 check_trace_index [trace_d, trace_c, trace_b, trace_a]
111 # Again, we should see more when we are logged in
112 get traces_path(:tag => "London")
113 check_trace_index [trace_c, trace_a]
116 # Check that I can get mine
119 create(:trace, :visibility => "identifiable") do |trace|
120 create(:tracetag, :trace => trace, :tag => "Birmingham")
122 trace_b = create(:trace, :visibility => "trackable", :user => user) do |trace|
123 create(:tracetag, :trace => trace, :tag => "London")
126 # First try to get it when not logged in
128 assert_redirected_to login_path(:referer => "/traces/mine")
132 # Now try when logged in
134 assert_redirected_to :action => "index", :display_name => user.display_name
136 # Fetch the actual index
137 get traces_path(:display_name => user.display_name)
138 check_trace_index [trace_b]
141 # Check the index of traces for a specific user
144 checked_user_traces_path = url_for :only_path => true, :controller => "traces", :action => "index", :display_name => user.display_name
145 second_user = create(:user)
146 third_user = create(:user)
148 trace_b = create(:trace, :visibility => "identifiable", :user => user)
149 trace_c = create(:trace, :visibility => "trackable", :user => user) do |trace|
150 create(:tracetag, :trace => trace, :tag => "London")
153 # Test a user with no traces
154 get traces_path(:display_name => second_user.display_name)
157 # Test the user with the traces - should see only public ones
158 get traces_path(:display_name => user.display_name)
159 check_trace_index [trace_b]
160 assert_dom ".nav-tabs" do
161 assert_dom "a[href='#{traces_path}']", :text => "All Traces", :count => 1
162 assert_dom "a[href='#{traces_mine_path}']", :text => "My Traces", :count => 0
163 assert_dom "a[href='#{checked_user_traces_path}']", :text => Regexp.new(Regexp.escape(user.display_name)), :count => 1
166 session_for(third_user)
168 # Should still see only public ones when authenticated as another user
169 get traces_path(:display_name => user.display_name)
170 check_trace_index [trace_b]
171 assert_dom ".nav-tabs" do
172 assert_dom "a[href='#{traces_path}']", :text => "All Traces", :count => 1
173 assert_dom "a[href='#{traces_mine_path}']", :text => "My Traces", :count => 1
174 assert_dom "a[href='#{checked_user_traces_path}']", :text => Regexp.new(Regexp.escape(user.display_name)), :count => 1
179 # Should see all traces when authenticated as the target user
180 get traces_path(:display_name => user.display_name)
181 check_trace_index [trace_c, trace_b]
182 assert_dom ".nav-tabs" do
183 assert_dom "a[href='#{traces_path}']", :text => "All Traces", :count => 1
184 assert_dom "a[href='#{traces_mine_path}']", :text => "My Traces", :count => 1
185 assert_dom "a[href='#{checked_user_traces_path}']", :text => Regexp.new(Regexp.escape(user.display_name)), :count => 0
188 # Should only see traces with the correct tag when a tag is specified
189 get traces_path(:display_name => user.display_name, :tag => "London")
190 check_trace_index [trace_c]
192 # Should get an error if the user does not exist
193 get traces_path(:display_name => "UnknownUser")
194 assert_response :not_found
195 assert_template "users/no_such_user"
198 # Check a multi-page index
200 # Create several pages worth of traces
201 create_list(:trace, 50, :visibility => "identifiable")
202 next_path = traces_path
204 # Try and get the index
206 assert_response :success
207 assert_select "table#trace_list tbody", :count => 1 do
208 assert_select "tr", :count => 20
210 check_no_page_link "Newer Traces"
211 next_path = check_page_link "Older Traces"
213 # Try and get the second page
215 assert_response :success
216 assert_select "table#trace_list tbody", :count => 1 do
217 assert_select "tr", :count => 20
219 check_page_link "Newer Traces"
220 next_path = check_page_link "Older Traces"
222 # Try and get the third page
224 assert_response :success
225 assert_select "table#trace_list tbody", :count => 1 do
226 assert_select "tr", :count => 10
228 next_path = check_page_link "Newer Traces"
229 check_no_page_link "Older Traces"
231 # Go back to the second page
233 assert_response :success
234 assert_select "table#trace_list tbody", :count => 1 do
235 assert_select "tr", :count => 20
237 next_path = check_page_link "Newer Traces"
238 check_page_link "Older Traces"
240 # Go back to the first page
242 assert_response :success
243 assert_select "table#trace_list tbody", :count => 1 do
244 assert_select "tr", :count => 20
246 check_no_page_link "Newer Traces"
247 check_page_link "Older Traces"
250 # Check a multi-page index of tagged traces
251 def test_index_tagged_paged
252 # Create several pages worth of traces
253 create_list(:trace, 100, :visibility => "identifiable") do |trace, index|
254 create(:tracetag, :trace => trace, :tag => "London") if index.even?
256 next_path = traces_path :tag => "London"
258 # Try and get the index
260 assert_response :success
261 assert_select "table#trace_list tbody", :count => 1 do
262 assert_select "tr", :count => 20
264 check_no_page_link "Newer Traces"
265 next_path = check_page_link "Older Traces"
267 # Try and get the second page
269 assert_response :success
270 assert_select "table#trace_list tbody", :count => 1 do
271 assert_select "tr", :count => 20
273 check_page_link "Newer Traces"
274 next_path = check_page_link "Older Traces"
276 # Try and get the third page
278 assert_response :success
279 assert_select "table#trace_list tbody", :count => 1 do
280 assert_select "tr", :count => 10
282 next_path = check_page_link "Newer Traces"
283 check_no_page_link "Older Traces"
285 # Go back to the second page
287 assert_response :success
288 assert_select "table#trace_list tbody", :count => 1 do
289 assert_select "tr", :count => 20
291 next_path = check_page_link "Newer Traces"
292 check_page_link "Older Traces"
294 # Go back to the first page
296 assert_response :success
297 assert_select "table#trace_list tbody", :count => 1 do
298 assert_select "tr", :count => 20
300 check_no_page_link "Newer Traces"
301 check_page_link "Older Traces"
304 def test_index_invalid_paged
305 # Try some invalid paged accesses
306 %w[-1 fred].each do |id|
307 get traces_path(:before => id)
308 assert_redirected_to :controller => :errors, :action => :bad_request
310 get traces_path(:after => id)
311 assert_redirected_to :controller => :errors, :action => :bad_request
315 # Check that the traces index is not displayed when the traces feature is disabled
316 def test_index_disabled
317 with_settings(:traces_disabled => true) do
319 assert_response :not_found
323 # Test showing a trace
325 public_trace_file = create(:trace, :visibility => "identifiable")
327 # First with no auth, which should work since the trace is public
328 get show_trace_path(public_trace_file.user, public_trace_file)
329 check_trace_show public_trace_file
331 # Now with some other user, which should work since the trace is public
332 session_for(create(:user))
333 get show_trace_path(public_trace_file.user, public_trace_file)
334 check_trace_show public_trace_file
336 # And finally we should be able to do it with the owner of the trace
337 session_for(public_trace_file.user)
338 get show_trace_path(public_trace_file.user, public_trace_file)
339 check_trace_show public_trace_file
342 # Check an anonymous trace can't be viewed by another user
344 anon_trace_file = create(:trace, :visibility => "trackable")
347 get show_trace_path(anon_trace_file.user, anon_trace_file)
348 assert_redirected_to :action => :index
350 # Now with some other user, which should not work since the trace is anon
351 session_for(create(:user))
352 get show_trace_path(anon_trace_file.user, anon_trace_file)
353 assert_redirected_to :action => :index
355 # And finally we should be able to do it with the owner of the trace
356 session_for(anon_trace_file.user)
357 get show_trace_path(anon_trace_file.user, anon_trace_file)
358 check_trace_show anon_trace_file
361 # Test showing a trace that doesn't exist
362 def test_show_not_found
363 deleted_trace_file = create(:trace, :deleted)
365 # First with a trace that has never existed
366 get show_trace_path(create(:user), 0)
367 assert_redirected_to :action => :index
369 # Now with a trace that has been deleted
370 session_for(deleted_trace_file.user)
371 get show_trace_path(deleted_trace_file.user, deleted_trace_file)
372 assert_redirected_to :action => :index
375 # Test fetching the new trace page
379 assert_redirected_to login_path(:referer => new_trace_path)
381 # Now authenticated as a user with gps.trace.visibility set
383 create(:user_preference, :user => user, :k => "gps.trace.visibility", :v => "identifiable")
386 assert_response :success
388 assert_select "select#trace_visibility option[value=identifiable][selected]", 1
390 # Now authenticated as a user with the legacy gps.trace.public preference,
391 # which is no longer supported and falls back to trackable
392 second_user = create(:user)
393 create(:user_preference, :user => second_user, :k => "gps.trace.public", :v => "default")
394 session_for(second_user)
396 assert_response :success
398 assert_select "select#trace_visibility option[value=trackable][selected]", 1
400 # Now authenticated as a user with no preferences, defaults to trackable
401 third_user = create(:user)
402 session_for(third_user)
404 assert_response :success
406 assert_select "select#trace_visibility option[value=trackable][selected]", 1
407 # New uploads only offer the two supported visibilities
408 assert_select "select#trace_visibility option", 2
411 # Test creating a trace
414 fixture = Rails.root.join("test/gpx/fixtures/a.gpx")
415 file = Rack::Test::UploadedFile.new(fixture, "application/gpx+xml")
419 post traces_path(:trace => { :gpx_file => file, :description => "New Trace", :tagstring => "new,trace", :visibility => "trackable" })
420 assert_response :forbidden
426 create(:user_preference, :user => user, :k => "gps.trace.visibility", :v => "identifiable")
427 assert_not_equal "trackable", user.preferences.find_by(:k => "gps.trace.visibility").v
429 post traces_path, :params => { :trace => { :gpx_file => file, :description => "New Trace", :tagstring => "new,trace", :visibility => "trackable" } }
430 assert_redirected_to :action => :index, :display_name => user.display_name
431 assert_match(/file has been uploaded/, flash[:notice])
432 trace = Trace.order(:id => :desc).first
433 assert_equal "a.gpx", trace.name
434 assert_equal "New Trace", trace.description
435 assert_equal %w[new trace], trace.tags.order(:tag).collect(&:tag)
436 assert_equal "trackable", trace.visibility
437 assert_not trace.inserted
438 assert_equal File.new(fixture).read, trace.file.blob.download
440 assert_equal "trackable", user.preferences.find_by(:k => "gps.trace.visibility").v
443 # A legacy visibility (public or private) is no longer accepted on upload
444 def test_create_post_with_legacy_visibility
445 fixture = Rails.root.join("test/gpx/fixtures/a.gpx")
446 file = Rack::Test::UploadedFile.new(fixture, "application/gpx+xml")
450 assert_no_difference "Trace.count" do
451 post traces_path, :params => { :trace => { :gpx_file => file, :description => "New Trace", :tagstring => "new,trace", :visibility => "public" } }
456 # Test creating a trace with validation errors
457 def test_create_post_with_validation_errors
459 fixture = Rails.root.join("test/gpx/fixtures/a.gpx")
460 file = Rack::Test::UploadedFile.new(fixture, "application/gpx+xml")
464 create(:user_preference, :user => user, :k => "gps.trace.visibility", :v => "identifiable")
465 assert_not_equal "trackable", user.preferences.find_by(:k => "gps.trace.visibility").v
467 post traces_path, :params => { :trace => { :gpx_file => file, :description => "", :tagstring => "new,trace", :visibility => "trackable" } }
469 assert_match "is too short (minimum is 1 character)", response.body
472 # Test fetching the edit page for a trace using GET
474 public_trace_file = create(:trace, :visibility => "identifiable")
475 deleted_trace_file = create(:trace, :deleted)
478 get edit_trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file)
479 assert_redirected_to login_path(:referer => edit_trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file.id))
481 # Now with some other user, which should fail
482 session_for(create(:user))
483 get edit_trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file)
484 assert_response :forbidden
486 # Now with a trace which doesn't exist
487 session_for(create(:user))
488 get edit_trace_path(:display_name => create(:user).display_name, :id => 0)
489 assert_response :not_found
491 # Now with a trace which has been deleted
492 session_for(deleted_trace_file.user)
493 get edit_trace_path(:display_name => deleted_trace_file.user.display_name, :id => deleted_trace_file)
494 assert_response :not_found
496 # Finally with a trace that we are allowed to edit
497 session_for(public_trace_file.user)
498 get edit_trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file)
499 assert_response :success
502 # An old visibility stays selected in the edit form, so changing other fields
503 # does not change it by mistake.
504 def test_edit_get_keeps_legacy_visibility
505 trace = create(:trace, :without_validations, :visibility => "private")
507 session_for(trace.user)
508 get edit_trace_path(:display_name => trace.user.display_name, :id => trace)
509 assert_response :success
510 assert_select "select#trace_visibility option", 3
511 assert_select "select#trace_visibility option[value=private][selected]", 1
514 # Test saving edits to a trace
516 public_trace_file = create(:trace, :visibility => "identifiable")
517 deleted_trace_file = create(:trace, :deleted)
520 new_details = { :description => "Changed description", :tagstring => "new_tag", :visibility => "trackable" }
523 put trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file, :trace => new_details)
524 assert_response :forbidden
526 # Now with some other user, which should fail
527 session_for(create(:user))
528 put trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file, :trace => new_details)
529 assert_response :forbidden
531 # Now with a trace which doesn't exist
532 session_for(create(:user))
533 put trace_path(:display_name => create(:user).display_name, :id => 0, :trace => new_details)
534 assert_response :not_found
536 # Now with a trace which has been deleted
537 session_for(deleted_trace_file.user)
538 put trace_path(:display_name => deleted_trace_file.user.display_name, :id => deleted_trace_file, :trace => new_details)
539 assert_response :not_found
541 # Finally with a trace that we are allowed to edit
542 session_for(public_trace_file.user)
543 put trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file, :trace => new_details)
544 assert_redirected_to :action => :show, :display_name => public_trace_file.user.display_name
545 trace = Trace.find(public_trace_file.id)
546 assert_equal new_details[:description], trace.description
547 assert_equal new_details[:tagstring], trace.tagstring
548 assert_equal new_details[:visibility], trace.visibility
551 # Test invalid updates
552 def test_update_invalid
553 trace = create(:trace)
556 session_for(trace.user)
557 put trace_path(trace, :trace => { :description => "Changed description", :tagstring => "new_tag", :visibility => "wrong" })
558 assert_response :success
559 assert_select "title", :text => /^Editing Trace/
562 # Test destroying a trace
564 public_trace_file = create(:trace, :visibility => "identifiable")
565 deleted_trace_file = create(:trace, :deleted)
568 delete trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file)
569 assert_response :forbidden
571 # Now with some other user, which should fail
572 session_for(create(:user))
573 delete trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file)
574 assert_response :forbidden
576 # Now with a trace which doesn't exist
577 session_for(create(:user))
578 delete trace_path(:display_name => create(:user).display_name, :id => 0)
579 assert_response :not_found
581 # Now with a trace has already been deleted
582 session_for(deleted_trace_file.user)
583 delete trace_path(:display_name => deleted_trace_file.user.display_name, :id => deleted_trace_file)
584 assert_response :not_found
586 # Now with a trace that we are allowed to delete
587 session_for(public_trace_file.user)
588 delete trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file)
589 assert_redirected_to :action => :index, :display_name => public_trace_file.user.display_name
590 trace = Trace.find(public_trace_file.id)
591 assert_not trace.visible
593 # Finally with a trace that is destroyed by an admin
594 public_trace_file = create(:trace, :visibility => "identifiable")
595 admin = create(:administrator_user)
597 delete trace_path(:display_name => public_trace_file.user.display_name, :id => public_trace_file)
598 assert_redirected_to :action => :index, :display_name => public_trace_file.user.display_name
599 trace = Trace.find(public_trace_file.id)
600 assert_not trace.visible
605 def check_trace_index(traces)
606 assert_response :success
607 assert_template "index"
610 assert_select "h2", /Nothing here yet/
612 assert_select "table#trace_list tbody", :count => 1 do
613 assert_select "tr", :count => traces.length do |rows|
614 traces.zip(rows).each do |trace, row|
615 assert_select row, "a", Regexp.new(Regexp.escape(trace.name))
616 assert_select row, "li", Regexp.new(Regexp.escape("#{trace.size} points")) if trace.inserted?
617 assert_select row, "td", Regexp.new(Regexp.escape(trace.description))
618 assert_select row, "td", Regexp.new(Regexp.escape("by #{trace.user.display_name}"))
619 assert_select row, "a[href='#{user_path trace.user}']", :text => trace.user.display_name
626 def check_no_page_link(name)
627 assert_select "a.page-link", { :text => /#{Regexp.quote(name)}/, :count => 0 }, "unexpected #{name} page link"
630 def check_page_link(name)
631 assert_select "a.page-link", { :text => /#{Regexp.quote(name)}/ }, "missing #{name} page link" do |buttons|
632 return buttons.first.attributes["href"].value
636 def check_trace_show(trace)
637 assert_response :success
638 assert_template "show"
640 assert_select "table", :count => 1 do
641 assert_select "td", /^#{Regexp.quote(trace.name)} /
642 assert_select "td a[href='#{user_path trace.user}']", :text => trace.user.display_name
643 assert_select "td", trace.description