test/controllers/api/changesets/uploads_controller_test.rb

   1 require "test_helper"
   2
   3 module Api
   4   module Changesets
   5     class UploadsControllerTest < ActionDispatch::IntegrationTest
   6       ##
   7       # test all routes which lead to this controller
   8       def test_routes
   9         assert_routing(
  10           { :path => "/api/0.6/changeset/1/upload", :method => :post },
  11           { :controller => "api/changesets/uploads", :action => "create", :changeset_id => "1" }
  12         )
  13       end
  14
  15       def test_upload_when_unauthorized
  16         changeset = create(:changeset)
  17         node = create(:node, :latitude => 0, :longitude => 0)
  18
  19         diff = <<~CHANGESET
  20           <osmChange>
  21             <modify>
  22               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
  23             </modify>
  24           </osmChange>
  25         CHANGESET
  26
  27         post api_changeset_upload_path(changeset), :params => diff
  28
  29         assert_response :unauthorized
  30
  31         assert_no_changes_in changeset
  32
  33         node.reload
  34         assert_equal 1, node.version
  35         assert_equal 0, node.latitude
  36         assert_equal 0, node.longitude
  37       end
  38
  39       def test_upload_by_private_user
  40         user = create(:user, :data_public => false)
  41         changeset = create(:changeset, :user => user)
  42         node = create(:node, :latitude => 0, :longitude => 0)
  43
  44         diff = <<~CHANGESET
  45           <osmChange>
  46             <modify>
  47               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
  48             </modify>
  49           </osmChange>
  50         CHANGESET
  51
  52         auth_header = bearer_authorization_header user
  53
  54         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
  55
  56         assert_response :forbidden
  57
  58         assert_no_changes_in changeset
  59
  60         node.reload
  61         assert_equal 1, node.version
  62         assert_equal 0, node.latitude
  63         assert_equal 0, node.longitude
  64       end
  65
  66       def test_upload_without_required_scope
  67         user = create(:user)
  68         changeset = create(:changeset, :user => user)
  69         node = create(:node, :latitude => 0, :longitude => 0)
  70
  71         diff = <<~CHANGESET
  72           <osmChange>
  73             <modify>
  74               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
  75             </modify>
  76           </osmChange>
  77         CHANGESET
  78
  79         auth_header = bearer_authorization_header user, :scopes => %w[read_prefs]
  80
  81         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
  82
  83         assert_response :forbidden
  84
  85         assert_no_changes_in changeset
  86
  87         node.reload
  88         assert_equal 1, node.version
  89         assert_equal 0, node.latitude
  90         assert_equal 0, node.longitude
  91       end
  92
  93       def test_upload_with_required_scope
  94         user = create(:user)
  95         changeset = create(:changeset, :user => user)
  96         node = create(:node, :latitude => 0, :longitude => 0)
  97
  98         diff = <<~CHANGESET
  99           <osmChange>
 100             <modify>
 101               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
 102             </modify>
 103           </osmChange>
 104         CHANGESET
 105
 106         auth_header = bearer_authorization_header user, :scopes => %w[write_api]
 107
 108         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 109
 110         assert_response :success
 111
 112         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 113           assert_dom "> node", 1 do
 114             assert_dom "> @old_id", node.id.to_s
 115             assert_dom "> @new_id", node.id.to_s
 116             assert_dom "> @new_version", "2"
 117           end
 118         end
 119
 120         changeset.reload
 121         assert_equal 1, changeset.num_changes
 122         assert_predicate changeset, :num_type_changes_in_sync?
 123         assert_equal 1, changeset.num_modified_nodes
 124
 125         node.reload
 126         assert_equal 2, node.version
 127         assert_equal 2 * GeoRecord::SCALE, node.latitude
 128         assert_equal 1 * GeoRecord::SCALE, node.longitude
 129       end
 130
 131       ##
 132       # try to upload with commands other than create, modify, or delete
 133       def test_upload_unknown_action
 134         changeset = create(:changeset)
 135
 136         diff = <<~CHANGESET
 137           <osmChange>
 138             <ping>
 139               <node id='1' lon='1' lat='1' changeset='#{changeset.id}' />
 140             </ping>
 141           </osmChange>
 142         CHANGESET
 143
 144         auth_header = bearer_authorization_header changeset.user
 145
 146         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 147
 148         assert_response :bad_request
 149         assert_equal "Unknown action ping, choices are create, modify, delete", @response.body
 150
 151         assert_no_changes_in changeset
 152       end
 153
 154       ##
 155       # test for issues in https://github.com/openstreetmap/trac-tickets/issues/1568
 156       def test_upload_empty_changeset
 157         changeset = create(:changeset)
 158
 159         auth_header = bearer_authorization_header changeset.user
 160
 161         ["<osmChange/>",
 162          "<osmChange></osmChange>",
 163          "<osmChange><modify/></osmChange>",
 164          "<osmChange><modify></modify></osmChange>"].each do |diff|
 165           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 166
 167           assert_response :success
 168         end
 169
 170         assert_no_changes_in changeset
 171       end
 172
 173       ##
 174       # test that the X-Error-Format header works to request XML errors
 175       def test_upload_xml_errors
 176         changeset = create(:changeset)
 177         node = create(:node)
 178         create(:relation_member, :member => node)
 179
 180         # try and delete a node that is in use
 181         diff = XML::Document.new
 182         diff.root = XML::Node.new "osmChange"
 183         delete = XML::Node.new "delete"
 184         diff.root << delete
 185         delete << xml_node_for_node(node)
 186
 187         auth_header = bearer_authorization_header changeset.user
 188         error_header = error_format_header "xml"
 189
 190         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header.merge(error_header)
 191
 192         assert_response :success
 193
 194         assert_dom "osmError[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1
 195         assert_dom "osmError>status", 1
 196         assert_dom "osmError>message", 1
 197       end
 198
 199       # -------------------------------------
 200       # Test creating elements.
 201       # -------------------------------------
 202
 203       def test_upload_create_node
 204         user = create(:user)
 205         changeset = create(:changeset, :user => user)
 206
 207         diff = <<~CHANGESET
 208           <osmChange>
 209             <create>
 210               <node id='-1' lon='30' lat='60' changeset='#{changeset.id}'>
 211                 <tag k='amenity' v='bar'/>
 212                 <tag k='name' v='Foo'/>
 213               </node>
 214             </create>
 215           </osmChange>
 216         CHANGESET
 217
 218         auth_header = bearer_authorization_header user
 219
 220         assert_difference "Node.count" => 1,
 221                           "OldNode.count" => 1,
 222                           "NodeTag.count" => 2,
 223                           "OldNodeTag.count" => 2 do
 224           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 225
 226           assert_response :success
 227         end
 228
 229         node = nil
 230         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 231           assert_dom "> node", 1 do |(node_el)|
 232             node = Node.find(node_el["new_id"].to_i)
 233             assert_dom "> @old_id", "-1"
 234             assert_dom "> @new_version", "1"
 235           end
 236         end
 237
 238         changeset.reload
 239         assert_equal 1, changeset.num_changes
 240         assert_predicate changeset, :num_type_changes_in_sync?
 241         assert_equal 1, changeset.num_created_nodes
 242
 243         assert_equal 1, node.version
 244         assert_equal changeset, node.changeset
 245         assert_predicate node, :visible?
 246         assert_equal({ "name" => "Foo", "amenity" => "bar" }, node.tags)
 247         assert_equal 60, node.lat
 248         assert_equal 30, node.lon
 249       end
 250
 251       def test_upload_create_way
 252         node1 = create(:node)
 253         node2 = create(:node)
 254         user = create(:user)
 255         changeset = create(:changeset, :user => user)
 256
 257         diff = <<~CHANGESET
 258           <osmChange>
 259             <create>
 260               <way id='-1' changeset='#{changeset.id}'>
 261                 <tag k='highway' v='primary'/>
 262                 <tag k='name' v='Foo'/>
 263                 <nd ref='#{node1.id}'/>
 264                 <nd ref='#{node2.id}'/>
 265               </way>
 266             </create>
 267           </osmChange>
 268         CHANGESET
 269
 270         auth_header = bearer_authorization_header user
 271
 272         assert_difference "Way.count" => 1,
 273                           "OldWay.count" => 1,
 274                           "WayTag.count" => 2,
 275                           "OldWayTag.count" => 2,
 276                           "WayNode.count" => 2,
 277                           "OldWayNode.count" => 2 do
 278           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 279
 280           assert_response :success
 281         end
 282
 283         way = nil
 284         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 285           assert_dom "> way", 1 do |(way_el)|
 286             way = Way.find(way_el["new_id"].to_i)
 287             assert_dom "> @old_id", "-1"
 288             assert_dom "> @new_version", "1"
 289           end
 290         end
 291
 292         changeset.reload
 293         assert_equal 1, changeset.num_changes
 294         assert_predicate changeset, :num_type_changes_in_sync?
 295         assert_equal 1, changeset.num_created_ways
 296
 297         assert_equal 1, way.version
 298         assert_equal changeset, way.changeset
 299         assert_predicate way, :visible?
 300         assert_equal({ "name" => "Foo", "highway" => "primary" }, way.tags)
 301         assert_equal [node1, node2], way.nodes
 302       end
 303
 304       def test_upload_create_relation
 305         node1 = create(:node)
 306         way1 = create(:way_with_nodes)
 307         relation1 = create(:relation)
 308         user = create(:user)
 309         changeset = create(:changeset, :user => user)
 310
 311         diff = <<~CHANGESET
 312           <osmChange>
 313             <create>
 314               <relation id='-1' changeset='#{changeset.id}'>
 315                 <member type='node' role='n_role' ref='#{node1.id}'/>
 316                 <member type='way' role='w_role' ref='#{way1.id}'/>
 317                 <member type='relation' role='r_role' ref='#{relation1.id}'/>
 318                 <tag k='type' v='collection'/>
 319               </relation>
 320             </create>
 321           </osmChange>
 322         CHANGESET
 323
 324         auth_header = bearer_authorization_header user
 325
 326         assert_difference "Relation.count" => 1,
 327                           "OldRelation.count" => 1,
 328                           "RelationTag.count" => 1,
 329                           "OldRelationTag.count" => 1,
 330                           "RelationMember.count" => 3,
 331                           "OldRelationMember.count" => 3 do
 332           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 333
 334           assert_response :success
 335         end
 336
 337         relation = nil
 338         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 339           assert_dom "> relation", 1 do |(relation_el)|
 340             relation = Relation.find(relation_el["new_id"].to_i)
 341             assert_dom "> @old_id", "-1"
 342             assert_dom "> @new_version", "1"
 343           end
 344         end
 345
 346         changeset.reload
 347         assert_equal 1, changeset.num_changes
 348         assert_predicate changeset, :num_type_changes_in_sync?
 349         assert_equal 1, changeset.num_created_relations
 350
 351         assert_equal 1, relation.version
 352         assert_equal changeset, relation.changeset
 353         assert_predicate relation, :visible?
 354         assert_equal({ "type" => "collection" }, relation.tags)
 355         assert_equal [["Node", node1.id, "n_role"],
 356                       ["Way", way1.id, "w_role"],
 357                       ["Relation", relation1.id, "r_role"]], relation.members
 358       end
 359
 360       def test_upload_create_elements
 361         user = create(:user)
 362         changeset = create(:changeset, :user => user)
 363         node = create(:node)
 364         way = create(:way_with_nodes, :nodes_count => 2)
 365         relation = create(:relation)
 366
 367         diff = <<~CHANGESET
 368           <osmChange>
 369             <create>
 370               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
 371                 <tag k='foo' v='bar'/>
 372                 <tag k='baz' v='bat'/>
 373               </node>
 374               <way id='-1' changeset='#{changeset.id}'>
 375                 <nd ref='#{node.id}'/>
 376               </way>
 377             </create>
 378             <create>
 379               <relation id='-1' changeset='#{changeset.id}'>
 380                 <member type='way' role='some' ref='#{way.id}'/>
 381                 <member type='node' role='some' ref='#{node.id}'/>
 382                 <member type='relation' role='some' ref='#{relation.id}'/>
 383               </relation>
 384             </create>
 385           </osmChange>
 386         CHANGESET
 387
 388         auth_header = bearer_authorization_header user
 389
 390         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 391
 392         assert_response :success
 393
 394         new_node_id, new_way_id, new_rel_id = nil
 395         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 396           # inspect the response to find out what the new element IDs are
 397           # check the old IDs are all present and negative one
 398           # check the versions are present and equal one
 399           assert_dom "> node", 1 do |(node_el)|
 400             new_node_id = node_el["new_id"].to_i
 401             assert_dom "> @old_id", "-1"
 402             assert_dom "> @new_version", "1"
 403           end
 404           assert_dom "> way", 1 do |(way_el)|
 405             new_way_id = way_el["new_id"].to_i
 406             assert_dom "> @old_id", "-1"
 407             assert_dom "> @new_version", "1"
 408           end
 409           assert_dom "> relation", 1 do |(rel_el)|
 410             new_rel_id = rel_el["new_id"].to_i
 411             assert_dom "> @old_id", "-1"
 412             assert_dom "> @new_version", "1"
 413           end
 414         end
 415
 416         changeset.reload
 417         assert_equal 3, changeset.num_changes
 418         assert_predicate changeset, :num_type_changes_in_sync?
 419         assert_equal 1, changeset.num_created_nodes
 420         assert_equal 1, changeset.num_created_ways
 421         assert_equal 1, changeset.num_created_relations
 422
 423         assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
 424         assert_equal 0, Way.find(new_way_id).tags.size, "new way should have no tags"
 425         assert_equal 0, Relation.find(new_rel_id).tags.size, "new relation should have no tags"
 426       end
 427
 428       ##
 429       # upload an element with a really long tag value
 430       def test_upload_create_node_with_tag_too_long
 431         changeset = create(:changeset)
 432
 433         diff = <<~CHANGESET
 434           <osmChange>
 435             <create>
 436               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
 437                 <tag k='foo' v='#{'x' * 256}'/>
 438               </node>
 439             </create>
 440           </osmChange>
 441         CHANGESET
 442
 443         auth_header = bearer_authorization_header changeset.user
 444
 445         assert_no_difference "Node.count" do
 446           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 447
 448           assert_response :bad_request
 449         end
 450
 451         assert_no_changes_in changeset
 452       end
 453
 454       def test_upload_create_nodes_with_invalid_placeholder_reuse_in_one_action_block
 455         changeset = create(:changeset)
 456
 457         diff = <<~CHANGESET
 458           <osmChange>
 459             <create>
 460               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
 461               <node id='-1' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
 462             </create>
 463           </osmChange>
 464         CHANGESET
 465
 466         auth_header = bearer_authorization_header changeset.user
 467
 468         assert_no_difference "Node.count" do
 469           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 470
 471           assert_response :bad_request
 472         end
 473
 474         assert_no_changes_in changeset
 475       end
 476
 477       def test_upload_create_nodes_with_invalid_placeholder_reuse_in_two_action_blocks
 478         changeset = create(:changeset)
 479
 480         diff = <<~CHANGESET
 481           <osmChange>
 482             <create>
 483               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
 484             </create>
 485             <create>
 486               <node id='-1' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
 487             </create>
 488           </osmChange>
 489         CHANGESET
 490
 491         auth_header = bearer_authorization_header changeset.user
 492
 493         assert_no_difference "Node.count" do
 494           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 495
 496           assert_response :bad_request
 497         end
 498
 499         assert_no_changes_in changeset
 500       end
 501
 502       def test_upload_create_way_referring_node_placeholder_defined_later
 503         changeset = create(:changeset)
 504
 505         diff = <<~CHANGESET
 506           <osmChange>
 507             <create>
 508               <way id="-1" changeset="#{changeset.id}">
 509                 <nd ref="-1"/>
 510               </way>
 511               <node id="-1" lat="1" lon="2" changeset="#{changeset.id}"/>
 512             </create>
 513           </osmChange>
 514         CHANGESET
 515
 516         auth_header = bearer_authorization_header changeset.user
 517
 518         assert_no_difference "Node.count" do
 519           assert_no_difference "Way.count" do
 520             post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 521
 522             assert_response :bad_request
 523           end
 524         end
 525         assert_equal "Placeholder node not found for reference -1 in way -1", @response.body
 526
 527         assert_no_changes_in changeset
 528       end
 529
 530       def test_upload_create_way_referring_undefined_node_placeholder
 531         changeset = create(:changeset)
 532
 533         diff = <<~CHANGESET
 534           <osmChange>
 535             <create>
 536               <way id="-1" changeset="#{changeset.id}">
 537                 <nd ref="-1"/>
 538               </way>
 539             </create>
 540           </osmChange>
 541         CHANGESET
 542
 543         auth_header = bearer_authorization_header changeset.user
 544
 545         assert_no_difference "Way.count" do
 546           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 547
 548           assert_response :bad_request
 549         end
 550         assert_equal "Placeholder node not found for reference -1 in way -1", @response.body
 551
 552         assert_no_changes_in changeset
 553       end
 554
 555       def test_upload_create_existing_way_referring_undefined_node_placeholder
 556         changeset = create(:changeset)
 557         way = create(:way)
 558
 559         diff = <<~CHANGESET
 560           <osmChange>
 561             <create>
 562               <way id="#{way.id}" changeset="#{changeset.id}" version="1">
 563                 <nd ref="-1"/>
 564               </way>
 565             </create>
 566           </osmChange>
 567         CHANGESET
 568
 569         auth_header = bearer_authorization_header changeset.user
 570
 571         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 572
 573         assert_response :bad_request
 574         assert_equal "Placeholder node not found for reference -1 in way #{way.id}", @response.body
 575
 576         assert_no_changes_in changeset
 577
 578         way.reload
 579         assert_equal 1, way.version
 580       end
 581
 582       def test_upload_create_relation_referring_undefined_node_placeholder
 583         changeset = create(:changeset)
 584
 585         diff = <<~CHANGESET
 586           <osmChange>
 587             <create>
 588               <relation id="-1" changeset="#{changeset.id}" version="1">
 589                 <member type="node" role="foo" ref="-1"/>
 590               </relation>
 591             </create>
 592           </osmChange>
 593         CHANGESET
 594
 595         auth_header = bearer_authorization_header changeset.user
 596
 597         assert_no_difference "Relation.count" do
 598           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 599
 600           assert_response :bad_request
 601         end
 602         assert_equal "Placeholder Node not found for reference -1 in relation -1.", @response.body
 603
 604         assert_no_changes_in changeset
 605       end
 606
 607       def test_upload_create_existing_relation_referring_undefined_way_placeholder
 608         changeset = create(:changeset)
 609         relation = create(:relation)
 610
 611         diff = <<~CHANGESET
 612           <osmChange>
 613             <create>
 614               <relation id="#{relation.id}" changeset="#{changeset.id}" version="1">
 615                 <member type="way" role="bar" ref="-1"/>
 616               </relation>
 617             </create>
 618           </osmChange>
 619         CHANGESET
 620
 621         auth_header = bearer_authorization_header changeset.user
 622
 623         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 624
 625         assert_response :bad_request
 626         assert_equal "Placeholder Way not found for reference -1 in relation #{relation.id}.", @response.body
 627
 628         assert_no_changes_in changeset
 629
 630         relation.reload
 631         assert_equal 1, relation.version
 632       end
 633
 634       def test_upload_create_relations_with_circular_references
 635         changeset = create(:changeset)
 636
 637         diff = <<~CHANGESET
 638           <osmChange version='0.6'>
 639             <create>
 640               <relation id='-2' version='0' changeset='#{changeset.id}'>
 641                 <member type='relation' role='' ref='-4' />
 642                 <tag k='type' v='route' />
 643                 <tag k='name' v='AtoB' />
 644               </relation>
 645               <relation id='-3' version='0' changeset='#{changeset.id}'>
 646                 <tag k='type' v='route' />
 647                 <tag k='name' v='BtoA' />
 648               </relation>
 649               <relation id='-4' version='0' changeset='#{changeset.id}'>
 650                 <member type='relation' role='' ref='-2' />
 651                 <member type='relation' role='' ref='-3' />
 652                 <tag k='type' v='route_master' />
 653                 <tag k='name' v='master' />
 654               </relation>
 655             </create>
 656           </osmChange>
 657         CHANGESET
 658
 659         auth_header = bearer_authorization_header changeset.user
 660
 661         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
 662
 663         assert_response :bad_request
 664         assert_equal "Placeholder Relation not found for reference -4 in relation -2.", @response.body
 665
 666         assert_no_changes_in changeset
 667       end
 668
 669       # -------------------------------------
 670       # Test modifying elements.
 671       # -------------------------------------
 672
 673       def test_upload_modify_node
 674         user = create(:user)
 675         changeset = create(:changeset, :user => user)
 676         node = create(:node, :latitude => 0, :longitude => 0)
 677         create(:node_tag, :node => node)
 678
 679         diff = <<~CHANGESET
 680           <osmChange>
 681             <modify>
 682               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
 683             </modify>
 684           </osmChange>
 685         CHANGESET
 686
 687         auth_header = bearer_authorization_header user
 688
 689         assert_difference "Node.count" => 0,
 690                           "OldNode.count" => 1,
 691                           "NodeTag.count" => -1,
 692                           "OldNodeTag.count" => 0 do
 693           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 694
 695           assert_response :success
 696         end
 697
 698         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 699           assert_dom "> node", 1 do
 700             assert_dom "> @old_id", node.id.to_s
 701             assert_dom "> @new_id", node.id.to_s
 702             assert_dom "> @new_version", "2"
 703           end
 704         end
 705
 706         changeset.reload
 707         assert_equal 1, changeset.num_changes
 708         assert_predicate changeset, :num_type_changes_in_sync?
 709         assert_equal 1, changeset.num_modified_nodes
 710
 711         node.reload
 712         assert_equal 2, node.version
 713         assert_equal 2 * GeoRecord::SCALE, node.latitude
 714         assert_equal 1 * GeoRecord::SCALE, node.longitude
 715         assert_equal 0, node.tags.size, "node #{node.id} should now have no tags"
 716       end
 717
 718       def test_upload_modify_way
 719         user = create(:user)
 720         changeset = create(:changeset, :user => user)
 721         node = create(:node)
 722         way = create(:way_with_nodes, :nodes_count => 3)
 723         create(:way_tag, :way => way)
 724
 725         diff = <<~CHANGESET
 726           <osmChange>
 727             <modify>
 728               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
 729                 <nd ref='#{node.id}'/>
 730               </way>
 731             </modify>
 732           </osmChange>
 733         CHANGESET
 734
 735         auth_header = bearer_authorization_header user
 736
 737         assert_difference "Way.count" => 0,
 738                           "OldWay.count" => 1,
 739                           "WayTag.count" => -1,
 740                           "OldWayTag.count" => 0,
 741                           "WayNode.count" => -2,
 742                           "OldWayNode.count" => 1 do
 743           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 744
 745           assert_response :success
 746         end
 747
 748         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 749           assert_dom "> way", 1 do
 750             assert_dom "> @old_id", way.id.to_s
 751             assert_dom "> @new_id", way.id.to_s
 752             assert_dom "> @new_version", "2"
 753           end
 754         end
 755
 756         changeset.reload
 757         assert_equal 1, changeset.num_changes
 758         assert_predicate changeset, :num_type_changes_in_sync?
 759         assert_equal 1, changeset.num_modified_ways
 760
 761         way.reload
 762         assert_equal 2, way.version
 763         assert_equal 0, way.tags.size, "way #{way.id} should now have no tags"
 764         assert_equal [node], way.nodes
 765       end
 766
 767       def test_upload_modify_relation
 768         user = create(:user)
 769         changeset = create(:changeset, :user => user)
 770         node = create(:node)
 771         way = create(:way_with_nodes)
 772         relation = create(:relation)
 773         other_relation = create(:relation)
 774         create(:relation_tag, :relation => relation)
 775
 776         diff = <<~CHANGESET
 777           <osmChange>
 778             <modify>
 779               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'>
 780                 <member type='way' role='some' ref='#{way.id}'/>
 781                 <member type='node' role='some' ref='#{node.id}'/>
 782                 <member type='relation' role='some' ref='#{other_relation.id}'/>
 783               </relation>
 784             </modify>
 785           </osmChange>
 786         CHANGESET
 787
 788         auth_header = bearer_authorization_header user
 789
 790         assert_difference "Relation.count" => 0,
 791                           "OldRelation.count" => 1,
 792                           "RelationTag.count" => -1,
 793                           "OldRelationTag.count" => 0,
 794                           "RelationMember.count" => 3,
 795                           "OldRelationMember.count" => 3 do
 796           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 797
 798           assert_response :success
 799         end
 800
 801         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 802           assert_dom "> relation", 1 do
 803             assert_dom "> @old_id", relation.id.to_s
 804             assert_dom "> @new_id", relation.id.to_s
 805             assert_dom "> @new_version", "2"
 806           end
 807         end
 808
 809         changeset.reload
 810         assert_equal 1, changeset.num_changes
 811         relation.reload
 812         assert_equal 2, relation.version
 813         assert_equal 0, relation.tags.size, "relation #{relation.id} should now have no tags"
 814         assert_equal [["Way", way.id, "some"], ["Node", node.id, "some"], ["Relation", other_relation.id, "some"]], relation.members
 815       end
 816
 817       def test_upload_modify_elements
 818         user = create(:user)
 819         changeset = create(:changeset, :user => user)
 820         node = create(:node, :latitude => 0, :longitude => 0)
 821         way = create(:way)
 822         relation = create(:relation)
 823         other_relation = create(:relation)
 824
 825         # create some tags, since we test that they are removed later
 826         create(:node_tag, :node => node)
 827         create(:way_tag, :way => way)
 828         create(:relation_tag, :relation => relation)
 829
 830         # simple diff to change a node, way and relation by removing their tags
 831         diff = <<~CHANGESET
 832           <osmChange>
 833             <modify>
 834               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
 835               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
 836                 <nd ref='#{node.id}'/>
 837               </way>
 838             </modify>
 839             <modify>
 840               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'>
 841                 <member type='way' role='some' ref='#{way.id}'/>
 842                 <member type='node' role='some' ref='#{node.id}'/>
 843                 <member type='relation' role='some' ref='#{other_relation.id}'/>
 844               </relation>
 845             </modify>
 846           </osmChange>
 847         CHANGESET
 848
 849         auth_header = bearer_authorization_header user
 850
 851         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 852
 853         assert_response :success
 854
 855         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 856           assert_dom "> node", 1 do
 857             assert_dom "> @old_id", node.id.to_s
 858             assert_dom "> @new_id", node.id.to_s
 859             assert_dom "> @new_version", "2"
 860           end
 861           assert_dom "> way", 1 do
 862             assert_dom "> @old_id", way.id.to_s
 863             assert_dom "> @new_id", way.id.to_s
 864             assert_dom "> @new_version", "2"
 865           end
 866           assert_dom "> relation", 1 do
 867             assert_dom "> @old_id", relation.id.to_s
 868             assert_dom "> @new_id", relation.id.to_s
 869             assert_dom "> @new_version", "2"
 870           end
 871         end
 872
 873         changeset.reload
 874         assert_equal 3, changeset.num_changes
 875         node.reload
 876         assert_equal 2, node.version
 877         assert_equal 2 * GeoRecord::SCALE, node.latitude
 878         assert_equal 1 * GeoRecord::SCALE, node.longitude
 879         assert_equal 0, node.tags.size, "node #{node.id} should now have no tags"
 880         way.reload
 881         assert_equal 2, way.version
 882         assert_equal 0, way.tags.size, "way #{way.id} should now have no tags"
 883         assert_equal [node], way.nodes
 884         relation.reload
 885         assert_equal 2, relation.version
 886         assert_equal 0, relation.tags.size, "relation #{relation.id} should now have no tags"
 887         assert_equal [["Way", way.id, "some"], ["Node", node.id, "some"], ["Relation", other_relation.id, "some"]], relation.members
 888       end
 889
 890       ##
 891       # upload multiple versions of the same element in the same diff.
 892       def test_upload_modify_multiple_node_versions
 893         node = create(:node)
 894         changeset = create(:changeset)
 895
 896         # change the location of a node multiple times, each time referencing
 897         # the last version. doesn't this depend on version numbers being
 898         # sequential?
 899         diff = <<~CHANGESET
 900           <osmChange>
 901             <modify>
 902               <node id='#{node.id}' lon='0.0' lat='0.0' changeset='#{changeset.id}' version='1'/>
 903               <node id='#{node.id}' lon='0.1' lat='0.0' changeset='#{changeset.id}' version='2'/>
 904               <node id='#{node.id}' lon='0.1' lat='0.1' changeset='#{changeset.id}' version='3'/>
 905               <node id='#{node.id}' lon='0.1' lat='0.2' changeset='#{changeset.id}' version='4'/>
 906               <node id='#{node.id}' lon='0.2' lat='0.2' changeset='#{changeset.id}' version='5'/>
 907               <node id='#{node.id}' lon='0.3' lat='0.2' changeset='#{changeset.id}' version='6'/>
 908               <node id='#{node.id}' lon='0.3' lat='0.3' changeset='#{changeset.id}' version='7'/>
 909               <node id='#{node.id}' lon='0.9' lat='0.9' changeset='#{changeset.id}' version='8'/>
 910             </modify>
 911           </osmChange>
 912         CHANGESET
 913
 914         auth_header = bearer_authorization_header changeset.user
 915
 916         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 917
 918         assert_response :success
 919
 920         assert_dom "diffResult>node", 8
 921
 922         changeset.reload
 923         assert_equal 8, changeset.num_changes
 924         assert_predicate changeset, :num_type_changes_in_sync?
 925         assert_equal 8, changeset.num_modified_nodes
 926
 927         node.reload
 928         assert_equal 9, node.version
 929         assert_equal 0.9 * GeoRecord::SCALE, node.latitude
 930         assert_equal 0.9 * GeoRecord::SCALE, node.longitude
 931       end
 932
 933       ##
 934       # upload multiple versions of the same element in the same diff, but
 935       # keep the version numbers the same.
 936       def test_upload_modify_duplicate_node_versions
 937         node = create(:node, :latitude => 0, :longitude => 0)
 938         changeset = create(:changeset)
 939
 940         diff = <<~CHANGESET
 941           <osmChange>
 942             <modify>
 943               <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
 944               <node id='#{node.id}' lon='2' lat='2' changeset='#{changeset.id}' version='1'/>
 945             </modify>
 946           </osmChange>
 947         CHANGESET
 948
 949         auth_header = bearer_authorization_header changeset.user
 950
 951         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 952
 953         assert_response :conflict
 954
 955         assert_no_changes_in changeset
 956
 957         node.reload
 958         assert_equal 1, node.version
 959         assert_equal 0, node.latitude
 960         assert_equal 0, node.longitude
 961       end
 962
 963       ##
 964       # try to upload some elements without specifying the version
 965       def test_upload_modify_missing_node_version
 966         node = create(:node, :latitude => 0, :longitude => 0)
 967         changeset = create(:changeset)
 968
 969         diff = <<~CHANGESET
 970           <osmChange>
 971             <modify>
 972               <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}'/>
 973             </modify>
 974           </osmChange>
 975         CHANGESET
 976
 977         auth_header = bearer_authorization_header changeset.user
 978
 979         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 980
 981         assert_response :bad_request
 982
 983         assert_no_changes_in changeset
 984
 985         node.reload
 986         assert_equal 1, node.version
 987         assert_equal 0, node.latitude
 988         assert_equal 0, node.longitude
 989       end
 990
 991       ##
 992       # create a diff which references several changesets, which should cause
 993       # a rollback and none of the diff gets committed
 994       def test_upload_modify_with_references_to_different_changesets
 995         changeset1 = create(:changeset)
 996         changeset2 = create(:changeset, :user => changeset1.user)
 997         node1 = create(:node)
 998         node2 = create(:node)
 999
1000         # simple diff to create a node way and relation using placeholders
1001         diff = <<~CHANGESET
1002           <osmChange>
1003             <modify>
1004               <node id='#{node1.id}' lon='0' lat='0' changeset='#{changeset1.id}' version='1'/>
1005             </modify>
1006             <modify>
1007               <node id='#{node2.id}' lon='0' lat='0' changeset='#{changeset2.id}' version='1'/>
1008             </modify>
1009           </osmChange>
1010         CHANGESET
1011
1012         auth_header = bearer_authorization_header changeset1.user
1013
1014         post api_changeset_upload_path(changeset1), :params => diff, :headers => auth_header
1015
1016         assert_response :conflict
1017
1018         assert_no_changes_in changeset1
1019         assert_no_changes_in changeset2
1020
1021         assert_nodes_are_equal(node1, Node.find(node1.id))
1022         assert_nodes_are_equal(node2, Node.find(node2.id))
1023       end
1024
1025       ##
1026       # upload a valid changeset which has a mixture of whitespace
1027       # to check a bug https://github.com/openstreetmap/trac-tickets/issues/1565
1028       def test_upload_modify_with_mixed_whitespace
1029         changeset = create(:changeset)
1030         node = create(:node)
1031         way = create(:way_with_nodes, :nodes_count => 2)
1032         relation = create(:relation)
1033         other_relation = create(:relation)
1034         create(:relation_tag, :relation => relation)
1035
1036         diff = <<~CHANGESET
1037           <osmChange>
1038           <modify><node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}'
1039             version='1'></node>
1040             <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}' version='2'><tag k='k' v='v'/></node></modify>
1041           <modify>
1042           <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'><member
1043             type='way' role='some' ref='#{way.id}'/><member
1044               type='node' role='some' ref='#{node.id}'/>
1045             <member type='relation' role='some' ref='#{other_relation.id}'/>
1046             </relation>
1047           </modify></osmChange>
1048         CHANGESET
1049
1050         auth_header = bearer_authorization_header changeset.user
1051
1052         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1053
1054         assert_response :success
1055
1056         assert_dom "diffResult>node", 2
1057         assert_dom "diffResult>relation", 1
1058
1059         assert_equal 1, Node.find(node.id).tags.size, "node #{node.id} should now have one tag"
1060         assert_equal 0, Relation.find(relation.id).tags.size, "relation #{relation.id} should now have no tags"
1061       end
1062
1063       def test_upload_modify_unknown_node_placeholder
1064         check_upload_results_in_not_found do |changeset|
1065           "<modify><node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/></modify>"
1066         end
1067       end
1068
1069       def test_upload_modify_unknown_way_placeholder
1070         check_upload_results_in_not_found do |changeset|
1071           "<modify><way id='-1' changeset='#{changeset.id}' version='1'/></modify>"
1072         end
1073       end
1074
1075       def test_upload_modify_unknown_relation_placeholder
1076         check_upload_results_in_not_found do |changeset|
1077           "<modify><relation id='-1' changeset='#{changeset.id}' version='1'/></modify>"
1078         end
1079       end
1080
1081       # -------------------------------------
1082       # Test deleting elements.
1083       # -------------------------------------
1084
1085       def test_upload_delete_node
1086         changeset = create(:changeset)
1087         node = create(:node, :lat => 0, :lon => 0)
1088         create(:node_tag, :node => node)
1089
1090         diff = <<~CHANGESET
1091           <osmChange>
1092             <delete>
1093               <node id='#{node.id}' changeset='#{changeset.id}' version='1' lat='0' lon='0'/>
1094             </delete>
1095           </osmChange>
1096         CHANGESET
1097
1098         auth_header = bearer_authorization_header changeset.user
1099
1100         assert_difference "Node.count" => 0,
1101                           "OldNode.count" => 1,
1102                           "NodeTag.count" => -1,
1103                           "OldNodeTag.count" => 0 do
1104           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1105
1106           assert_response :success
1107         end
1108
1109         assert_dom "diffResult", 1 do
1110           assert_dom "> node", 1 do
1111             assert_dom "> @old_id", node.id.to_s
1112           end
1113         end
1114
1115         node.reload
1116         assert_not_predicate node, :visible?
1117       end
1118
1119       def test_upload_delete_way
1120         changeset = create(:changeset)
1121         way = create(:way_with_nodes, :nodes_count => 3)
1122         create(:way_tag, :way => way)
1123
1124         diff = <<~CHANGESET
1125           <osmChange>
1126             <delete>
1127               <way id='#{way.id}' changeset='#{changeset.id}' version='1'/>
1128             </delete>
1129           </osmChange>
1130         CHANGESET
1131
1132         auth_header = bearer_authorization_header changeset.user
1133
1134         assert_difference "Way.count" => 0,
1135                           "OldWay.count" => 1,
1136                           "WayTag.count" => -1,
1137                           "OldWayTag.count" => 0,
1138                           "WayNode.count" => -3,
1139                           "OldWayNode.count" => 0 do
1140           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1141
1142           assert_response :success
1143         end
1144
1145         assert_dom "diffResult", 1 do
1146           assert_dom "> way", 1 do
1147             assert_dom "> @old_id", way.id.to_s
1148           end
1149         end
1150
1151         way.reload
1152         assert_not_predicate way, :visible?
1153       end
1154
1155       def test_upload_delete_relation
1156         changeset = create(:changeset)
1157         relation = create(:relation)
1158         create(:relation_member, :relation => relation, :member => create(:node))
1159         create(:relation_tag, :relation => relation)
1160
1161         diff = <<~CHANGESET
1162           <osmChange>
1163             <delete>
1164               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'/>
1165             </delete>
1166           </osmChange>
1167         CHANGESET
1168
1169         auth_header = bearer_authorization_header changeset.user
1170
1171         assert_difference "Relation.count" => 0,
1172                           "OldRelation.count" => 1,
1173                           "RelationTag.count" => -1,
1174                           "OldRelationTag.count" => 0,
1175                           "RelationMember.count" => -1,
1176                           "OldRelationMember.count" => 0 do
1177           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1178
1179           assert_response :success
1180         end
1181
1182         assert_dom "diffResult", 1 do
1183           assert_dom "> relation", 1 do
1184             assert_dom "> @old_id", relation.id.to_s
1185           end
1186         end
1187
1188         relation.reload
1189         assert_not_predicate relation, :visible?
1190       end
1191
1192       ##
1193       # test a complex delete where we delete elements which rely on each other
1194       # in the same transaction.
1195       def test_upload_delete_elements
1196         changeset = create(:changeset)
1197         super_relation = create(:relation)
1198         used_relation = create(:relation)
1199         used_way = create(:way)
1200         used_node = create(:node)
1201         create(:relation_member, :relation => super_relation, :member => used_relation)
1202         create(:relation_member, :relation => super_relation, :member => used_way)
1203         create(:relation_member, :relation => super_relation, :member => used_node)
1204
1205         diff = XML::Document.new
1206         diff.root = XML::Node.new "osmChange"
1207         delete = XML::Node.new "delete"
1208         diff.root << delete
1209         delete << xml_node_for_relation(super_relation)
1210         delete << xml_node_for_relation(used_relation)
1211         delete << xml_node_for_way(used_way)
1212         delete << xml_node_for_node(used_node)
1213         %w[node way relation].each do |type|
1214           delete.find("//osmChange/delete/#{type}").each do |n|
1215             n["changeset"] = changeset.id.to_s
1216           end
1217         end
1218
1219         auth_header = bearer_authorization_header changeset.user
1220
1221         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1222
1223         assert_response :success
1224
1225         assert_dom "diffResult", 1 do
1226           assert_dom "> node", 1
1227           assert_dom "> way", 1
1228           assert_dom "> relation", 2
1229         end
1230
1231         assert_not Node.find(used_node.id).visible
1232         assert_not Way.find(used_way.id).visible
1233         assert_not Relation.find(super_relation.id).visible
1234         assert_not Relation.find(used_relation.id).visible
1235       end
1236
1237       ##
1238       # test uploading a delete with no lat/lon, as they are optional in the osmChange spec.
1239       def test_upload_delete_node_without_latlon
1240         node = create(:node)
1241         changeset = create(:changeset)
1242
1243         diff = "<osmChange><delete><node id='#{node.id}' version='#{node.version}' changeset='#{changeset.id}'/></delete></osmChange>"
1244
1245         auth_header = bearer_authorization_header changeset.user
1246
1247         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1248
1249         assert_response :success
1250
1251         assert_dom "diffResult", 1 do
1252           assert_dom "> node", 1 do
1253             assert_dom "> @old_id", node.id.to_s
1254             assert_dom "> @new_id", 0
1255             assert_dom "> @new_version", 0
1256           end
1257         end
1258
1259         node.reload
1260         assert_not node.visible
1261       end
1262
1263       ##
1264       # test that deleting stuff in a transaction doesn't bypass the checks
1265       # to ensure that used elements are not deleted.
1266       def test_upload_delete_referenced_elements
1267         changeset = create(:changeset)
1268         relation = create(:relation)
1269         other_relation = create(:relation)
1270         used_way = create(:way)
1271         used_node = create(:node)
1272         create(:relation_member, :relation => relation, :member => used_way)
1273         create(:relation_member, :relation => relation, :member => used_node)
1274
1275         diff = XML::Document.new
1276         diff.root = XML::Node.new "osmChange"
1277         delete = XML::Node.new "delete"
1278         diff.root << delete
1279         delete << xml_node_for_relation(other_relation)
1280         delete << xml_node_for_way(used_way)
1281         delete << xml_node_for_node(used_node)
1282         %w[node way relation].each do |type|
1283           delete.find("//osmChange/delete/#{type}").each do |n|
1284             n["changeset"] = changeset.id.to_s
1285           end
1286         end
1287
1288         auth_header = bearer_authorization_header changeset.user
1289
1290         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1291
1292         assert_response :precondition_failed
1293         assert_equal "Precondition failed: Way #{used_way.id} is still used by relations #{relation.id}.", @response.body
1294
1295         assert_no_changes_in changeset
1296
1297         assert Node.find(used_node.id).visible
1298         assert Way.find(used_way.id).visible
1299         assert Relation.find(relation.id).visible
1300         assert Relation.find(other_relation.id).visible
1301       end
1302
1303       ##
1304       # test that a conditional delete of an in use object works.
1305       def test_upload_delete_if_unused
1306         changeset = create(:changeset)
1307         super_relation = create(:relation)
1308         used_relation = create(:relation)
1309         used_way = create(:way)
1310         used_node = create(:node)
1311         create(:relation_member, :relation => super_relation, :member => used_relation)
1312         create(:relation_member, :relation => super_relation, :member => used_way)
1313         create(:relation_member, :relation => super_relation, :member => used_node)
1314
1315         diff = XML::Document.new
1316         diff.root = XML::Node.new "osmChange"
1317         delete = XML::Node.new "delete"
1318         diff.root << delete
1319         delete["if-unused"] = ""
1320         delete << xml_node_for_relation(used_relation)
1321         delete << xml_node_for_way(used_way)
1322         delete << xml_node_for_node(used_node)
1323         %w[node way relation].each do |type|
1324           delete.find("//osmChange/delete/#{type}").each do |n|
1325             n["changeset"] = changeset.id.to_s
1326           end
1327         end
1328
1329         auth_header = bearer_authorization_header changeset.user
1330
1331         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1332
1333         assert_response :success
1334
1335         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
1336           assert_dom "> node", 1 do
1337             assert_dom "> @old_id", used_node.id.to_s
1338             assert_dom "> @new_id", used_node.id.to_s
1339             assert_dom "> @new_version", used_node.version.to_s
1340           end
1341           assert_dom "> way", 1 do
1342             assert_dom "> @old_id", used_way.id.to_s
1343             assert_dom "> @new_id", used_way.id.to_s
1344             assert_dom "> @new_version", used_way.version.to_s
1345           end
1346           assert_dom "> relation", 1 do
1347             assert_dom "> @old_id", used_relation.id.to_s
1348             assert_dom "> @new_id", used_relation.id.to_s
1349             assert_dom "> @new_version", used_relation.version.to_s
1350           end
1351         end
1352
1353         assert_no_changes_in changeset
1354
1355         assert Node.find(used_node.id).visible
1356         assert Way.find(used_way.id).visible
1357         assert Relation.find(used_relation.id).visible
1358       end
1359
1360       def test_upload_delete_with_multiple_blocks_and_if_unused
1361         changeset = create(:changeset)
1362         node = create(:node)
1363         way = create(:way)
1364         create(:way_node, :way => way, :node => node)
1365         alone_node = create(:node)
1366
1367         diff = <<~CHANGESET
1368           <osmChange version='0.6'>
1369             <delete version="0.6">
1370               <node id="#{node.id}" version="#{node.version}" changeset="#{changeset.id}"/>
1371             </delete>
1372             <delete version="0.6" if-unused="true">
1373               <node id="#{alone_node.id}" version="#{alone_node.version}" changeset="#{changeset.id}"/>
1374             </delete>
1375           </osmChange>
1376         CHANGESET
1377
1378         auth_header = bearer_authorization_header changeset.user
1379
1380         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1381
1382         assert_response :precondition_failed
1383         assert_equal "Precondition failed: Node #{node.id} is still used by ways #{way.id}.", @response.body
1384
1385         assert_no_changes_in changeset
1386       end
1387
1388       def test_upload_delete_unknown_node_placeholder
1389         check_upload_results_in_not_found do |changeset|
1390           "<delete><node id='-1' changeset='#{changeset.id}' version='1'/></delete>"
1391         end
1392       end
1393
1394       def test_upload_delete_unknown_way_placeholder
1395         check_upload_results_in_not_found do |changeset|
1396           "<delete><way id='-1' changeset='#{changeset.id}' version='1'/></delete>"
1397         end
1398       end
1399
1400       def test_upload_delete_unknown_relation_placeholder
1401         check_upload_results_in_not_found do |changeset|
1402           "<delete><relation id='-1' changeset='#{changeset.id}' version='1'/></delete>"
1403         end
1404       end
1405
1406       # -------------------------------------
1407       # Test combined element changes.
1408       # -------------------------------------
1409
1410       ##
1411       # upload something which creates new objects and inserts them into
1412       # existing containers using placeholders.
1413       def test_upload_create_and_insert_elements
1414         way = create(:way)
1415         node = create(:node)
1416         relation = create(:relation)
1417         create(:way_node, :way => way, :node => node)
1418         changeset = create(:changeset)
1419
1420         diff = <<~CHANGESET
1421           <osmChange>
1422             <create>
1423               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1424                 <tag k='foo' v='bar'/>
1425                 <tag k='baz' v='bat'/>
1426               </node>
1427             </create>
1428             <modify>
1429               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
1430                 <nd ref='-1'/>
1431                 <nd ref='#{node.id}'/>
1432               </way>
1433               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'>
1434                 <member type='way' role='some' ref='#{way.id}'/>
1435                 <member type='node' role='some' ref='-1'/>
1436                 <member type='relation' role='some' ref='#{relation.id}'/>
1437               </relation>
1438             </modify>
1439           </osmChange>
1440         CHANGESET
1441
1442         auth_header = bearer_authorization_header changeset.user
1443
1444         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1445
1446         assert_response :success
1447
1448         new_node_id = nil
1449         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
1450           assert_dom "> node", 1 do |(node_el)|
1451             new_node_id = node_el["new_id"].to_i
1452           end
1453           assert_dom "> way", 1
1454           assert_dom "> relation", 1
1455         end
1456
1457         assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
1458         assert_equal [new_node_id, node.id], Way.find(way.id).nds, "way nodes should match"
1459         Relation.find(relation.id).members.each do |type, id, _role|
1460           assert_equal new_node_id, id, "relation should contain new node" if type == "node"
1461         end
1462       end
1463
1464       ##
1465       # test that a placeholder can be reused within the same upload.
1466       def test_upload_create_modify_delete_node_reusing_placeholder
1467         changeset = create(:changeset)
1468
1469         diff = <<~CHANGESET
1470           <osmChange>
1471             <create>
1472               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1473                 <tag k="foo" v="bar"/>
1474               </node>
1475             </create>
1476             <modify>
1477               <node id='-1' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
1478             </modify>
1479             <delete>
1480               <node id='-1' lon='2' lat='2' changeset='#{changeset.id}' version='2'/>
1481             </delete>
1482           </osmChange>
1483         CHANGESET
1484
1485         auth_header = bearer_authorization_header changeset.user
1486
1487         assert_difference "Node.count", 1 do
1488           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1489
1490           assert_response :success
1491         end
1492
1493         assert_dom "diffResult>node", 3
1494         assert_dom "diffResult>node[old_id='-1']", 3
1495
1496         node = Node.last
1497         assert_equal 3, node.version
1498         assert_not node.visible
1499       end
1500
1501       def test_upload_create_and_duplicate_delete
1502         changeset = create(:changeset)
1503
1504         diff = <<~CHANGESET
1505           <osmChange>
1506             <create>
1507               <node id="-1" lat="39" lon="116" changeset="#{changeset.id}" />
1508             </create>
1509             <delete>
1510               <node id="-1" version="1" changeset="#{changeset.id}" />
1511               <node id="-1" version="1" changeset="#{changeset.id}" />
1512             </delete>
1513           </osmChange>
1514         CHANGESET
1515
1516         auth_header = bearer_authorization_header changeset.user
1517
1518         assert_no_difference "Node.count" do
1519           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1520
1521           assert_response :gone
1522         end
1523
1524         assert_no_changes_in changeset
1525       end
1526
1527       def test_upload_create_and_duplicate_delete_if_unused
1528         changeset = create(:changeset)
1529
1530         diff = <<~CHANGESET
1531           <osmChange>
1532             <create>
1533               <node id="-1" lat="39" lon="116" changeset="#{changeset.id}" />
1534             </create>
1535             <delete if-unused="true">
1536               <node id="-1" version="1" changeset="#{changeset.id}" />
1537               <node id="-1" version="1" changeset="#{changeset.id}" />
1538             </delete>
1539           </osmChange>
1540         CHANGESET
1541
1542         auth_header = bearer_authorization_header changeset.user
1543
1544         assert_difference "Node.count", 1 do
1545           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1546
1547           assert_response :success
1548         end
1549
1550         assert_dom "diffResult>node", 3
1551         assert_dom "diffResult>node[old_id='-1']", 3
1552         assert_dom "diffResult>node[new_version='1']", 1
1553         assert_dom "diffResult>node[new_version='2']", 1
1554
1555         node = Node.last
1556         assert_equal 2, node.version
1557         assert_not node.visible
1558       end
1559
1560       # -------------------------------------
1561       # Test bounding boxes.
1562       # -------------------------------------
1563
1564       def test_upload_bbox_of_widely_spaced_nodes
1565         user = create(:user)
1566
1567         # create an old changeset to ensure we have the maximum rate limit
1568         create(:changeset, :user => user, :created_at => Time.now.utc - 28.days)
1569
1570         changeset = create(:changeset, :user => user)
1571
1572         # upload some widely-spaced nodes, spiralling positive and negative
1573         diff = <<~CHANGESET
1574           <osmChange>
1575             <create>
1576               <node id='-1' lon='-20' lat='-10' changeset='#{changeset.id}'/>
1577               <node id='-10' lon='20'  lat='10' changeset='#{changeset.id}'/>
1578               <node id='-2' lon='-40' lat='-20' changeset='#{changeset.id}'/>
1579               <node id='-11' lon='40'  lat='20' changeset='#{changeset.id}'/>
1580               <node id='-3' lon='-60' lat='-30' changeset='#{changeset.id}'/>
1581               <node id='-12' lon='60'  lat='30' changeset='#{changeset.id}'/>
1582               <node id='-4' lon='-80' lat='-40' changeset='#{changeset.id}'/>
1583               <node id='-13' lon='80'  lat='40' changeset='#{changeset.id}'/>
1584               <node id='-5' lon='-100' lat='-50' changeset='#{changeset.id}'/>
1585               <node id='-14' lon='100'  lat='50' changeset='#{changeset.id}'/>
1586               <node id='-6' lon='-120' lat='-60' changeset='#{changeset.id}'/>
1587               <node id='-15' lon='120'  lat='60' changeset='#{changeset.id}'/>
1588               <node id='-7' lon='-140' lat='-70' changeset='#{changeset.id}'/>
1589               <node id='-16' lon='140'  lat='70' changeset='#{changeset.id}'/>
1590               <node id='-8' lon='-160' lat='-80' changeset='#{changeset.id}'/>
1591               <node id='-17' lon='160'  lat='80' changeset='#{changeset.id}'/>
1592               <node id='-9' lon='-179.9' lat='-89.9' changeset='#{changeset.id}'/>
1593               <node id='-18' lon='179.9'  lat='89.9' changeset='#{changeset.id}'/>
1594             </create>
1595           </osmChange>
1596         CHANGESET
1597
1598         auth_header = bearer_authorization_header user
1599
1600         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1601
1602         assert_response :success
1603
1604         changeset.reload
1605         assert_equal 18, changeset.num_changes
1606         assert_predicate changeset, :num_type_changes_in_sync?
1607         assert_equal 18, changeset.num_created_nodes
1608
1609         # check that the changeset bbox is within bounds
1610         assert_operator changeset.min_lon, :>=, -180 * GeoRecord::SCALE, "Minimum longitude (#{changeset.min_lon / GeoRecord::SCALE}) should be >= -180 to be valid."
1611         assert_operator changeset.max_lon, :<=, 180 * GeoRecord::SCALE, "Maximum longitude (#{changeset.max_lon / GeoRecord::SCALE}) should be <= 180 to be valid."
1612         assert_operator changeset.min_lat, :>=, -90 * GeoRecord::SCALE, "Minimum latitude (#{changeset.min_lat / GeoRecord::SCALE}) should be >= -90 to be valid."
1613         assert_operator changeset.max_lat, :<=, 90 * GeoRecord::SCALE, "Maximum latitude (#{changeset.max_lat / GeoRecord::SCALE}) should be <= 90 to be valid."
1614       end
1615
1616       def test_upload_bbox_of_moved_node
1617         changeset = create(:changeset)
1618         node = create(:node, :lat => 1.0, :lon => 2.0)
1619
1620         diff = <<~CHANGESET
1621           <osmChange>
1622             <modify>
1623               <node id='#{node.id}' lat='1.1' lon='2.1' changeset='#{changeset.id}' version='1'/>
1624             </modify>
1625           </osmChange>
1626         CHANGESET
1627
1628         auth_header = bearer_authorization_header changeset.user
1629
1630         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1631
1632         assert_response :success
1633
1634         changeset.reload
1635         assert_equal 1, changeset.num_changes
1636         assert_predicate changeset, :num_type_changes_in_sync?
1637         assert_equal 1, changeset.num_modified_nodes
1638
1639         # check the bbox
1640         assert_equal 1.0 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1.0 degrees"
1641         assert_equal 2.0 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 2.0 degrees"
1642         assert_equal 1.1 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 1.1 degrees"
1643         assert_equal 2.1 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 2.1 degrees"
1644       end
1645
1646       def test_upload_bbox_of_extended_way
1647         way = create(:way)
1648         initial_node = create(:node, :lat => 1.1, :lon => 2.1)
1649         create(:way_node, :way => way, :node => initial_node)
1650         added_node = create(:node, :lat => 1.3, :lon => 2.3)
1651         changeset = create(:changeset)
1652
1653         diff = <<~CHANGESET
1654           <osmChange>
1655             <modify>
1656               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
1657                 <nd ref='#{initial_node.id}'/>
1658                 <nd ref='#{added_node.id}'/>
1659               </way>
1660             </modify>
1661           </osmChange>
1662         CHANGESET
1663
1664         auth_header = bearer_authorization_header changeset.user
1665
1666         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1667
1668         assert_response :success
1669
1670         changeset.reload
1671         assert_equal 1, changeset.num_changes
1672         assert_predicate changeset, :num_type_changes_in_sync?
1673         assert_equal 1, changeset.num_modified_ways
1674
1675         # check the bbox
1676         assert_equal 1.1 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1.1 degrees"
1677         assert_equal 2.1 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 2.1 degrees"
1678         assert_equal 1.3 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 1.3 degrees"
1679         assert_equal 2.3 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 2.3 degrees"
1680       end
1681
1682       # -------------------------------------
1683       # Test upload rate/size limits.
1684       # -------------------------------------
1685
1686       def test_upload_initial_rate_limit
1687         user = create(:user)
1688         node = create(:node)
1689         way = create(:way_with_nodes, :nodes_count => 2)
1690         relation = create(:relation)
1691
1692         # create a changeset that puts us near the initial rate limit
1693         num_changes = Settings.initial_changes_per_hour - 2
1694         changeset = create(:changeset, :user => user,
1695                                        :created_at => Time.now.utc - 5.minutes,
1696                                        :num_changes => num_changes,
1697                                        :num_created_nodes => num_changes)
1698
1699         diff = <<~CHANGESET
1700           <osmChange>
1701             <create>
1702               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1703                 <tag k='foo' v='bar'/>
1704                 <tag k='baz' v='bat'/>
1705               </node>
1706               <way id='-1' changeset='#{changeset.id}'>
1707                 <nd ref='#{node.id}'/>
1708               </way>
1709             </create>
1710             <create>
1711               <relation id='-1' changeset='#{changeset.id}'>
1712                 <member type='way' role='some' ref='#{way.id}'/>
1713                 <member type='node' role='some' ref='#{node.id}'/>
1714                 <member type='relation' role='some' ref='#{relation.id}'/>
1715               </relation>
1716             </create>
1717           </osmChange>
1718         CHANGESET
1719
1720         auth_header = bearer_authorization_header user
1721
1722         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1723
1724         assert_response :too_many_requests, "upload did not hit rate limit"
1725
1726         changeset.reload
1727         assert_equal num_changes, changeset.num_changes
1728         assert_predicate changeset, :num_type_changes_in_sync?
1729       end
1730
1731       def test_upload_maximum_rate_limit
1732         user = create(:user)
1733         node = create(:node)
1734         way = create(:way_with_nodes, :nodes_count => 2)
1735         relation = create(:relation)
1736
1737         # create a changeset to establish our initial edit time
1738         changeset = create(:changeset, :user => user,
1739                                        :created_at => Time.now.utc - 28.days)
1740
1741         # create changeset to put us near the maximum rate limit
1742         remaining_num_changes = Settings.max_changes_per_hour - 2
1743         num_changes = 0
1744         while remaining_num_changes.positive?
1745           num_changes = [remaining_num_changes, Changeset::MAX_ELEMENTS].min
1746           changeset = create(:changeset, :user => user,
1747                                          :created_at => Time.now.utc - 5.minutes,
1748                                          :num_changes => num_changes,
1749                                          :num_created_nodes => num_changes)
1750           remaining_num_changes -= num_changes
1751         end
1752
1753         diff = <<~CHANGESET
1754           <osmChange>
1755             <create>
1756               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1757                 <tag k='foo' v='bar'/>
1758                 <tag k='baz' v='bat'/>
1759               </node>
1760               <way id='-1' changeset='#{changeset.id}'>
1761                 <nd ref='#{node.id}'/>
1762               </way>
1763             </create>
1764             <create>
1765               <relation id='-1' changeset='#{changeset.id}'>
1766                 <member type='way' role='some' ref='#{way.id}'/>
1767                 <member type='node' role='some' ref='#{node.id}'/>
1768                 <member type='relation' role='some' ref='#{relation.id}'/>
1769               </relation>
1770             </create>
1771           </osmChange>
1772         CHANGESET
1773
1774         auth_header = bearer_authorization_header user
1775
1776         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1777
1778         assert_response :too_many_requests, "upload did not hit rate limit"
1779
1780         changeset.reload
1781         assert_equal num_changes, changeset.num_changes
1782         assert_predicate changeset, :num_type_changes_in_sync?
1783       end
1784
1785       def test_upload_initial_size_limit
1786         user = create(:user)
1787
1788         # create a changeset that puts us near the initial size limit
1789         changeset = create(:changeset, :user => user,
1790                                        :min_lat => (-0.5 * GeoRecord::SCALE).round, :min_lon => (0.5 * GeoRecord::SCALE).round,
1791                                        :max_lat => (0.5 * GeoRecord::SCALE).round, :max_lon => (2.5 * GeoRecord::SCALE).round)
1792
1793         diff = <<~CHANGESET
1794           <osmChange>
1795             <create>
1796               <node id='-1' lon='0.9' lat='2.9' changeset='#{changeset.id}'>
1797                 <tag k='foo' v='bar'/>
1798                 <tag k='baz' v='bat'/>
1799               </node>
1800             </create>
1801           </osmChange>
1802         CHANGESET
1803
1804         auth_header = bearer_authorization_header user
1805
1806         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1807
1808         assert_response :payload_too_large, "upload did not hit size limit"
1809
1810         assert_no_changes_in changeset
1811       end
1812
1813       def test_upload_size_limit_after_one_week
1814         user = create(:user)
1815
1816         # create a changeset to establish our initial edit time
1817         create(:changeset, :user => user, :created_at => Time.now.utc - 7.days)
1818
1819         # create a changeset that puts us near the initial size limit
1820         changeset = create(:changeset, :user => user, :bbox => [0.5, -0.5, 2.5, 0.5])
1821
1822         diff = <<~CHANGESET
1823           <osmChange>
1824             <create>
1825               <node id='-1' lon='35' lat='35' changeset='#{changeset.id}'>
1826                 <tag k='foo' v='bar'/>
1827                 <tag k='baz' v='bat'/>
1828               </node>
1829             </create>
1830           </osmChange>
1831         CHANGESET
1832
1833         auth_header = bearer_authorization_header user
1834
1835         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1836
1837         assert_response :payload_too_large, "upload did not hit size limit"
1838
1839         assert_no_changes_in changeset
1840       end
1841
1842       private
1843
1844       def check_upload_results_in_not_found(&)
1845         changeset = create(:changeset)
1846         diff = "<osmChange>#{yield changeset}</osmChange>"
1847         auth_header = bearer_authorization_header changeset.user
1848
1849         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1850
1851         assert_response :not_found
1852
1853         assert_no_changes_in changeset
1854       end
1855
1856       def assert_no_changes_in(changeset)
1857         changeset.reload
1858         assert_equal 0, changeset.num_changes
1859         assert_predicate changeset, :num_type_changes_in_sync?
1860       end
1861     end
1862   end
1863 end