test/controllers/api/changesets/uploads_controller_test.rb

   1 require "test_helper"
   2
   3 module Api
   4   module Changesets
   5     class UploadsControllerTest < ActionDispatch::IntegrationTest
   6       ##
   7       # test all routes which lead to this controller
   8       def test_routes
   9         assert_routing(
  10           { :path => "/api/0.6/changeset/1/upload", :method => :post },
  11           { :controller => "api/changesets/uploads", :action => "create", :changeset_id => "1" }
  12         )
  13       end
  14
  15       def test_upload_when_unauthorized
  16         changeset = create(:changeset)
  17         node = create(:node, :latitude => 0, :longitude => 0)
  18
  19         diff = <<~CHANGESET
  20           <osmChange>
  21             <modify>
  22               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
  23             </modify>
  24           </osmChange>
  25         CHANGESET
  26
  27         post api_changeset_upload_path(changeset), :params => diff
  28
  29         assert_response :unauthorized
  30
  31         assert_no_changes_in changeset
  32
  33         node.reload
  34         assert_equal 1, node.version
  35         assert_equal 0, node.latitude
  36         assert_equal 0, node.longitude
  37       end
  38
  39       def test_upload_by_private_user
  40         user = create(:user, :data_public => false)
  41         changeset = create(:changeset, :user => user)
  42         node = create(:node, :latitude => 0, :longitude => 0)
  43
  44         diff = <<~CHANGESET
  45           <osmChange>
  46             <modify>
  47               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
  48             </modify>
  49           </osmChange>
  50         CHANGESET
  51
  52         auth_header = bearer_authorization_header user
  53
  54         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
  55
  56         assert_response :forbidden
  57
  58         assert_no_changes_in changeset
  59
  60         node.reload
  61         assert_equal 1, node.version
  62         assert_equal 0, node.latitude
  63         assert_equal 0, node.longitude
  64       end
  65
  66       def test_upload_without_required_scope
  67         user = create(:user)
  68         changeset = create(:changeset, :user => user)
  69         node = create(:node, :latitude => 0, :longitude => 0)
  70
  71         diff = <<~CHANGESET
  72           <osmChange>
  73             <modify>
  74               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
  75             </modify>
  76           </osmChange>
  77         CHANGESET
  78
  79         auth_header = bearer_authorization_header user, :scopes => %w[read_prefs]
  80
  81         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
  82
  83         assert_response :forbidden
  84
  85         assert_no_changes_in changeset
  86
  87         node.reload
  88         assert_equal 1, node.version
  89         assert_equal 0, node.latitude
  90         assert_equal 0, node.longitude
  91       end
  92
  93       def test_upload_with_required_scope
  94         user = create(:user)
  95         changeset = create(:changeset, :user => user)
  96         node = create(:node, :latitude => 0, :longitude => 0)
  97
  98         diff = <<~CHANGESET
  99           <osmChange>
 100             <modify>
 101               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
 102             </modify>
 103           </osmChange>
 104         CHANGESET
 105
 106         auth_header = bearer_authorization_header user, :scopes => %w[write_api]
 107
 108         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 109
 110         assert_response :success
 111
 112         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 113           assert_dom "> node", 1 do
 114             assert_dom "> @old_id", node.id.to_s
 115             assert_dom "> @new_id", node.id.to_s
 116             assert_dom "> @new_version", "2"
 117           end
 118         end
 119
 120         changeset.reload
 121         assert_equal 1, changeset.num_changes
 122         assert_predicate changeset, :num_type_changes_in_sync?
 123         assert_equal 1, changeset.num_modified_nodes
 124
 125         node.reload
 126         assert_equal 2, node.version
 127         assert_equal 2 * GeoRecord::SCALE, node.latitude
 128         assert_equal 1 * GeoRecord::SCALE, node.longitude
 129       end
 130
 131       ##
 132       # try to upload with commands other than create, modify, or delete
 133       def test_upload_unknown_action
 134         changeset = create(:changeset)
 135
 136         diff = <<~CHANGESET
 137           <osmChange>
 138             <ping>
 139               <node id='1' lon='1' lat='1' changeset='#{changeset.id}' />
 140             </ping>
 141           </osmChange>
 142         CHANGESET
 143
 144         auth_header = bearer_authorization_header changeset.user
 145
 146         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 147
 148         assert_response :bad_request
 149         assert_equal "Unknown action ping, choices are create, modify, delete", @response.body
 150
 151         assert_no_changes_in changeset
 152       end
 153
 154       ##
 155       # test for issues in https://github.com/openstreetmap/trac-tickets/issues/1568
 156       def test_upload_empty_changeset
 157         changeset = create(:changeset)
 158
 159         auth_header = bearer_authorization_header changeset.user
 160
 161         ["<osmChange/>",
 162          "<osmChange></osmChange>",
 163          "<osmChange><modify/></osmChange>",
 164          "<osmChange><modify></modify></osmChange>"].each do |diff|
 165           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 166
 167           assert_response :success
 168         end
 169
 170         assert_no_changes_in changeset
 171       end
 172
 173       ##
 174       # test that the X-Error-Format header works to request XML errors
 175       def test_upload_xml_errors
 176         changeset = create(:changeset)
 177         node = create(:node)
 178         create(:relation_member, :member => node)
 179
 180         # try and delete a node that is in use
 181         diff = XML::Document.new
 182         diff.root = XML::Node.new "osmChange"
 183         delete = XML::Node.new "delete"
 184         diff.root << delete
 185         delete << xml_node_for_node(node)
 186
 187         auth_header = bearer_authorization_header changeset.user
 188         error_header = error_format_header "xml"
 189
 190         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header.merge(error_header)
 191
 192         assert_response :success
 193
 194         assert_dom "osmError[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1
 195         assert_dom "osmError>status", 1
 196         assert_dom "osmError>message", 1
 197       end
 198
 199       # -------------------------------------
 200       # Test creating elements.
 201       # -------------------------------------
 202
 203       def test_upload_create_node
 204         user = create(:user)
 205         changeset = create(:changeset, :user => user)
 206
 207         diff = <<~CHANGESET
 208           <osmChange>
 209             <create>
 210               <node id='-1' lon='30' lat='60' changeset='#{changeset.id}'>
 211                 <tag k='amenity' v='bar'/>
 212                 <tag k='name' v='Foo'/>
 213               </node>
 214             </create>
 215           </osmChange>
 216         CHANGESET
 217
 218         auth_header = bearer_authorization_header user
 219
 220         assert_difference "Node.count" => 1,
 221                           "OldNode.count" => 1,
 222                           "NodeTag.count" => 2,
 223                           "OldNodeTag.count" => 2 do
 224           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 225
 226           assert_response :success
 227         end
 228
 229         node = nil
 230         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 231           assert_dom "> node", 1 do |(node_el)|
 232             node = Node.find(node_el["new_id"].to_i)
 233             assert_dom "> @old_id", "-1"
 234             assert_dom "> @new_version", "1"
 235           end
 236         end
 237
 238         changeset.reload
 239         assert_equal 1, changeset.num_changes
 240         assert_predicate changeset, :num_type_changes_in_sync?
 241         assert_equal 1, changeset.num_created_nodes
 242
 243         assert_equal 1, node.version
 244         assert_equal changeset, node.changeset
 245         assert_predicate node, :visible?
 246         assert_equal({ "name" => "Foo", "amenity" => "bar" }, node.tags)
 247         assert_equal 60, node.lat
 248         assert_equal 30, node.lon
 249       end
 250
 251       def test_upload_create_way
 252         node1 = create(:node)
 253         node2 = create(:node)
 254         user = create(:user)
 255         changeset = create(:changeset, :user => user)
 256
 257         diff = <<~CHANGESET
 258           <osmChange>
 259             <create>
 260               <way id='-1' changeset='#{changeset.id}'>
 261                 <tag k='highway' v='primary'/>
 262                 <tag k='name' v='Foo'/>
 263                 <nd ref='#{node1.id}'/>
 264                 <nd ref='#{node2.id}'/>
 265               </way>
 266             </create>
 267           </osmChange>
 268         CHANGESET
 269
 270         auth_header = bearer_authorization_header user
 271
 272         assert_difference "Way.count" => 1,
 273                           "OldWay.count" => 1,
 274                           "WayTag.count" => 2,
 275                           "OldWayTag.count" => 2,
 276                           "WayNode.count" => 2,
 277                           "OldWayNode.count" => 2 do
 278           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 279
 280           assert_response :success
 281         end
 282
 283         way = nil
 284         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 285           assert_dom "> way", 1 do |(way_el)|
 286             way = Way.find(way_el["new_id"].to_i)
 287             assert_dom "> @old_id", "-1"
 288             assert_dom "> @new_version", "1"
 289           end
 290         end
 291
 292         changeset.reload
 293         assert_equal 1, changeset.num_changes
 294         assert_predicate changeset, :num_type_changes_in_sync?
 295         assert_equal 1, changeset.num_created_ways
 296
 297         assert_equal 1, way.version
 298         assert_equal changeset, way.changeset
 299         assert_predicate way, :visible?
 300         assert_equal({ "name" => "Foo", "highway" => "primary" }, way.tags)
 301         assert_equal [node1, node2], way.nodes
 302       end
 303
 304       def test_upload_create_relation
 305         node1 = create(:node)
 306         way1 = create(:way_with_nodes)
 307         relation1 = create(:relation)
 308         user = create(:user)
 309         changeset = create(:changeset, :user => user)
 310
 311         diff = <<~CHANGESET
 312           <osmChange>
 313             <create>
 314               <relation id='-1' changeset='#{changeset.id}'>
 315                 <member type='node' role='n_role' ref='#{node1.id}'/>
 316                 <member type='way' role='w_role' ref='#{way1.id}'/>
 317                 <member type='relation' role='r_role' ref='#{relation1.id}'/>
 318                 <tag k='type' v='collection'/>
 319               </relation>
 320             </create>
 321           </osmChange>
 322         CHANGESET
 323
 324         auth_header = bearer_authorization_header user
 325
 326         assert_difference "Relation.count" => 1,
 327                           "OldRelation.count" => 1,
 328                           "RelationTag.count" => 1,
 329                           "OldRelationTag.count" => 1,
 330                           "RelationMember.count" => 3,
 331                           "OldRelationMember.count" => 3 do
 332           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 333
 334           assert_response :success
 335         end
 336
 337         relation = nil
 338         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 339           assert_dom "> relation", 1 do |(relation_el)|
 340             relation = Relation.find(relation_el["new_id"].to_i)
 341             assert_dom "> @old_id", "-1"
 342             assert_dom "> @new_version", "1"
 343           end
 344         end
 345
 346         changeset.reload
 347         assert_equal 1, changeset.num_changes
 348         assert_predicate changeset, :num_type_changes_in_sync?
 349         assert_equal 1, changeset.num_created_relations
 350
 351         assert_equal 1, relation.version
 352         assert_equal changeset, relation.changeset
 353         assert_predicate relation, :visible?
 354         assert_equal({ "type" => "collection" }, relation.tags)
 355         assert_equal [["Node", node1.id, "n_role"],
 356                       ["Way", way1.id, "w_role"],
 357                       ["Relation", relation1.id, "r_role"]], relation.members
 358       end
 359
 360       def test_upload_create_elements
 361         user = create(:user)
 362         changeset = create(:changeset, :user => user)
 363         node = create(:node)
 364         way = create(:way_with_nodes, :nodes_count => 2)
 365         relation = create(:relation)
 366
 367         diff = <<~CHANGESET
 368           <osmChange>
 369             <create>
 370               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
 371                 <tag k='foo' v='bar'/>
 372                 <tag k='baz' v='bat'/>
 373               </node>
 374               <way id='-1' changeset='#{changeset.id}'>
 375                 <nd ref='#{node.id}'/>
 376               </way>
 377             </create>
 378             <create>
 379               <relation id='-1' changeset='#{changeset.id}'>
 380                 <member type='way' role='some' ref='#{way.id}'/>
 381                 <member type='node' role='some' ref='#{node.id}'/>
 382                 <member type='relation' role='some' ref='#{relation.id}'/>
 383               </relation>
 384             </create>
 385           </osmChange>
 386         CHANGESET
 387
 388         auth_header = bearer_authorization_header user
 389
 390         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 391
 392         assert_response :success
 393
 394         new_node_id, new_way_id, new_rel_id = nil
 395         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 396           # inspect the response to find out what the new element IDs are
 397           # check the old IDs are all present and negative one
 398           # check the versions are present and equal one
 399           assert_dom "> node", 1 do |(node_el)|
 400             new_node_id = node_el["new_id"].to_i
 401             assert_dom "> @old_id", "-1"
 402             assert_dom "> @new_version", "1"
 403           end
 404           assert_dom "> way", 1 do |(way_el)|
 405             new_way_id = way_el["new_id"].to_i
 406             assert_dom "> @old_id", "-1"
 407             assert_dom "> @new_version", "1"
 408           end
 409           assert_dom "> relation", 1 do |(rel_el)|
 410             new_rel_id = rel_el["new_id"].to_i
 411             assert_dom "> @old_id", "-1"
 412             assert_dom "> @new_version", "1"
 413           end
 414         end
 415
 416         changeset.reload
 417         assert_equal 3, changeset.num_changes
 418         assert_predicate changeset, :num_type_changes_in_sync?
 419         assert_equal 1, changeset.num_created_nodes
 420         assert_equal 1, changeset.num_created_ways
 421         assert_equal 1, changeset.num_created_relations
 422
 423         assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
 424         assert_equal 0, Way.find(new_way_id).tags.size, "new way should have no tags"
 425         assert_equal 0, Relation.find(new_rel_id).tags.size, "new relation should have no tags"
 426       end
 427
 428       ##
 429       # upload an element with a really long tag value
 430       def test_upload_create_node_with_tag_too_long
 431         changeset = create(:changeset)
 432
 433         diff = <<~CHANGESET
 434           <osmChange>
 435             <create>
 436               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
 437                 <tag k='foo' v='#{'x' * 256}'/>
 438               </node>
 439             </create>
 440           </osmChange>
 441         CHANGESET
 442
 443         auth_header = bearer_authorization_header changeset.user
 444
 445         assert_no_difference "Node.count" do
 446           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 447
 448           assert_response :bad_request
 449         end
 450
 451         assert_no_changes_in changeset
 452       end
 453
 454       def test_upload_create_nodes_with_invalid_placeholder_reuse_in_one_action_block
 455         changeset = create(:changeset)
 456
 457         diff = <<~CHANGESET
 458           <osmChange>
 459             <create>
 460               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
 461               <node id='-1' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
 462             </create>
 463           </osmChange>
 464         CHANGESET
 465
 466         auth_header = bearer_authorization_header changeset.user
 467
 468         assert_no_difference "Node.count" do
 469           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 470
 471           assert_response :bad_request
 472         end
 473
 474         assert_no_changes_in changeset
 475       end
 476
 477       def test_upload_create_nodes_with_invalid_placeholder_reuse_in_two_action_blocks
 478         changeset = create(:changeset)
 479
 480         diff = <<~CHANGESET
 481           <osmChange>
 482             <create>
 483               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
 484             </create>
 485             <create>
 486               <node id='-1' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
 487             </create>
 488           </osmChange>
 489         CHANGESET
 490
 491         auth_header = bearer_authorization_header changeset.user
 492
 493         assert_no_difference "Node.count" do
 494           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 495
 496           assert_response :bad_request
 497         end
 498
 499         assert_no_changes_in changeset
 500       end
 501
 502       def test_upload_create_way_referring_node_placeholder_defined_later
 503         changeset = create(:changeset)
 504
 505         diff = <<~CHANGESET
 506           <osmChange>
 507             <create>
 508               <way id="-1" changeset="#{changeset.id}">
 509                 <nd ref="-1"/>
 510               </way>
 511               <node id="-1" lat="1" lon="2" changeset="#{changeset.id}"/>
 512             </create>
 513           </osmChange>
 514         CHANGESET
 515
 516         auth_header = bearer_authorization_header changeset.user
 517
 518         assert_no_difference "Node.count" do
 519           assert_no_difference "Way.count" do
 520             post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 521
 522             assert_response :bad_request
 523           end
 524         end
 525         assert_equal "Placeholder node not found for reference -1 in way -1", @response.body
 526
 527         assert_no_changes_in changeset
 528       end
 529
 530       def test_upload_create_way_referring_undefined_node_placeholder
 531         changeset = create(:changeset)
 532
 533         diff = <<~CHANGESET
 534           <osmChange>
 535             <create>
 536               <way id="-1" changeset="#{changeset.id}">
 537                 <nd ref="-1"/>
 538               </way>
 539             </create>
 540           </osmChange>
 541         CHANGESET
 542
 543         auth_header = bearer_authorization_header changeset.user
 544
 545         assert_no_difference "Way.count" do
 546           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 547
 548           assert_response :bad_request
 549         end
 550         assert_equal "Placeholder node not found for reference -1 in way -1", @response.body
 551
 552         assert_no_changes_in changeset
 553       end
 554
 555       def test_upload_create_existing_way_referring_undefined_node_placeholder
 556         changeset = create(:changeset)
 557         way = create(:way)
 558
 559         diff = <<~CHANGESET
 560           <osmChange>
 561             <create>
 562               <way id="#{way.id}" changeset="#{changeset.id}" version="1">
 563                 <nd ref="-1"/>
 564               </way>
 565             </create>
 566           </osmChange>
 567         CHANGESET
 568
 569         auth_header = bearer_authorization_header changeset.user
 570
 571         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 572
 573         assert_response :bad_request
 574         assert_equal "Placeholder node not found for reference -1 in way #{way.id}", @response.body
 575
 576         assert_no_changes_in changeset
 577
 578         way.reload
 579         assert_equal 1, way.version
 580       end
 581
 582       def test_upload_create_relation_referring_undefined_node_placeholder
 583         changeset = create(:changeset)
 584
 585         diff = <<~CHANGESET
 586           <osmChange>
 587             <create>
 588               <relation id="-1" changeset="#{changeset.id}" version="1">
 589                 <member type="node" role="foo" ref="-1"/>
 590               </relation>
 591             </create>
 592           </osmChange>
 593         CHANGESET
 594
 595         auth_header = bearer_authorization_header changeset.user
 596
 597         assert_no_difference "Relation.count" do
 598           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 599
 600           assert_response :bad_request
 601         end
 602         assert_equal "Placeholder Node not found for reference -1 in relation -1.", @response.body
 603
 604         assert_no_changes_in changeset
 605       end
 606
 607       def test_upload_create_existing_relation_referring_undefined_way_placeholder
 608         changeset = create(:changeset)
 609         relation = create(:relation)
 610
 611         diff = <<~CHANGESET
 612           <osmChange>
 613             <create>
 614               <relation id="#{relation.id}" changeset="#{changeset.id}" version="1">
 615                 <member type="way" role="bar" ref="-1"/>
 616               </relation>
 617             </create>
 618           </osmChange>
 619         CHANGESET
 620
 621         auth_header = bearer_authorization_header changeset.user
 622
 623         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 624
 625         assert_response :bad_request
 626         assert_equal "Placeholder Way not found for reference -1 in relation #{relation.id}.", @response.body
 627
 628         assert_no_changes_in changeset
 629
 630         relation.reload
 631         assert_equal 1, relation.version
 632       end
 633
 634       def test_upload_create_relations_with_circular_references
 635         changeset = create(:changeset)
 636
 637         diff = <<~CHANGESET
 638           <osmChange version='0.6'>
 639             <create>
 640               <relation id='-2' version='0' changeset='#{changeset.id}'>
 641                 <member type='relation' role='' ref='-4' />
 642                 <tag k='type' v='route' />
 643                 <tag k='name' v='AtoB' />
 644               </relation>
 645               <relation id='-3' version='0' changeset='#{changeset.id}'>
 646                 <tag k='type' v='route' />
 647                 <tag k='name' v='BtoA' />
 648               </relation>
 649               <relation id='-4' version='0' changeset='#{changeset.id}'>
 650                 <member type='relation' role='' ref='-2' />
 651                 <member type='relation' role='' ref='-3' />
 652                 <tag k='type' v='route_master' />
 653                 <tag k='name' v='master' />
 654               </relation>
 655             </create>
 656           </osmChange>
 657         CHANGESET
 658
 659         auth_header = bearer_authorization_header changeset.user
 660
 661         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
 662
 663         assert_response :bad_request
 664         assert_equal "Placeholder Relation not found for reference -4 in relation -2.", @response.body
 665
 666         assert_no_changes_in changeset
 667       end
 668
 669       # -------------------------------------
 670       # Test modifying elements.
 671       # -------------------------------------
 672
 673       def test_upload_modify_node
 674         user = create(:user)
 675         changeset = create(:changeset, :user => user)
 676         node = create(:node, :latitude => 0, :longitude => 0)
 677         create(:node_tag, :node => node)
 678
 679         diff = <<~CHANGESET
 680           <osmChange>
 681             <modify>
 682               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
 683             </modify>
 684           </osmChange>
 685         CHANGESET
 686
 687         auth_header = bearer_authorization_header user
 688
 689         assert_difference "Node.count" => 0,
 690                           "OldNode.count" => 1,
 691                           "NodeTag.count" => -1,
 692                           "OldNodeTag.count" => 0 do
 693           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 694
 695           assert_response :success
 696         end
 697
 698         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 699           assert_dom "> node", 1 do
 700             assert_dom "> @old_id", node.id.to_s
 701             assert_dom "> @new_id", node.id.to_s
 702             assert_dom "> @new_version", "2"
 703           end
 704         end
 705
 706         changeset.reload
 707         assert_equal 1, changeset.num_changes
 708         assert_predicate changeset, :num_type_changes_in_sync?
 709         assert_equal 1, changeset.num_modified_nodes
 710
 711         node.reload
 712         assert_equal 2, node.version
 713         assert_equal 2 * GeoRecord::SCALE, node.latitude
 714         assert_equal 1 * GeoRecord::SCALE, node.longitude
 715         assert_equal 0, node.tags.size, "node #{node.id} should now have no tags"
 716       end
 717
 718       def test_upload_modify_way
 719         user = create(:user)
 720         changeset = create(:changeset, :user => user)
 721         node = create(:node)
 722         way = create(:way_with_nodes, :nodes_count => 3)
 723         create(:way_tag, :way => way)
 724
 725         diff = <<~CHANGESET
 726           <osmChange>
 727             <modify>
 728               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
 729                 <nd ref='#{node.id}'/>
 730               </way>
 731             </modify>
 732           </osmChange>
 733         CHANGESET
 734
 735         auth_header = bearer_authorization_header user
 736
 737         assert_difference "Way.count" => 0,
 738                           "OldWay.count" => 1,
 739                           "WayTag.count" => -1,
 740                           "OldWayTag.count" => 0,
 741                           "WayNode.count" => -2,
 742                           "OldWayNode.count" => 1 do
 743           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 744
 745           assert_response :success
 746         end
 747
 748         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 749           assert_dom "> way", 1 do
 750             assert_dom "> @old_id", way.id.to_s
 751             assert_dom "> @new_id", way.id.to_s
 752             assert_dom "> @new_version", "2"
 753           end
 754         end
 755
 756         changeset.reload
 757         assert_equal 1, changeset.num_changes
 758         assert_predicate changeset, :num_type_changes_in_sync?
 759         assert_equal 1, changeset.num_modified_ways
 760
 761         way.reload
 762         assert_equal 2, way.version
 763         assert_equal 0, way.tags.size, "way #{way.id} should now have no tags"
 764         assert_equal [node], way.nodes
 765       end
 766
 767       def test_upload_modify_relation
 768         user = create(:user)
 769         changeset = create(:changeset, :user => user)
 770         node = create(:node)
 771         way = create(:way_with_nodes)
 772         relation = create(:relation)
 773         other_relation = create(:relation)
 774         create(:relation_tag, :relation => relation)
 775
 776         diff = <<~CHANGESET
 777           <osmChange>
 778             <modify>
 779               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'>
 780                 <member type='way' role='some' ref='#{way.id}'/>
 781                 <member type='node' role='some' ref='#{node.id}'/>
 782                 <member type='relation' role='some' ref='#{other_relation.id}'/>
 783               </relation>
 784             </modify>
 785           </osmChange>
 786         CHANGESET
 787
 788         auth_header = bearer_authorization_header user
 789
 790         assert_difference "Relation.count" => 0,
 791                           "OldRelation.count" => 1,
 792                           "RelationTag.count" => -1,
 793                           "OldRelationTag.count" => 0,
 794                           "RelationMember.count" => 3,
 795                           "OldRelationMember.count" => 3 do
 796           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 797
 798           assert_response :success
 799         end
 800
 801         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 802           assert_dom "> relation", 1 do
 803             assert_dom "> @old_id", relation.id.to_s
 804             assert_dom "> @new_id", relation.id.to_s
 805             assert_dom "> @new_version", "2"
 806           end
 807         end
 808
 809         changeset.reload
 810         assert_equal 1, changeset.num_changes
 811         assert_predicate changeset, :num_type_changes_in_sync?
 812         assert_equal 1, changeset.num_modified_relations
 813
 814         relation.reload
 815         assert_equal 2, relation.version
 816         assert_equal 0, relation.tags.size, "relation #{relation.id} should now have no tags"
 817         assert_equal [["Way", way.id, "some"], ["Node", node.id, "some"], ["Relation", other_relation.id, "some"]], relation.members
 818       end
 819
 820       def test_upload_modify_elements
 821         user = create(:user)
 822         changeset = create(:changeset, :user => user)
 823         node = create(:node, :latitude => 0, :longitude => 0)
 824         way = create(:way)
 825         relation = create(:relation)
 826         other_relation = create(:relation)
 827
 828         # create some tags, since we test that they are removed later
 829         create(:node_tag, :node => node)
 830         create(:way_tag, :way => way)
 831         create(:relation_tag, :relation => relation)
 832
 833         # simple diff to change a node, way and relation by removing their tags
 834         diff = <<~CHANGESET
 835           <osmChange>
 836             <modify>
 837               <node id='#{node.id}' lon='1' lat='2' changeset='#{changeset.id}' version='1'/>
 838               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
 839                 <nd ref='#{node.id}'/>
 840               </way>
 841             </modify>
 842             <modify>
 843               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'>
 844                 <member type='way' role='some' ref='#{way.id}'/>
 845                 <member type='node' role='some' ref='#{node.id}'/>
 846                 <member type='relation' role='some' ref='#{other_relation.id}'/>
 847               </relation>
 848             </modify>
 849           </osmChange>
 850         CHANGESET
 851
 852         auth_header = bearer_authorization_header user
 853
 854         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 855
 856         assert_response :success
 857
 858         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
 859           assert_dom "> node", 1 do
 860             assert_dom "> @old_id", node.id.to_s
 861             assert_dom "> @new_id", node.id.to_s
 862             assert_dom "> @new_version", "2"
 863           end
 864           assert_dom "> way", 1 do
 865             assert_dom "> @old_id", way.id.to_s
 866             assert_dom "> @new_id", way.id.to_s
 867             assert_dom "> @new_version", "2"
 868           end
 869           assert_dom "> relation", 1 do
 870             assert_dom "> @old_id", relation.id.to_s
 871             assert_dom "> @new_id", relation.id.to_s
 872             assert_dom "> @new_version", "2"
 873           end
 874         end
 875
 876         changeset.reload
 877         assert_equal 3, changeset.num_changes
 878         assert_predicate changeset, :num_type_changes_in_sync?
 879         assert_equal 1, changeset.num_modified_nodes
 880         assert_equal 1, changeset.num_modified_ways
 881         assert_equal 1, changeset.num_modified_relations
 882
 883         node.reload
 884         assert_equal 2, node.version
 885         assert_equal 2 * GeoRecord::SCALE, node.latitude
 886         assert_equal 1 * GeoRecord::SCALE, node.longitude
 887         assert_equal 0, node.tags.size, "node #{node.id} should now have no tags"
 888         way.reload
 889         assert_equal 2, way.version
 890         assert_equal 0, way.tags.size, "way #{way.id} should now have no tags"
 891         assert_equal [node], way.nodes
 892         relation.reload
 893         assert_equal 2, relation.version
 894         assert_equal 0, relation.tags.size, "relation #{relation.id} should now have no tags"
 895         assert_equal [["Way", way.id, "some"], ["Node", node.id, "some"], ["Relation", other_relation.id, "some"]], relation.members
 896       end
 897
 898       ##
 899       # upload multiple versions of the same element in the same diff.
 900       def test_upload_modify_multiple_node_versions
 901         node = create(:node)
 902         changeset = create(:changeset)
 903
 904         # change the location of a node multiple times, each time referencing
 905         # the last version. doesn't this depend on version numbers being
 906         # sequential?
 907         diff = <<~CHANGESET
 908           <osmChange>
 909             <modify>
 910               <node id='#{node.id}' lon='0.0' lat='0.0' changeset='#{changeset.id}' version='1'/>
 911               <node id='#{node.id}' lon='0.1' lat='0.0' changeset='#{changeset.id}' version='2'/>
 912               <node id='#{node.id}' lon='0.1' lat='0.1' changeset='#{changeset.id}' version='3'/>
 913               <node id='#{node.id}' lon='0.1' lat='0.2' changeset='#{changeset.id}' version='4'/>
 914               <node id='#{node.id}' lon='0.2' lat='0.2' changeset='#{changeset.id}' version='5'/>
 915               <node id='#{node.id}' lon='0.3' lat='0.2' changeset='#{changeset.id}' version='6'/>
 916               <node id='#{node.id}' lon='0.3' lat='0.3' changeset='#{changeset.id}' version='7'/>
 917               <node id='#{node.id}' lon='0.9' lat='0.9' changeset='#{changeset.id}' version='8'/>
 918             </modify>
 919           </osmChange>
 920         CHANGESET
 921
 922         auth_header = bearer_authorization_header changeset.user
 923
 924         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 925
 926         assert_response :success
 927
 928         assert_dom "diffResult>node", 8
 929
 930         changeset.reload
 931         assert_equal 8, changeset.num_changes
 932         assert_predicate changeset, :num_type_changes_in_sync?
 933         assert_equal 8, changeset.num_modified_nodes
 934
 935         node.reload
 936         assert_equal 9, node.version
 937         assert_equal 0.9 * GeoRecord::SCALE, node.latitude
 938         assert_equal 0.9 * GeoRecord::SCALE, node.longitude
 939       end
 940
 941       ##
 942       # upload multiple versions of the same element in the same diff, but
 943       # keep the version numbers the same.
 944       def test_upload_modify_duplicate_node_versions
 945         node = create(:node, :latitude => 0, :longitude => 0)
 946         changeset = create(:changeset)
 947
 948         diff = <<~CHANGESET
 949           <osmChange>
 950             <modify>
 951               <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
 952               <node id='#{node.id}' lon='2' lat='2' changeset='#{changeset.id}' version='1'/>
 953             </modify>
 954           </osmChange>
 955         CHANGESET
 956
 957         auth_header = bearer_authorization_header changeset.user
 958
 959         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 960
 961         assert_response :conflict
 962
 963         assert_no_changes_in changeset
 964
 965         node.reload
 966         assert_equal 1, node.version
 967         assert_equal 0, node.latitude
 968         assert_equal 0, node.longitude
 969       end
 970
 971       ##
 972       # try to upload some elements without specifying the version
 973       def test_upload_modify_missing_node_version
 974         node = create(:node, :latitude => 0, :longitude => 0)
 975         changeset = create(:changeset)
 976
 977         diff = <<~CHANGESET
 978           <osmChange>
 979             <modify>
 980               <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}'/>
 981             </modify>
 982           </osmChange>
 983         CHANGESET
 984
 985         auth_header = bearer_authorization_header changeset.user
 986
 987         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
 988
 989         assert_response :bad_request
 990
 991         assert_no_changes_in changeset
 992
 993         node.reload
 994         assert_equal 1, node.version
 995         assert_equal 0, node.latitude
 996         assert_equal 0, node.longitude
 997       end
 998
 999       ##
1000       # create a diff which references several changesets, which should cause
1001       # a rollback and none of the diff gets committed
1002       def test_upload_modify_with_references_to_different_changesets
1003         changeset1 = create(:changeset)
1004         changeset2 = create(:changeset, :user => changeset1.user)
1005         node1 = create(:node)
1006         node2 = create(:node)
1007
1008         # simple diff to create a node way and relation using placeholders
1009         diff = <<~CHANGESET
1010           <osmChange>
1011             <modify>
1012               <node id='#{node1.id}' lon='0' lat='0' changeset='#{changeset1.id}' version='1'/>
1013             </modify>
1014             <modify>
1015               <node id='#{node2.id}' lon='0' lat='0' changeset='#{changeset2.id}' version='1'/>
1016             </modify>
1017           </osmChange>
1018         CHANGESET
1019
1020         auth_header = bearer_authorization_header changeset1.user
1021
1022         post api_changeset_upload_path(changeset1), :params => diff, :headers => auth_header
1023
1024         assert_response :conflict
1025
1026         assert_no_changes_in changeset1
1027         assert_no_changes_in changeset2
1028
1029         assert_nodes_are_equal(node1, Node.find(node1.id))
1030         assert_nodes_are_equal(node2, Node.find(node2.id))
1031       end
1032
1033       ##
1034       # upload a valid changeset which has a mixture of whitespace
1035       # to check a bug https://github.com/openstreetmap/trac-tickets/issues/1565
1036       def test_upload_modify_with_mixed_whitespace
1037         changeset = create(:changeset)
1038         node = create(:node)
1039         way = create(:way_with_nodes, :nodes_count => 2)
1040         relation = create(:relation)
1041         other_relation = create(:relation)
1042         create(:relation_tag, :relation => relation)
1043
1044         diff = <<~CHANGESET
1045           <osmChange>
1046           <modify><node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}'
1047             version='1'></node>
1048             <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}' version='2'><tag k='k' v='v'/></node></modify>
1049           <modify>
1050           <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'><member
1051             type='way' role='some' ref='#{way.id}'/><member
1052               type='node' role='some' ref='#{node.id}'/>
1053             <member type='relation' role='some' ref='#{other_relation.id}'/>
1054             </relation>
1055           </modify></osmChange>
1056         CHANGESET
1057
1058         auth_header = bearer_authorization_header changeset.user
1059
1060         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1061
1062         assert_response :success
1063
1064         assert_dom "diffResult>node", 2
1065         assert_dom "diffResult>relation", 1
1066
1067         changeset.reload
1068         assert_equal 3, changeset.num_changes
1069         assert_predicate changeset, :num_type_changes_in_sync?
1070         assert_equal 2, changeset.num_modified_nodes
1071         assert_equal 1, changeset.num_modified_relations
1072
1073         assert_equal 1, Node.find(node.id).tags.size, "node #{node.id} should now have one tag"
1074         assert_equal 0, Relation.find(relation.id).tags.size, "relation #{relation.id} should now have no tags"
1075       end
1076
1077       def test_upload_modify_unknown_node_placeholder
1078         check_upload_results_in_not_found do |changeset|
1079           "<modify><node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/></modify>"
1080         end
1081       end
1082
1083       def test_upload_modify_unknown_way_placeholder
1084         check_upload_results_in_not_found do |changeset|
1085           "<modify><way id='-1' changeset='#{changeset.id}' version='1'/></modify>"
1086         end
1087       end
1088
1089       def test_upload_modify_unknown_relation_placeholder
1090         check_upload_results_in_not_found do |changeset|
1091           "<modify><relation id='-1' changeset='#{changeset.id}' version='1'/></modify>"
1092         end
1093       end
1094
1095       # -------------------------------------
1096       # Test deleting elements.
1097       # -------------------------------------
1098
1099       def test_upload_delete_node
1100         changeset = create(:changeset)
1101         node = create(:node, :lat => 0, :lon => 0)
1102         create(:node_tag, :node => node)
1103
1104         diff = <<~CHANGESET
1105           <osmChange>
1106             <delete>
1107               <node id='#{node.id}' changeset='#{changeset.id}' version='1' lat='0' lon='0'/>
1108             </delete>
1109           </osmChange>
1110         CHANGESET
1111
1112         auth_header = bearer_authorization_header changeset.user
1113
1114         assert_difference "Node.count" => 0,
1115                           "OldNode.count" => 1,
1116                           "NodeTag.count" => -1,
1117                           "OldNodeTag.count" => 0 do
1118           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1119
1120           assert_response :success
1121         end
1122
1123         assert_dom "diffResult", 1 do
1124           assert_dom "> node", 1 do
1125             assert_dom "> @old_id", node.id.to_s
1126           end
1127         end
1128
1129         node.reload
1130         assert_not_predicate node, :visible?
1131       end
1132
1133       def test_upload_delete_way
1134         changeset = create(:changeset)
1135         way = create(:way_with_nodes, :nodes_count => 3)
1136         create(:way_tag, :way => way)
1137
1138         diff = <<~CHANGESET
1139           <osmChange>
1140             <delete>
1141               <way id='#{way.id}' changeset='#{changeset.id}' version='1'/>
1142             </delete>
1143           </osmChange>
1144         CHANGESET
1145
1146         auth_header = bearer_authorization_header changeset.user
1147
1148         assert_difference "Way.count" => 0,
1149                           "OldWay.count" => 1,
1150                           "WayTag.count" => -1,
1151                           "OldWayTag.count" => 0,
1152                           "WayNode.count" => -3,
1153                           "OldWayNode.count" => 0 do
1154           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1155
1156           assert_response :success
1157         end
1158
1159         assert_dom "diffResult", 1 do
1160           assert_dom "> way", 1 do
1161             assert_dom "> @old_id", way.id.to_s
1162           end
1163         end
1164
1165         way.reload
1166         assert_not_predicate way, :visible?
1167       end
1168
1169       def test_upload_delete_relation
1170         changeset = create(:changeset)
1171         relation = create(:relation)
1172         create(:relation_member, :relation => relation, :member => create(:node))
1173         create(:relation_tag, :relation => relation)
1174
1175         diff = <<~CHANGESET
1176           <osmChange>
1177             <delete>
1178               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'/>
1179             </delete>
1180           </osmChange>
1181         CHANGESET
1182
1183         auth_header = bearer_authorization_header changeset.user
1184
1185         assert_difference "Relation.count" => 0,
1186                           "OldRelation.count" => 1,
1187                           "RelationTag.count" => -1,
1188                           "OldRelationTag.count" => 0,
1189                           "RelationMember.count" => -1,
1190                           "OldRelationMember.count" => 0 do
1191           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1192
1193           assert_response :success
1194         end
1195
1196         assert_dom "diffResult", 1 do
1197           assert_dom "> relation", 1 do
1198             assert_dom "> @old_id", relation.id.to_s
1199           end
1200         end
1201
1202         relation.reload
1203         assert_not_predicate relation, :visible?
1204       end
1205
1206       ##
1207       # test a complex delete where we delete elements which rely on each other
1208       # in the same transaction.
1209       def test_upload_delete_elements
1210         changeset = create(:changeset)
1211         super_relation = create(:relation)
1212         used_relation = create(:relation)
1213         used_way = create(:way)
1214         used_node = create(:node)
1215         create(:relation_member, :relation => super_relation, :member => used_relation)
1216         create(:relation_member, :relation => super_relation, :member => used_way)
1217         create(:relation_member, :relation => super_relation, :member => used_node)
1218
1219         diff = XML::Document.new
1220         diff.root = XML::Node.new "osmChange"
1221         delete = XML::Node.new "delete"
1222         diff.root << delete
1223         delete << xml_node_for_relation(super_relation)
1224         delete << xml_node_for_relation(used_relation)
1225         delete << xml_node_for_way(used_way)
1226         delete << xml_node_for_node(used_node)
1227         %w[node way relation].each do |type|
1228           delete.find("//osmChange/delete/#{type}").each do |n|
1229             n["changeset"] = changeset.id.to_s
1230           end
1231         end
1232
1233         auth_header = bearer_authorization_header changeset.user
1234
1235         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1236
1237         assert_response :success
1238
1239         assert_dom "diffResult", 1 do
1240           assert_dom "> node", 1
1241           assert_dom "> way", 1
1242           assert_dom "> relation", 2
1243         end
1244
1245         assert_not Node.find(used_node.id).visible
1246         assert_not Way.find(used_way.id).visible
1247         assert_not Relation.find(super_relation.id).visible
1248         assert_not Relation.find(used_relation.id).visible
1249       end
1250
1251       ##
1252       # test uploading a delete with no lat/lon, as they are optional in the osmChange spec.
1253       def test_upload_delete_node_without_latlon
1254         node = create(:node)
1255         changeset = create(:changeset)
1256
1257         diff = "<osmChange><delete><node id='#{node.id}' version='#{node.version}' changeset='#{changeset.id}'/></delete></osmChange>"
1258
1259         auth_header = bearer_authorization_header changeset.user
1260
1261         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1262
1263         assert_response :success
1264
1265         assert_dom "diffResult", 1 do
1266           assert_dom "> node", 1 do
1267             assert_dom "> @old_id", node.id.to_s
1268             assert_dom "> @new_id", 0
1269             assert_dom "> @new_version", 0
1270           end
1271         end
1272
1273         node.reload
1274         assert_not node.visible
1275       end
1276
1277       ##
1278       # test that deleting stuff in a transaction doesn't bypass the checks
1279       # to ensure that used elements are not deleted.
1280       def test_upload_delete_referenced_elements
1281         changeset = create(:changeset)
1282         relation = create(:relation)
1283         other_relation = create(:relation)
1284         used_way = create(:way)
1285         used_node = create(:node)
1286         create(:relation_member, :relation => relation, :member => used_way)
1287         create(:relation_member, :relation => relation, :member => used_node)
1288
1289         diff = XML::Document.new
1290         diff.root = XML::Node.new "osmChange"
1291         delete = XML::Node.new "delete"
1292         diff.root << delete
1293         delete << xml_node_for_relation(other_relation)
1294         delete << xml_node_for_way(used_way)
1295         delete << xml_node_for_node(used_node)
1296         %w[node way relation].each do |type|
1297           delete.find("//osmChange/delete/#{type}").each do |n|
1298             n["changeset"] = changeset.id.to_s
1299           end
1300         end
1301
1302         auth_header = bearer_authorization_header changeset.user
1303
1304         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1305
1306         assert_response :precondition_failed
1307         assert_equal "Precondition failed: Way #{used_way.id} is still used by relations #{relation.id}.", @response.body
1308
1309         assert_no_changes_in changeset
1310
1311         assert Node.find(used_node.id).visible
1312         assert Way.find(used_way.id).visible
1313         assert Relation.find(relation.id).visible
1314         assert Relation.find(other_relation.id).visible
1315       end
1316
1317       ##
1318       # test that a conditional delete of an in use object works.
1319       def test_upload_delete_if_unused
1320         changeset = create(:changeset)
1321         super_relation = create(:relation)
1322         used_relation = create(:relation)
1323         used_way = create(:way)
1324         used_node = create(:node)
1325         create(:relation_member, :relation => super_relation, :member => used_relation)
1326         create(:relation_member, :relation => super_relation, :member => used_way)
1327         create(:relation_member, :relation => super_relation, :member => used_node)
1328
1329         diff = XML::Document.new
1330         diff.root = XML::Node.new "osmChange"
1331         delete = XML::Node.new "delete"
1332         diff.root << delete
1333         delete["if-unused"] = ""
1334         delete << xml_node_for_relation(used_relation)
1335         delete << xml_node_for_way(used_way)
1336         delete << xml_node_for_node(used_node)
1337         %w[node way relation].each do |type|
1338           delete.find("//osmChange/delete/#{type}").each do |n|
1339             n["changeset"] = changeset.id.to_s
1340           end
1341         end
1342
1343         auth_header = bearer_authorization_header changeset.user
1344
1345         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1346
1347         assert_response :success
1348
1349         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
1350           assert_dom "> node", 1 do
1351             assert_dom "> @old_id", used_node.id.to_s
1352             assert_dom "> @new_id", used_node.id.to_s
1353             assert_dom "> @new_version", used_node.version.to_s
1354           end
1355           assert_dom "> way", 1 do
1356             assert_dom "> @old_id", used_way.id.to_s
1357             assert_dom "> @new_id", used_way.id.to_s
1358             assert_dom "> @new_version", used_way.version.to_s
1359           end
1360           assert_dom "> relation", 1 do
1361             assert_dom "> @old_id", used_relation.id.to_s
1362             assert_dom "> @new_id", used_relation.id.to_s
1363             assert_dom "> @new_version", used_relation.version.to_s
1364           end
1365         end
1366
1367         assert_no_changes_in changeset
1368
1369         assert Node.find(used_node.id).visible
1370         assert Way.find(used_way.id).visible
1371         assert Relation.find(used_relation.id).visible
1372       end
1373
1374       def test_upload_delete_with_multiple_blocks_and_if_unused
1375         changeset = create(:changeset)
1376         node = create(:node)
1377         way = create(:way)
1378         create(:way_node, :way => way, :node => node)
1379         alone_node = create(:node)
1380
1381         diff = <<~CHANGESET
1382           <osmChange version='0.6'>
1383             <delete version="0.6">
1384               <node id="#{node.id}" version="#{node.version}" changeset="#{changeset.id}"/>
1385             </delete>
1386             <delete version="0.6" if-unused="true">
1387               <node id="#{alone_node.id}" version="#{alone_node.version}" changeset="#{changeset.id}"/>
1388             </delete>
1389           </osmChange>
1390         CHANGESET
1391
1392         auth_header = bearer_authorization_header changeset.user
1393
1394         post api_changeset_upload_path(changeset), :params => diff.to_s, :headers => auth_header
1395
1396         assert_response :precondition_failed
1397         assert_equal "Precondition failed: Node #{node.id} is still used by ways #{way.id}.", @response.body
1398
1399         assert_no_changes_in changeset
1400       end
1401
1402       def test_upload_delete_unknown_node_placeholder
1403         check_upload_results_in_not_found do |changeset|
1404           "<delete><node id='-1' changeset='#{changeset.id}' version='1'/></delete>"
1405         end
1406       end
1407
1408       def test_upload_delete_unknown_way_placeholder
1409         check_upload_results_in_not_found do |changeset|
1410           "<delete><way id='-1' changeset='#{changeset.id}' version='1'/></delete>"
1411         end
1412       end
1413
1414       def test_upload_delete_unknown_relation_placeholder
1415         check_upload_results_in_not_found do |changeset|
1416           "<delete><relation id='-1' changeset='#{changeset.id}' version='1'/></delete>"
1417         end
1418       end
1419
1420       # -------------------------------------
1421       # Test combined element changes.
1422       # -------------------------------------
1423
1424       ##
1425       # upload something which creates new objects and inserts them into
1426       # existing containers using placeholders.
1427       def test_upload_create_and_insert_elements
1428         way = create(:way)
1429         node = create(:node)
1430         relation = create(:relation)
1431         create(:way_node, :way => way, :node => node)
1432         changeset = create(:changeset)
1433
1434         diff = <<~CHANGESET
1435           <osmChange>
1436             <create>
1437               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1438                 <tag k='foo' v='bar'/>
1439                 <tag k='baz' v='bat'/>
1440               </node>
1441             </create>
1442             <modify>
1443               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
1444                 <nd ref='-1'/>
1445                 <nd ref='#{node.id}'/>
1446               </way>
1447               <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'>
1448                 <member type='way' role='some' ref='#{way.id}'/>
1449                 <member type='node' role='some' ref='-1'/>
1450                 <member type='relation' role='some' ref='#{relation.id}'/>
1451               </relation>
1452             </modify>
1453           </osmChange>
1454         CHANGESET
1455
1456         auth_header = bearer_authorization_header changeset.user
1457
1458         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1459
1460         assert_response :success
1461
1462         new_node_id = nil
1463         assert_dom "diffResult[version='#{Settings.api_version}'][generator='#{Settings.generator}']", 1 do
1464           assert_dom "> node", 1 do |(node_el)|
1465             new_node_id = node_el["new_id"].to_i
1466           end
1467           assert_dom "> way", 1
1468           assert_dom "> relation", 1
1469         end
1470
1471         changeset.reload
1472         assert_equal 3, changeset.num_changes
1473         assert_predicate changeset, :num_type_changes_in_sync?
1474         assert_equal 1, changeset.num_created_nodes
1475         assert_equal 1, changeset.num_modified_ways
1476         assert_equal 1, changeset.num_modified_relations
1477
1478         assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
1479         assert_equal [new_node_id, node.id], Way.find(way.id).nds, "way nodes should match"
1480         Relation.find(relation.id).members.each do |type, id, _role|
1481           assert_equal new_node_id, id, "relation should contain new node" if type == "node"
1482         end
1483       end
1484
1485       ##
1486       # test that a placeholder can be reused within the same upload.
1487       def test_upload_create_modify_delete_node_reusing_placeholder
1488         changeset = create(:changeset)
1489
1490         diff = <<~CHANGESET
1491           <osmChange>
1492             <create>
1493               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1494                 <tag k="foo" v="bar"/>
1495               </node>
1496             </create>
1497             <modify>
1498               <node id='-1' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
1499             </modify>
1500             <delete>
1501               <node id='-1' lon='2' lat='2' changeset='#{changeset.id}' version='2'/>
1502             </delete>
1503           </osmChange>
1504         CHANGESET
1505
1506         auth_header = bearer_authorization_header changeset.user
1507
1508         assert_difference "Node.count", 1 do
1509           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1510
1511           assert_response :success
1512         end
1513
1514         assert_dom "diffResult>node", 3
1515         assert_dom "diffResult>node[old_id='-1']", 3
1516
1517         node = Node.last
1518         assert_equal 3, node.version
1519         assert_not node.visible
1520       end
1521
1522       def test_upload_create_and_duplicate_delete
1523         changeset = create(:changeset)
1524
1525         diff = <<~CHANGESET
1526           <osmChange>
1527             <create>
1528               <node id="-1" lat="39" lon="116" changeset="#{changeset.id}" />
1529             </create>
1530             <delete>
1531               <node id="-1" version="1" changeset="#{changeset.id}" />
1532               <node id="-1" version="1" changeset="#{changeset.id}" />
1533             </delete>
1534           </osmChange>
1535         CHANGESET
1536
1537         auth_header = bearer_authorization_header changeset.user
1538
1539         assert_no_difference "Node.count" do
1540           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1541
1542           assert_response :gone
1543         end
1544
1545         assert_no_changes_in changeset
1546       end
1547
1548       def test_upload_create_and_duplicate_delete_if_unused
1549         changeset = create(:changeset)
1550
1551         diff = <<~CHANGESET
1552           <osmChange>
1553             <create>
1554               <node id="-1" lat="39" lon="116" changeset="#{changeset.id}" />
1555             </create>
1556             <delete if-unused="true">
1557               <node id="-1" version="1" changeset="#{changeset.id}" />
1558               <node id="-1" version="1" changeset="#{changeset.id}" />
1559             </delete>
1560           </osmChange>
1561         CHANGESET
1562
1563         auth_header = bearer_authorization_header changeset.user
1564
1565         assert_difference "Node.count", 1 do
1566           post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1567
1568           assert_response :success
1569         end
1570
1571         assert_dom "diffResult>node", 3
1572         assert_dom "diffResult>node[old_id='-1']", 3
1573         assert_dom "diffResult>node[new_version='1']", 1
1574         assert_dom "diffResult>node[new_version='2']", 1
1575
1576         node = Node.last
1577         assert_equal 2, node.version
1578         assert_not node.visible
1579       end
1580
1581       # -------------------------------------
1582       # Test bounding boxes.
1583       # -------------------------------------
1584
1585       def test_upload_bbox_of_widely_spaced_nodes
1586         user = create(:user)
1587
1588         # create an old changeset to ensure we have the maximum rate limit
1589         create(:changeset, :user => user, :created_at => Time.now.utc - 28.days)
1590
1591         changeset = create(:changeset, :user => user)
1592
1593         # upload some widely-spaced nodes, spiralling positive and negative
1594         diff = <<~CHANGESET
1595           <osmChange>
1596             <create>
1597               <node id='-1' lon='-20' lat='-10' changeset='#{changeset.id}'/>
1598               <node id='-10' lon='20'  lat='10' changeset='#{changeset.id}'/>
1599               <node id='-2' lon='-40' lat='-20' changeset='#{changeset.id}'/>
1600               <node id='-11' lon='40'  lat='20' changeset='#{changeset.id}'/>
1601               <node id='-3' lon='-60' lat='-30' changeset='#{changeset.id}'/>
1602               <node id='-12' lon='60'  lat='30' changeset='#{changeset.id}'/>
1603               <node id='-4' lon='-80' lat='-40' changeset='#{changeset.id}'/>
1604               <node id='-13' lon='80'  lat='40' changeset='#{changeset.id}'/>
1605               <node id='-5' lon='-100' lat='-50' changeset='#{changeset.id}'/>
1606               <node id='-14' lon='100'  lat='50' changeset='#{changeset.id}'/>
1607               <node id='-6' lon='-120' lat='-60' changeset='#{changeset.id}'/>
1608               <node id='-15' lon='120'  lat='60' changeset='#{changeset.id}'/>
1609               <node id='-7' lon='-140' lat='-70' changeset='#{changeset.id}'/>
1610               <node id='-16' lon='140'  lat='70' changeset='#{changeset.id}'/>
1611               <node id='-8' lon='-160' lat='-80' changeset='#{changeset.id}'/>
1612               <node id='-17' lon='160'  lat='80' changeset='#{changeset.id}'/>
1613               <node id='-9' lon='-179.9' lat='-89.9' changeset='#{changeset.id}'/>
1614               <node id='-18' lon='179.9'  lat='89.9' changeset='#{changeset.id}'/>
1615             </create>
1616           </osmChange>
1617         CHANGESET
1618
1619         auth_header = bearer_authorization_header user
1620
1621         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1622
1623         assert_response :success
1624
1625         changeset.reload
1626         assert_equal 18, changeset.num_changes
1627         assert_predicate changeset, :num_type_changes_in_sync?
1628         assert_equal 18, changeset.num_created_nodes
1629
1630         # check that the changeset bbox is within bounds
1631         assert_operator changeset.min_lon, :>=, -180 * GeoRecord::SCALE, "Minimum longitude (#{changeset.min_lon / GeoRecord::SCALE}) should be >= -180 to be valid."
1632         assert_operator changeset.max_lon, :<=, 180 * GeoRecord::SCALE, "Maximum longitude (#{changeset.max_lon / GeoRecord::SCALE}) should be <= 180 to be valid."
1633         assert_operator changeset.min_lat, :>=, -90 * GeoRecord::SCALE, "Minimum latitude (#{changeset.min_lat / GeoRecord::SCALE}) should be >= -90 to be valid."
1634         assert_operator changeset.max_lat, :<=, 90 * GeoRecord::SCALE, "Maximum latitude (#{changeset.max_lat / GeoRecord::SCALE}) should be <= 90 to be valid."
1635       end
1636
1637       def test_upload_bbox_of_moved_node
1638         changeset = create(:changeset)
1639         node = create(:node, :lat => 1.0, :lon => 2.0)
1640
1641         diff = <<~CHANGESET
1642           <osmChange>
1643             <modify>
1644               <node id='#{node.id}' lat='1.1' lon='2.1' changeset='#{changeset.id}' version='1'/>
1645             </modify>
1646           </osmChange>
1647         CHANGESET
1648
1649         auth_header = bearer_authorization_header changeset.user
1650
1651         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1652
1653         assert_response :success
1654
1655         changeset.reload
1656         assert_equal 1, changeset.num_changes
1657         assert_predicate changeset, :num_type_changes_in_sync?
1658         assert_equal 1, changeset.num_modified_nodes
1659
1660         # check the bbox
1661         assert_equal 1.0 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1.0 degrees"
1662         assert_equal 2.0 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 2.0 degrees"
1663         assert_equal 1.1 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 1.1 degrees"
1664         assert_equal 2.1 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 2.1 degrees"
1665       end
1666
1667       def test_upload_bbox_of_extended_way
1668         way = create(:way)
1669         initial_node = create(:node, :lat => 1.1, :lon => 2.1)
1670         create(:way_node, :way => way, :node => initial_node)
1671         added_node = create(:node, :lat => 1.3, :lon => 2.3)
1672         changeset = create(:changeset)
1673
1674         diff = <<~CHANGESET
1675           <osmChange>
1676             <modify>
1677               <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
1678                 <nd ref='#{initial_node.id}'/>
1679                 <nd ref='#{added_node.id}'/>
1680               </way>
1681             </modify>
1682           </osmChange>
1683         CHANGESET
1684
1685         auth_header = bearer_authorization_header changeset.user
1686
1687         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1688
1689         assert_response :success
1690
1691         changeset.reload
1692         assert_equal 1, changeset.num_changes
1693         assert_predicate changeset, :num_type_changes_in_sync?
1694         assert_equal 1, changeset.num_modified_ways
1695
1696         # check the bbox
1697         assert_equal 1.1 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1.1 degrees"
1698         assert_equal 2.1 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 2.1 degrees"
1699         assert_equal 1.3 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 1.3 degrees"
1700         assert_equal 2.3 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 2.3 degrees"
1701       end
1702
1703       # -------------------------------------
1704       # Test upload rate/size limits.
1705       # -------------------------------------
1706
1707       def test_upload_initial_rate_limit
1708         user = create(:user)
1709         node = create(:node)
1710         way = create(:way_with_nodes, :nodes_count => 2)
1711         relation = create(:relation)
1712
1713         # create a changeset that puts us near the initial rate limit
1714         num_changes = Settings.initial_changes_per_hour - 2
1715         changeset = create(:changeset, :user => user,
1716                                        :created_at => Time.now.utc - 5.minutes,
1717                                        :num_changes => num_changes,
1718                                        :num_created_nodes => num_changes)
1719
1720         diff = <<~CHANGESET
1721           <osmChange>
1722             <create>
1723               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1724                 <tag k='foo' v='bar'/>
1725                 <tag k='baz' v='bat'/>
1726               </node>
1727               <way id='-1' changeset='#{changeset.id}'>
1728                 <nd ref='#{node.id}'/>
1729               </way>
1730             </create>
1731             <create>
1732               <relation id='-1' changeset='#{changeset.id}'>
1733                 <member type='way' role='some' ref='#{way.id}'/>
1734                 <member type='node' role='some' ref='#{node.id}'/>
1735                 <member type='relation' role='some' ref='#{relation.id}'/>
1736               </relation>
1737             </create>
1738           </osmChange>
1739         CHANGESET
1740
1741         auth_header = bearer_authorization_header user
1742
1743         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1744
1745         assert_response :too_many_requests, "upload did not hit rate limit"
1746
1747         changeset.reload
1748         assert_equal num_changes, changeset.num_changes
1749         assert_predicate changeset, :num_type_changes_in_sync?
1750       end
1751
1752       def test_upload_maximum_rate_limit
1753         user = create(:user)
1754         node = create(:node)
1755         way = create(:way_with_nodes, :nodes_count => 2)
1756         relation = create(:relation)
1757
1758         # create a changeset to establish our initial edit time
1759         changeset = create(:changeset, :user => user,
1760                                        :created_at => Time.now.utc - 28.days)
1761
1762         # create changeset to put us near the maximum rate limit
1763         remaining_num_changes = Settings.max_changes_per_hour - 2
1764         num_changes = 0
1765         while remaining_num_changes.positive?
1766           num_changes = [remaining_num_changes, Changeset::MAX_ELEMENTS].min
1767           changeset = create(:changeset, :user => user,
1768                                          :created_at => Time.now.utc - 5.minutes,
1769                                          :num_changes => num_changes,
1770                                          :num_created_nodes => num_changes)
1771           remaining_num_changes -= num_changes
1772         end
1773
1774         diff = <<~CHANGESET
1775           <osmChange>
1776             <create>
1777               <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
1778                 <tag k='foo' v='bar'/>
1779                 <tag k='baz' v='bat'/>
1780               </node>
1781               <way id='-1' changeset='#{changeset.id}'>
1782                 <nd ref='#{node.id}'/>
1783               </way>
1784             </create>
1785             <create>
1786               <relation id='-1' changeset='#{changeset.id}'>
1787                 <member type='way' role='some' ref='#{way.id}'/>
1788                 <member type='node' role='some' ref='#{node.id}'/>
1789                 <member type='relation' role='some' ref='#{relation.id}'/>
1790               </relation>
1791             </create>
1792           </osmChange>
1793         CHANGESET
1794
1795         auth_header = bearer_authorization_header user
1796
1797         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1798
1799         assert_response :too_many_requests, "upload did not hit rate limit"
1800
1801         changeset.reload
1802         assert_equal num_changes, changeset.num_changes
1803         assert_predicate changeset, :num_type_changes_in_sync?
1804       end
1805
1806       def test_upload_initial_size_limit
1807         user = create(:user)
1808
1809         # create a changeset that puts us near the initial size limit
1810         changeset = create(:changeset, :user => user,
1811                                        :min_lat => (-0.5 * GeoRecord::SCALE).round, :min_lon => (0.5 * GeoRecord::SCALE).round,
1812                                        :max_lat => (0.5 * GeoRecord::SCALE).round, :max_lon => (2.5 * GeoRecord::SCALE).round)
1813
1814         diff = <<~CHANGESET
1815           <osmChange>
1816             <create>
1817               <node id='-1' lon='0.9' lat='2.9' changeset='#{changeset.id}'>
1818                 <tag k='foo' v='bar'/>
1819                 <tag k='baz' v='bat'/>
1820               </node>
1821             </create>
1822           </osmChange>
1823         CHANGESET
1824
1825         auth_header = bearer_authorization_header user
1826
1827         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1828
1829         assert_response :payload_too_large, "upload did not hit size limit"
1830
1831         assert_no_changes_in changeset
1832       end
1833
1834       def test_upload_size_limit_after_one_week
1835         user = create(:user)
1836
1837         # create a changeset to establish our initial edit time
1838         create(:changeset, :user => user, :created_at => Time.now.utc - 7.days)
1839
1840         # create a changeset that puts us near the initial size limit
1841         changeset = create(:changeset, :user => user, :bbox => [0.5, -0.5, 2.5, 0.5])
1842
1843         diff = <<~CHANGESET
1844           <osmChange>
1845             <create>
1846               <node id='-1' lon='35' lat='35' changeset='#{changeset.id}'>
1847                 <tag k='foo' v='bar'/>
1848                 <tag k='baz' v='bat'/>
1849               </node>
1850             </create>
1851           </osmChange>
1852         CHANGESET
1853
1854         auth_header = bearer_authorization_header user
1855
1856         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1857
1858         assert_response :payload_too_large, "upload did not hit size limit"
1859
1860         assert_no_changes_in changeset
1861       end
1862
1863       private
1864
1865       def check_upload_results_in_not_found(&)
1866         changeset = create(:changeset)
1867         diff = "<osmChange>#{yield changeset}</osmChange>"
1868         auth_header = bearer_authorization_header changeset.user
1869
1870         post api_changeset_upload_path(changeset), :params => diff, :headers => auth_header
1871
1872         assert_response :not_found
1873
1874         assert_no_changes_in changeset
1875       end
1876
1877       def assert_no_changes_in(changeset)
1878         changeset.reload
1879         assert_equal 0, changeset.num_changes
1880         assert_predicate changeset, :num_type_changes_in_sync?
1881       end
1882     end
1883   end
1884 end