3 class BrowseControllerTest < ActionDispatch::IntegrationTest
5 # test all routes which lead to this controller
8 { :path => "/node/1", :method => :get },
9 { :controller => "browse", :action => "node", :id => "1" }
12 { :path => "/node/1/history", :method => :get },
13 { :controller => "browse", :action => "node_history", :id => "1" }
16 { :path => "/way/1", :method => :get },
17 { :controller => "browse", :action => "way", :id => "1" }
20 { :path => "/way/1/history", :method => :get },
21 { :controller => "browse", :action => "way_history", :id => "1" }
24 { :path => "/relation/1", :method => :get },
25 { :controller => "browse", :action => "relation", :id => "1" }
28 { :path => "/relation/1/history", :method => :get },
29 { :controller => "browse", :action => "relation_history", :id => "1" }
32 { :path => "/changeset/1", :method => :get },
33 { :controller => "browse", :action => "changeset", :id => "1" }
36 { :path => "/query", :method => :get },
37 { :controller => "browse", :action => "query" }
41 def test_read_relation
42 relation = create(:relation)
43 browse_check :relation_path, relation.id, "browse/feature"
44 assert_select "h4", /^Version/ do
45 assert_select "a[href='#{old_relation_path relation, 1}']", :text => "1", :count => 1
47 assert_select ".secondary-actions a[href='#{api_relation_path relation}']", :count => 1
48 assert_select ".secondary-actions a[href='#{relation_history_path relation}']", :count => 1
49 assert_select ".secondary-actions a[href='#{old_relation_path relation, 1}']", :count => 0
52 def test_multiple_version_relation_links
53 relation = create(:relation, :with_history, :version => 2)
54 browse_check :relation_path, relation.id, "browse/feature"
55 assert_select ".secondary-actions a[href='#{relation_history_path relation}']", :count => 1
56 assert_select ".secondary-actions a[href='#{old_relation_path relation, 1}']", :count => 1
57 assert_select ".secondary-actions a[href='#{old_relation_path relation, 2}']", :count => 1
60 def test_read_relation_history
61 relation = create(:relation, :with_history)
62 browse_check :relation_history_path, relation.id, "browse/history"
63 assert_select "h4", /^Version/ do
64 assert_select "a[href='#{old_relation_path relation, 1}']", :text => "1", :count => 1
70 browse_check :way_path, way.id, "browse/feature"
71 assert_select "h4", /^Version/ do
72 assert_select "a[href='#{old_way_path way, 1}']", :text => "1", :count => 1
74 assert_select ".secondary-actions a[href='#{api_way_path way}']", :count => 1
75 assert_select ".secondary-actions a[href='#{way_history_path way}']", :count => 1
76 assert_select ".secondary-actions a[href='#{old_way_path way, 1}']", :count => 0
79 def test_multiple_version_way_links
80 way = create(:way, :with_history, :version => 2)
81 browse_check :way_path, way.id, "browse/feature"
82 assert_select ".secondary-actions a[href='#{way_history_path way}']", :count => 1
83 assert_select ".secondary-actions a[href='#{old_way_path way, 1}']", :count => 1
84 assert_select ".secondary-actions a[href='#{old_way_path way, 2}']", :count => 1
87 def test_read_way_history
88 way = create(:way, :with_history)
89 browse_check :way_history_path, way.id, "browse/history"
90 assert_select "h4", /^Version/ do
91 assert_select "a[href='#{old_way_path way, 1}']", :text => "1", :count => 1
97 browse_check :node_path, node.id, "browse/feature"
98 assert_select "h4", /^Version/ do
99 assert_select "a[href='#{old_node_path node, 1}']", :text => "1", :count => 1
101 assert_select ".secondary-actions a[href='#{api_node_path node}']", :count => 1
102 assert_select ".secondary-actions a[href='#{node_history_path node}']", :count => 1
103 assert_select ".secondary-actions a[href='#{old_node_path node, 1}']", :count => 0
106 def test_multiple_version_node_links
107 node = create(:node, :with_history, :version => 2)
108 browse_check :node_path, node.id, "browse/feature"
109 assert_select ".secondary-actions a[href='#{node_history_path node}']", :count => 1
110 assert_select ".secondary-actions a[href='#{old_node_path node, 1}']", :count => 1
111 assert_select ".secondary-actions a[href='#{old_node_path node, 2}']", :count => 1
114 def test_read_deleted_node
115 node = create(:node, :visible => false)
116 browse_check :node_path, node.id, "browse/feature"
117 assert_select "h4", /^Version/ do
118 assert_select "a[href='#{old_node_path node, 1}']", :text => "1", :count => 1
120 assert_select "a[href='#{api_node_path node}']", :count => 0
123 def test_read_node_history
124 node = create(:node, :with_history)
125 browse_check :node_history_path, node.id, "browse/history"
126 assert_select "h4", /^Version/ do
127 assert_select "a[href='#{old_node_path node, 1}']", :text => "1", :count => 1
131 def test_read_changeset
133 changeset = create(:changeset, :user => user)
134 create(:changeset, :user => user)
135 browse_check :changeset_path, changeset.id, "browse/changeset"
138 def test_read_private_changeset
140 changeset = create(:changeset, :user => create(:user, :data_public => false))
141 create(:changeset, :user => user)
142 browse_check :changeset_path, changeset.id, "browse/changeset"
146 # Methods to check redaction.
148 # note that these are presently highly reliant on the structure of the
149 # page for the selection tests, which doesn't work out particularly
150 # well if that structure changes. so... if you change the page layout
151 # then please make it more easily (and robustly) testable!
153 def test_redacted_node
154 node = create(:node, :with_history, :deleted, :version => 2)
155 node_v1 = node.old_nodes.find_by(:version => 1)
156 node_v1.redact!(create(:redaction))
158 get node_path(:id => node)
159 assert_response :success
160 assert_template "feature"
162 # check that we don't show lat/lon for a redacted node.
163 assert_select ".browse-section", 1
164 assert_select ".browse-section.browse-node", 1
165 assert_select ".browse-section.browse-node .latitude", 0
166 assert_select ".browse-section.browse-node .longitude", 0
169 def test_redacted_node_history
170 node = create(:node, :with_history, :deleted, :version => 2)
171 node_v1 = node.old_nodes.find_by(:version => 1)
172 node_v1.redact!(create(:redaction))
174 get node_history_path(:id => node)
175 assert_response :success
176 assert_template "browse/history"
178 # there are 2 revisions of the redacted node, but only one
179 # should be showing details here.
180 assert_select ".browse-section", 2
181 assert_select ".browse-section.browse-redacted", 1
182 assert_select ".browse-section.browse-node", 1
183 assert_select ".browse-section.browse-node .latitude", 0
184 assert_select ".browse-section.browse-node .longitude", 0
187 def test_redacted_way_history
188 way = create(:way, :with_history, :version => 4)
189 way_v1 = way.old_ways.find_by(:version => 1)
190 way_v1.redact!(create(:redaction))
191 way_v3 = way.old_ways.find_by(:version => 3)
192 way_v3.redact!(create(:redaction))
194 get way_history_path(:id => way)
195 assert_response :success
196 assert_template "browse/history"
198 # there are 4 revisions of the redacted way, but only 2
199 # should be showing details here.
200 assert_select ".browse-section", 4
201 assert_select ".browse-section.browse-redacted", 2
202 assert_select ".browse-section.browse-way", 2
205 def test_redacted_relation_history
206 relation = create(:relation, :with_history, :version => 4)
207 relation_v1 = relation.old_relations.find_by(:version => 1)
208 relation_v1.redact!(create(:redaction))
209 relation_v3 = relation.old_relations.find_by(:version => 3)
210 relation_v3.redact!(create(:redaction))
212 get relation_history_path(:id => relation)
213 assert_response :success
214 assert_template "browse/history"
216 # there are 4 revisions of the redacted relation, but only 2
217 # should be showing details here.
218 assert_select ".browse-section", 4
219 assert_select ".browse-section.browse-redacted", 2
220 assert_select ".browse-section.browse-relation", 2
225 assert_response :success
226 assert_template "browse/query"
231 # This is a convenience method for most of the above checks
232 # First we check that when we don't have an id, it will correctly return a 404
233 # then we check that we get the correct 404 when a non-existant id is passed
234 # then we check that it will get a successful response, when we do pass an id
235 def browse_check(path, id, template)
236 path_method = method(path)
238 assert_raise ActionController::UrlGenerationError do
242 assert_raise ActionController::UrlGenerationError do
243 get path_method.call(:id => -10) # we won't have an id that's negative
246 get path_method.call(:id => 0)
247 assert_response :not_found
248 assert_template "browse/not_found"
249 assert_template :layout => "map"
251 get path_method.call(:id => 0), :xhr => true
252 assert_response :not_found
253 assert_template "browse/not_found"
254 assert_template :layout => "xhr"
256 get path_method.call(:id => id)
257 assert_response :success
258 assert_template template
259 assert_template :layout => "map"
261 get path_method.call(:id => id), :xhr => true
262 assert_response :success
263 assert_template template
264 assert_template :layout => "xhr"