1 # The ChangesetController is the RESTful interface to Changeset objects
4 class ChangesetsController < ApiController
5 before_action :check_api_writable, :only => [:create, :update, :upload, :subscribe, :unsubscribe]
6 before_action :check_api_readable, :except => [:create, :update, :upload, :download, :query, :subscribe, :unsubscribe]
7 before_action :setup_user_auth, :only => [:show]
8 before_action :authorize, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
12 before_action :require_public_data, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
13 before_action :set_request_formats, :except => [:create, :close, :upload]
15 around_action :api_call_handle_error
16 around_action :api_call_timeout, :except => [:upload]
18 # Helper methods for checking consistency
19 include ConsistencyValidations
22 # Return XML giving the basic info about the changeset. Does not
23 # return anything about the nodes, ways and relations in the changeset.
25 @changeset = Changeset.find(params[:id])
26 if params[:include_discussion].presence
27 @comments = @changeset.comments
28 @comments = @comments.unscope(:where => :visible) if params[:show_hidden_comments].presence && can?(:restore, ChangesetComment)
29 @comments = @comments.includes(:author)
32 respond_to do |format|
38 # Create a changeset from XML.
40 cs = Changeset.from_xml(request.raw_post, :create => true)
42 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
43 cs.user = current_user
46 # Subscribe user to changeset comments
47 cs.subscribe(current_user)
49 render :plain => cs.id.to_s
53 # marks a changeset as closed. this may be called multiple times
54 # on the same changeset, so is idempotent.
56 changeset = Changeset.find(params[:id])
57 check_changeset_consistency(changeset, current_user)
59 # to close the changeset, we'll just set its closed_at time to
60 # now. this might not be enough if there are concurrency issues,
61 # but we'll have to wait and see.
62 changeset.set_closed_time_now
69 # Upload a diff in a single transaction.
71 # This means that each change within the diff must succeed, i.e: that
72 # each version number mentioned is still current. Otherwise the entire
73 # transaction *must* be rolled back.
75 # Furthermore, each element in the diff can only reference the current
78 # Returns: a diffResult document, as described in
79 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
81 changeset = Changeset.find(params[:id])
82 check_changeset_consistency(changeset, current_user)
84 diff_reader = DiffReader.new(request.raw_post, changeset)
85 Changeset.transaction do
86 result = diff_reader.commit
87 # the number of changes in this changeset has already been
88 # updated and is visible in this transaction so we don't need
89 # to allow for any more when checking the limit
91 render :xml => result.to_s
96 # download the changeset as an osmChange document.
98 # to make it easier to revert diffs it would be better if the osmChange
99 # format were reversible, i.e: contained both old and new versions of
100 # modified elements. but it doesn't at the moment...
102 # this method cannot order the database changes fully (i.e: timestamp and
103 # version number may be too coarse) so the resulting diff may not apply
104 # to a different database. however since changesets are not atomic this
105 # behaviour cannot be guaranteed anyway and is the result of a design
108 changeset = Changeset.find(params[:id])
110 # get all the elements in the changeset which haven't been redacted
111 # and stick them in a big array.
112 elements = [changeset.old_nodes.unredacted,
113 changeset.old_ways.unredacted,
114 changeset.old_relations.unredacted].flatten
116 # sort the elements by timestamp and version number, as this is the
117 # almost sensible ordering available. this would be much nicer if
118 # global (SVN-style) versioning were used - then that would be
120 elements.sort_by! { |e| [e.timestamp, e.version] }
122 # generate an output element for each operation. note: we avoid looking
123 # at the history because it is simpler - but it would be more correct to
124 # check these assertions.
129 elements.each do |elt|
131 # first version, so it must be newly-created.
137 # if the element isn't visible then it must have been deleted
142 respond_to do |format|
148 # query changesets by bounding box, time, user or open/closed status.
150 raise OSM::APIBadUserInput, "cannot use order=oldest with time" if params[:time] && params[:order] == "oldest"
152 # find any bounding box
153 bbox = BoundingBox.from_bbox_params(params) if params["bbox"]
155 # create the conditions that the user asked for. some or all of
157 changesets = Changeset.all
158 changesets = conditions_bbox(changesets, bbox)
159 changesets = conditions_user(changesets, params["user"], params["display_name"])
160 changesets = conditions_time(changesets, params["time"])
161 changesets = conditions_from_to(changesets, params["from"], params["to"])
162 changesets = conditions_open(changesets, params["open"])
163 changesets = conditions_closed(changesets, params["closed"])
164 changesets = conditions_ids(changesets, params["changesets"])
166 # sort the changesets
167 changesets = if params[:order] == "oldest"
168 changesets.order(:created_at => :asc)
170 changesets.order(:created_at => :desc)
174 changesets = changesets.limit(result_limit)
176 # preload users, tags and comments, and render result
177 @changesets = changesets.preload(:user, :changeset_tags, :comments)
180 respond_to do |format|
187 # updates a changeset's tags. none of the changeset's attributes are
188 # user-modifiable, so they will be ignored.
190 # changesets are not (yet?) versioned, so we don't have to deal with
191 # history tables here. changesets are locked to a single user, however.
193 # after succesful update, returns the XML of the changeset.
195 @changeset = Changeset.find(params[:id])
196 new_changeset = Changeset.from_xml(request.raw_post)
198 check_changeset_consistency(@changeset, current_user)
199 @changeset.update_from(new_changeset, current_user)
202 respond_to do |format|
209 # Adds a subscriber to the changeset
211 # Check the arguments are sane
212 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
214 # Extract the arguments
215 id = params[:id].to_i
217 # Find the changeset and check it is valid
218 changeset = Changeset.find(id)
219 raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribed?(current_user)
222 changeset.subscribe(current_user)
224 # Return a copy of the updated changeset
225 @changeset = changeset
228 respond_to do |format|
235 # Removes a subscriber from the changeset
237 # Check the arguments are sane
238 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
240 # Extract the arguments
241 id = params[:id].to_i
243 # Find the changeset and check it is valid
244 changeset = Changeset.find(id)
245 raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribed?(current_user)
247 # Remove the subscriber
248 changeset.unsubscribe(current_user)
250 # Return a copy of the updated changeset
251 @changeset = changeset
254 respond_to do |format|
262 #------------------------------------------------------------
263 # utility functions below.
264 #------------------------------------------------------------
267 # if a bounding box was specified do some sanity checks.
268 # restrict changesets to those enclosed by a bounding box
269 def conditions_bbox(changesets, bbox)
271 bbox.check_boundaries
272 bbox = bbox.to_scaled
274 changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
275 bbox.max_lon.to_i, bbox.min_lon.to_i,
276 bbox.max_lat.to_i, bbox.min_lat.to_i)
283 # restrict changesets to those by a particular user
284 def conditions_user(changesets, user, name)
285 if user.nil? && name.nil?
288 # shouldn't provide both name and UID
289 raise OSM::APIBadUserInput, "provide either the user ID or display name, but not both" if user && name
291 # use either the name or the UID to find the user which we're selecting on.
293 # user input checking, we don't have any UIDs < 1
294 raise OSM::APIBadUserInput, "invalid user ID" if user.to_i < 1
296 u = User.find_by(:id => user.to_i)
298 u = User.find_by(:display_name => name)
301 # make sure we found a user
302 raise OSM::APINotFoundError if u.nil?
304 # should be able to get changesets of public users only, or
305 # our own changesets regardless of public-ness.
306 unless u.data_public?
307 # get optional user auth stuff so that users can see their own
308 # changesets if they're non-public
311 raise OSM::APINotFoundError if current_user.nil? || current_user != u
314 changesets.where(:user => u)
319 # restrict changesets to those during a particular time period
320 def conditions_time(changesets, time)
323 elsif time.count(",") == 1
324 # if there is a range, i.e: comma separated, then the first is
325 # low, second is high - same as with bounding boxes.
327 # check that we actually have 2 elements in the array
328 times = time.split(",")
329 raise OSM::APIBadUserInput, "bad time range" if times.size != 2
331 from, to = times.collect { |t| Time.parse(t).utc }
332 changesets.where("closed_at >= ? and created_at <= ?", from, to)
334 # if there is no comma, assume its a lower limit on time
335 changesets.where("closed_at >= ?", Time.parse(time).utc)
337 # stupid Time seems to throw both of these for bad parsing, so
338 # we have to catch both and ensure the correct code path is taken.
339 rescue ArgumentError, RuntimeError => e
340 raise OSM::APIBadUserInput, e.message.to_s
344 # restrict changesets to those opened during a particular time period
345 # works similar to from..to of notes controller, including the requirement of 'from' when specifying 'to'
346 def conditions_from_to(changesets, from, to)
349 from = Time.parse(from).utc
351 raise OSM::APIBadUserInput, "Date #{from} is in a wrong format"
361 raise OSM::APIBadUserInput, "Date #{to} is in a wrong format"
364 changesets.where(:created_at => from..to)
371 # return changesets which are open (haven't been closed yet)
372 # we do this by seeing if the 'closed at' time is in the future. Also if we've
373 # hit the maximum number of changes then it counts as no longer open.
374 # if parameter 'open' is nill then open and closed changesets are returned
375 def conditions_open(changesets, open)
379 changesets.where("closed_at >= ? and num_changes <= ?",
380 Time.now.utc, Changeset::MAX_ELEMENTS)
385 # query changesets which are closed
386 # ('closed at' time has passed or changes limit is hit)
387 def conditions_closed(changesets, closed)
391 changesets.where("closed_at < ? or num_changes > ?",
392 Time.now.utc, Changeset::MAX_ELEMENTS)
397 # query changesets by a list of ids
398 # (either specified as array or comma-separated string)
399 def conditions_ids(changesets, ids)
403 raise OSM::APIBadUserInput, "No changesets were given to search for"
405 ids = ids.split(",").collect(&:to_i)
406 changesets.where(:id => ids)
411 # Get the maximum number of results to return
414 if params[:limit].to_i.positive? && params[:limit].to_i <= Settings.max_changeset_query_limit
417 raise OSM::APIBadUserInput, "Changeset limit must be between 1 and #{Settings.max_changeset_query_limit}"
420 Settings.default_changeset_query_limit