test/models/changeset_test.rb

   1 require "test_helper"
   2
   3 class ChangesetTest < ActiveSupport::TestCase
   4   def test_num_changes_valid
   5     changeset = create(:changeset)
   6     assert_predicate changeset, :valid?
   7     changeset.num_changes = nil
   8     assert_not_predicate changeset, :valid?
   9     changeset.num_changes = -1
  10     assert_not_predicate changeset, :valid?
  11     changeset.num_changes = 0
  12     assert_predicate changeset, :valid?
  13     changeset.num_changes = 1
  14     assert_predicate changeset, :valid?
  15   end
  16
  17   def test_num_type_changes_valid
  18     [:num_created_nodes, :num_modified_nodes, :num_deleted_nodes,
  19      :num_created_ways, :num_modified_ways, :num_deleted_ways,
  20      :num_created_relations, :num_modified_relations, :num_deleted_relations].each do |counter_attribute|
  21        changeset = create(:changeset)
  22        assert_predicate changeset, :valid?
  23        changeset[counter_attribute] = nil
  24        assert_not_predicate changeset, :valid?
  25        changeset[counter_attribute] = -1
  26        assert_not_predicate changeset, :valid?
  27        changeset[counter_attribute] = 0
  28        assert_predicate changeset, :valid?
  29        changeset[counter_attribute] = 1
  30        assert_predicate changeset, :valid?
  31      end
  32   end
  33
  34   def test_num_type_changes_in_sync_for_new_changeset
  35     changeset = create(:changeset)
  36     assert_predicate changeset, :num_type_changes_in_sync?
  37   end
  38
  39   def test_num_type_changes_not_in_sync_for_changeset_without_type_changes
  40     changeset = create(:changeset, :num_changes => 1)
  41     assert_not_predicate changeset, :num_type_changes_in_sync?
  42   end
  43
  44   def test_num_type_changes_in_sync_for_changeset_with_created_nodes
  45     changeset = create(:changeset, :num_changes => 1, :num_created_nodes => 1)
  46     assert_predicate changeset, :num_type_changes_in_sync?
  47   end
  48
  49   def test_num_type_changes_in_sync_for_changeset_with_modified_nodes
  50     changeset = create(:changeset, :num_changes => 1, :num_modified_nodes => 1)
  51     assert_predicate changeset, :num_type_changes_in_sync?
  52   end
  53
  54   def test_num_type_changes_in_sync_for_changeset_with_deleted_nodes
  55     changeset = create(:changeset, :num_changes => 1, :num_deleted_nodes => 1)
  56     assert_predicate changeset, :num_type_changes_in_sync?
  57   end
  58
  59   def test_num_type_changes_in_sync_for_changeset_with_changed_nodes
  60     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
  61                                    :num_created_nodes => 3,
  62                                    :num_modified_nodes => 2,
  63                                    :num_deleted_nodes => 1)
  64     assert_predicate changeset, :num_type_changes_in_sync?
  65   end
  66
  67   def test_num_type_changes_in_sync_for_changeset_with_created_ways
  68     changeset = create(:changeset, :num_changes => 1, :num_created_ways => 1)
  69     assert_predicate changeset, :num_type_changes_in_sync?
  70   end
  71
  72   def test_num_type_changes_in_sync_for_changeset_with_modified_ways
  73     changeset = create(:changeset, :num_changes => 1, :num_modified_ways => 1)
  74     assert_predicate changeset, :num_type_changes_in_sync?
  75   end
  76
  77   def test_num_type_changes_in_sync_for_changeset_with_deleted_ways
  78     changeset = create(:changeset, :num_changes => 1, :num_deleted_ways => 1)
  79     assert_predicate changeset, :num_type_changes_in_sync?
  80   end
  81
  82   def test_num_type_changes_in_sync_for_changeset_with_changed_ways
  83     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
  84                                    :num_created_ways => 3,
  85                                    :num_modified_ways => 2,
  86                                    :num_deleted_ways => 1)
  87     assert_predicate changeset, :num_type_changes_in_sync?
  88   end
  89
  90   def test_num_type_changes_in_sync_for_changeset_with_created_relations
  91     changeset = create(:changeset, :num_changes => 1, :num_created_relations => 1)
  92     assert_predicate changeset, :num_type_changes_in_sync?
  93   end
  94
  95   def test_num_type_changes_in_sync_for_changeset_with_modified_relations
  96     changeset = create(:changeset, :num_changes => 1, :num_modified_relations => 1)
  97     assert_predicate changeset, :num_type_changes_in_sync?
  98   end
  99
 100   def test_num_type_changes_in_sync_for_changeset_with_deleted_relations
 101     changeset = create(:changeset, :num_changes => 1, :num_deleted_relations => 1)
 102     assert_predicate changeset, :num_type_changes_in_sync?
 103   end
 104
 105   def test_num_type_changes_in_sync_for_changeset_with_changed_relations
 106     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 107                                    :num_created_relations => 3,
 108                                    :num_modified_relations => 2,
 109                                    :num_deleted_relations => 1)
 110     assert_predicate changeset, :num_type_changes_in_sync?
 111   end
 112
 113   def test_num_type_changes_in_sync_for_changeset_with_created_elements
 114     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 115                                    :num_created_nodes => 3,
 116                                    :num_created_ways => 2,
 117                                    :num_created_relations => 1)
 118     assert_predicate changeset, :num_type_changes_in_sync?
 119   end
 120
 121   def test_num_type_changes_in_sync_for_changeset_with_modified_elements
 122     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 123                                    :num_modified_nodes => 3,
 124                                    :num_modified_ways => 2,
 125                                    :num_modified_relations => 1)
 126     assert_predicate changeset, :num_type_changes_in_sync?
 127   end
 128
 129   def test_num_type_changes_in_sync_for_changeset_with_deleted_elements
 130     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 131                                    :num_deleted_nodes => 3,
 132                                    :num_deleted_ways => 2,
 133                                    :num_deleted_relations => 1)
 134     assert_predicate changeset, :num_type_changes_in_sync?
 135   end
 136
 137   def test_num_type_changes_in_sync_for_changeset_with_changed_elements
 138     changeset = create(:changeset, :num_changes => 33 + 32 + 31 + 23 + 22 + 21 + 13 + 12 + 11,
 139                                    :num_created_nodes => 33,
 140                                    :num_created_ways => 32,
 141                                    :num_created_relations => 31,
 142                                    :num_modified_nodes => 23,
 143                                    :num_modified_ways => 22,
 144                                    :num_modified_relations => 21,
 145                                    :num_deleted_nodes => 13,
 146                                    :num_deleted_ways => 12,
 147                                    :num_deleted_relations => 11)
 148     assert_predicate changeset, :num_type_changes_in_sync?
 149   end
 150
 151   def test_from_xml_no_text
 152     no_text = ""
 153     message_create = assert_raise(OSM::APIBadXMLError) do
 154       Changeset.from_xml(no_text, :create => true)
 155     end
 156     assert_match(/Must specify a string with one or more characters/, message_create.message)
 157     message_update = assert_raise(OSM::APIBadXMLError) do
 158       Changeset.from_xml(no_text, :create => false)
 159     end
 160     assert_match(/Must specify a string with one or more characters/, message_update.message)
 161   end
 162
 163   def test_from_xml_no_changeset
 164     nocs = "<osm></osm>"
 165     message_create = assert_raise(OSM::APIBadXMLError) do
 166       Changeset.from_xml(nocs, :create => true)
 167     end
 168     assert_match %r{XML doesn't contain an osm/changeset element}, message_create.message
 169     message_update = assert_raise(OSM::APIBadXMLError) do
 170       Changeset.from_xml(nocs, :create => false)
 171     end
 172     assert_match %r{XML doesn't contain an osm/changeset element}, message_update.message
 173   end
 174
 175   def test_from_xml_no_k_v
 176     nokv = "<osm><changeset><tag /></changeset></osm>"
 177     message_create = assert_raise(OSM::APIBadXMLError) do
 178       Changeset.from_xml(nokv, :create => true)
 179     end
 180     assert_match(/tag is missing key/, message_create.message)
 181     message_update = assert_raise(OSM::APIBadXMLError) do
 182       Changeset.from_xml(nokv, :create => false)
 183     end
 184     assert_match(/tag is missing key/, message_update.message)
 185   end
 186
 187   def test_from_xml_no_v
 188     no_v = "<osm><changeset><tag k='key' /></changeset></osm>"
 189     message_create = assert_raise(OSM::APIBadXMLError) do
 190       Changeset.from_xml(no_v, :create => true)
 191     end
 192     assert_match(/tag is missing value/, message_create.message)
 193     message_update = assert_raise(OSM::APIBadXMLError) do
 194       Changeset.from_xml(no_v, :create => false)
 195     end
 196     assert_match(/tag is missing value/, message_update.message)
 197   end
 198
 199   def test_from_xml_duplicate_k
 200     dupk = "<osm><changeset><tag k='dup' v='test' /><tag k='dup' v='value' /></changeset></osm>"
 201     message_create = assert_raise(OSM::APIDuplicateTagsError) do
 202       Changeset.from_xml(dupk, :create => true)
 203     end
 204     assert_equal "Element changeset/ has duplicate tags with key dup", message_create.message
 205     message_update = assert_raise(OSM::APIDuplicateTagsError) do
 206       Changeset.from_xml(dupk, :create => false)
 207     end
 208     assert_equal "Element changeset/ has duplicate tags with key dup", message_update.message
 209   end
 210
 211   def test_from_xml_valid
 212     # Example taken from the Update section on the API_v0.6 docs on the wiki
 213     xml = "<osm><changeset><tag k=\"comment\" v=\"Just adding some streetnames and a restaurant\"/></changeset></osm>"
 214     assert_nothing_raised do
 215       Changeset.from_xml(xml, :create => false)
 216     end
 217     assert_nothing_raised do
 218       Changeset.from_xml(xml, :create => true)
 219     end
 220   end
 221 end