test/models/changeset_test.rb

   1 require "test_helper"
   2
   3 class ChangesetTest < ActiveSupport::TestCase
   4   def test_num_changes_valid
   5     changeset = create(:changeset)
   6     assert_predicate changeset, :valid?
   7     changeset.num_changes = nil
   8     assert_not_predicate changeset, :valid?
   9     changeset.num_changes = -1
  10     assert_not_predicate changeset, :valid?
  11     changeset.num_changes = 0
  12     assert_predicate changeset, :valid?
  13     changeset.num_changes = 1
  14     assert_predicate changeset, :valid?
  15   end
  16
  17   def test_num_type_changes_valid
  18     [:num_created_nodes, :num_modified_nodes, :num_deleted_nodes,
  19      :num_created_ways, :num_modified_ways, :num_deleted_ways,
  20      :num_created_relations, :num_modified_relations, :num_deleted_relations].each do |counter_attribute|
  21        changeset = create(:changeset)
  22        assert_predicate changeset, :valid?
  23        changeset[counter_attribute] = nil
  24        assert_not_predicate changeset, :valid?
  25        changeset[counter_attribute] = -1
  26        assert_not_predicate changeset, :valid?
  27        changeset[counter_attribute] = 0
  28        assert_predicate changeset, :valid?
  29        changeset[counter_attribute] = 1
  30        assert_predicate changeset, :valid?
  31      end
  32   end
  33
  34   def test_num_type_changes_in_sync_for_new_changeset
  35     changeset = create(:changeset)
  36     assert_equal 0, changeset.num_created_elements
  37     assert_equal 0, changeset.num_modified_elements
  38     assert_equal 0, changeset.num_deleted_elements
  39     assert_predicate changeset, :num_type_changes_in_sync?
  40   end
  41
  42   def test_num_type_changes_not_in_sync_for_changeset_without_type_changes
  43     changeset = create(:changeset, :num_changes => 1)
  44     assert_equal 0, changeset.num_created_elements
  45     assert_equal 0, changeset.num_modified_elements
  46     assert_equal 0, changeset.num_deleted_elements
  47     assert_not_predicate changeset, :num_type_changes_in_sync?
  48   end
  49
  50   def test_num_type_changes_in_sync_for_changeset_with_created_nodes
  51     changeset = create(:changeset, :num_changes => 1, :num_created_nodes => 1)
  52     assert_equal 1, changeset.num_created_elements
  53     assert_equal 0, changeset.num_modified_elements
  54     assert_equal 0, changeset.num_deleted_elements
  55     assert_predicate changeset, :num_type_changes_in_sync?
  56   end
  57
  58   def test_num_type_changes_in_sync_for_changeset_with_modified_nodes
  59     changeset = create(:changeset, :num_changes => 1, :num_modified_nodes => 1)
  60     assert_equal 0, changeset.num_created_elements
  61     assert_equal 1, changeset.num_modified_elements
  62     assert_equal 0, changeset.num_deleted_elements
  63     assert_predicate changeset, :num_type_changes_in_sync?
  64   end
  65
  66   def test_num_type_changes_in_sync_for_changeset_with_deleted_nodes
  67     changeset = create(:changeset, :num_changes => 1, :num_deleted_nodes => 1)
  68     assert_equal 0, changeset.num_created_elements
  69     assert_equal 0, changeset.num_modified_elements
  70     assert_equal 1, changeset.num_deleted_elements
  71     assert_predicate changeset, :num_type_changes_in_sync?
  72   end
  73
  74   def test_num_type_changes_in_sync_for_changeset_with_changed_nodes
  75     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
  76                                    :num_created_nodes => 3,
  77                                    :num_modified_nodes => 2,
  78                                    :num_deleted_nodes => 1)
  79     assert_equal 3, changeset.num_created_elements
  80     assert_equal 2, changeset.num_modified_elements
  81     assert_equal 1, changeset.num_deleted_elements
  82     assert_predicate changeset, :num_type_changes_in_sync?
  83   end
  84
  85   def test_num_type_changes_in_sync_for_changeset_with_created_ways
  86     changeset = create(:changeset, :num_changes => 1, :num_created_ways => 1)
  87     assert_equal 1, changeset.num_created_elements
  88     assert_equal 0, changeset.num_modified_elements
  89     assert_equal 0, changeset.num_deleted_elements
  90     assert_predicate changeset, :num_type_changes_in_sync?
  91   end
  92
  93   def test_num_type_changes_in_sync_for_changeset_with_modified_ways
  94     changeset = create(:changeset, :num_changes => 1, :num_modified_ways => 1)
  95     assert_equal 0, changeset.num_created_elements
  96     assert_equal 1, changeset.num_modified_elements
  97     assert_equal 0, changeset.num_deleted_elements
  98     assert_predicate changeset, :num_type_changes_in_sync?
  99   end
 100
 101   def test_num_type_changes_in_sync_for_changeset_with_deleted_ways
 102     changeset = create(:changeset, :num_changes => 1, :num_deleted_ways => 1)
 103     assert_equal 0, changeset.num_created_elements
 104     assert_equal 0, changeset.num_modified_elements
 105     assert_equal 1, changeset.num_deleted_elements
 106     assert_predicate changeset, :num_type_changes_in_sync?
 107   end
 108
 109   def test_num_type_changes_in_sync_for_changeset_with_changed_ways
 110     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 111                                    :num_created_ways => 3,
 112                                    :num_modified_ways => 2,
 113                                    :num_deleted_ways => 1)
 114     assert_equal 3, changeset.num_created_elements
 115     assert_equal 2, changeset.num_modified_elements
 116     assert_equal 1, changeset.num_deleted_elements
 117     assert_predicate changeset, :num_type_changes_in_sync?
 118   end
 119
 120   def test_num_type_changes_in_sync_for_changeset_with_created_relations
 121     changeset = create(:changeset, :num_changes => 1, :num_created_relations => 1)
 122     assert_equal 1, changeset.num_created_elements
 123     assert_equal 0, changeset.num_modified_elements
 124     assert_equal 0, changeset.num_deleted_elements
 125     assert_predicate changeset, :num_type_changes_in_sync?
 126   end
 127
 128   def test_num_type_changes_in_sync_for_changeset_with_modified_relations
 129     changeset = create(:changeset, :num_changes => 1, :num_modified_relations => 1)
 130     assert_equal 0, changeset.num_created_elements
 131     assert_equal 1, changeset.num_modified_elements
 132     assert_equal 0, changeset.num_deleted_elements
 133     assert_predicate changeset, :num_type_changes_in_sync?
 134   end
 135
 136   def test_num_type_changes_in_sync_for_changeset_with_deleted_relations
 137     changeset = create(:changeset, :num_changes => 1, :num_deleted_relations => 1)
 138     assert_equal 0, changeset.num_created_elements
 139     assert_equal 0, changeset.num_modified_elements
 140     assert_equal 1, changeset.num_deleted_elements
 141     assert_predicate changeset, :num_type_changes_in_sync?
 142   end
 143
 144   def test_num_type_changes_in_sync_for_changeset_with_changed_relations
 145     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 146                                    :num_created_relations => 3,
 147                                    :num_modified_relations => 2,
 148                                    :num_deleted_relations => 1)
 149     assert_equal 3, changeset.num_created_elements
 150     assert_equal 2, changeset.num_modified_elements
 151     assert_equal 1, changeset.num_deleted_elements
 152     assert_predicate changeset, :num_type_changes_in_sync?
 153   end
 154
 155   def test_num_type_changes_in_sync_for_changeset_with_created_elements
 156     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 157                                    :num_created_nodes => 3,
 158                                    :num_created_ways => 2,
 159                                    :num_created_relations => 1)
 160     assert_equal 3 + 2 + 1, changeset.num_created_elements
 161     assert_equal 0, changeset.num_modified_elements
 162     assert_equal 0, changeset.num_deleted_elements
 163     assert_predicate changeset, :num_type_changes_in_sync?
 164   end
 165
 166   def test_num_type_changes_in_sync_for_changeset_with_modified_elements
 167     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 168                                    :num_modified_nodes => 3,
 169                                    :num_modified_ways => 2,
 170                                    :num_modified_relations => 1)
 171     assert_equal 0, changeset.num_created_elements
 172     assert_equal 3 + 2 + 1, changeset.num_modified_elements
 173     assert_equal 0, changeset.num_deleted_elements
 174     assert_predicate changeset, :num_type_changes_in_sync?
 175   end
 176
 177   def test_num_type_changes_in_sync_for_changeset_with_deleted_elements
 178     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 179                                    :num_deleted_nodes => 3,
 180                                    :num_deleted_ways => 2,
 181                                    :num_deleted_relations => 1)
 182     assert_equal 0, changeset.num_created_elements
 183     assert_equal 0, changeset.num_modified_elements
 184     assert_equal 3 + 2 + 1, changeset.num_deleted_elements
 185     assert_predicate changeset, :num_type_changes_in_sync?
 186   end
 187
 188   def test_num_type_changes_in_sync_for_changeset_with_changed_elements
 189     changeset = create(:changeset, :num_changes => 33 + 32 + 31 + 23 + 22 + 21 + 13 + 12 + 11,
 190                                    :num_created_nodes => 33,
 191                                    :num_created_ways => 32,
 192                                    :num_created_relations => 31,
 193                                    :num_modified_nodes => 23,
 194                                    :num_modified_ways => 22,
 195                                    :num_modified_relations => 21,
 196                                    :num_deleted_nodes => 13,
 197                                    :num_deleted_ways => 12,
 198                                    :num_deleted_relations => 11)
 199     assert_equal 33 + 32 + 31, changeset.num_created_elements
 200     assert_equal 23 + 22 + 21, changeset.num_modified_elements
 201     assert_equal 13 + 12 + 11, changeset.num_deleted_elements
 202     assert_predicate changeset, :num_type_changes_in_sync?
 203   end
 204
 205   def test_from_xml_no_text
 206     no_text = ""
 207     message_create = assert_raise(OSM::APIBadXMLError) do
 208       Changeset.from_xml(no_text, :create => true)
 209     end
 210     assert_match(/Must specify a string with one or more characters/, message_create.message)
 211     message_update = assert_raise(OSM::APIBadXMLError) do
 212       Changeset.from_xml(no_text, :create => false)
 213     end
 214     assert_match(/Must specify a string with one or more characters/, message_update.message)
 215   end
 216
 217   def test_from_xml_no_changeset
 218     nocs = "<osm></osm>"
 219     message_create = assert_raise(OSM::APIBadXMLError) do
 220       Changeset.from_xml(nocs, :create => true)
 221     end
 222     assert_match %r{XML doesn't contain an osm/changeset element}, message_create.message
 223     message_update = assert_raise(OSM::APIBadXMLError) do
 224       Changeset.from_xml(nocs, :create => false)
 225     end
 226     assert_match %r{XML doesn't contain an osm/changeset element}, message_update.message
 227   end
 228
 229   def test_from_xml_no_k_v
 230     nokv = "<osm><changeset><tag /></changeset></osm>"
 231     message_create = assert_raise(OSM::APIBadXMLError) do
 232       Changeset.from_xml(nokv, :create => true)
 233     end
 234     assert_match(/tag is missing key/, message_create.message)
 235     message_update = assert_raise(OSM::APIBadXMLError) do
 236       Changeset.from_xml(nokv, :create => false)
 237     end
 238     assert_match(/tag is missing key/, message_update.message)
 239   end
 240
 241   def test_from_xml_no_v
 242     no_v = "<osm><changeset><tag k='key' /></changeset></osm>"
 243     message_create = assert_raise(OSM::APIBadXMLError) do
 244       Changeset.from_xml(no_v, :create => true)
 245     end
 246     assert_match(/tag is missing value/, message_create.message)
 247     message_update = assert_raise(OSM::APIBadXMLError) do
 248       Changeset.from_xml(no_v, :create => false)
 249     end
 250     assert_match(/tag is missing value/, message_update.message)
 251   end
 252
 253   def test_from_xml_duplicate_k
 254     dupk = "<osm><changeset><tag k='dup' v='test' /><tag k='dup' v='value' /></changeset></osm>"
 255     message_create = assert_raise(OSM::APIDuplicateTagsError) do
 256       Changeset.from_xml(dupk, :create => true)
 257     end
 258     assert_equal "Element changeset/ has duplicate tags with key dup", message_create.message
 259     message_update = assert_raise(OSM::APIDuplicateTagsError) do
 260       Changeset.from_xml(dupk, :create => false)
 261     end
 262     assert_equal "Element changeset/ has duplicate tags with key dup", message_update.message
 263   end
 264
 265   def test_from_xml_valid
 266     # Example taken from the Update section on the API_v0.6 docs on the wiki
 267     xml = "<osm><changeset><tag k=\"comment\" v=\"Just adding some streetnames and a restaurant\"/></changeset></osm>"
 268     assert_nothing_raised do
 269       Changeset.from_xml(xml, :create => false)
 270     end
 271     assert_nothing_raised do
 272       Changeset.from_xml(xml, :create => true)
 273     end
 274   end
 275 end