1 # frozen_string_literal: true
5 class ChangesetsControllerTest < ActionDispatch::IntegrationTest
7 # test all routes which lead to this controller
10 { :path => "/changeset/1", :method => :get },
11 { :controller => "changesets", :action => "show", :id => "1" }
14 { :path => "/user/name/history", :method => :get },
15 { :controller => "changesets", :action => "index", :display_name => "name" }
18 { :path => "/user/name/history/feed", :method => :get },
19 { :controller => "changesets", :action => "feed", :display_name => "name", :format => :atom }
22 { :path => "/history/friends", :method => :get },
23 { :controller => "changesets", :action => "index", :friends => true, :format => :html }
26 { :path => "/history/nearby", :method => :get },
27 { :controller => "changesets", :action => "index", :nearby => true, :format => :html }
30 { :path => "/history", :method => :get },
31 { :controller => "changesets", :action => "index" }
34 { :path => "/history/feed", :method => :get },
35 { :controller => "changesets", :action => "feed", :format => :atom }
40 # This should display the last 20 changesets closed
42 changesets = create_list(:changeset, 30, :num_changes => 1)
44 get history_path(:format => "html")
45 assert_response :success
46 assert_template "history"
47 assert_template :layout => "map"
48 assert_select "h2", :text => "Changesets", :count => 1
49 assert_select "link[rel='alternate'][type='application/atom+xml']", :count => 1 do
50 assert_select "[href=?]", "http://www.example.com/history/feed"
53 get history_path(:format => "html", :list => "1"), :xhr => true
54 assert_response :success
55 assert_template "index"
57 check_index_result(changesets.last(20))
61 # This should display the last 20 changesets closed
63 changesets = create_list(:changeset, 30, :num_changes => 1)
65 get history_path(:format => "html"), :headers => { "Turbo-Frame" => "sidebar_content_frame" }
66 assert_response :success
67 assert_template "history"
68 assert_template :layout => "xhr"
69 assert_select "h2", :text => "Changesets", :count => 1
70 assert_select "link[rel='alternate'][type='application/atom+xml']", :count => 1 do
71 assert_select "[href=?]", "http://www.example.com/history/feed"
74 get history_path(:format => "html", :list => "1"), :xhr => true
75 assert_response :success
76 assert_template "index"
78 check_index_result(changesets.last(20))
82 # This should report an error
83 def test_index_invalid_xhr
84 %w[-1 0 fred].each do |id|
85 get history_path(:format => "html", :list => "1", :before => id)
86 assert_redirected_to :controller => :errors, :action => :bad_request
88 get history_path(:format => "html", :list => "1", :after => id)
89 assert_redirected_to :controller => :errors, :action => :bad_request
94 # This should display the last 20 changesets closed in a specific area
96 changesets = create_list(:changeset, 10, :num_changes => 1, :bbox => [5, 5, 5, 5])
97 other_changesets = create_list(:changeset, 10, :num_changes => 1, :bbox => [0, 0, 1, 1])
99 # First check they all show up without a bbox parameter
100 get history_path(:format => "html", :list => "1"), :xhr => true
101 assert_response :success
102 assert_template "index"
103 check_index_result(changesets + other_changesets)
105 # Then check with bbox parameter
106 get history_path(:format => "html", :bbox => "4.5,4.5,5.5,5.5")
107 assert_response :success
108 assert_template "history"
109 assert_template :layout => "map"
110 assert_select "h2", :text => "Changesets", :count => 1
111 assert_select "link[rel='alternate'][type='application/atom+xml']", :count => 1 do
112 assert_select "[href=?]", "http://www.example.com/history/feed?bbox=4.5%2C4.5%2C5.5%2C5.5"
115 get history_path(:format => "html", :bbox => "4.5,4.5,5.5,5.5", :list => "1"), :xhr => true
116 assert_response :success
117 assert_template "index"
119 check_index_result(changesets)
122 def test_index_bbox_invalid
123 get history_path(:format => "html", :bbox => "4.5,4.5,5.5", :list => "1"), :xhr => true
124 assert_redirected_to :controller => :errors, :action => :bad_request
126 get history_feed_path(:bbox => "4.5,4.5,5.5")
127 assert_response :bad_request
129 get history_feed_path(:bbox => "")
130 assert_response :bad_request
133 def test_index_bbox_across_antimeridian_with_changesets_close_to_antimeridian
134 west_of_antimeridian_changeset = create(:changeset, :num_changes => 1, :bbox => [176, 0, 178, 1])
135 east_of_antimeridian_changeset = create(:changeset, :num_changes => 1, :bbox => [-178, 0, -176, 1])
137 get history_path(:format => "html", :list => "1")
138 assert_response :success
139 check_index_result([east_of_antimeridian_changeset, west_of_antimeridian_changeset])
141 # negative longitudes
142 get history_path(:format => "html", :list => "1", :bbox => "-190,-10,-170,10")
143 assert_response :success
144 check_index_result([east_of_antimeridian_changeset, west_of_antimeridian_changeset])
146 get history_path(:format => "html", :list => "1", :bbox => "-183,-10,-177,10")
147 assert_response :success
148 check_index_result([east_of_antimeridian_changeset, west_of_antimeridian_changeset])
150 get history_path(:format => "html", :list => "1", :bbox => "-181,-10,-177,10")
151 assert_response :success
152 check_index_result([east_of_antimeridian_changeset])
154 get history_path(:format => "html", :list => "1", :bbox => "-183,-10,-179,10")
155 assert_response :success
156 check_index_result([west_of_antimeridian_changeset])
158 get history_path(:format => "html", :list => "1", :bbox => "-181,-10,-179,10")
159 assert_response :success
160 check_index_result([])
162 # positive longitudes
163 get history_path(:format => "html", :list => "1", :bbox => "170,-10,190,10")
164 assert_response :success
165 check_index_result([east_of_antimeridian_changeset, west_of_antimeridian_changeset])
167 get history_path(:format => "html", :list => "1", :bbox => "177,-10,183,10")
168 assert_response :success
169 check_index_result([east_of_antimeridian_changeset, west_of_antimeridian_changeset])
171 get history_path(:format => "html", :list => "1", :bbox => "177,-10,181,10")
172 assert_response :success
173 check_index_result([west_of_antimeridian_changeset])
175 get history_path(:format => "html", :list => "1", :bbox => "179,-10,183,10")
176 assert_response :success
177 check_index_result([east_of_antimeridian_changeset])
179 get history_path(:format => "html", :list => "1", :bbox => "179,-10,181,10")
180 assert_response :success
181 check_index_result([])
184 def test_index_bbox_across_antimeridian_with_changesets_around_globe
185 changeset1 = create(:changeset, :num_changes => 1, :bbox => [-150, 40, -140, 50])
186 changeset2 = create(:changeset, :num_changes => 1, :bbox => [-30, -30, -20, -20])
187 changeset3 = create(:changeset, :num_changes => 1, :bbox => [10, 60, 20, 70])
188 changeset4 = create(:changeset, :num_changes => 1, :bbox => [150, -60, 160, -50])
190 # no bbox, get all changesets
191 get history_path(:format => "html", :list => "1")
192 assert_response :success
193 check_index_result([changeset4, changeset3, changeset2, changeset1])
195 # large enough bbox within normal range
196 get history_path(:format => "html", :list => "1", :bbox => "-170,-80,170,80")
197 assert_response :success
198 check_index_result([changeset4, changeset3, changeset2, changeset1])
200 # bbox for [1,2] within normal range
201 get history_path(:format => "html", :list => "1", :bbox => "-160,-80,0,80")
202 assert_response :success
203 check_index_result([changeset2, changeset1])
205 # bbox for [1,4] containing antimeridian with negative lon
206 get history_path(:format => "html", :list => "1", :bbox => "-220,-80,-100,80")
207 assert_response :success
208 check_index_result([changeset4, changeset1])
210 # bbox for [1,4] containing antimeridian with positive lon
211 get history_path(:format => "html", :list => "1", :bbox => "100,-80,220,80")
212 assert_response :success
213 check_index_result([changeset4, changeset1])
215 # large enough bbox outside normal range
216 get history_path(:format => "html", :list => "1", :bbox => "-220,-80,220,80")
217 assert_response :success
218 check_index_result([changeset4, changeset3, changeset2, changeset1])
222 # Test that -180..180 longitudes don't result in empty bbox
223 def test_index_bbox_entire_world
224 changeset = create(:changeset, :num_changes => 1, :bbox => [30, 60, 31, 61])
226 get history_path(:format => "html", :list => "1", :bbox => "-180,-80,-180,80")
227 assert_response :success
228 check_index_result([])
230 get history_path(:format => "html", :list => "1", :bbox => "180,-80,180,80")
231 assert_response :success
232 check_index_result([])
234 get history_path(:format => "html", :list => "1", :bbox => "-180,-80,180,80")
235 assert_response :success
236 check_index_result([changeset])
240 # Test that -270..270 longitudes don't result in 90..-90 bbox
241 def test_index_bbox_larger_than_entire_world
242 changeset1 = create(:changeset, :num_changes => 1, :bbox => [30, 60, 31, 61])
243 changeset2 = create(:changeset, :num_changes => 1, :bbox => [130, 60, 131, 61])
245 get history_path(:format => "html", :list => "1", :bbox => "-90,-80,90,80")
246 assert_response :success
247 check_index_result([changeset1])
249 get history_path(:format => "html", :list => "1", :bbox => "-270,-80,270,80")
250 assert_response :success
251 check_index_result([changeset2, changeset1])
255 # Checks the display of the user changesets listing
258 create(:changeset, :user => user, :num_changes => 1)
259 create(:changeset, :closed, :user => user, :num_changes => 1)
262 get history_path(:format => "html", :display_name => user.display_name)
263 assert_response :success
264 assert_template "history"
265 assert_template :layout => "map"
266 assert_select "h2", :text => "Changesets by #{user.display_name}", :count => 1 do
267 assert_select "a[href=?]", user_path(user)
269 assert_select "link[rel='alternate'][type='application/atom+xml']", :count => 1 do
270 assert_select "[href=?]", "http://www.example.com/user/#{ERB::Util.url_encode(user.display_name)}/history/feed"
273 get history_path(:format => "html", :display_name => user.display_name, :list => "1"), :xhr => true
274 assert_response :success
275 assert_template "index"
277 check_index_result(user.changesets)
281 # Checks the display of the user changesets listing for a private user
282 def test_index_private_user
283 private_user = create(:user, :data_public => false)
284 create(:changeset, :user => private_user)
285 create(:changeset, :closed, :user => private_user)
287 get history_path(:format => "html", :display_name => private_user.display_name)
288 assert_response :success
289 assert_template "history"
291 get history_path(:format => "html", :display_name => private_user.display_name, :list => "1"), :xhr => true
292 assert_response :success
293 assert_template "index"
295 check_index_result([])
299 # Check the not found of the index user changesets
300 def test_index_user_not_found
301 get history_path(:format => "html", :display_name => "Some random user")
302 assert_response :not_found
303 assert_template "users/no_such_user"
305 get history_path(:format => "html", :display_name => "Some random user", :list => "1"), :xhr => true
306 assert_response :not_found
307 assert_template "users/no_such_user"
311 # Checks the display of the friends changesets listing
312 def test_index_friends
313 private_user = create(:user, :data_public => true)
314 follow = create(:follow, :follower => private_user)
315 changeset = create(:changeset, :user => follow.following, :num_changes => 1)
316 _changeset2 = create(:changeset, :user => create(:user), :num_changes => 1)
318 get friend_changesets_path
319 assert_redirected_to login_path(:referer => friend_changesets_path)
321 session_for(private_user)
323 get friend_changesets_path
324 assert_response :success
325 assert_template "history"
327 get friend_changesets_path(:list => "1"), :xhr => true
328 assert_response :success
329 assert_template "index"
331 check_index_result([changeset])
335 # Checks the display of the nearby user changesets listing
336 def test_index_nearby
337 private_user = create(:user, :data_public => false, :home_lat => 51.1, :home_lon => 1.0)
338 user = create(:user, :home_lat => 51.0, :home_lon => 1.0)
339 far_away_user = create(:user, :home_lat => 51.0, :home_lon => 130)
340 changeset = create(:changeset, :user => user, :num_changes => 1)
341 _changeset2 = create(:changeset, :user => far_away_user, :num_changes => 1)
343 get nearby_changesets_path
344 assert_redirected_to login_path(:referer => nearby_changesets_path)
346 session_for(private_user)
348 get nearby_changesets_path
349 assert_response :success
350 assert_template "history"
352 get nearby_changesets_path(:list => "1"), :xhr => true
353 assert_response :success
354 assert_template "index"
356 check_index_result([changeset])
360 # Check that we can't request later pages of the changesets index
361 def test_index_before_id
362 changeset1 = create(:changeset, :num_changes => 1)
363 changeset2 = create(:changeset, :num_changes => 1)
365 get history_path(:format => "html", :before => changeset2.id), :headers => { "Turbo-Frame" => "sidebar_content_frame" }
366 assert_response :success
367 assert_template "history"
368 assert_template :layout => "xhr"
369 assert_select "h2", :text => "Changesets", :count => 1
371 get history_path(:format => "html", :list => "1", :before => changeset2.id), :xhr => true
372 assert_response :success
373 assert_template "index"
375 check_index_result [changeset1]
378 def test_index_after_id
379 changeset1 = create(:changeset, :num_changes => 1)
380 changeset2 = create(:changeset, :num_changes => 1)
382 get history_path(:format => "html", :after => changeset1.id), :headers => { "Turbo-Frame" => "sidebar_content_frame" }
383 assert_response :success
384 assert_template "history"
385 assert_template :layout => "xhr"
386 assert_select "h2", :text => "Changesets", :count => 1
388 get history_path(:format => "html", :list => "1", :after => changeset1.id), :xhr => true
389 assert_response :success
390 assert_template "index"
392 check_index_result [changeset2]
396 # Check that a list with a next page link works
398 create_list(:changeset, 50)
400 get history_path(:format => "html")
401 assert_response :success
403 get history_path(:format => "html"), :xhr => true
404 assert_response :success
408 changeset = create(:changeset)
409 create(:changeset_tag, :changeset => changeset, :k => "comment", :v => "tested-changeset-comment")
410 commenting_user = create(:user)
411 changeset_comment = create(:changeset_comment, :changeset => changeset, :author => commenting_user, :body => "Unwanted comment")
413 sidebar_browse_check :changeset_path, changeset.id, "changesets/show"
414 assert_dom "h2", :text => "Changeset: #{changeset.id}"
415 assert_dom "p", :text => "tested-changeset-comment"
416 assert_dom "article#c#{changeset_comment.id}" do
417 assert_dom "> small", :text => /^Comment from #{commenting_user.display_name}/
418 assert_dom "a[href='#{user_path(commenting_user)}']"
422 def test_show_linkified_comment
423 changeset = create(:changeset)
424 create(:changeset_tag, :changeset => changeset, :k => "comment", :v => "Check out http://example.com/ & special <characters>!")
425 sidebar_browse_check :changeset_path, changeset.id, "changesets/show"
426 assert_dom "p", :text => %r{Check out http://example.com/ & special <characters>!} do
427 assert_dom "a[href='http://example.com/']", :text => "http://example.com/"
431 def test_show_closed_changeset
432 changeset = create(:changeset, :closed)
434 sidebar_browse_check :changeset_path, changeset.id, "changesets/show"
437 def test_show_private_changeset
439 changeset = create(:changeset, :user => create(:user, :data_public => false))
440 create(:changeset, :user => user)
442 sidebar_browse_check :changeset_path, changeset.id, "changesets/show"
445 def test_show_element_links
446 changeset = create(:changeset)
447 node = create(:node, :with_history, :changeset => changeset)
448 way = create(:way, :with_history, :changeset => changeset)
449 relation = create(:relation, :with_history, :changeset => changeset)
451 sidebar_browse_check :changeset_path, changeset.id, "changesets/show"
452 assert_dom "a[href='#{node_path node}']", :count => 1
453 assert_dom "a[href='#{old_node_path node, 1}']", :count => 1
454 assert_dom "a[href='#{way_path way}']", :count => 1
455 assert_dom "a[href='#{old_way_path way, 1}']", :count => 1
456 assert_dom "a[href='#{relation_path relation}']", :count => 1
457 assert_dom "a[href='#{old_relation_path relation, 1}']", :count => 1
460 def test_show_paginated_element_links
462 changeset = create(:changeset)
463 nodes = create_list(:node, page_size + 1, :with_history, :changeset => changeset)
464 ways = create_list(:way, page_size + 1, :with_history, :changeset => changeset)
465 relations = create_list(:relation, page_size + 1, :with_history, :changeset => changeset)
467 sidebar_browse_check :changeset_path, changeset.id, "changesets/show"
468 page_size.times do |i|
469 assert_dom "a[href='#{node_path nodes[i]}']", :count => 1
470 assert_dom "a[href='#{old_node_path nodes[i], 1}']", :count => 1
471 assert_dom "a[href='#{way_path ways[i]}']", :count => 1
472 assert_dom "a[href='#{old_way_path ways[i], 1}']", :count => 1
473 assert_dom "a[href='#{relation_path relations[i]}']", :count => 1
474 assert_dom "a[href='#{old_relation_path relations[i], 1}']", :count => 1
478 def test_show_adjacent_changesets
480 changesets = create_list(:changeset, 3, :user => user, :num_changes => 1)
482 sidebar_browse_check :changeset_path, changesets[1].id, "changesets/show"
483 assert_dom "a[href='#{changeset_path changesets[0]}']", :count => 1
484 assert_dom "a[href='#{changeset_path changesets[2]}']", :count => 1
487 def test_show_adjacent_nonempty_changesets
489 changeset1 = create(:changeset, :user => user, :num_changes => 1)
490 create(:changeset, :user => user, :num_changes => 0)
491 changeset3 = create(:changeset, :user => user, :num_changes => 1)
492 create(:changeset, :user => user, :num_changes => 0)
493 changeset5 = create(:changeset, :user => user, :num_changes => 1)
495 sidebar_browse_check :changeset_path, changeset3.id, "changesets/show"
496 assert_dom "a[href='#{changeset_path changeset1}']", :count => 1
497 assert_dom "a[href='#{changeset_path changeset5}']", :count => 1
501 # This should display the last 20 non-empty changesets
503 changeset = create(:changeset, :num_changes => 1)
504 create(:changeset_tag, :changeset => changeset)
505 create(:changeset_tag, :changeset => changeset, :k => "website", :v => "http://example.com/")
506 closed_changeset = create(:changeset, :closed, :num_changes => 1)
507 create(:changeset_tag, :changeset => closed_changeset, :k => "website", :v => "https://osm.org/")
508 _empty_changeset = create(:changeset, :num_changes => 0)
510 get history_feed_path(:format => :atom)
511 assert_response :success
512 assert_template "index"
513 assert_equal "application/atom+xml", response.media_type
515 check_feed_result([closed_changeset, changeset])
519 # This should correctly escape XML special characters in the comment
520 def test_feed_with_comment_tag
521 changeset = create(:changeset, :num_changes => 1)
522 create(:changeset_tag, :changeset => changeset, :k => "comment", :v => "tested<changeset>comment")
524 get history_feed_path(:format => :atom)
525 assert_response :success
526 assert_template "index"
527 assert_equal "application/atom+xml", response.media_type
529 check_feed_result([changeset])
533 # This should display the last 20 changesets closed in a specific area
535 changeset = create(:changeset, :num_changes => 1, :bbox => [5, 5, 5, 5])
536 create(:changeset_tag, :changeset => changeset)
537 create(:changeset_tag, :changeset => changeset, :k => "website", :v => "http://example.com/")
538 closed_changeset = create(:changeset, :closed, :num_changes => 1, :bbox => [5, 5, 5, 5])
539 _elsewhere_changeset = create(:changeset, :num_changes => 1, :bbox => [-5, -5, -5, -5])
540 _empty_changeset = create(:changeset, :num_changes => 0, :bbox => [5, 5, 5, 5])
542 get history_feed_path(:format => :atom, :bbox => "4.5,4.5,5.5,5.5")
543 assert_response :success
544 assert_template "index"
545 assert_equal "application/atom+xml", response.media_type
547 check_feed_result([closed_changeset, changeset])
551 # Checks the display of the user changesets feed
554 changesets = create_list(:changeset, 3, :user => user, :num_changes => 4)
555 create(:changeset_tag, :changeset => changesets[1])
556 create(:changeset_tag, :changeset => changesets[1], :k => "website", :v => "http://example.com/")
557 _other_changeset = create(:changeset)
559 get history_feed_path(:format => :atom, :display_name => user.display_name)
561 assert_response :success
562 assert_template "index"
563 assert_equal "application/atom+xml", response.media_type
565 check_feed_result(changesets.reverse)
569 # Check the not found of the user changesets feed
570 def test_feed_user_not_found
571 get history_feed_path(:format => "atom", :display_name => "Some random user")
572 assert_response :not_found
576 # Check that we can't request later pages of the changesets feed
578 get history_feed_path(:format => "atom", :before => 100)
579 assert_redirected_to :action => :feed
583 get history_feed_path(:format => "atom", :after => 100)
584 assert_redirected_to :action => :feed
590 # check the result of a index
591 def check_index_result(changesets)
593 assert_select "ol", :count => 0
595 assert_select "ol", :count => 1 do
596 assert_select "li", :count => changesets.size
598 changesets.each do |changeset|
599 assert_select "li#changeset_#{changeset.id}", :count => 1
606 # check the result of a feed
607 def check_feed_result(changesets)
608 assert_operator changesets.size, :<=, 20
611 assert_select "feed", :count => 0
613 assert_select "feed", :count => 1 do
614 assert_select "> title", :count => 1, :text => /^Changesets/
615 assert_select "> entry", :count => changesets.size do |entries|
616 entries.zip(changesets) do |entry, changeset|
617 assert_select entry, "> id", :text => changeset_url(:id => changeset.id)
619 changeset_comment = changeset.tags["comment"]
621 assert_select entry, "> title", :count => 1, :text => "Changeset #{changeset.id} - #{changeset_comment}"
623 assert_select entry, "> title", :count => 1, :text => "Changeset #{changeset.id}"
626 assert_select entry, "> content > xhtml|div > xhtml|table" do
627 if changeset.tags.empty?
628 assert_select "> xhtml|tr > xhtml|td > xhtml|table", :count => 0
630 assert_select "> xhtml|tr > xhtml|td > xhtml|table", :count => 1 do
631 changeset.tags.each_key do |key|
632 assert_select "> xhtml|tr > xhtml|td", :text => /^#{key} = /