2 require "changeset_controller"
4 class ChangesetControllerTest < ActionController::TestCase
8 # test all routes which lead to this controller
11 { :path => "/api/0.6/changeset/create", :method => :put },
12 { :controller => "changeset", :action => "create" }
15 { :path => "/api/0.6/changeset/1/upload", :method => :post },
16 { :controller => "changeset", :action => "upload", :id => "1" }
19 { :path => "/api/0.6/changeset/1/download", :method => :get },
20 { :controller => "changeset", :action => "download", :id => "1" }
23 { :path => "/api/0.6/changeset/1/expand_bbox", :method => :post },
24 { :controller => "changeset", :action => "expand_bbox", :id => "1" }
27 { :path => "/api/0.6/changeset/1", :method => :get },
28 { :controller => "changeset", :action => "read", :id => "1" }
31 { :path => "/api/0.6/changeset/1/subscribe", :method => :post },
32 { :controller => "changeset", :action => "subscribe", :id => "1" }
35 { :path => "/api/0.6/changeset/1/unsubscribe", :method => :post },
36 { :controller => "changeset", :action => "unsubscribe", :id => "1" }
39 { :path => "/api/0.6/changeset/1", :method => :put },
40 { :controller => "changeset", :action => "update", :id => "1" }
43 { :path => "/api/0.6/changeset/1/close", :method => :put },
44 { :controller => "changeset", :action => "close", :id => "1" }
47 { :path => "/api/0.6/changeset/1/comment", :method => :post },
48 { :controller => "changeset", :action => "comment", :id => "1" }
51 { :path => "/api/0.6/changeset/comment/1/hide", :method => :post },
52 { :controller => "changeset", :action => "hide_comment", :id => "1" }
55 { :path => "/api/0.6/changeset/comment/1/unhide", :method => :post },
56 { :controller => "changeset", :action => "unhide_comment", :id => "1" }
59 { :path => "/api/0.6/changesets", :method => :get },
60 { :controller => "changeset", :action => "query" }
63 { :path => "/changeset/1/comments/feed", :method => :get },
64 { :controller => "changeset", :action => "comments_feed", :id => "1", :format => "rss" }
67 { :path => "/user/name/history", :method => :get },
68 { :controller => "changeset", :action => "list", :display_name => "name" }
71 { :path => "/user/name/history/feed", :method => :get },
72 { :controller => "changeset", :action => "feed", :display_name => "name", :format => :atom }
75 { :path => "/history/friends", :method => :get },
76 { :controller => "changeset", :action => "list", :friends => true, :format => :html }
79 { :path => "/history/nearby", :method => :get },
80 { :controller => "changeset", :action => "list", :nearby => true, :format => :html }
83 { :path => "/history", :method => :get },
84 { :controller => "changeset", :action => "list" }
87 { :path => "/history/feed", :method => :get },
88 { :controller => "changeset", :action => "feed", :format => :atom }
91 { :path => "/history/comments/feed", :method => :get },
92 { :controller => "changeset", :action => "comments_feed", :format => "rss" }
96 # -----------------------
97 # Test simple changeset creation
98 # -----------------------
101 basic_authorization create(:user, :data_public => false).email, "test"
102 # Create the first user's changeset
103 content "<osm><changeset>" +
104 "<tag k='created_by' v='osm test suite checking changesets'/>" +
107 assert_require_public_data
109 basic_authorization create(:user).email, "test"
110 # Create the first user's changeset
111 content "<osm><changeset>" +
112 "<tag k='created_by' v='osm test suite checking changesets'/>" +
116 assert_response :success, "Creation of changeset did not return sucess status"
117 newid = @response.body.to_i
119 # check end time, should be an hour ahead of creation time
120 cs = Changeset.find(newid)
121 duration = cs.closed_at - cs.created_at
122 # the difference can either be a rational, or a floating point number
123 # of seconds, depending on the code path taken :-(
124 if duration.class == Rational
125 assert_equal Rational(1, 24), duration, "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"
127 # must be number of seconds...
128 assert_equal 3600, duration.round, "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"
131 # checks if uploader was subscribed
132 assert_equal 1, cs.subscribers.length
135 def test_create_invalid
136 basic_authorization create(:user, :data_public => false).email, "test"
137 content "<osm><changeset></osm>"
139 assert_require_public_data
141 ## Try the public user
142 basic_authorization create(:user).email, "test"
143 content "<osm><changeset></osm>"
145 assert_response :bad_request, "creating a invalid changeset should fail"
148 def test_create_invalid_no_content
149 ## First check with no auth
151 assert_response :unauthorized, "shouldn't be able to create a changeset with no auth"
153 ## Now try to with a non-public user
154 basic_authorization create(:user, :data_public => false).email, "test"
156 assert_require_public_data
158 ## Try an inactive user
159 basic_authorization create(:user, :pending).email, "test"
163 ## Now try to use a normal user
164 basic_authorization create(:user).email, "test"
166 assert_response :bad_request, "creating a changeset with no content should fail"
169 def test_create_wrong_method
170 basic_authorization create(:user).email, "test"
172 assert_response :method_not_allowed
174 assert_response :method_not_allowed
178 # check that the changeset can be read and returns the correct
179 # document structure.
181 changeset_id = create(:changeset).id
183 get :read, :id => changeset_id
184 assert_response :success, "cannot get first changeset"
186 assert_select "osm[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
187 assert_select "osm>changeset[id='#{changeset_id}']", 1
188 assert_select "osm>changeset>discussion", 0
190 get :read, :id => changeset_id, :include_discussion => true
191 assert_response :success, "cannot get first changeset with comments"
193 assert_select "osm[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
194 assert_select "osm>changeset[id='#{changeset_id}']", 1
195 assert_select "osm>changeset>discussion", 1
196 assert_select "osm>changeset>discussion>comment", 0
198 changeset_id = create(:changeset, :closed).id
199 create_list(:changeset_comment, 3, :changeset_id => changeset_id)
201 get :read, :id => changeset_id, :include_discussion => true
202 assert_response :success, "cannot get closed changeset with comments"
204 assert_select "osm[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
205 assert_select "osm>changeset[id='#{changeset_id}']", 1
206 assert_select "osm>changeset>discussion", 1
207 assert_select "osm>changeset>discussion>comment", 3
211 # check that a changeset that doesn't exist returns an appropriate message
212 def test_read_not_found
213 [0, -32, 233455644, "afg", "213"].each do |id|
216 assert_response :not_found, "should get a not found"
217 rescue ActionController::UrlGenerationError => ex
218 assert_match /No route matches/, ex.to_s
224 # test that the user who opened a change can close it
226 private_user = create(:user, :data_public => false)
227 private_changeset = create(:changeset, :user => private_user)
229 changeset = create(:changeset, :user => user)
231 ## Try without authentication
232 put :close, :id => changeset.id
233 assert_response :unauthorized
235 ## Try using the non-public user
236 basic_authorization private_user.email, "test"
237 put :close, :id => private_changeset.id
238 assert_require_public_data
240 ## The try with the public user
241 basic_authorization user.email, "test"
244 put :close, :id => cs_id
245 assert_response :success
247 # test that it really is closed now
248 cs = Changeset.find(cs_id)
250 "changeset should be closed now (#{cs.closed_at} > #{Time.now.getutc}.")
254 # test that a different user can't close another user's changeset
255 def test_close_invalid
257 changeset = create(:changeset)
259 basic_authorization user.email, "test"
261 put :close, :id => changeset.id
262 assert_response :conflict
263 assert_equal "The user doesn't own that changeset", @response.body
267 # test that you can't close using another method
268 def test_close_method_invalid
270 changeset = create(:changeset, :user => user)
272 basic_authorization user.email, "test"
274 get :close, :id => changeset.id
275 assert_response :method_not_allowed
277 post :close, :id => changeset.id
278 assert_response :method_not_allowed
282 # check that you can't close a changeset that isn't found
283 def test_close_not_found
284 cs_ids = [0, -132, "123"]
286 # First try to do it with no auth
289 put :close, :id => id
290 assert_response :unauthorized, "Shouldn't be able close the non-existant changeset #{id}, when not authorized"
291 rescue ActionController::UrlGenerationError => ex
292 assert_match /No route matches/, ex.to_s
297 basic_authorization create(:user).email, "test"
300 put :close, :id => id
301 assert_response :not_found, "The changeset #{id} doesn't exist, so can't be closed"
302 rescue ActionController::UrlGenerationError => ex
303 assert_match /No route matches/, ex.to_s
309 # upload something simple, but valid and check that it can
311 # Also try without auth and another user.
312 def test_upload_simple_valid
313 private_user = create(:user, :data_public => false)
314 private_changeset = create(:changeset, :user => private_user)
316 changeset = create(:changeset, :user => user)
320 relation = create(:relation)
321 other_relation = create(:relation)
322 # create some tags, since we test that they are removed later
323 create(:node_tag, :node => node)
324 create(:way_tag, :way => way)
325 create(:relation_tag, :relation => relation)
328 changeset_id = changeset.id
330 # simple diff to change a node, way and relation by removing
335 <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
336 <way id='#{way.id}' changeset='#{changeset_id}' version='1'>
337 <nd ref='#{node.id}'/>
341 <relation id='#{relation.id}' changeset='#{changeset_id}' version='1'>
342 <member type='way' role='some' ref='#{way.id}'/>
343 <member type='node' role='some' ref='#{node.id}'/>
344 <member type='relation' role='some' ref='#{other_relation.id}'/>
352 post :upload, :id => changeset_id
353 assert_response :unauthorized,
354 "shouldn't be able to upload a simple valid diff to changeset: #{@response.body}"
356 ## Now try with a private user
357 basic_authorization private_user.email, "test"
358 changeset_id = private_changeset.id
360 # simple diff to change a node, way and relation by removing
365 <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
366 <way id='#{way.id}' changeset='#{changeset_id}' version='1'>
367 <nd ref='#{node.id}'/>
371 <relation id='#{relation.id}' changeset='#{changeset_id}' version='1'>
372 <member type='way' role='some' ref='#{way.id}'/>
373 <member type='node' role='some' ref='#{node.id}'/>
374 <member type='relation' role='some' ref='#{other_relation.id}'/>
382 post :upload, :id => changeset_id
383 assert_response :forbidden,
384 "can't upload a simple valid diff to changeset: #{@response.body}"
386 ## Now try with the public user
387 basic_authorization user.email, "test"
388 changeset_id = changeset.id
390 # simple diff to change a node, way and relation by removing
395 <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
396 <way id='#{way.id}' changeset='#{changeset_id}' version='1'>
397 <nd ref='#{node.id}'/>
401 <relation id='#{relation.id}' changeset='#{changeset_id}' version='1'>
402 <member type='way' role='some' ref='#{way.id}'/>
403 <member type='node' role='some' ref='#{node.id}'/>
404 <member type='relation' role='some' ref='#{other_relation.id}'/>
412 post :upload, :id => changeset_id
413 assert_response :success,
414 "can't upload a simple valid diff to changeset: #{@response.body}"
416 # check that the changes made it into the database
417 assert_equal 0, Node.find(node.id).tags.size, "node #{node.id} should now have no tags"
418 assert_equal 0, Way.find(way.id).tags.size, "way #{way.id} should now have no tags"
419 assert_equal 0, Relation.find(relation.id).tags.size, "relation #{relation.id} should now have no tags"
423 # upload something which creates new objects using placeholders
424 def test_upload_create_valid
426 changeset = create(:changeset, :user => user)
428 basic_authorization user.email, "test"
430 # simple diff to create a node way and relation using placeholders
434 <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
435 <tag k='foo' v='bar'/>
436 <tag k='baz' v='bat'/>
438 <way id='-1' changeset='#{changeset.id}'>
443 <relation id='-1' changeset='#{changeset.id}'>
444 <member type='way' role='some' ref='3'/>
445 <member type='node' role='some' ref='5'/>
446 <member type='relation' role='some' ref='3'/>
454 post :upload, :id => changeset.id
455 assert_response :success,
456 "can't upload a simple valid creation to changeset: #{@response.body}"
458 # check the returned payload
459 assert_select "diffResult[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
460 assert_select "diffResult>node", 1
461 assert_select "diffResult>way", 1
462 assert_select "diffResult>relation", 1
464 # inspect the response to find out what the new element IDs are
465 doc = XML::Parser.string(@response.body).parse
466 new_node_id = doc.find("//diffResult/node").first["new_id"].to_i
467 new_way_id = doc.find("//diffResult/way").first["new_id"].to_i
468 new_rel_id = doc.find("//diffResult/relation").first["new_id"].to_i
470 # check the old IDs are all present and negative one
471 assert_equal -1, doc.find("//diffResult/node").first["old_id"].to_i
472 assert_equal -1, doc.find("//diffResult/way").first["old_id"].to_i
473 assert_equal -1, doc.find("//diffResult/relation").first["old_id"].to_i
475 # check the versions are present and equal one
476 assert_equal 1, doc.find("//diffResult/node").first["new_version"].to_i
477 assert_equal 1, doc.find("//diffResult/way").first["new_version"].to_i
478 assert_equal 1, doc.find("//diffResult/relation").first["new_version"].to_i
480 # check that the changes made it into the database
481 assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
482 assert_equal 0, Way.find(new_way_id).tags.size, "new way should have no tags"
483 assert_equal 0, Relation.find(new_rel_id).tags.size, "new relation should have no tags"
487 # test a complex delete where we delete elements which rely on eachother
488 # in the same transaction.
489 def test_upload_delete
490 changeset = create(:changeset)
491 super_relation = create(:relation)
492 used_relation = create(:relation)
493 used_way = create(:way)
494 used_node = create(:node)
495 create(:relation_member, :relation => super_relation, :member => used_relation)
496 create(:relation_member, :relation => super_relation, :member => used_way)
497 create(:relation_member, :relation => super_relation, :member => used_node)
499 basic_authorization changeset.user.display_name, "test"
501 diff = XML::Document.new
502 diff.root = XML::Node.new "osmChange"
503 delete = XML::Node.new "delete"
505 delete << super_relation.to_xml_node
506 delete << used_relation.to_xml_node
507 delete << used_way.to_xml_node
508 delete << used_node.to_xml_node
510 # update the changeset to one that this user owns
511 %w(node way relation).each do |type|
512 delete.find("//osmChange/delete/#{type}").each do |n|
513 n["changeset"] = changeset.id.to_s
519 post :upload, :id => changeset.id
520 assert_response :success,
521 "can't upload a deletion diff to changeset: #{@response.body}"
523 # check the response is well-formed
524 assert_select "diffResult>node", 1
525 assert_select "diffResult>way", 1
526 assert_select "diffResult>relation", 2
528 # check that everything was deleted
529 assert_equal false, Node.find(used_node.id).visible
530 assert_equal false, Way.find(used_way.id).visible
531 assert_equal false, Relation.find(super_relation.id).visible
532 assert_equal false, Relation.find(used_relation.id).visible
536 # test uploading a delete with no lat/lon, as they are optional in
537 # the osmChange spec.
538 def test_upload_nolatlon_delete
540 changeset = create(:changeset)
542 basic_authorization changeset.user.display_name, "test"
543 diff = "<osmChange><delete><node id='#{node.id}' version='#{node.version}' changeset='#{changeset.id}'/></delete></osmChange>"
547 post :upload, :id => changeset.id
548 assert_response :success,
549 "can't upload a deletion diff to changeset: #{@response.body}"
551 # check the response is well-formed
552 assert_select "diffResult>node", 1
554 # check that everything was deleted
555 assert_equal false, Node.find(node.id).visible
558 def test_repeated_changeset_create
560 basic_authorization create(:user).email, "test"
562 # create a temporary changeset
563 content "<osm><changeset>" +
564 "<tag k='created_by' v='osm test suite checking changesets'/>" +
566 assert_difference "Changeset.count", 1 do
569 assert_response :success
573 def test_upload_large_changeset
574 basic_authorization create(:user).email, "test"
577 content "<osm><changeset/></osm>"
579 assert_response :success, "Should be able to create a changeset: #{@response.body}"
580 changeset_id = @response.body.to_i
582 # upload some widely-spaced nodes, spiralling positive and negative to cause
583 # largest bbox over-expansion possible.
587 <node id='-1' lon='-20' lat='-10' changeset='#{changeset_id}'/>
588 <node id='-10' lon='20' lat='10' changeset='#{changeset_id}'/>
589 <node id='-2' lon='-40' lat='-20' changeset='#{changeset_id}'/>
590 <node id='-11' lon='40' lat='20' changeset='#{changeset_id}'/>
591 <node id='-3' lon='-60' lat='-30' changeset='#{changeset_id}'/>
592 <node id='-12' lon='60' lat='30' changeset='#{changeset_id}'/>
593 <node id='-4' lon='-80' lat='-40' changeset='#{changeset_id}'/>
594 <node id='-13' lon='80' lat='40' changeset='#{changeset_id}'/>
595 <node id='-5' lon='-100' lat='-50' changeset='#{changeset_id}'/>
596 <node id='-14' lon='100' lat='50' changeset='#{changeset_id}'/>
597 <node id='-6' lon='-120' lat='-60' changeset='#{changeset_id}'/>
598 <node id='-15' lon='120' lat='60' changeset='#{changeset_id}'/>
599 <node id='-7' lon='-140' lat='-70' changeset='#{changeset_id}'/>
600 <node id='-16' lon='140' lat='70' changeset='#{changeset_id}'/>
601 <node id='-8' lon='-160' lat='-80' changeset='#{changeset_id}'/>
602 <node id='-17' lon='160' lat='80' changeset='#{changeset_id}'/>
603 <node id='-9' lon='-179.9' lat='-89.9' changeset='#{changeset_id}'/>
604 <node id='-18' lon='179.9' lat='89.9' changeset='#{changeset_id}'/>
609 # upload it, which used to cause an error like "PGError: ERROR:
610 # integer out of range" (bug #2152). but shouldn't any more.
612 post :upload, :id => changeset_id
613 assert_response :success,
614 "can't upload a spatially-large diff to changeset: #{@response.body}"
616 # check that the changeset bbox is within bounds
617 cs = Changeset.find(changeset_id)
618 assert cs.min_lon >= -180 * GeoRecord::SCALE, "Minimum longitude (#{cs.min_lon / GeoRecord::SCALE}) should be >= -180 to be valid."
619 assert cs.max_lon <= 180 * GeoRecord::SCALE, "Maximum longitude (#{cs.max_lon / GeoRecord::SCALE}) should be <= 180 to be valid."
620 assert cs.min_lat >= -90 * GeoRecord::SCALE, "Minimum latitude (#{cs.min_lat / GeoRecord::SCALE}) should be >= -90 to be valid."
621 assert cs.max_lat >= 90 * GeoRecord::SCALE, "Maximum latitude (#{cs.max_lat / GeoRecord::SCALE}) should be <= 90 to be valid."
625 # test that deleting stuff in a transaction doesn't bypass the checks
626 # to ensure that used elements are not deleted.
627 def test_upload_delete_invalid
628 changeset = create(:changeset)
629 relation = create(:relation)
630 other_relation = create(:relation)
631 used_way = create(:way)
632 used_node = create(:node)
633 create(:relation_member, :relation => relation, :member => used_way)
634 create(:relation_member, :relation => relation, :member => used_node)
636 basic_authorization changeset.user.email, "test"
638 diff = XML::Document.new
639 diff.root = XML::Node.new "osmChange"
640 delete = XML::Node.new "delete"
642 delete << other_relation.to_xml_node
643 delete << used_way.to_xml_node
644 delete << used_node.to_xml_node
646 # update the changeset to one that this user owns
647 %w(node way relation).each do |type|
648 delete.find("//osmChange/delete/#{type}").each do |n|
649 n["changeset"] = changeset.id.to_s
655 post :upload, :id => changeset.id
656 assert_response :precondition_failed,
657 "shouldn't be able to upload a invalid deletion diff: #{@response.body}"
658 assert_equal "Precondition failed: Way #{used_way.id} is still used by relations #{relation.id}.", @response.body
660 # check that nothing was, in fact, deleted
661 assert_equal true, Node.find(used_node.id).visible
662 assert_equal true, Way.find(used_way.id).visible
663 assert_equal true, Relation.find(relation.id).visible
664 assert_equal true, Relation.find(other_relation.id).visible
668 # test that a conditional delete of an in use object works.
669 def test_upload_delete_if_unused
670 changeset = create(:changeset)
671 super_relation = create(:relation)
672 used_relation = create(:relation)
673 used_way = create(:way)
674 used_node = create(:node)
675 create(:relation_member, :relation => super_relation, :member => used_relation)
676 create(:relation_member, :relation => super_relation, :member => used_way)
677 create(:relation_member, :relation => super_relation, :member => used_node)
679 basic_authorization changeset.user.email, "test"
681 diff = XML::Document.new
682 diff.root = XML::Node.new "osmChange"
683 delete = XML::Node.new "delete"
685 delete["if-unused"] = ""
686 delete << used_relation.to_xml_node
687 delete << used_way.to_xml_node
688 delete << used_node.to_xml_node
690 # update the changeset to one that this user owns
691 %w(node way relation).each do |type|
692 delete.find("//osmChange/delete/#{type}").each do |n|
693 n["changeset"] = changeset.id.to_s
699 post :upload, :id => changeset.id
700 assert_response :success,
701 "can't do a conditional delete of in use objects: #{@response.body}"
703 # check the returned payload
704 assert_select "diffResult[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
705 assert_select "diffResult>node", 1
706 assert_select "diffResult>way", 1
707 assert_select "diffResult>relation", 1
710 doc = XML::Parser.string(@response.body).parse
712 # check the old IDs are all present and what we expect
713 assert_equal used_node.id, doc.find("//diffResult/node").first["old_id"].to_i
714 assert_equal used_way.id, doc.find("//diffResult/way").first["old_id"].to_i
715 assert_equal used_relation.id, doc.find("//diffResult/relation").first["old_id"].to_i
717 # check the new IDs are all present and unchanged
718 assert_equal used_node.id, doc.find("//diffResult/node").first["new_id"].to_i
719 assert_equal used_way.id, doc.find("//diffResult/way").first["new_id"].to_i
720 assert_equal used_relation.id, doc.find("//diffResult/relation").first["new_id"].to_i
722 # check the new versions are all present and unchanged
723 assert_equal used_node.version, doc.find("//diffResult/node").first["new_version"].to_i
724 assert_equal used_way.version, doc.find("//diffResult/way").first["new_version"].to_i
725 assert_equal used_relation.version, doc.find("//diffResult/relation").first["new_version"].to_i
727 # check that nothing was, in fact, deleted
728 assert_equal true, Node.find(used_node.id).visible
729 assert_equal true, Way.find(used_way.id).visible
730 assert_equal true, Relation.find(used_relation.id).visible
734 # upload an element with a really long tag value
735 def test_upload_invalid_too_long_tag
736 changeset = create(:changeset)
738 basic_authorization changeset.user.email, "test"
740 # simple diff to create a node way and relation using placeholders
744 <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
745 <tag k='foo' v='#{'x' * 256}'/>
753 post :upload, :id => changeset.id
754 assert_response :bad_request,
755 "shoudln't be able to upload too long a tag to changeset: #{@response.body}"
759 # upload something which creates new objects and inserts them into
760 # existing containers using placeholders.
761 def test_upload_complex
764 relation = create(:relation)
765 create(:way_node, :way => way, :node => node)
767 changeset = create(:changeset)
769 basic_authorization changeset.user.email, "test"
771 # simple diff to create a node way and relation using placeholders
775 <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
776 <tag k='foo' v='bar'/>
777 <tag k='baz' v='bat'/>
781 <way id='#{way.id}' changeset='#{changeset.id}' version='1'>
783 <nd ref='#{node.id}'/>
785 <relation id='#{relation.id}' changeset='#{changeset.id}' version='1'>
786 <member type='way' role='some' ref='#{way.id}'/>
787 <member type='node' role='some' ref='-1'/>
788 <member type='relation' role='some' ref='#{relation.id}'/>
796 post :upload, :id => changeset.id
797 assert_response :success,
798 "can't upload a complex diff to changeset: #{@response.body}"
800 # check the returned payload
801 assert_select "diffResult[version='#{API_VERSION}'][generator='#{GENERATOR}']", 1
802 assert_select "diffResult>node", 1
803 assert_select "diffResult>way", 1
804 assert_select "diffResult>relation", 1
806 # inspect the response to find out what the new element IDs are
807 doc = XML::Parser.string(@response.body).parse
808 new_node_id = doc.find("//diffResult/node").first["new_id"].to_i
810 # check that the changes made it into the database
811 assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
812 assert_equal [new_node_id, node.id], Way.find(way.id).nds, "way nodes should match"
813 Relation.find(relation.id).members.each do |type, id, _role|
815 assert_equal new_node_id, id, "relation should contain new node"
821 # create a diff which references several changesets, which should cause
822 # a rollback and none of the diff gets committed
823 def test_upload_invalid_changesets
824 basic_authorization changesets(:public_user_first_change).user.email, "test"
825 cs_id = changesets(:public_user_first_change).id
827 # simple diff to create a node way and relation using placeholders
831 <node id='1' lon='0' lat='0' changeset='#{cs_id}' version='1'/>
832 <way id='1' changeset='#{cs_id}' version='1'>
837 <relation id='1' changeset='#{cs_id}' version='1'>
838 <member type='way' role='some' ref='3'/>
839 <member type='node' role='some' ref='5'/>
840 <member type='relation' role='some' ref='3'/>
844 <node id='-1' lon='0' lat='0' changeset='4'>
845 <tag k='foo' v='bar'/>
846 <tag k='baz' v='bat'/>
851 # cache the objects before uploading them
852 node = current_nodes(:visible_node)
853 way = current_ways(:visible_way)
854 rel = current_relations(:visible_relation)
858 post :upload, :id => cs_id
859 assert_response :conflict,
860 "uploading a diff with multiple changsets should have failed"
862 # check that objects are unmodified
863 assert_nodes_are_equal(node, Node.find(1))
864 assert_ways_are_equal(way, Way.find(1))
865 assert_relations_are_equal(rel, Relation.find(1))
869 # upload multiple versions of the same element in the same diff.
870 def test_upload_multiple_valid
871 basic_authorization changesets(:public_user_first_change).user.email, "test"
872 cs_id = changesets(:public_user_first_change).id
874 # change the location of a node multiple times, each time referencing
875 # the last version. doesn't this depend on version numbers being
880 <node id='1' lon='0' lat='0' changeset='#{cs_id}' version='1'/>
881 <node id='1' lon='1' lat='0' changeset='#{cs_id}' version='2'/>
882 <node id='1' lon='1' lat='1' changeset='#{cs_id}' version='3'/>
883 <node id='1' lon='1' lat='2' changeset='#{cs_id}' version='4'/>
884 <node id='1' lon='2' lat='2' changeset='#{cs_id}' version='5'/>
885 <node id='1' lon='3' lat='2' changeset='#{cs_id}' version='6'/>
886 <node id='1' lon='3' lat='3' changeset='#{cs_id}' version='7'/>
887 <node id='1' lon='9' lat='9' changeset='#{cs_id}' version='8'/>
894 post :upload, :id => cs_id
895 assert_response :success,
896 "can't upload multiple versions of an element in a diff: #{@response.body}"
898 # check the response is well-formed. its counter-intuitive, but the
899 # API will return multiple elements with the same ID and different
900 # version numbers for each change we made.
901 assert_select "diffResult>node", 8
905 # upload multiple versions of the same element in the same diff, but
906 # keep the version numbers the same.
907 def test_upload_multiple_duplicate
908 basic_authorization changesets(:public_user_first_change).user.email, "test"
909 cs_id = changesets(:public_user_first_change).id
914 <node id='1' lon='0' lat='0' changeset='#{cs_id}' version='1'/>
915 <node id='1' lon='1' lat='1' changeset='#{cs_id}' version='1'/>
922 post :upload, :id => cs_id
923 assert_response :conflict,
924 "shouldn't be able to upload the same element twice in a diff: #{@response.body}"
928 # try to upload some elements without specifying the version
929 def test_upload_missing_version
930 basic_authorization changesets(:public_user_first_change).user.email, "test"
931 cs_id = changesets(:public_user_first_change).id
936 <node id='1' lon='1' lat='1' changeset='cs_id'/>
943 post :upload, :id => cs_id
944 assert_response :bad_request,
945 "shouldn't be able to upload an element without version: #{@response.body}"
949 # try to upload with commands other than create, modify, or delete
950 def test_action_upload_invalid
951 basic_authorization changesets(:public_user_first_change).user.email, "test"
952 cs_id = changesets(:public_user_first_change).id
957 <node id='1' lon='1' lat='1' changeset='#{cs_id}' />
962 post :upload, :id => cs_id
963 assert_response :bad_request, "Shouldn't be able to upload a diff with the action ping"
964 assert_equal @response.body, "Unknown action ping, choices are create, modify, delete"
968 # upload a valid changeset which has a mixture of whitespace
969 # to check a bug reported by ivansanchez (#1565).
970 def test_upload_whitespace_valid
971 basic_authorization changesets(:public_user_first_change).user.email, "test"
972 changeset_id = changesets(:public_user_first_change).id
976 <modify><node id='1' lon='0' lat='0' changeset='#{changeset_id}'
978 <node id='1' lon='1' lat='1' changeset='#{changeset_id}' version='2'><tag k='k' v='v'/></node></modify>
980 <relation id='1' changeset='#{changeset_id}' version='1'><member
981 type='way' role='some' ref='3'/><member
982 type='node' role='some' ref='5'/>
983 <member type='relation' role='some' ref='3'/>
985 </modify></osmChange>
990 post :upload, :id => changeset_id
991 assert_response :success,
992 "can't upload a valid diff with whitespace variations to changeset: #{@response.body}"
994 # check the response is well-formed
995 assert_select "diffResult>node", 2
996 assert_select "diffResult>relation", 1
998 # check that the changes made it into the database
999 assert_equal 1, Node.find(1).tags.size, "node 1 should now have one tag"
1000 assert_equal 0, Relation.find(1).tags.size, "relation 1 should now have no tags"
1004 # upload a valid changeset which has a mixture of whitespace
1005 # to check a bug reported by ivansanchez.
1006 def test_upload_reuse_placeholder_valid
1007 basic_authorization changesets(:public_user_first_change).user.email, "test"
1008 changeset_id = changesets(:public_user_first_change).id
1013 <node id='-1' lon='0' lat='0' changeset='#{changeset_id}'>
1014 <tag k="foo" v="bar"/>
1018 <node id='-1' lon='1' lat='1' changeset='#{changeset_id}' version='1'/>
1021 <node id='-1' lon='2' lat='2' changeset='#{changeset_id}' version='2'/>
1028 post :upload, :id => changeset_id
1029 assert_response :success,
1030 "can't upload a valid diff with re-used placeholders to changeset: #{@response.body}"
1032 # check the response is well-formed
1033 assert_select "diffResult>node", 3
1034 assert_select "diffResult>node[old_id='-1']", 3
1038 # test what happens if a diff upload re-uses placeholder IDs in an
1040 def test_upload_placeholder_invalid
1041 basic_authorization changesets(:public_user_first_change).user.email, "test"
1042 changeset_id = changesets(:public_user_first_change).id
1047 <node id='-1' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
1048 <node id='-1' lon='1' lat='1' changeset='#{changeset_id}' version='1'/>
1049 <node id='-1' lon='2' lat='2' changeset='#{changeset_id}' version='2'/>
1056 post :upload, :id => changeset_id
1057 assert_response :bad_request,
1058 "shouldn't be able to re-use placeholder IDs"
1062 # test that uploading a way referencing invalid placeholders gives a
1063 # proper error, not a 500.
1064 def test_upload_placeholder_invalid_way
1065 basic_authorization changesets(:public_user_first_change).user.email, "test"
1066 changeset_id = changesets(:public_user_first_change).id
1071 <node id="-1" lon="0" lat="0" changeset="#{changeset_id}" version="1"/>
1072 <node id="-2" lon="1" lat="1" changeset="#{changeset_id}" version="1"/>
1073 <node id="-3" lon="2" lat="2" changeset="#{changeset_id}" version="1"/>
1074 <way id="-1" changeset="#{changeset_id}" version="1">
1086 post :upload, :id => changeset_id
1087 assert_response :bad_request,
1088 "shouldn't be able to use invalid placeholder IDs"
1089 assert_equal "Placeholder node not found for reference -4 in way -1", @response.body
1091 # the same again, but this time use an existing way
1095 <node id="-1" lon="0" lat="0" changeset="#{changeset_id}" version="1"/>
1096 <node id="-2" lon="1" lat="1" changeset="#{changeset_id}" version="1"/>
1097 <node id="-3" lon="2" lat="2" changeset="#{changeset_id}" version="1"/>
1098 <way id="1" changeset="#{changeset_id}" version="1">
1110 post :upload, :id => changeset_id
1111 assert_response :bad_request,
1112 "shouldn't be able to use invalid placeholder IDs"
1113 assert_equal "Placeholder node not found for reference -4 in way 1", @response.body
1117 # test that uploading a relation referencing invalid placeholders gives a
1118 # proper error, not a 500.
1119 def test_upload_placeholder_invalid_relation
1120 basic_authorization changesets(:public_user_first_change).user.email, "test"
1121 changeset_id = changesets(:public_user_first_change).id
1126 <node id="-1" lon="0" lat="0" changeset="#{changeset_id}" version="1"/>
1127 <node id="-2" lon="1" lat="1" changeset="#{changeset_id}" version="1"/>
1128 <node id="-3" lon="2" lat="2" changeset="#{changeset_id}" version="1"/>
1129 <relation id="-1" changeset="#{changeset_id}" version="1">
1130 <member type="node" role="foo" ref="-1"/>
1131 <member type="node" role="foo" ref="-2"/>
1132 <member type="node" role="foo" ref="-3"/>
1133 <member type="node" role="foo" ref="-4"/>
1141 post :upload, :id => changeset_id
1142 assert_response :bad_request,
1143 "shouldn't be able to use invalid placeholder IDs"
1144 assert_equal "Placeholder Node not found for reference -4 in relation -1.", @response.body
1146 # the same again, but this time use an existing way
1150 <node id="-1" lon="0" lat="0" changeset="#{changeset_id}" version="1"/>
1151 <node id="-2" lon="1" lat="1" changeset="#{changeset_id}" version="1"/>
1152 <node id="-3" lon="2" lat="2" changeset="#{changeset_id}" version="1"/>
1153 <relation id="1" changeset="#{changeset_id}" version="1">
1154 <member type="node" role="foo" ref="-1"/>
1155 <member type="node" role="foo" ref="-2"/>
1156 <member type="node" role="foo" ref="-3"/>
1157 <member type="way" role="bar" ref="-1"/>
1165 post :upload, :id => changeset_id
1166 assert_response :bad_request,
1167 "shouldn't be able to use invalid placeholder IDs"
1168 assert_equal "Placeholder Way not found for reference -1 in relation 1.", @response.body
1172 # test what happens if a diff is uploaded containing only a node
1174 def test_upload_node_move
1175 basic_authorization create(:user).email, "test"
1177 content "<osm><changeset>" +
1178 "<tag k='created_by' v='osm test suite checking changesets'/>" +
1179 "</changeset></osm>"
1181 assert_response :success
1182 changeset_id = @response.body.to_i
1184 old_node = current_nodes(:visible_node)
1186 diff = XML::Document.new
1187 diff.root = XML::Node.new "osmChange"
1188 modify = XML::Node.new "modify"
1189 xml_old_node = old_node.to_xml_node
1190 xml_old_node["lat"] = 2.0.to_s
1191 xml_old_node["lon"] = 2.0.to_s
1192 xml_old_node["changeset"] = changeset_id.to_s
1193 modify << xml_old_node
1198 post :upload, :id => changeset_id
1199 assert_response :success,
1200 "diff should have uploaded OK"
1203 changeset = Changeset.find(changeset_id)
1204 assert_equal 1 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 1 degree"
1205 assert_equal 2 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 2 degrees"
1206 assert_equal 1 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1 degree"
1207 assert_equal 2 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 2 degrees"
1211 # test what happens if a diff is uploaded adding a node to a way.
1212 def test_upload_way_extend
1213 basic_authorization create(:user).email, "test"
1215 content "<osm><changeset>" +
1216 "<tag k='created_by' v='osm test suite checking changesets'/>" +
1217 "</changeset></osm>"
1219 assert_response :success
1220 changeset_id = @response.body.to_i
1222 old_way = current_ways(:visible_way)
1224 diff = XML::Document.new
1225 diff.root = XML::Node.new "osmChange"
1226 modify = XML::Node.new "modify"
1227 xml_old_way = old_way.to_xml_node
1228 nd_ref = XML::Node.new "nd"
1229 nd_ref["ref"] = current_nodes(:visible_node).id.to_s
1230 xml_old_way << nd_ref
1231 xml_old_way["changeset"] = changeset_id.to_s
1232 modify << xml_old_way
1237 post :upload, :id => changeset_id
1238 assert_response :success,
1239 "diff should have uploaded OK"
1242 changeset = Changeset.find(changeset_id)
1243 assert_equal 1 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 1 degree"
1244 assert_equal 3 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 3 degrees"
1245 assert_equal 1 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1 degree"
1246 assert_equal 3 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 3 degrees"
1250 # test for more issues in #1568
1251 def test_upload_empty_invalid
1252 basic_authorization changesets(:public_user_first_change).user.email, "test"
1255 "<osmChange></osmChange>",
1256 "<osmChange><modify/></osmChange>",
1257 "<osmChange><modify></modify></osmChange>"].each do |diff|
1260 post :upload, :id => changesets(:public_user_first_change).id
1261 assert_response(:success, "should be able to upload " +
1262 "empty changeset: " + diff)
1267 # test that the X-Error-Format header works to request XML errors
1268 def test_upload_xml_errors
1269 basic_authorization changesets(:public_user_first_change).user.email, "test"
1270 cs = changesets(:public_user_first_change)
1272 # try and delete a node that is in use
1273 diff = XML::Document.new
1274 diff.root = XML::Node.new "osmChange"
1275 delete = XML::Node.new "delete"
1277 delete << current_nodes(:node_used_by_relationship).to_xml_node
1282 post :upload, :id => cs.id
1283 assert_response :success,
1284 "failed to return error in XML format"
1286 # check the returned payload
1287 assert_select "osmError[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
1288 assert_select "osmError>status", 1
1289 assert_select "osmError>message", 1
1293 # when we make some simple changes we get the same changes back from the
1295 def test_diff_download_simple
1296 ## First try with a non-public user, which should get a forbidden
1297 basic_authorization(create(:user, :data_public => false).email, "test")
1299 # create a temporary changeset
1300 content "<osm><changeset>" +
1301 "<tag k='created_by' v='osm test suite checking changesets'/>" +
1302 "</changeset></osm>"
1304 assert_response :forbidden
1306 ## Now try with a normal user
1307 basic_authorization(create(:user).email, "test")
1309 # create a temporary changeset
1310 content "<osm><changeset>" +
1311 "<tag k='created_by' v='osm test suite checking changesets'/>" +
1312 "</changeset></osm>"
1314 assert_response :success
1315 changeset_id = @response.body.to_i
1321 <node id='1' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
1322 <node id='1' lon='1' lat='0' changeset='#{changeset_id}' version='2'/>
1323 <node id='1' lon='1' lat='1' changeset='#{changeset_id}' version='3'/>
1324 <node id='1' lon='1' lat='2' changeset='#{changeset_id}' version='4'/>
1325 <node id='1' lon='2' lat='2' changeset='#{changeset_id}' version='5'/>
1326 <node id='1' lon='3' lat='2' changeset='#{changeset_id}' version='6'/>
1327 <node id='1' lon='3' lat='3' changeset='#{changeset_id}' version='7'/>
1328 <node id='1' lon='9' lat='9' changeset='#{changeset_id}' version='8'/>
1335 post :upload, :id => changeset_id
1336 assert_response :success,
1337 "can't upload multiple versions of an element in a diff: #{@response.body}"
1339 get :download, :id => changeset_id
1340 assert_response :success
1342 assert_select "osmChange", 1
1343 assert_select "osmChange>modify", 8
1344 assert_select "osmChange>modify>node", 8
1348 # culled this from josm to ensure that nothing in the way that josm
1349 # is formatting the request is causing it to fail.
1351 # NOTE: the error turned out to be something else completely!
1352 def test_josm_upload
1353 basic_authorization(create(:user).email, "test")
1355 # create a temporary changeset
1356 content "<osm><changeset>" +
1357 "<tag k='created_by' v='osm test suite checking changesets'/>" +
1358 "</changeset></osm>"
1360 assert_response :success
1361 changeset_id = @response.body.to_i
1364 <osmChange version="0.6" generator="JOSM">
1365 <create version="0.6" generator="JOSM">
1366 <node id='-1' visible='true' changeset='#{changeset_id}' lat='51.49619982187321' lon='-0.18722061869438314' />
1367 <node id='-2' visible='true' changeset='#{changeset_id}' lat='51.496359883909605' lon='-0.18653093576241928' />
1368 <node id='-3' visible='true' changeset='#{changeset_id}' lat='51.49598132358285' lon='-0.18719613290981638' />
1369 <node id='-4' visible='true' changeset='#{changeset_id}' lat='51.4961591711078' lon='-0.18629015888084607' />
1370 <node id='-5' visible='true' changeset='#{changeset_id}' lat='51.49582126021711' lon='-0.18708186591517145' />
1371 <node id='-6' visible='true' changeset='#{changeset_id}' lat='51.49591018437858' lon='-0.1861432441734455' />
1372 <node id='-7' visible='true' changeset='#{changeset_id}' lat='51.49560784152179' lon='-0.18694719410005425' />
1373 <node id='-8' visible='true' changeset='#{changeset_id}' lat='51.49567389979617' lon='-0.1860289771788006' />
1374 <node id='-9' visible='true' changeset='#{changeset_id}' lat='51.49543761398892' lon='-0.186820684213126' />
1375 <way id='-10' action='modiy' visible='true' changeset='#{changeset_id}'>
1385 <tag k='highway' v='residential' />
1386 <tag k='name' v='Foobar Street' />
1394 post :upload, :id => changeset_id
1395 assert_response :success,
1396 "can't upload a diff from JOSM: #{@response.body}"
1398 get :download, :id => changeset_id
1399 assert_response :success
1401 assert_select "osmChange", 1
1402 assert_select "osmChange>create>node", 9
1403 assert_select "osmChange>create>way", 1
1404 assert_select "osmChange>create>way>nd", 9
1405 assert_select "osmChange>create>way>tag", 2
1409 # when we make some complex changes we get the same changes back from the
1411 def test_diff_download_complex
1412 basic_authorization(create(:user).email, "test")
1414 # create a temporary changeset
1415 content "<osm><changeset>" +
1416 "<tag k='created_by' v='osm test suite checking changesets'/>" +
1417 "</changeset></osm>"
1419 assert_response :success
1420 changeset_id = @response.body.to_i
1426 <node id='1' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
1429 <node id='-1' lon='9' lat='9' changeset='#{changeset_id}' version='0'/>
1430 <node id='-2' lon='8' lat='9' changeset='#{changeset_id}' version='0'/>
1431 <node id='-3' lon='7' lat='9' changeset='#{changeset_id}' version='0'/>
1434 <node id='3' lon='20' lat='15' changeset='#{changeset_id}' version='1'/>
1435 <way id='1' changeset='#{changeset_id}' version='1'>
1447 post :upload, :id => changeset_id
1448 assert_response :success,
1449 "can't upload multiple versions of an element in a diff: #{@response.body}"
1451 get :download, :id => changeset_id
1452 assert_response :success
1454 assert_select "osmChange", 1
1455 assert_select "osmChange>create", 3
1456 assert_select "osmChange>delete", 1
1457 assert_select "osmChange>modify", 2
1458 assert_select "osmChange>create>node", 3
1459 assert_select "osmChange>delete>node", 1
1460 assert_select "osmChange>modify>node", 1
1461 assert_select "osmChange>modify>way", 1
1464 def test_changeset_download
1465 tag = create(:old_node_tag, :old_node => nodes(:used_node_2))
1467 get :download, :id => changesets(:normal_user_first_change).id
1469 assert_response :success
1471 # print @response.body
1472 # FIXME: needs more assert_select tests
1473 assert_select "osmChange[version='#{API_VERSION}'][generator='#{GENERATOR}']" do
1474 assert_select "create", :count => 5
1475 assert_select "create>node[id='#{nodes(:used_node_2).node_id}'][visible='#{nodes(:used_node_2).visible?}'][version='#{nodes(:used_node_2).version}']" do
1476 assert_select "tag[k='#{tag.k}'][v='#{tag.v}']"
1478 assert_select "create>node[id='#{nodes(:visible_node).node_id}']"
1483 # check that the bounding box of a changeset gets updated correctly
1484 # FIXME: This should really be moded to a integration test due to the with_controller
1485 def test_changeset_bbox
1486 basic_authorization create(:user).email, "test"
1488 # create a new changeset
1489 content "<osm><changeset/></osm>"
1491 assert_response :success, "Creating of changeset failed."
1492 changeset_id = @response.body.to_i
1494 # add a single node to it
1495 with_controller(NodeController.new) do
1496 content "<osm><node lon='1' lat='2' changeset='#{changeset_id}'/></osm>"
1498 assert_response :success, "Couldn't create node."
1501 # get the bounding box back from the changeset
1502 get :read, :id => changeset_id
1503 assert_response :success, "Couldn't read back changeset."
1504 assert_select "osm>changeset[min_lon='1.0']", 1
1505 assert_select "osm>changeset[max_lon='1.0']", 1
1506 assert_select "osm>changeset[min_lat='2.0']", 1
1507 assert_select "osm>changeset[max_lat='2.0']", 1
1509 # add another node to it
1510 with_controller(NodeController.new) do
1511 content "<osm><node lon='2' lat='1' changeset='#{changeset_id}'/></osm>"
1513 assert_response :success, "Couldn't create second node."
1516 # get the bounding box back from the changeset
1517 get :read, :id => changeset_id
1518 assert_response :success, "Couldn't read back changeset for the second time."
1519 assert_select "osm>changeset[min_lon='1.0']", 1
1520 assert_select "osm>changeset[max_lon='2.0']", 1
1521 assert_select "osm>changeset[min_lat='1.0']", 1
1522 assert_select "osm>changeset[max_lat='2.0']", 1
1524 # add (delete) a way to it, which contains a point at (3,3)
1525 with_controller(WayController.new) do
1526 content update_changeset(current_ways(:visible_way).to_xml,
1528 put :delete, :id => current_ways(:visible_way).id
1529 assert_response :success, "Couldn't delete a way."
1532 # get the bounding box back from the changeset
1533 get :read, :id => changeset_id
1534 assert_response :success, "Couldn't read back changeset for the third time."
1535 # note that the 3.1 here is because of the bbox overexpansion
1536 assert_select "osm>changeset[min_lon='1.0']", 1
1537 assert_select "osm>changeset[max_lon='3.1']", 1
1538 assert_select "osm>changeset[min_lat='1.0']", 1
1539 assert_select "osm>changeset[max_lat='3.1']", 1
1543 # test that the changeset :include method works as it should
1544 def test_changeset_include
1545 basic_authorization create(:user).display_name, "test"
1547 # create a new changeset
1548 content "<osm><changeset/></osm>"
1550 assert_response :success, "Creating of changeset failed."
1551 changeset_id = @response.body.to_i
1553 # NOTE: the include method doesn't over-expand, like inserting
1554 # a real method does. this is because we expect the client to
1555 # know what it is doing!
1556 check_after_include(changeset_id, 1, 1, [1, 1, 1, 1])
1557 check_after_include(changeset_id, 3, 3, [1, 1, 3, 3])
1558 check_after_include(changeset_id, 4, 2, [1, 1, 4, 3])
1559 check_after_include(changeset_id, 2, 2, [1, 1, 4, 3])
1560 check_after_include(changeset_id, -1, -1, [-1, -1, 4, 3])
1561 check_after_include(changeset_id, -2, 5, [-2, -1, 4, 5])
1565 # test that a not found, wrong method with the expand bbox works as expected
1566 def test_changeset_expand_bbox_error
1567 basic_authorization create(:user).display_name, "test"
1569 # create a new changeset
1570 content "<osm><changeset/></osm>"
1572 assert_response :success, "Creating of changeset failed."
1573 changeset_id = @response.body.to_i
1579 content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"
1580 put :expand_bbox, :id => changeset_id
1581 assert_response :method_not_allowed, "shouldn't be able to put a bbox expand"
1583 # Try to get the update
1584 content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"
1585 get :expand_bbox, :id => changeset_id
1586 assert_response :method_not_allowed, "shouldn't be able to get a bbox expand"
1588 # Try to use a hopefully missing changeset
1589 content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"
1590 post :expand_bbox, :id => changeset_id + 13245
1591 assert_response :not_found, "shouldn't be able to do a bbox expand on a nonexistant changeset"
1595 # test the query functionality of changesets
1597 private_user = create(:user, :data_public => false)
1598 private_user_changeset = create(:changeset, :user => private_user)
1599 private_user_closed_changeset = create(:changeset, :closed, :user => private_user)
1600 user = create(:user)
1601 changeset = create(:changeset, :user => user)
1602 closed_changeset = create(:changeset, :closed, :user => user, :created_at => Time.utc(2008, 1, 1, 0, 0, 0), :closed_at => Time.utc(2008, 1, 2, 0, 0, 0))
1604 get :query, :bbox => "-10,-10, 10, 10"
1605 assert_response :success, "can't get changesets in bbox"
1606 assert_changesets [1, 4, 6]
1608 get :query, :bbox => "4.5,4.5,4.6,4.6"
1609 assert_response :success, "can't get changesets in bbox"
1610 assert_changesets [1]
1612 # not found when looking for changesets of non-existing users
1613 get :query, :user => User.maximum(:id) + 1
1614 assert_response :not_found
1615 get :query, :display_name => " "
1616 assert_response :not_found
1618 # can't get changesets of user 1 without authenticating
1619 get :query, :user => private_user.id
1620 assert_response :not_found, "shouldn't be able to get changesets by non-public user (ID)"
1621 get :query, :display_name => private_user.display_name
1622 assert_response :not_found, "shouldn't be able to get changesets by non-public user (name)"
1624 # but this should work
1625 basic_authorization private_user.email, "test"
1626 get :query, :user => private_user.id
1627 assert_response :success, "can't get changesets by user ID"
1628 assert_changesets [private_user_changeset.id, private_user_closed_changeset.id]
1630 get :query, :display_name => private_user.display_name
1631 assert_response :success, "can't get changesets by user name"
1632 assert_changesets [private_user_changeset.id, private_user_closed_changeset.id]
1634 # check that the correct error is given when we provide both UID and name
1635 get :query, :user => private_user.id, :display_name => private_user.display_name
1636 assert_response :bad_request, "should be a bad request to have both ID and name specified"
1638 get :query, :user => private_user.id, :open => true
1639 assert_response :success, "can't get changesets by user and open"
1640 assert_changesets [private_user_changeset.id]
1642 get :query, :time => "2007-12-31"
1643 assert_response :success, "can't get changesets by time-since"
1644 assert_changesets [1, 2, 4, 5, 6, private_user_changeset.id, private_user_closed_changeset.id, changeset.id, closed_changeset.id]
1646 get :query, :time => "2008-01-01T12:34Z"
1647 assert_response :success, "can't get changesets by time-since with hour"
1648 assert_changesets [1, 2, 4, 5, 6, private_user_changeset.id, private_user_closed_changeset.id, changeset.id, closed_changeset.id]
1650 get :query, :time => "2007-12-31T23:59Z,2008-01-02T00:01Z"
1651 assert_response :success, "can't get changesets by time-range"
1652 assert_changesets [1, 5, 6, closed_changeset.id]
1654 get :query, :open => "true"
1655 assert_response :success, "can't get changesets by open-ness"
1656 assert_changesets [1, 2, 4, private_user_changeset.id, changeset.id]
1658 get :query, :closed => "true"
1659 assert_response :success, "can't get changesets by closed-ness"
1660 assert_changesets [3, 5, 6, 7, 8, 9, private_user_closed_changeset.id, closed_changeset.id]
1662 get :query, :closed => "true", :user => private_user.id
1663 assert_response :success, "can't get changesets by closed-ness and user"
1664 assert_changesets [private_user_closed_changeset.id]
1666 get :query, :closed => "true", :user => user.id
1667 assert_response :success, "can't get changesets by closed-ness and user"
1668 assert_changesets [closed_changeset.id]
1670 get :query, :changesets => "#{private_user_changeset.id},#{changeset.id},#{closed_changeset.id}"
1671 assert_response :success, "can't get changesets by id (as comma-separated string)"
1672 assert_changesets [private_user_changeset.id, changeset.id, closed_changeset.id]
1674 get :query, :changesets => ""
1675 assert_response :bad_request, "should be a bad request since changesets is empty"
1679 # check that errors are returned if garbage is inserted
1680 # into query strings
1681 def test_query_invalid
1684 ";drop table users;"].each do |bbox|
1685 get :query, :bbox => bbox
1686 assert_response :bad_request, "'#{bbox}' isn't a bbox"
1691 ";drop table users;",
1693 "-,-"].each do |time|
1694 get :query, :time => time
1695 assert_response :bad_request, "'#{time}' isn't a valid time range"
1702 get :query, :user => uid
1703 assert_response :bad_request, "'#{uid}' isn't a valid user ID"
1708 # check updating tags on a changeset
1709 def test_changeset_update
1710 private_user = create(:user, :data_public => false)
1711 private_changeset = create(:changeset, :user => private_user)
1712 user = create(:user)
1713 changeset = create(:changeset, :user => user)
1715 ## First try with a non-public user
1716 new_changeset = private_changeset.to_xml
1717 new_tag = XML::Node.new "tag"
1718 new_tag["k"] = "tagtesting"
1719 new_tag["v"] = "valuetesting"
1720 new_changeset.find("//osm/changeset").first << new_tag
1721 content new_changeset
1723 # try without any authorization
1724 put :update, :id => private_changeset.id
1725 assert_response :unauthorized
1727 # try with the wrong authorization
1728 basic_authorization create(:user).email, "test"
1729 put :update, :id => private_changeset.id
1730 assert_response :conflict
1732 # now this should get an unauthorized
1733 basic_authorization private_user.email, "test"
1734 put :update, :id => private_changeset.id
1735 assert_require_public_data "user with their data non-public, shouldn't be able to edit their changeset"
1737 ## Now try with the public user
1738 create(:changeset_tag, :changeset => changeset)
1739 new_changeset = changeset.to_xml
1740 new_tag = XML::Node.new "tag"
1741 new_tag["k"] = "tagtesting"
1742 new_tag["v"] = "valuetesting"
1743 new_changeset.find("//osm/changeset").first << new_tag
1744 content new_changeset
1746 # try without any authorization
1747 @request.env["HTTP_AUTHORIZATION"] = nil
1748 put :update, :id => changeset.id
1749 assert_response :unauthorized
1751 # try with the wrong authorization
1752 basic_authorization create(:user).email, "test"
1753 put :update, :id => changeset.id
1754 assert_response :conflict
1756 # now this should work...
1757 basic_authorization user.email, "test"
1758 put :update, :id => changeset.id
1759 assert_response :success
1761 assert_select "osm>changeset[id='#{changeset.id}']", 1
1762 assert_select "osm>changeset>tag", 2
1763 assert_select "osm>changeset>tag[k='tagtesting'][v='valuetesting']", 1
1767 # check that a user different from the one who opened the changeset
1769 def test_changeset_update_invalid
1770 basic_authorization create(:user).email, "test"
1772 changeset = create(:changeset)
1773 new_changeset = changeset.to_xml
1774 new_tag = XML::Node.new "tag"
1775 new_tag["k"] = "testing"
1776 new_tag["v"] = "testing"
1777 new_changeset.find("//osm/changeset").first << new_tag
1779 content new_changeset
1780 put :update, :id => changeset.id
1781 assert_response :conflict
1785 # check that a changeset can contain a certain max number of changes.
1786 ## FIXME should be changed to an integration test due to the with_controller
1787 def test_changeset_limits
1788 basic_authorization create(:user).email, "test"
1790 # open a new changeset
1791 content "<osm><changeset/></osm>"
1793 assert_response :success, "can't create a new changeset"
1794 cs_id = @response.body.to_i
1796 # start the counter just short of where the changeset should finish.
1798 # alter the database to set the counter on the changeset directly,
1799 # otherwise it takes about 6 minutes to fill all of them.
1800 changeset = Changeset.find(cs_id)
1801 changeset.num_changes = Changeset::MAX_ELEMENTS - offset
1804 with_controller(NodeController.new) do
1806 content "<osm><node changeset='#{cs_id}' lat='0.0' lon='0.0'/></osm>"
1808 assert_response :success, "can't create a new node"
1809 node_id = @response.body.to_i
1811 get :read, :id => node_id
1812 assert_response :success, "can't read back new node"
1813 node_doc = XML::Parser.string(@response.body).parse
1814 node_xml = node_doc.find("//osm/node").first
1816 # loop until we fill the changeset with nodes
1818 node_xml["lat"] = rand.to_s
1819 node_xml["lon"] = rand.to_s
1820 node_xml["version"] = (i + 1).to_s
1823 put :update, :id => node_id
1824 assert_response :success, "attempt #{i} should have succeeded"
1827 # trying again should fail
1828 node_xml["lat"] = rand.to_s
1829 node_xml["lon"] = rand.to_s
1830 node_xml["version"] = offset.to_s
1833 put :update, :id => node_id
1834 assert_response :conflict, "final attempt should have failed"
1837 changeset = Changeset.find(cs_id)
1838 assert_equal Changeset::MAX_ELEMENTS + 1, changeset.num_changes
1840 # check that the changeset is now closed as well
1841 assert(!changeset.is_open?,
1842 "changeset should have been auto-closed by exceeding " +
1847 # This should display the last 20 changesets closed
1849 get :list, :format => "html"
1850 assert_response :success
1851 assert_template "history"
1852 assert_template :layout => "map"
1853 assert_select "h2", :text => "Changesets", :count => 1
1855 xhr :get, :list, :format => "html", :list => "1"
1856 assert_response :success
1857 assert_template "list"
1859 check_list_result(Changeset.all)
1863 # This should display the last 20 changesets closed
1865 xhr :get, :list, :format => "html"
1866 assert_response :success
1867 assert_template "history"
1868 assert_template :layout => "xhr"
1869 assert_select "h2", :text => "Changesets", :count => 1
1871 xhr :get, :list, :format => "html", :list => "1"
1872 assert_response :success
1873 assert_template "list"
1875 check_list_result(Changeset.all)
1879 # This should display the last 20 changesets closed in a specific area
1881 get :list, :format => "html", :bbox => "4.5,4.5,5.5,5.5"
1882 assert_response :success
1883 assert_template "history"
1884 assert_template :layout => "map"
1885 assert_select "h2", :text => "Changesets", :count => 1
1887 xhr :get, :list, :format => "html", :bbox => "4.5,4.5,5.5,5.5", :list => "1"
1888 assert_response :success
1889 assert_template "list"
1891 check_list_result(Changeset.where("min_lon < 55000000 and max_lon > 45000000 and min_lat < 55000000 and max_lat > 45000000"))
1895 # Checks the display of the user changesets listing
1897 user = create(:user)
1898 create(:changeset, :user => user)
1899 create(:changeset, :closed, :user => user)
1901 get :list, :format => "html", :display_name => user.display_name
1902 assert_response :success
1903 assert_template "history"
1905 xhr :get, :list, :format => "html", :display_name => user.display_name, :list => "1"
1906 assert_response :success
1907 assert_template "list"
1909 check_list_result(user.changesets)
1913 # Checks the display of the user changesets listing for a private user
1914 def test_list_private_user
1915 private_user = create(:user, :data_public => false)
1916 create(:changeset, :user => private_user)
1917 create(:changeset, :closed, :user => private_user)
1919 get :list, :format => "html", :display_name => private_user.display_name
1920 assert_response :success
1921 assert_template "history"
1923 xhr :get, :list, :format => "html", :display_name => private_user.display_name, :list => "1"
1924 assert_response :success
1925 assert_template "list"
1927 check_list_result(Changeset.none)
1931 # Check the not found of the list user changesets
1932 def test_list_user_not_found
1933 get :list, :format => "html", :display_name => "Some random user"
1934 assert_response :not_found
1935 assert_template "user/no_such_user"
1937 xhr :get, :list, :format => "html", :display_name => "Some random user", :list => "1"
1938 assert_response :not_found
1939 assert_template "user/no_such_user"
1943 # Checks the display of the friends changesets listing
1944 def test_list_friends
1945 private_user = create(:user, :data_public => true)
1946 friend = create(:friend, :befriender => private_user)
1947 create(:changeset, :user => friend.befriendee)
1949 get :list, :friends => true
1950 assert_response :redirect
1951 assert_redirected_to :controller => :user, :action => :login, :referer => friend_changesets_path
1953 session[:user] = private_user.id
1955 get :list, :friends => true
1956 assert_response :success
1957 assert_template "history"
1959 xhr :get, :list, :friends => true, :list => "1"
1960 assert_response :success
1961 assert_template "list"
1963 check_list_result(Changeset.where(:user => private_user.friend_users.identifiable))
1967 # Checks the display of the nearby user changesets listing
1968 def test_list_nearby
1969 private_user = create(:user, :data_public => false, :home_lat => 51.1, :home_lon => 1.0)
1970 user = create(:user, :home_lat => 51.0, :home_lon => 1.0)
1971 create(:changeset, :user => user)
1973 get :list, :nearby => true
1974 assert_response :redirect
1975 assert_redirected_to :controller => :user, :action => :login, :referer => nearby_changesets_path
1977 session[:user] = private_user.id
1979 get :list, :nearby => true
1980 assert_response :success
1981 assert_template "history"
1983 xhr :get, :list, :nearby => true, :list => "1"
1984 assert_response :success
1985 assert_template "list"
1987 check_list_result(Changeset.where(:user => user.nearby))
1991 # Check that we can't request later pages of the changesets list
1992 def test_list_max_id
1993 xhr :get, :list, :format => "html", :max_id => 4
1994 assert_response :success
1995 assert_template "history"
1996 assert_template :layout => "xhr"
1997 assert_select "h2", :text => "Changesets", :count => 1
1999 xhr :get, :list, :format => "html", :list => "1", :max_id => 4
2000 assert_response :success
2001 assert_template "list"
2003 check_list_result(Changeset.where("id <= 4"))
2007 # This should display the last 20 changesets closed
2009 get :feed, :format => :atom
2010 assert_response :success
2011 assert_template "list"
2012 assert_equal "application/atom+xml", response.content_type
2014 check_feed_result(Changeset.all)
2018 # This should display the last 20 changesets closed in a specific area
2020 get :feed, :format => :atom, :bbox => "4.5,4.5,5.5,5.5"
2021 assert_response :success
2022 assert_template "list"
2023 assert_equal "application/atom+xml", response.content_type
2025 check_feed_result(Changeset.where("min_lon < 55000000 and max_lon > 45000000 and min_lat < 55000000 and max_lat > 45000000"))
2029 # Checks the display of the user changesets feed
2031 user = create(:user)
2032 create_list(:changeset, 3, :user => user, :num_changes => 4)
2034 get :feed, :format => :atom, :display_name => user.display_name
2035 assert_response :success
2036 assert_template "list"
2037 assert_equal "application/atom+xml", response.content_type
2039 check_feed_result(user.changesets)
2043 # Check the not found of the user changesets feed
2044 def test_feed_user_not_found
2045 get :feed, :format => "atom", :display_name => "Some random user"
2046 assert_response :not_found
2050 # Check that we can't request later pages of the changesets feed
2051 def test_feed_max_id
2052 get :feed, :format => "atom", :max_id => 100
2053 assert_response :redirect
2054 assert_redirected_to :action => :feed
2058 # check that the changeset download for a changeset with a redacted
2059 # element in it doesn't contain that element.
2060 def test_diff_download_redacted
2061 changeset = create(:changeset)
2062 node = create(:node, :with_history, :version => 2, :changeset => changeset)
2063 node_v1 = node.old_nodes.find_by(:version => 1)
2064 node_v1.redact!(create(:redaction))
2066 get :download, :id => changeset.id
2067 assert_response :success
2069 assert_select "osmChange", 1
2070 # this changeset contains the node in versions 1 & 2, but 1 should
2072 assert_select "osmChange node[id='#{node.id}']", 1
2073 assert_select "osmChange node[id='#{node.id}'][version='1']", 0
2077 # create comment success
2078 def test_create_comment_success
2079 user = create(:user)
2080 user2 = create(:user)
2081 private_user = create(:user, :data_public => false)
2082 suspended_user = create(:user, :suspended)
2083 deleted_user = create(:user, :deleted)
2084 private_user_closed_changeset = create(:changeset, :closed, :user => private_user)
2086 basic_authorization(user.email, "test")
2088 assert_difference "ChangesetComment.count", 1 do
2089 assert_no_difference "ActionMailer::Base.deliveries.size" do
2090 post :comment, :id => private_user_closed_changeset.id, :text => "This is a comment"
2093 assert_response :success
2095 changeset = create(:changeset, :closed, :user => private_user)
2096 changeset.subscribers.push(private_user)
2097 changeset.subscribers.push(user)
2098 changeset.subscribers.push(suspended_user)
2099 changeset.subscribers.push(deleted_user)
2101 assert_difference "ChangesetComment.count", 1 do
2102 assert_difference "ActionMailer::Base.deliveries.size", 1 do
2103 post :comment, :id => changeset.id, :text => "This is a comment"
2106 assert_response :success
2108 email = ActionMailer::Base.deliveries.first
2109 assert_equal 1, email.to.length
2110 assert_equal "[OpenStreetMap] #{user.display_name} has commented on one of your changesets", email.subject
2111 assert_equal private_user.email, email.to.first
2113 ActionMailer::Base.deliveries.clear
2115 basic_authorization(user2.email, "test")
2117 assert_difference "ChangesetComment.count", 1 do
2118 assert_difference "ActionMailer::Base.deliveries.size", 2 do
2119 post :comment, :id => changeset.id, :text => "This is a comment"
2122 assert_response :success
2124 email = ActionMailer::Base.deliveries.find { |e| e.to.first == private_user.email }
2125 assert_not_nil email
2126 assert_equal 1, email.to.length
2127 assert_equal "[OpenStreetMap] #{user2.display_name} has commented on one of your changesets", email.subject
2129 email = ActionMailer::Base.deliveries.find { |e| e.to.first == user.email }
2130 assert_not_nil email
2131 assert_equal 1, email.to.length
2132 assert_equal "[OpenStreetMap] #{user2.display_name} has commented on a changeset you are interested in", email.subject
2134 ActionMailer::Base.deliveries.clear
2138 # create comment fail
2139 def test_create_comment_fail
2141 post :comment, :id => create(:changeset, :closed).id, :text => "This is a comment"
2142 assert_response :unauthorized
2144 basic_authorization(create(:user).email, "test")
2147 assert_no_difference "ChangesetComment.count" do
2148 post :comment, :id => 999111, :text => "This is a comment"
2150 assert_response :not_found
2152 # not closed changeset
2153 assert_no_difference "ChangesetComment.count" do
2154 post :comment, :id => create(:changeset).id, :text => "This is a comment"
2156 assert_response :conflict
2159 assert_no_difference "ChangesetComment.count" do
2160 post :comment, :id => create(:changeset, :closed).id
2162 assert_response :bad_request
2165 assert_no_difference "ChangesetComment.count" do
2166 post :comment, :id => create(:changeset, :closed).id, :text => ""
2168 assert_response :bad_request
2172 # test subscribe success
2173 def test_subscribe_success
2174 basic_authorization(create(:user).email, "test")
2175 changeset = create(:changeset, :closed)
2177 assert_difference "changeset.subscribers.count", 1 do
2178 post :subscribe, :id => changeset.id
2180 assert_response :success
2184 # test subscribe fail
2185 def test_subscribe_fail
2186 user = create(:user)
2189 changeset = create(:changeset, :closed)
2190 assert_no_difference "changeset.subscribers.count" do
2191 post :subscribe, :id => changeset.id
2193 assert_response :unauthorized
2195 basic_authorization(user.email, "test")
2198 assert_no_difference "changeset.subscribers.count" do
2199 post :subscribe, :id => 999111
2201 assert_response :not_found
2203 # not closed changeset
2204 changeset = create(:changeset)
2205 assert_no_difference "changeset.subscribers.count" do
2206 post :subscribe, :id => changeset.id
2208 assert_response :conflict
2210 # trying to subscribe when already subscribed
2211 changeset = create(:changeset, :closed)
2212 changeset.subscribers.push(user)
2213 assert_no_difference "changeset.subscribers.count" do
2214 post :subscribe, :id => changeset.id
2216 assert_response :conflict
2220 # test unsubscribe success
2221 def test_unsubscribe_success
2222 user = create(:user)
2223 basic_authorization(user.email, "test")
2224 changeset = create(:changeset, :closed)
2225 changeset.subscribers.push(user)
2227 assert_difference "changeset.subscribers.count", -1 do
2228 post :unsubscribe, :id => changeset.id
2230 assert_response :success
2234 # test unsubscribe fail
2235 def test_unsubscribe_fail
2237 changeset = create(:changeset, :closed)
2238 assert_no_difference "changeset.subscribers.count" do
2239 post :unsubscribe, :id => changeset.id
2241 assert_response :unauthorized
2243 basic_authorization(create(:user).email, "test")
2246 assert_no_difference "changeset.subscribers.count" do
2247 post :unsubscribe, :id => 999111
2249 assert_response :not_found
2251 # not closed changeset
2252 changeset = create(:changeset)
2253 assert_no_difference "changeset.subscribers.count" do
2254 post :unsubscribe, :id => changeset.id
2256 assert_response :conflict
2258 # trying to unsubscribe when not subscribed
2259 changeset = create(:changeset, :closed)
2260 assert_no_difference "changeset.subscribers.count" do
2261 post :unsubscribe, :id => changeset.id
2263 assert_response :not_found
2267 # test hide comment fail
2268 def test_hide_comment_fail
2270 comment = create(:changeset_comment)
2271 assert_equal true, comment.visible
2273 post :hide_comment, :id => comment.id
2274 assert_response :unauthorized
2275 assert_equal true, comment.reload.visible
2277 basic_authorization(create(:user).email, "test")
2280 post :hide_comment, :id => comment.id
2281 assert_response :forbidden
2282 assert_equal true, comment.reload.visible
2284 basic_authorization(create(:moderator_user).email, "test")
2287 post :hide_comment, :id => 999111
2288 assert_response :not_found
2289 assert_equal true, comment.reload.visible
2293 # test hide comment succes
2294 def test_hide_comment_success
2295 comment = create(:changeset_comment)
2296 assert_equal true, comment.visible
2298 basic_authorization(create(:moderator_user).email, "test")
2300 post :hide_comment, :id => comment.id
2301 assert_response :success
2302 assert_equal false, comment.reload.visible
2306 # test unhide comment fail
2307 def test_unhide_comment_fail
2309 comment = create(:changeset_comment, :visible => false)
2310 assert_equal false, comment.visible
2312 post :unhide_comment, :id => comment.id
2313 assert_response :unauthorized
2314 assert_equal false, comment.reload.visible
2316 basic_authorization(create(:user).email, "test")
2319 post :unhide_comment, :id => comment.id
2320 assert_response :forbidden
2321 assert_equal false, comment.reload.visible
2323 basic_authorization(create(:moderator_user).email, "test")
2326 post :unhide_comment, :id => 999111
2327 assert_response :not_found
2328 assert_equal false, comment.reload.visible
2332 # test unhide comment succes
2333 def test_unhide_comment_success
2334 comment = create(:changeset_comment, :visible => false)
2335 assert_equal false, comment.visible
2337 basic_authorization(create(:moderator_user).email, "test")
2339 post :unhide_comment, :id => comment.id
2340 assert_response :success
2341 assert_equal true, comment.reload.visible
2345 # test comments feed
2346 def test_comments_feed
2347 changeset = create(:changeset, :closed)
2348 create_list(:changeset_comment, 3, :changeset => changeset)
2350 get :comments_feed, :format => "rss"
2351 assert_response :success
2352 assert_equal "application/rss+xml", @response.content_type
2353 assert_select "rss", :count => 1 do
2354 assert_select "channel", :count => 1 do
2355 assert_select "item", :count => 3
2359 get :comments_feed, :format => "rss", :limit => 2
2360 assert_response :success
2361 assert_equal "application/rss+xml", @response.content_type
2362 assert_select "rss", :count => 1 do
2363 assert_select "channel", :count => 1 do
2364 assert_select "item", :count => 2
2368 get :comments_feed, :id => changeset.id, :format => "rss"
2369 assert_response :success
2370 assert_equal "application/rss+xml", @response.content_type
2371 assert_select "rss", :count => 1 do
2372 assert_select "channel", :count => 1 do
2373 assert_select "item", :count => 3
2379 # test comments feed
2380 def test_comments_feed_bad_limit
2381 get :comments_feed, :format => "rss", :limit => 0
2382 assert_response :bad_request
2384 get :comments_feed, :format => "rss", :limit => 100001
2385 assert_response :bad_request
2391 # boilerplate for checking that certain changesets exist in the
2393 def assert_changesets(ids)
2394 assert_select "osm>changeset", ids.size
2396 assert_select "osm>changeset[id='#{id}']", 1
2401 # call the include method and assert properties of the bbox
2402 def check_after_include(changeset_id, lon, lat, bbox)
2403 content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"
2404 post :expand_bbox, :id => changeset_id
2405 assert_response :success, "Setting include of changeset failed: #{@response.body}"
2407 # check exactly one changeset
2408 assert_select "osm>changeset", 1
2409 assert_select "osm>changeset[id='#{changeset_id}']", 1
2412 doc = XML::Parser.string(@response.body).parse
2413 changeset = doc.find("//osm/changeset").first
2414 assert_equal bbox[0], changeset["min_lon"].to_f, "min lon"
2415 assert_equal bbox[1], changeset["min_lat"].to_f, "min lat"
2416 assert_equal bbox[2], changeset["max_lon"].to_f, "max lon"
2417 assert_equal bbox[3], changeset["max_lat"].to_f, "max lat"
2421 # update the changeset_id of a way element
2422 def update_changeset(xml, changeset_id)
2423 xml_attr_rewrite(xml, "changeset", changeset_id)
2427 # update an attribute in a way element
2428 def xml_attr_rewrite(xml, name, value)
2429 xml.find("//osm/way").first[name] = value.to_s
2434 # check the result of a list
2435 def check_list_result(changesets)
2436 changesets = changesets.where("num_changes > 0")
2437 .order(:created_at => :desc)
2439 assert changesets.size <= 20
2441 assert_select "ol.changesets", :count => [changesets.size, 1].min do
2442 assert_select "li", :count => changesets.size
2444 changesets.each do |changeset|
2445 assert_select "li#changeset_#{changeset.id}", :count => 1
2451 # check the result of a feed
2452 def check_feed_result(changesets)
2453 changesets = changesets.where("num_changes > 0")
2454 .order(:created_at => :desc)
2456 assert changesets.size <= 20
2458 assert_select "feed", :count => [changesets.size, 1].min do
2459 assert_select "> title", :count => 1, :text => /^Changesets/
2460 assert_select "> entry", :count => changesets.size
2462 changesets.each do |changeset|
2463 assert_select "> entry > id", changeset_url(:id => changeset.id)