test/models/user_test.rb

   1 # frozen_string_literal: true
   2
   3 require "test_helper"
   4
   5 class UserTest < ActiveSupport::TestCase
   6   include Rails::Dom::Testing::Assertions::SelectorAssertions
   7
   8   def test_invalid_with_empty_attributes
   9     user = build(:user, :email => nil,
  10                         :pass_crypt => nil,
  11                         :display_name => nil,
  12                         :home_lat => nil,
  13                         :home_lon => nil,
  14                         :home_zoom => nil)
  15     assert_not_predicate user, :valid?
  16     assert_predicate user.errors[:email], :any?
  17     assert_predicate user.errors[:pass_crypt], :any?
  18     assert_predicate user.errors[:display_name], :any?
  19     assert_predicate user.errors[:home_lat], :none?
  20     assert_predicate user.errors[:home_lon], :none?
  21     assert_predicate user.errors[:home_zoom], :none?
  22   end
  23
  24   def test_unique_email
  25     existing_user = create(:user)
  26     new_user = build(:user, :email => existing_user.email)
  27     assert_not new_user.save
  28     assert_includes new_user.errors[:email], "has already been taken"
  29   end
  30
  31   def test_unique_display_name
  32     create(:user, :display_name => "H\u{e9}nryIV")
  33
  34     %W[H\u{e9}nryIV he\u{301}nryiv H\u{c9}nry\u2163 he\u{301}nry\u2173].each do |name|
  35       new_user = build(:user, :display_name => name)
  36       assert_not new_user.save
  37       assert_includes new_user.errors[:display_name], "has already been taken"
  38     end
  39   end
  40
  41   def test_email_valid
  42     ok = %w[a@s.com test@shaunmcdonald.me.uk hello_local@ping-d.ng
  43             test_local@openstreetmap.org test-local@example.com]
  44     bad = %w[hi ht@ n@ @.com help@.me.uk help"hi.me.uk も対@応します
  45              輕觸搖晃的遊戲@ah.com も対応します@s.name]
  46
  47     ok.each do |name|
  48       user = build(:user)
  49       user.email = name
  50       assert user.valid?(:save), "#{name} isn't valid when it should be"
  51     end
  52
  53     bad.each do |name|
  54       user = build(:user)
  55       user.email = name
  56       assert user.invalid?(:save), "#{name} is valid when it shouldn't be"
  57     end
  58   end
  59
  60   def test_display_name_length
  61     user = build(:user)
  62     user.display_name = "123"
  63     assert_predicate user, :valid?, "should allow 3 char name name"
  64     user.display_name = "12"
  65     assert_not_predicate user, :valid?, "should not allow 2 char name"
  66     user.display_name = ""
  67     assert_not_predicate user, :valid?, "should not allow blank/0 char name"
  68     user.display_name = nil
  69     assert_not_predicate user, :valid?, "should not allow nil value"
  70   end
  71
  72   def test_display_name_width
  73     user = build(:user)
  74     user.display_name = "123"
  75     assert_predicate user, :valid?, "should allow 3 column name name"
  76     user.display_name = "12"
  77     assert_not_predicate user, :valid?, "should not allow 2 column name"
  78     user.display_name = "1\u{200B}2"
  79     assert_not_predicate user, :valid?, "should not allow 2 column name"
  80     user.display_name = "\u{200B}\u{200B}\u{200B}"
  81     assert_not_predicate user, :valid?, "should not allow 0 column name"
  82   end
  83
  84   def test_display_name_valid
  85     # Due to sanitisation in the view some of these that you might not
  86     # expect are allowed
  87     # However, would they affect the xml planet dumps?
  88     ok = ["Name", "'me", "he\"", "<hr>", "*ho", "\"help\"@",
  89           "vergrößern", "ルシステムにも対応します", "輕觸搖晃的遊戲", "space space"]
  90     # These need to be 3 chars in length, otherwise the length test above
  91     # should be used.
  92     bad = ["<hr/>", "test@example.com", "s/f", "aa/", "aa;", "aa.",
  93            "aa,", "aa?", "/;.,?", "も対応します/", "#ping",
  94            "foo\x1fbar", "foo\x7fbar", "foo\ufffebar", "foo\uffffbar",
  95            "new", "terms", "save", "confirm", "confirm-email",
  96            "go_public", "reset-password", "forgot-password", "suspended",
  97            "trailing whitespace ", " leading whitespace"]
  98     ok.each do |display_name|
  99       user = build(:user)
 100       user.display_name = display_name
 101       assert_predicate user, :valid?, "#{display_name} is invalid, when it should be"
 102     end
 103
 104     bad.each do |display_name|
 105       user = build(:user)
 106       user.display_name = display_name
 107       assert_not_predicate user, :valid?, "#{display_name} is valid when it shouldn't be"
 108     end
 109   end
 110
 111   def test_display_name_user_id_new
 112     existing_user = create(:user)
 113     user = build(:user)
 114
 115     user.display_name = "user_#{existing_user.id}"
 116     assert_not_predicate user, :valid?, "user_<id> name is valid for existing user id when it shouldn't be"
 117
 118     user.display_name = "user_#{existing_user.id + 1}"
 119     assert_not_predicate user, :valid?, "user_<id> name is valid for new user id when it shouldn't be"
 120   end
 121
 122   def test_display_name_user_id_rename
 123     existing_user = create(:user)
 124     user = create(:user)
 125
 126     user.display_name = "user_#{existing_user.id}"
 127     assert_not_predicate user, :valid?, "user_<id> name is valid for existing user id when it shouldn't be"
 128
 129     user.display_name = "user_#{user.id}"
 130     assert_predicate user, :valid?, "user_<id> name is invalid for own id, when it should be"
 131   end
 132
 133   def test_display_name_user_id_unchanged_is_valid
 134     user = build(:user, :display_name => "user_0")
 135     user.save(:validate => false)
 136     user.reload
 137
 138     assert_predicate user, :valid?, "user_0 display_name is invalid but it hasn't been changed"
 139   end
 140
 141   def test_description_length
 142     user = build(:user)
 143     user.description = "x" * 65536
 144     assert_predicate user, :valid?, "should allow 65536 char description"
 145     user.description = "x" * 65537
 146     assert_not_predicate user, :valid?, "should not allow 65537 char description"
 147     user.description = ""
 148     assert_predicate user, :valid?, "should allow blank/0 char description"
 149     user.description = nil
 150     assert_predicate user, :valid?, "should allow nil value"
 151   end
 152
 153   def test_spam_score
 154     user = build(:user, :description => "foo [bar](http://example.com/) baz")
 155     assert_equal 12, user.spam_score
 156   end
 157
 158   def test_suspend_if_possible
 159     active = create(:user, :active)
 160     active.suspend_if_possible!
 161     assert_equal "suspended", active.reload.status
 162
 163     confirmed = create(:user, :confirmed)
 164     confirmed.suspend_if_possible!
 165     assert_equal "suspended", confirmed.reload.status
 166
 167     suspended = create(:user, :suspended)
 168     suspended.suspend_if_possible!
 169     assert_equal "suspended", suspended.reload.status
 170   end
 171
 172   def test_follows
 173     alice = create(:user, :active)
 174     bob = create(:user, :active)
 175     charlie = create(:user, :active)
 176     create(:follow, :follower => alice, :following => bob)
 177
 178     assert alice.follows?(bob)
 179     assert_not alice.follows?(charlie)
 180     assert_not bob.follows?(alice)
 181     assert_not bob.follows?(charlie)
 182     assert_not charlie.follows?(bob)
 183     assert_not charlie.follows?(alice)
 184   end
 185
 186   def test_users_nearby
 187     alice = create(:user, :active, :home_lat => 51.0, :home_lon => 1.0, :data_public => false)
 188     bob = create(:user, :active, :home_lat => 51.1, :home_lon => 1.0, :data_public => true)
 189     charlie = create(:user, :active, :home_lat => 51.1, :home_lon => 1.1, :data_public => true)
 190     david = create(:user, :active, :home_lat => 10.0, :home_lon => -123.0, :data_public => true)
 191     _edward = create(:user, :suspended, :home_lat => 10.0, :home_lon => -123.0, :data_public => true)
 192     south_pole_user = create(:user, :active, :home_lat => -90.0, :home_lon => 0.0, :data_public => true)
 193     vagrant_user = create(:user, :active, :home_lat => nil, :home_lon => nil, :data_public => true)
 194
 195     # bob and charlie are both near alice
 196     assert_equal [bob, charlie], alice.nearby
 197     # charlie and alice are both near bob, but alice has their data private
 198     assert_equal [charlie], bob.nearby
 199     # david has no user nearby, since edward is not active
 200     assert_empty david.nearby
 201     # south_pole_user has no user nearby, and doesn't throw exception
 202     assert_empty south_pole_user.nearby
 203     # vagrant_user has no home location
 204     assert_empty vagrant_user.nearby
 205   end
 206
 207   def test_friends
 208     norm = create(:user, :active)
 209     sec = create(:user, :active)
 210     create(:follow, :follower => norm, :following => sec)
 211
 212     assert_equal [sec], norm.followings
 213     assert_equal 1, norm.followings.size
 214
 215     assert_empty sec.followings
 216     assert_equal 0, sec.followings.size
 217   end
 218
 219   def test_user_preferred_editor
 220     user = create(:user)
 221     assert_nil user.preferred_editor
 222     user.preferred_editor = "id"
 223     assert_equal "id", user.preferred_editor
 224     user.save!
 225
 226     user.preferred_editor = "invalid_editor"
 227     assert_raise(ActiveRecord::RecordInvalid) { user.save! }
 228   end
 229
 230   def test_heatmap_public_by_default
 231     # A bit roundabout, but want to make sure that
 232     # the factory doesn't betray us here by setting
 233     # a default value.
 234     attrs = attributes_for(:user)
 235     attrs.delete(:public_heatmap)
 236     user = User.new(attrs)
 237     user.save!
 238     assert_predicate user, :public_heatmap?
 239   end
 240
 241   def test_visible
 242     pending = create(:user, :pending)
 243     active = create(:user, :active)
 244     confirmed = create(:user, :confirmed)
 245     suspended = create(:user, :suspended)
 246     deleted = create(:user, :deleted)
 247
 248     assert User.visible.find(pending.id)
 249     assert User.visible.find(active.id)
 250     assert User.visible.find(confirmed.id)
 251     assert_raise ActiveRecord::RecordNotFound do
 252       User.visible.find(suspended.id)
 253     end
 254     assert_raise ActiveRecord::RecordNotFound do
 255       User.visible.find(deleted.id)
 256     end
 257   end
 258
 259   def test_active
 260     pending = create(:user, :pending)
 261     active = create(:user, :active)
 262     confirmed = create(:user, :confirmed)
 263     suspended = create(:user, :suspended)
 264     deleted = create(:user, :deleted)
 265
 266     assert User.active.find(active.id)
 267     assert User.active.find(confirmed.id)
 268     assert_raise ActiveRecord::RecordNotFound do
 269       User.active.find(pending.id)
 270     end
 271     assert_raise ActiveRecord::RecordNotFound do
 272       User.active.find(suspended.id)
 273     end
 274     assert_raise ActiveRecord::RecordNotFound do
 275       User.active.find(deleted.id)
 276     end
 277   end
 278
 279   def test_identifiable
 280     public_user = create(:user, :data_public => true)
 281     private_user = create(:user, :data_public => false)
 282
 283     assert User.identifiable.find(public_user.id)
 284     assert_raise ActiveRecord::RecordNotFound do
 285       User.identifiable.find(private_user.id)
 286     end
 287   end
 288
 289   def test_languages
 290     user = create(:user, :languages => ["en"])
 291     assert_equal ["en"], user.languages
 292     user.languages = %w[de fr en]
 293     assert_equal %w[de fr en], user.languages
 294     user.languages = %w[fr de sl]
 295     assert_equal %w[fr de sl], user.preferred_languages.map(&:to_s)
 296     user = create(:user, :languages => %w[en de])
 297     assert_equal %w[en de], user.languages
 298   end
 299
 300   def test_preferred_color_scheme_nil_if_nothing_selected
 301     user = create(:user)
 302     assert_nil user.preferred_color_scheme(:map, :site)
 303   end
 304
 305   def test_preferred_color_scheme_as_selected
 306     preferences = [
 307       create(:user_preference, :k => "map.color_scheme", :v => "dark"),
 308       create(:user_preference, :k => "site.color_scheme", :v => "light")
 309     ]
 310     user = create(:user, :preferences => preferences)
 311
 312     assert_equal "dark", user.preferred_color_scheme(:map, :site)
 313   end
 314
 315   def test_preferred_color_scheme_fallback_if_auto
 316     preferences = [
 317       create(:user_preference, :k => "map.color_scheme", :v => "auto"),
 318       create(:user_preference, :k => "site.color_scheme", :v => "light")
 319     ]
 320     user = create(:user, :preferences => preferences)
 321
 322     assert_nil user.preferred_color_scheme(:map)
 323     assert_equal "light", user.preferred_color_scheme(:map, :site)
 324   end
 325
 326   def test_preferred_color_scheme_fallback_if_missing
 327     preferences = [
 328       create(:user_preference, :k => "site.color_scheme", :v => "light")
 329     ]
 330     user = create(:user, :preferences => preferences)
 331
 332     assert_nil user.preferred_color_scheme(:map)
 333     assert_equal "light", user.preferred_color_scheme(:map, :site)
 334   end
 335
 336   def test_default_diary_language_undefined
 337     create(:language, :code => "en")
 338     user = create(:user, :languages => [])
 339     assert_nil user.default_diary_language
 340   end
 341
 342   def test_default_diary_language_known
 343     create(:language, :code => "en")
 344     user = create(:user, :languages => ["en"])
 345     assert_equal "en", user.default_diary_language
 346   end
 347
 348   def test_default_diary_language_known_with_fallback
 349     create(:language, :code => "en")
 350     create(:language, :code => "fr")
 351     user = create(:user, :languages => ["fr en"])
 352     assert_equal "fr", user.default_diary_language
 353   end
 354
 355   def test_default_diary_language_unknown
 356     create(:language, :code => "en")
 357     user = create(:user, :languages => ["unknown"])
 358     assert_nil user.default_diary_language
 359   end
 360
 361   def test_default_diary_language_unknown_with_known_fallback
 362     create(:language, :code => "en")
 363     user = create(:user, :languages => ["unknown en"])
 364     assert_equal "en", user.default_diary_language
 365   end
 366
 367   def test_default_diary_language_set
 368     create(:language, :code => "en")
 369     user = create(:user, :languages => [])
 370
 371     assert_difference "user.preferences.count", 1 do
 372       assert_equal "en", (user.default_diary_language = "en")
 373     end
 374
 375     user.reload
 376     assert_equal "en", user.default_diary_language
 377     preference = user.preferences.find_by(:k => "diary.default_language")
 378     assert_equal "en", preference.v
 379   end
 380
 381   def test_default_diary_language_set_twice
 382     create(:language, :code => "en")
 383     create(:language, :code => "fr")
 384     user = create(:user, :languages => [])
 385
 386     assert_difference "user.preferences.count", 1 do
 387       assert_equal "en", (user.default_diary_language = "en")
 388     end
 389     assert_difference "user.preferences.count", 0 do
 390       assert_equal "fr", (user.default_diary_language = "fr")
 391     end
 392
 393     user.reload
 394     assert_equal "fr", user.default_diary_language
 395     preference = user.preferences.find_by(:k => "diary.default_language")
 396     assert_equal "fr", preference.v
 397   end
 398
 399   def test_visible?
 400     assert_predicate build(:user, :pending), :visible?
 401     assert_predicate build(:user, :active), :visible?
 402     assert_predicate build(:user, :confirmed), :visible?
 403     assert_not_predicate build(:user, :suspended), :visible?
 404     assert_not_predicate build(:user, :deleted), :visible?
 405   end
 406
 407   def test_active?
 408     assert_not_predicate build(:user, :pending), :active?
 409     assert_predicate build(:user, :active), :active?
 410     assert_predicate build(:user, :confirmed), :active?
 411     assert_not_predicate build(:user, :suspended), :active?
 412     assert_not_predicate build(:user, :deleted), :active?
 413   end
 414
 415   def test_moderator?
 416     assert_not_predicate create(:user), :moderator?
 417     assert_predicate create(:moderator_user), :moderator?
 418   end
 419
 420   def test_administrator?
 421     assert_not_predicate create(:user), :administrator?
 422     assert_predicate create(:administrator_user), :administrator?
 423   end
 424
 425   def test_role?
 426     assert_not create(:user).role?("administrator")
 427     assert_not create(:user).role?("moderator")
 428     assert create(:administrator_user).role?("administrator")
 429     assert create(:moderator_user).role?("moderator")
 430   end
 431
 432   def test_suspend
 433     user = create(:user)
 434     user.suspend
 435     assert_equal "suspended", user.status
 436   end
 437
 438   def test_suspend_closes_issues
 439     user = create(:user)
 440     issue = create(:issue, :reportable => user)
 441     user.suspend
 442     assert_equal "suspended", user.status
 443     assert_equal "resolved", issue.reload.status
 444   end
 445
 446   def test_mark_deleted
 447     user = create(:user)
 448     user.mark_deleted
 449     assert_equal "deleted", user.status
 450   end
 451
 452   def test_mark_deleted_closes_issues
 453     user = create(:user)
 454     issue = create(:issue, :reportable => user)
 455     user.mark_deleted
 456     assert_equal "deleted", user.status
 457     assert_equal "resolved", issue.reload.status
 458   end
 459
 460   def test_soft_destroy
 461     user = create(:user, :with_home_location, :description => "foo")
 462     user.soft_destroy
 463     assert_equal "user_#{user.id}", user.display_name
 464     assert_predicate user.description, :blank?
 465     assert_nil user.home_lat
 466     assert_nil user.home_lon
 467     assert_not_predicate user.avatar, :attached?
 468     assert_equal "deleted", user.status
 469     assert_not_predicate user, :visible?
 470     assert_not_predicate user, :active?
 471   end
 472
 473   def test_soft_destroy_closes_issues
 474     user = create(:user)
 475     issue = create(:issue, :reportable => user)
 476     user.soft_destroy
 477     assert_equal "deleted", user.status
 478     assert_equal "resolved", issue.reload.status
 479   end
 480
 481   def test_soft_destroy_revokes_oauth2_tokens
 482     user = create(:user)
 483     oauth_access_token = create(:oauth_access_token, :user => user)
 484     assert_equal 1, user.access_tokens.not_expired.count
 485
 486     user.soft_destroy
 487
 488     assert_equal 0, user.access_tokens.not_expired.count
 489     oauth_access_token.reload
 490     assert_predicate oauth_access_token, :revoked?
 491   end
 492
 493   def test_deletion_allowed_when_no_changesets
 494     with_user_account_deletion_delay(10000) do
 495       user = create(:user)
 496       assert_predicate user, :deletion_allowed?
 497     end
 498   end
 499
 500   def test_deletion_allowed_without_delay
 501     with_user_account_deletion_delay(nil) do
 502       user = create(:user)
 503       create(:changeset, :user => user)
 504       user.reload
 505       assert_predicate user, :deletion_allowed?
 506     end
 507   end
 508
 509   def test_deletion_allowed_past_delay
 510     with_user_account_deletion_delay(10) do
 511       user = create(:user)
 512       create(:changeset, :user => user, :created_at => Time.now.utc - 12.hours, :closed_at => Time.now.utc - 10.hours)
 513       user.reload
 514       assert_predicate user, :deletion_allowed?
 515     end
 516   end
 517
 518   def test_deletion_allowed_during_delay
 519     with_user_account_deletion_delay(10) do
 520       user = create(:user)
 521       create(:changeset, :user => user, :created_at => Time.now.utc - 11.hours, :closed_at => Time.now.utc - 9.hours)
 522       user.reload
 523       assert_not_predicate user, :deletion_allowed?
 524       assert_equal Time.now.utc + 1.hour, user.deletion_allowed_at
 525     end
 526   end
 527
 528   def test_deletion_allowed_past_zero_delay
 529     with_user_account_deletion_delay(0) do
 530       user = create(:user)
 531       create(:changeset, :user => user, :created_at => Time.now.utc, :closed_at => Time.now.utc + 1.hour)
 532       travel 90.minutes do
 533         user.reload
 534         assert_predicate user, :deletion_allowed?
 535       end
 536     end
 537   end
 538
 539   def test_deletion_allowed_during_zero_delay
 540     with_user_account_deletion_delay(0) do
 541       user = create(:user)
 542       create(:changeset, :user => user, :created_at => Time.now.utc, :closed_at => Time.now.utc + 1.hour)
 543       travel 30.minutes do
 544         user.reload
 545         assert_not_predicate user, :deletion_allowed?
 546         assert_equal Time.now.utc + 30.minutes, user.deletion_allowed_at
 547       end
 548     end
 549   end
 550 end