test/models/changeset_test.rb

   1 # frozen_string_literal: true
   2
   3 require "test_helper"
   4
   5 class ChangesetTest < ActiveSupport::TestCase
   6   def test_num_changes_valid
   7     changeset = create(:changeset)
   8     assert_predicate changeset, :valid?
   9     changeset.num_changes = nil
  10     assert_not_predicate changeset, :valid?
  11     changeset.num_changes = -1
  12     assert_not_predicate changeset, :valid?
  13     changeset.num_changes = 0
  14     assert_predicate changeset, :valid?
  15     changeset.num_changes = 1
  16     assert_predicate changeset, :valid?
  17   end
  18
  19   def test_num_type_changes_valid
  20     [:num_created_nodes, :num_modified_nodes, :num_deleted_nodes,
  21      :num_created_ways, :num_modified_ways, :num_deleted_ways,
  22      :num_created_relations, :num_modified_relations, :num_deleted_relations].each do |counter_attribute|
  23        changeset = create(:changeset)
  24        assert_predicate changeset, :valid?
  25        changeset[counter_attribute] = nil
  26        assert_not_predicate changeset, :valid?
  27        changeset[counter_attribute] = -1
  28        assert_not_predicate changeset, :valid?
  29        changeset[counter_attribute] = 0
  30        assert_predicate changeset, :valid?
  31        changeset[counter_attribute] = 1
  32        assert_predicate changeset, :valid?
  33      end
  34   end
  35
  36   def test_num_type_changes_in_sync_for_new_changeset
  37     changeset = create(:changeset)
  38
  39     assert_equal 0, changeset.num_created_elements
  40     assert_equal 0, changeset.num_modified_elements
  41     assert_equal 0, changeset.num_deleted_elements
  42
  43     assert_equal 0, changeset.num_changed_nodes
  44     assert_equal 0, changeset.num_changed_ways
  45     assert_equal 0, changeset.num_changed_relations
  46
  47     assert_predicate changeset, :num_type_changes_in_sync?
  48   end
  49
  50   def test_num_type_changes_not_in_sync_for_changeset_without_type_changes
  51     changeset = create(:changeset, :num_changes => 1)
  52
  53     assert_equal 0, changeset.num_created_elements
  54     assert_equal 0, changeset.num_modified_elements
  55     assert_equal 0, changeset.num_deleted_elements
  56
  57     assert_equal 0, changeset.num_changed_nodes
  58     assert_equal 0, changeset.num_changed_ways
  59     assert_equal 0, changeset.num_changed_relations
  60
  61     assert_not_predicate changeset, :num_type_changes_in_sync?
  62   end
  63
  64   def test_num_type_changes_in_sync_for_changeset_with_created_nodes
  65     changeset = create(:changeset, :num_changes => 1, :num_created_nodes => 1)
  66
  67     assert_equal 1, changeset.num_created_elements
  68     assert_equal 0, changeset.num_modified_elements
  69     assert_equal 0, changeset.num_deleted_elements
  70
  71     assert_equal 1, changeset.num_changed_nodes
  72     assert_equal 0, changeset.num_changed_ways
  73     assert_equal 0, changeset.num_changed_relations
  74
  75     assert_predicate changeset, :num_type_changes_in_sync?
  76   end
  77
  78   def test_num_type_changes_in_sync_for_changeset_with_modified_nodes
  79     changeset = create(:changeset, :num_changes => 1, :num_modified_nodes => 1)
  80
  81     assert_equal 0, changeset.num_created_elements
  82     assert_equal 1, changeset.num_modified_elements
  83     assert_equal 0, changeset.num_deleted_elements
  84
  85     assert_equal 1, changeset.num_changed_nodes
  86     assert_equal 0, changeset.num_changed_ways
  87     assert_equal 0, changeset.num_changed_relations
  88
  89     assert_predicate changeset, :num_type_changes_in_sync?
  90   end
  91
  92   def test_num_type_changes_in_sync_for_changeset_with_deleted_nodes
  93     changeset = create(:changeset, :num_changes => 1, :num_deleted_nodes => 1)
  94
  95     assert_equal 0, changeset.num_created_elements
  96     assert_equal 0, changeset.num_modified_elements
  97     assert_equal 1, changeset.num_deleted_elements
  98
  99     assert_equal 1, changeset.num_changed_nodes
 100     assert_equal 0, changeset.num_changed_ways
 101     assert_equal 0, changeset.num_changed_relations
 102
 103     assert_predicate changeset, :num_type_changes_in_sync?
 104   end
 105
 106   def test_num_type_changes_in_sync_for_changeset_with_changed_nodes
 107     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 108                                    :num_created_nodes => 3,
 109                                    :num_modified_nodes => 2,
 110                                    :num_deleted_nodes => 1)
 111
 112     assert_equal 3, changeset.num_created_elements
 113     assert_equal 2, changeset.num_modified_elements
 114     assert_equal 1, changeset.num_deleted_elements
 115
 116     assert_equal 3 + 2 + 1, changeset.num_changed_nodes
 117     assert_equal 0, changeset.num_changed_ways
 118     assert_equal 0, changeset.num_changed_relations
 119
 120     assert_predicate changeset, :num_type_changes_in_sync?
 121   end
 122
 123   def test_num_type_changes_in_sync_for_changeset_with_created_ways
 124     changeset = create(:changeset, :num_changes => 1, :num_created_ways => 1)
 125
 126     assert_equal 1, changeset.num_created_elements
 127     assert_equal 0, changeset.num_modified_elements
 128     assert_equal 0, changeset.num_deleted_elements
 129
 130     assert_equal 0, changeset.num_changed_nodes
 131     assert_equal 1, changeset.num_changed_ways
 132     assert_equal 0, changeset.num_changed_relations
 133
 134     assert_predicate changeset, :num_type_changes_in_sync?
 135   end
 136
 137   def test_num_type_changes_in_sync_for_changeset_with_modified_ways
 138     changeset = create(:changeset, :num_changes => 1, :num_modified_ways => 1)
 139
 140     assert_equal 0, changeset.num_created_elements
 141     assert_equal 1, changeset.num_modified_elements
 142     assert_equal 0, changeset.num_deleted_elements
 143
 144     assert_equal 0, changeset.num_changed_nodes
 145     assert_equal 1, changeset.num_changed_ways
 146     assert_equal 0, changeset.num_changed_relations
 147
 148     assert_predicate changeset, :num_type_changes_in_sync?
 149   end
 150
 151   def test_num_type_changes_in_sync_for_changeset_with_deleted_ways
 152     changeset = create(:changeset, :num_changes => 1, :num_deleted_ways => 1)
 153
 154     assert_equal 0, changeset.num_created_elements
 155     assert_equal 0, changeset.num_modified_elements
 156     assert_equal 1, changeset.num_deleted_elements
 157
 158     assert_equal 0, changeset.num_changed_nodes
 159     assert_equal 1, changeset.num_changed_ways
 160     assert_equal 0, changeset.num_changed_relations
 161
 162     assert_predicate changeset, :num_type_changes_in_sync?
 163   end
 164
 165   def test_num_type_changes_in_sync_for_changeset_with_changed_ways
 166     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 167                                    :num_created_ways => 3,
 168                                    :num_modified_ways => 2,
 169                                    :num_deleted_ways => 1)
 170
 171     assert_equal 3, changeset.num_created_elements
 172     assert_equal 2, changeset.num_modified_elements
 173     assert_equal 1, changeset.num_deleted_elements
 174
 175     assert_equal 0, changeset.num_changed_nodes
 176     assert_equal 3 + 2 + 1, changeset.num_changed_ways
 177     assert_equal 0, changeset.num_changed_relations
 178
 179     assert_predicate changeset, :num_type_changes_in_sync?
 180   end
 181
 182   def test_num_type_changes_in_sync_for_changeset_with_created_relations
 183     changeset = create(:changeset, :num_changes => 1, :num_created_relations => 1)
 184
 185     assert_equal 1, changeset.num_created_elements
 186     assert_equal 0, changeset.num_modified_elements
 187     assert_equal 0, changeset.num_deleted_elements
 188
 189     assert_equal 0, changeset.num_changed_nodes
 190     assert_equal 0, changeset.num_changed_ways
 191     assert_equal 1, changeset.num_changed_relations
 192
 193     assert_predicate changeset, :num_type_changes_in_sync?
 194   end
 195
 196   def test_num_type_changes_in_sync_for_changeset_with_modified_relations
 197     changeset = create(:changeset, :num_changes => 1, :num_modified_relations => 1)
 198
 199     assert_equal 0, changeset.num_created_elements
 200     assert_equal 1, changeset.num_modified_elements
 201     assert_equal 0, changeset.num_deleted_elements
 202
 203     assert_equal 0, changeset.num_changed_nodes
 204     assert_equal 0, changeset.num_changed_ways
 205     assert_equal 1, changeset.num_changed_relations
 206
 207     assert_predicate changeset, :num_type_changes_in_sync?
 208   end
 209
 210   def test_num_type_changes_in_sync_for_changeset_with_deleted_relations
 211     changeset = create(:changeset, :num_changes => 1, :num_deleted_relations => 1)
 212
 213     assert_equal 0, changeset.num_created_elements
 214     assert_equal 0, changeset.num_modified_elements
 215     assert_equal 1, changeset.num_deleted_elements
 216
 217     assert_equal 0, changeset.num_changed_nodes
 218     assert_equal 0, changeset.num_changed_ways
 219     assert_equal 1, changeset.num_changed_relations
 220
 221     assert_predicate changeset, :num_type_changes_in_sync?
 222   end
 223
 224   def test_num_type_changes_in_sync_for_changeset_with_changed_relations
 225     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 226                                    :num_created_relations => 3,
 227                                    :num_modified_relations => 2,
 228                                    :num_deleted_relations => 1)
 229
 230     assert_equal 3, changeset.num_created_elements
 231     assert_equal 2, changeset.num_modified_elements
 232     assert_equal 1, changeset.num_deleted_elements
 233
 234     assert_equal 0, changeset.num_changed_nodes
 235     assert_equal 0, changeset.num_changed_ways
 236     assert_equal 3 + 2 + 1, changeset.num_changed_relations
 237
 238     assert_predicate changeset, :num_type_changes_in_sync?
 239   end
 240
 241   def test_num_type_changes_in_sync_for_changeset_with_created_elements
 242     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 243                                    :num_created_nodes => 3,
 244                                    :num_created_ways => 2,
 245                                    :num_created_relations => 1)
 246
 247     assert_equal 3 + 2 + 1, changeset.num_created_elements
 248     assert_equal 0, changeset.num_modified_elements
 249     assert_equal 0, changeset.num_deleted_elements
 250
 251     assert_equal 3, changeset.num_changed_nodes
 252     assert_equal 2, changeset.num_changed_ways
 253     assert_equal 1, changeset.num_changed_relations
 254
 255     assert_predicate changeset, :num_type_changes_in_sync?
 256   end
 257
 258   def test_num_type_changes_in_sync_for_changeset_with_modified_elements
 259     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 260                                    :num_modified_nodes => 3,
 261                                    :num_modified_ways => 2,
 262                                    :num_modified_relations => 1)
 263
 264     assert_equal 0, changeset.num_created_elements
 265     assert_equal 3 + 2 + 1, changeset.num_modified_elements
 266     assert_equal 0, changeset.num_deleted_elements
 267
 268     assert_equal 3, changeset.num_changed_nodes
 269     assert_equal 2, changeset.num_changed_ways
 270     assert_equal 1, changeset.num_changed_relations
 271
 272     assert_predicate changeset, :num_type_changes_in_sync?
 273   end
 274
 275   def test_num_type_changes_in_sync_for_changeset_with_deleted_elements
 276     changeset = create(:changeset, :num_changes => 3 + 2 + 1,
 277                                    :num_deleted_nodes => 3,
 278                                    :num_deleted_ways => 2,
 279                                    :num_deleted_relations => 1)
 280
 281     assert_equal 0, changeset.num_created_elements
 282     assert_equal 0, changeset.num_modified_elements
 283     assert_equal 3 + 2 + 1, changeset.num_deleted_elements
 284
 285     assert_equal 3, changeset.num_changed_nodes
 286     assert_equal 2, changeset.num_changed_ways
 287     assert_equal 1, changeset.num_changed_relations
 288
 289     assert_predicate changeset, :num_type_changes_in_sync?
 290   end
 291
 292   def test_num_type_changes_in_sync_for_changeset_with_changed_elements
 293     changeset = create(:changeset, :num_changes => 33 + 32 + 31 + 23 + 22 + 21 + 13 + 12 + 11,
 294                                    :num_created_nodes => 33,
 295                                    :num_created_ways => 32,
 296                                    :num_created_relations => 31,
 297                                    :num_modified_nodes => 23,
 298                                    :num_modified_ways => 22,
 299                                    :num_modified_relations => 21,
 300                                    :num_deleted_nodes => 13,
 301                                    :num_deleted_ways => 12,
 302                                    :num_deleted_relations => 11)
 303
 304     assert_equal 33 + 32 + 31, changeset.num_created_elements
 305     assert_equal 23 + 22 + 21, changeset.num_modified_elements
 306     assert_equal 13 + 12 + 11, changeset.num_deleted_elements
 307
 308     assert_equal 33 + 23 + 13, changeset.num_changed_nodes
 309     assert_equal 32 + 22 + 12, changeset.num_changed_ways
 310     assert_equal 31 + 21 + 11, changeset.num_changed_relations
 311
 312     assert_predicate changeset, :num_type_changes_in_sync?
 313   end
 314
 315   def test_actual_num_changed_elements_in_sync
 316     changeset = create(:changeset, :num_changes => 5 + 4 + 3,
 317                                    :num_created_nodes => 5,
 318                                    :num_created_ways => 4,
 319                                    :num_created_relations => 3)
 320     create_list(:old_node, 5, :changeset => changeset)
 321     create_list(:old_way, 4, :changeset => changeset)
 322     create_list(:old_relation, 3, :changeset => changeset)
 323
 324     assert_predicate changeset, :num_type_changes_in_sync?
 325
 326     assert_equal 5, changeset.actual_num_changed_nodes
 327     assert_equal 4, changeset.actual_num_changed_ways
 328     assert_equal 3, changeset.actual_num_changed_relations
 329   end
 330
 331   def test_actual_num_changed_elements_out_of_sync
 332     changeset = create(:changeset, :num_changes => 5 + 4 + 3)
 333     create_list(:old_node, 5, :changeset => changeset)
 334     create_list(:old_way, 4, :changeset => changeset)
 335     create_list(:old_relation, 3, :changeset => changeset)
 336
 337     assert_not_predicate changeset, :num_type_changes_in_sync?
 338
 339     assert_equal 5, changeset.actual_num_changed_nodes
 340     assert_equal 4, changeset.actual_num_changed_ways
 341     assert_equal 3, changeset.actual_num_changed_relations
 342   end
 343
 344   def test_from_xml_no_text
 345     no_text = ""
 346     message_create = assert_raise(OSM::APIBadXMLError) do
 347       Changeset.from_xml(no_text, :create => true)
 348     end
 349     assert_match(/Must specify a string with one or more characters/, message_create.message)
 350     message_update = assert_raise(OSM::APIBadXMLError) do
 351       Changeset.from_xml(no_text, :create => false)
 352     end
 353     assert_match(/Must specify a string with one or more characters/, message_update.message)
 354   end
 355
 356   def test_from_xml_no_changeset
 357     nocs = "<osm></osm>"
 358     message_create = assert_raise(OSM::APIBadXMLError) do
 359       Changeset.from_xml(nocs, :create => true)
 360     end
 361     assert_match %r{XML doesn't contain an osm/changeset element}, message_create.message
 362     message_update = assert_raise(OSM::APIBadXMLError) do
 363       Changeset.from_xml(nocs, :create => false)
 364     end
 365     assert_match %r{XML doesn't contain an osm/changeset element}, message_update.message
 366   end
 367
 368   def test_from_xml_no_k_v
 369     nokv = "<osm><changeset><tag /></changeset></osm>"
 370     message_create = assert_raise(OSM::APIBadXMLError) do
 371       Changeset.from_xml(nokv, :create => true)
 372     end
 373     assert_match(/tag is missing key/, message_create.message)
 374     message_update = assert_raise(OSM::APIBadXMLError) do
 375       Changeset.from_xml(nokv, :create => false)
 376     end
 377     assert_match(/tag is missing key/, message_update.message)
 378   end
 379
 380   def test_from_xml_no_v
 381     no_v = "<osm><changeset><tag k='key' /></changeset></osm>"
 382     message_create = assert_raise(OSM::APIBadXMLError) do
 383       Changeset.from_xml(no_v, :create => true)
 384     end
 385     assert_match(/tag is missing value/, message_create.message)
 386     message_update = assert_raise(OSM::APIBadXMLError) do
 387       Changeset.from_xml(no_v, :create => false)
 388     end
 389     assert_match(/tag is missing value/, message_update.message)
 390   end
 391
 392   def test_from_xml_duplicate_k
 393     dupk = "<osm><changeset><tag k='dup' v='test' /><tag k='dup' v='value' /></changeset></osm>"
 394     message_create = assert_raise(OSM::APIDuplicateTagsError) do
 395       Changeset.from_xml(dupk, :create => true)
 396     end
 397     assert_equal "Element changeset/ has duplicate tags with key dup", message_create.message
 398     message_update = assert_raise(OSM::APIDuplicateTagsError) do
 399       Changeset.from_xml(dupk, :create => false)
 400     end
 401     assert_equal "Element changeset/ has duplicate tags with key dup", message_update.message
 402   end
 403
 404   def test_from_xml_valid
 405     # Example taken from the Update section on the API_v0.6 docs on the wiki
 406     xml = "<osm><changeset><tag k=\"comment\" v=\"Just adding some streetnames and a restaurant\"/></changeset></osm>"
 407     assert_nothing_raised do
 408       Changeset.from_xml(xml, :create => false)
 409     end
 410     assert_nothing_raised do
 411       Changeset.from_xml(xml, :create => true)
 412     end
 413   end
 414 end