Tidy up code for adding a map to the changeset list page

[rails.git] / public / javascripts / map.js

diff --git a/public/javascripts/map.js b/public/javascripts/map.js
index df9d30992c7a8751bdfe59bcc836a7e465a06049..66ed9e909492ca0efc6c3950cf64f617aa5d5c0c 100644 (file)
--- a/public/javascripts/map.js
+++ b/public/javascripts/map.js
@@ -149,7 +149,7 @@ function addObjectToMap(url, zoom, callback) {
    layer.loadGML();
 }
 
-function addBoxToMap(boxbounds, attributes, line) {
+function addBoxToMap(boxbounds, id, outline) {
    if (!vectors) {
      // Be aware that IE requires Vector layers be initialised on page load, and not under deferred script conditions
      vectors = new OpenLayers.Layer.Vector("Boxes", {
@@ -157,20 +157,20 @@ function addBoxToMap(boxbounds, attributes, line) {
      });
      map.addLayer(vectors);
    }
-
    var geometry;
-   if (line) {
+   if (outline) {
      vertices = boxbounds.toGeometry().getVertices();
-     vertices.push( new OpenLayers.Geometry.Point( vertices[0].x, vertices[0].y ) );
+     vertices.push(new OpenLayers.Geometry.Point(vertices[0].x, vertices[0].y));
      geometry = new OpenLayers.Geometry.LineString(vertices).transform(epsg4326, map.getProjectionObject());
    } else {
      geometry = boxbounds.toGeometry().transform(epsg4326, map.getProjectionObject());
-   }  
-   var box = new OpenLayers.Feature.Vector(geometry, attributes, {
+   }
+   var box = new OpenLayers.Feature.Vector(geometry, {}, {
       strokeWidth: 2,
       strokeColor: '#ee9900',
       fillOpacity: 0
    });
+   box.fid = id;
 
    vectors.addFeatures(box);