Avoid using format as a URL parameter name

[rails.git] / test / models / note_test.rb

diff --git a/test/models/note_test.rb b/test/models/note_test.rb
index 441f52eb6b8a0036c3fc1a60a8b263c912785d87..0abd0136ee68760fc8aa72071ccb0d5e8c29c226 100644 (file)
--- a/test/models/note_test.rb
+++ b/test/models/note_test.rb
@@ -2,11 +2,9 @@
 require "test_helper"
 
 class NoteTest < ActiveSupport::TestCase
-  fixtures :users
-
   def test_status_valid
-    ok = %w(open closed hidden)
-    bad = %w(expropriated fubared)
+    ok = %w[open closed hidden]
+    bad = %w[expropriated fubared]
 
     ok.each do |status|
       note = create(:note)
@@ -51,16 +49,19 @@ class NoteTest < ActiveSupport::TestCase
   end
 
   def test_author
-    anonymous_comment = create(:note_comment)
-    assert_nil anonymous_comment.note.author
-    comment = create(:note_comment, :author_id => users(:normal_user).id)
-    assert_equal users(:normal_user), comment.note.author
+    comment = create(:note_comment)
+    assert_nil comment.note.author
+
+    user = create(:user)
+    comment = create(:note_comment, :author => user)
+    assert_equal user, comment.note.author
   end
 
   def test_author_ip
+    comment = create(:note_comment)
+    assert_nil comment.note.author_ip
+
     comment = create(:note_comment, :author_ip => IPAddr.new("192.168.1.1"))
     assert_equal IPAddr.new("192.168.1.1"), comment.note.author_ip
-    comment = create(:note_comment, :author_ip => nil)
-    assert_nil comment.note.author_ip
   end
 end