Added exit counts as seperate keys in locale file
authorJ Guthrie <jamie.guthrie@gmail.com>
Wed, 25 Apr 2018 23:35:41 +0000 (00:35 +0100)
committerJ Guthrie <jamie.guthrie@gmail.com>
Wed, 25 Apr 2018 23:43:01 +0000 (00:43 +0100)
app/assets/javascripts/index/directions/osrm.js
config/locales/en.yml

index 6e7a6de..e249ce1 100644 (file)
@@ -60,19 +60,11 @@ function OSRMEngine() {
         'depart': 8,
         'arrive': 14
       };
-      var convertExitNumber = function(exitNum) {
-        var j = exitNum % 10,
-        k = exitNum % 100;
-        if (j === 1 && k !== 11) {
-            return exitNum + "st";
+      var numToWord = function(num) {
+        if(num > 10) {
+          num = 11;
         }
-        if (j === 2 && k !== 12) {
-            return exitNum + "nd";
-        }
-        if (j === 3 && k !== 13) {
-            return exitNum + "rd";
-        }
-        return exitNum + "th";
+        return ["zero", "one", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten", "gt_ten"][num];
       };
       var transformed_steps = input_steps.map(function(step, idx) {
         var maneuver_id;
@@ -126,7 +118,7 @@ function OSRMEngine() {
 
         if (step.maneuver.type.match(/rotary|roundabout/)) {
           if (step.maneuver.exit) {
-            instText += I18n.t(template + '_with_exit', { exit: convertExitNumber(step.maneuver.exit), name: name } );
+            instText += I18n.t(template + '_with_exit', { exit: I18n.t('javascripts.directions.instructions.exit_counts.' + numToWord(step.maneuver.exit)), name: name } );
           } else {
             instText += I18n.t(template + '_without_exit', { name: name } );
           }
index 3297185..2c1ac01 100644 (file)
@@ -2382,6 +2382,18 @@ en:
         continue_with_exit: At roundabout continue straight onto %{name}
         unnamed: "unnamed road"
         courtesy: "Directions courtesy of %{link}"
+        exit_counts:
+          one: "1st"
+          two: "2nd"
+          three: "3rd"
+          four: "4th"
+          five: "5th"
+          six: "6th"
+          seven: "7th"
+          eight: "8th"
+          nine: "9th"
+          ten: "10th"
+          gt_ten: ""
       time: "Time"
     query:
       node: Node