Rename xml processing methods with an update_ prefix
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 30 Aug 2017 10:40:54 +0000 (11:40 +0100)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 30 Aug 2017 10:40:54 +0000 (11:40 +0100)
They behave differently from the other from_xml methods on other models.

app/controllers/trace_controller.rb
app/models/trace.rb

index 4e10a6c..41c488e 100644 (file)
@@ -263,7 +263,7 @@ class TraceController < ApplicationController
     trace = Trace.visible.find(params[:id])
 
     if trace.user == current_user
-      trace.from_xml(request.raw_post)
+      trace.update_from_xml(request.raw_post)
       trace.save!
 
       head :ok
index b7b96c6..160060a 100644 (file)
@@ -172,12 +172,12 @@ class Trace < ActiveRecord::Base
     el1
   end
 
-  def from_xml(xml, create = false)
+  def update_from_xml(xml, create = false)
     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse
 
     doc.find("//osm/gpx_file").each do |pt|
-      return from_xml_node(pt, create)
+      return update_from_xml_node(pt, create)
     end
 
     raise OSM::APIBadXMLError.new("trace", xml, "XML doesn't contain an osm/gpx_file element.")
@@ -185,7 +185,7 @@ class Trace < ActiveRecord::Base
     raise OSM::APIBadXMLError.new("trace", xml, ex.message)
   end
 
-  def from_xml_node(pt, create = false)
+  def update_from_xml_node(pt, create = false)
     raise OSM::APIBadXMLError.new("trace", pt, "visibility missing") if pt["visibility"].nil?
     self.visibility = pt["visibility"]