Moved find_token method into the token class, since that seems a more appropriate...
authorMatt Amos <zerebubuth@gmail.com>
Mon, 3 Aug 2009 14:00:29 +0000 (14:00 +0000)
committerMatt Amos <zerebubuth@gmail.com>
Mon, 3 Aug 2009 14:00:29 +0000 (14:00 +0000)
app/models/client_application.rb
app/models/oauth_token.rb
test/unit/client_application_test.rb [deleted file]
test/unit/oauth_token_test.rb
vendor/plugins/oauth-plugin/lib/oauth/rails/controller_methods.rb

index 2186dc5dfc367abf152b824d9a44c6b02bc20615..d3799abe00a483db593d68ef2e6bc4e8d07c4de0 100644 (file)
@@ -6,16 +6,6 @@ class ClientApplication < ActiveRecord::Base
   validates_uniqueness_of :key
   before_validation_on_create :generate_keys
   
-  def self.find_token(token_key)
-    token = OauthToken.find_by_token(token_key, :include => :client_application)
-    if token && token.authorized?
-      logger.info "Loaded #{token.token} which was authorized by (user_id=#{token.user_id}) on the #{token.authorized_at}"
-      token
-    else
-      nil
-    end
-  end
-  
   def self.verify_request(request, options = {}, &block)
     begin
       signature = OAuth::Signature.build(request, options, &block)
index 5fca40ce203e425965a59a222615976cf70eb5e4..f64ec53dbaf4869712d0b2bd1abc1f19a1dd1870 100644 (file)
@@ -5,6 +5,16 @@ class OauthToken < ActiveRecord::Base
   validates_presence_of :client_application, :token, :secret
   before_validation_on_create :generate_keys
   
+  def self.find_token(token_key)
+    token = OauthToken.find_by_token(token_key, :include => :client_application)
+    if token && token.authorized?
+      logger.info "Loaded #{token.token} which was authorized by (user_id=#{token.user_id}) on the #{token.authorized_at}"
+      token
+    else
+      nil
+    end
+  end
+  
   def invalidated?
     invalidated_at != nil
   end
diff --git a/test/unit/client_application_test.rb b/test/unit/client_application_test.rb
deleted file mode 100644 (file)
index 213d4d2..0000000
+++ /dev/null
@@ -1,17 +0,0 @@
-require File.dirname(__FILE__) + '/../test_helper'
-
-class ClientApplicationTest < ActiveSupport::TestCase
-  api_fixtures
-
-  ##
-  # test that tokens can't be found unless they're authorised
-  def test_find_token
-    tok = client_applications(:oauth_web_app).create_request_token
-    assert_equal false, tok.authorized?, "Token should be created unauthorised."
-    assert_equal nil, ClientApplication.find_token(tok.token), "Shouldn't be able to find unauthorised token"
-    tok.authorize!(users(:public_user))
-    assert_equal true, tok.authorized?, "Token should now be authorised."
-    assert_not_equal nil, ClientApplication.find_token(tok.token), "Should be able to find authorised token"
-  end
-
-end
index eb8219c57fe208c50b51f298148d0c6a8dc49186..655e64eda18ad956a11fda5a6c5333bf5426b470 100644 (file)
@@ -23,4 +23,15 @@ class OauthTokenTest < ActiveSupport::TestCase
     assert_equal false, tok.authorized?, "Token should now be invalid."
   end
 
+  ##
+  # test that tokens can't be found unless they're authorised
+  def test_find_token
+    tok = client_applications(:oauth_web_app).create_request_token
+    assert_equal false, tok.authorized?, "Token should be created unauthorised."
+    assert_equal nil, OauthToken.find_token(tok.token), "Shouldn't be able to find unauthorised token"
+    tok.authorize!(users(:public_user))
+    assert_equal true, tok.authorized?, "Token should now be authorised."
+    assert_not_equal nil, OauthToken.find_token(tok.token), "Should be able to find authorised token"
+  end
+
 end
index 668328b7e79fad807610e55f086313c5822fb977..68ef9d224738ecb9420247525865e9bc67a94625 100644 (file)
@@ -96,7 +96,7 @@ module OAuth
       def verify_oauth_signature
         begin
           valid = ClientApplication.verify_request(request) do |request|
-            self.current_token = ClientApplication.find_token(request.token)
+            self.current_token = OauthToken.find_token(request.token)
             logger.info "self=#{self.class.to_s}"
             logger.info "token=#{self.current_token}"
             # return the token secret and the consumer secret
@@ -111,4 +111,4 @@ module OAuth
       end
     end
   end
-end
\ No newline at end of file
+end