Matt Amos [Fri, 7 Nov 2008 11:36:00 +0000 (11:36 +0000)]
D'oh! Fixed stupid errors in changeset controller.
Andy Allan [Fri, 7 Nov 2008 11:21:46 +0000 (11:21 +0000)]
users fixtures should all have creation times
Andy Allan [Fri, 7 Nov 2008 11:20:25 +0000 (11:20 +0000)]
Booleans should be true/false for compatibility with other db adapters
Matt Amos [Thu, 6 Nov 2008 19:10:19 +0000 (19:10 +0000)]
Ooops. Added missing access control to changeset controller.
Matt Amos [Thu, 6 Nov 2008 18:42:06 +0000 (18:42 +0000)]
Added a changeset/#id/include method to POST to to expand the bounding box.
Matt Amos [Thu, 6 Nov 2008 17:56:24 +0000 (17:56 +0000)]
Implemented changeset bounding box handling for relations, based on the conversation on the mailing list. Its a bit complex...
Shaun McDonald [Thu, 6 Nov 2008 17:15:22 +0000 (17:15 +0000)]
Doing the update version part of the migration in chunks of 10000 instead of all at once so that MySQL doesn't choke with running out of table locks.
Shaun McDonald [Thu, 6 Nov 2008 14:20:07 +0000 (14:20 +0000)]
Removing depricated config option in the development env
Shaun McDonald [Wed, 5 Nov 2008 18:42:38 +0000 (18:42 +0000)]
Fixing the migration so that it will better match the live databetter.
Matt Amos [Tue, 4 Nov 2008 15:52:22 +0000 (15:52 +0000)]
Added first attempt at bounding box support in changesets and tests for the same.
Shaun McDonald [Tue, 4 Nov 2008 13:54:45 +0000 (13:54 +0000)]
Minor fix (integer => bigint) to one of the migrations so that they will run fully again.
Shaun McDonald [Mon, 3 Nov 2008 18:54:19 +0000 (18:54 +0000)]
Adding an extra test to make sure that the correct response is returned when an invalid changeset action is uploaded.
Shaun McDonald [Mon, 3 Nov 2008 18:05:19 +0000 (18:05 +0000)]
Additional api tests for the changes. Also making sure that you cannot request a change of 0 length, so that you can detect erronious input.
Shaun McDonald [Mon, 3 Nov 2008 00:12:18 +0000 (00:12 +0000)]
Adding a restriction to prevent more than 2000 nodes to be added to any way. Tests still need to be written. Capabilities api request also updated.
Shaun McDonald [Fri, 31 Oct 2008 18:02:12 +0000 (18:02 +0000)]
Add a description meta tag for the all web pages. Wording probably needs to be improved.
Shaun McDonald [Thu, 30 Oct 2008 18:50:45 +0000 (18:50 +0000)]
Starting the gpx trace testing with additional fixtures
Matt Amos [Wed, 29 Oct 2008 16:27:15 +0000 (16:27 +0000)]
Added custom validator for UTF-8 strings.
Shaun McDonald [Wed, 29 Oct 2008 15:45:48 +0000 (15:45 +0000)]
add a comment about why the error handler is required, as per mail from TomH. Also adding the option so that we are using the old style of migrations, rather than the 2.1+ migrations.
Matt Amos [Wed, 29 Oct 2008 15:33:23 +0000 (15:33 +0000)]
Better error message and test for invalid UTF-8 sequences.
Shaun McDonald [Tue, 28 Oct 2008 20:42:48 +0000 (20:42 +0000)]
Updating to use Rails 2.1.2. Moving the gem dependancies to the config/environment.rb file. Moving the vendor/plugins externals into our svn.
Andy Allan [Tue, 28 Oct 2008 18:34:05 +0000 (18:34 +0000)]
message title shouldn't accept invalid utf-8 sequences - test currently fails
Matt Amos [Tue, 28 Oct 2008 15:01:17 +0000 (15:01 +0000)]
Made full test a bit more thorough.
Matt Amos [Tue, 28 Oct 2008 14:49:51 +0000 (14:49 +0000)]
Added tests for relations for way/relation and a bit of DRYing up.
Shaun McDonald [Tue, 28 Oct 2008 12:49:51 +0000 (12:49 +0000)]
Adding stub functional test files for all the controllers that should have tests written for them.
Shaun McDonald [Tue, 28 Oct 2008 12:27:10 +0000 (12:27 +0000)]
Moving all the functional tests to the Rails 2 way, which uses less code by having an additional sub-class to take care of the duplicate code in every test. There is a bug in rails 2.0.2, which means that super doesn't get called in the setup method in the functional tests. This is fixed in Rails 2.1.2, thus a version bump should really be done.
Shaun McDonald [Mon, 27 Oct 2008 18:45:28 +0000 (18:45 +0000)]
Prepare for Rails 2.1+, as we will no longer be able to use a symbol in the set_fixture_class method, instead we must use a Class. This change doesn't affect Rails 2.0.2, as currently used. All tests still work. :-)
Matt Amos [Mon, 27 Oct 2008 17:50:28 +0000 (17:50 +0000)]
Implemented osmChange diff downloads for changesets and a couple of tests.
Matt Amos [Mon, 27 Oct 2008 16:48:09 +0000 (16:48 +0000)]
Updated comment to reflect implementation.
Shaun McDonald [Sun, 26 Oct 2008 23:43:37 +0000 (23:43 +0000)]
cover the other extreme in the map bounary sanitizeation. Ading some documentation, which is parsed when running rake doc:app. Fixing up a couple of tests.
Matt Amos [Thu, 23 Oct 2008 15:14:17 +0000 (15:14 +0000)]
Added tests for changeset upload code. Refactored diff reading code and put it into /lib. Changed the route of a changeset upload to explicitly refer to the changeset it applies to (i.e: resource).
Shaun McDonald [Wed, 22 Oct 2008 09:40:16 +0000 (09:40 +0000)]
Fixing the error messages
Shaun McDonald [Tue, 21 Oct 2008 16:18:18 +0000 (16:18 +0000)]
Adding new browse controller test, which is mostly stubs just now. Also adding the version number of the recently changed nodes in the data browser.
Shaun McDonald [Tue, 21 Oct 2008 14:28:52 +0000 (14:28 +0000)]
making it clearer when a test case fails, as to which test case it is that is failing. Adding some more bboxes for testing.
Matt Amos [Tue, 21 Oct 2008 14:00:08 +0000 (14:00 +0000)]
Added min_lat > max_lat test.
Matt Amos [Tue, 21 Oct 2008 11:40:06 +0000 (11:40 +0000)]
Refactored test a bit to make it nicer.
Matt Amos [Tue, 21 Oct 2008 11:38:13 +0000 (11:38 +0000)]
Added test for relations_for_node where the relation had been deleted.
Matt Amos [Tue, 21 Oct 2008 10:52:52 +0000 (10:52 +0000)]
Added tests for ways_for_node. Altered behaviour to not return deleted ways. Fixed ways fixture where most recent history != current.
Matt Amos [Tue, 21 Oct 2008 09:31:36 +0000 (09:31 +0000)]
Removed debugging code.
Shaun McDonald [Mon, 20 Oct 2008 20:40:06 +0000 (20:40 +0000)]
Making the capabilities api version indipendent
Shaun McDonald [Mon, 20 Oct 2008 15:05:12 +0000 (15:05 +0000)]
Adding some api tests for both the map and trackpoints requests. Needs some better bboxes. Adding new changeset controller fnctional tests.
Shaun McDonald [Sun, 19 Oct 2008 07:09:04 +0000 (07:09 +0000)]
more testing of the api. Changing the generator so that it is a constant to come in line with the server url and the api version. Adding tracepoints per page to the capabilities api call. Better error message for api call.
Matt Amos [Fri, 17 Oct 2008 11:21:40 +0000 (11:21 +0000)]
Altered a functional test on way_tags.
Matt Amos [Fri, 17 Oct 2008 11:06:58 +0000 (11:06 +0000)]
More functional tests, this time for way_tags.
Matt Amos [Thu, 16 Oct 2008 13:02:09 +0000 (13:02 +0000)]
Fixed fixtures and added new tests for ways and way_nodes.
Shaun McDonald [Thu, 16 Oct 2008 07:11:28 +0000 (07:11 +0000)]
adding the Last-Modified response header to the version action
Andy Allan [Wed, 15 Oct 2008 16:56:56 +0000 (16:56 +0000)]
set the db encoding to utf-8, otherwise data is stored incorrectly in db. Can be seen by roundtrip truncating at 255 bytes instead of 255 chars. Connection setting (here) is independant of mysql setup
Shaun McDonald [Wed, 15 Oct 2008 16:20:43 +0000 (16:20 +0000)]
Adding a lower and upper length on various web site varchar fields. Fixes one test.
Andy Allan [Wed, 15 Oct 2008 15:23:56 +0000 (15:23 +0000)]
Checking foreign key constraints on message recipients and senders
Andy Allan [Wed, 15 Oct 2008 13:17:10 +0000 (13:17 +0000)]
utf-8 wide-char testing of message title - this will come in useful for other things e.g. k/v pairs
Matt Amos [Wed, 15 Oct 2008 11:12:26 +0000 (11:12 +0000)]
Added more fixtures and tests for node versioning calls.
Shaun McDonald [Tue, 14 Oct 2008 18:33:03 +0000 (18:33 +0000)]
more work on the data browser to show the changesets. Also showing the version number. Would be good to have an additional route for showing a specific version of the node/way/relation from the changeset.
Matt Amos [Tue, 14 Oct 2008 16:40:17 +0000 (16:40 +0000)]
Cleaned up some unreachable code. Added first test on the 'old' node controller.
Matt Amos [Tue, 14 Oct 2008 14:34:17 +0000 (14:34 +0000)]
Added some more functional tests for way and relation delete methods.
Matt Amos [Tue, 14 Oct 2008 14:27:12 +0000 (14:27 +0000)]
Fixed up delete methods on nodes, ways and relations to return the new version number and added some more tests.
Shaun McDonald [Mon, 13 Oct 2008 20:48:58 +0000 (20:48 +0000)]
adding changeset stuff for the data browser
Matt Amos [Mon, 13 Oct 2008 17:50:15 +0000 (17:50 +0000)]
Added a bunch more tests on the API 0.6. Fixed node/way/relation from_xml code to disallow duplicate tag keys.
Shaun McDonald [Mon, 13 Oct 2008 17:05:52 +0000 (17:05 +0000)]
now you will actually save the changeset on updating ways. Showing the changeset in the data browser detail.
Shaun McDonald [Mon, 13 Oct 2008 16:11:57 +0000 (16:11 +0000)]
fix so that changeset will be closed without an exception due to double validation
Matt Amos [Mon, 13 Oct 2008 15:46:22 +0000 (15:46 +0000)]
All API 0.6 functional tests now pass.
Matt Amos [Mon, 13 Oct 2008 15:40:32 +0000 (15:40 +0000)]
Fixed up way controller tests for API 0.6.
Shaun McDonald [Mon, 13 Oct 2008 15:39:21 +0000 (15:39 +0000)]
Creating consistency check for creation of nodes, way and relations. Moving some creation code from the controller to the model, and adding error handling on create errors.
Matt Amos [Mon, 13 Oct 2008 15:23:48 +0000 (15:23 +0000)]
Fixed problems with the relations functional tests.
Matt Amos [Mon, 13 Oct 2008 14:38:32 +0000 (14:38 +0000)]
Fixed xml method of old way model.
Shaun McDonald [Mon, 13 Oct 2008 14:34:04 +0000 (14:34 +0000)]
moving the check consistency to it's own file so that checks will be able to be loaded into the way and relation models, without loading the node stuff.
Matt Amos [Mon, 13 Oct 2008 14:29:30 +0000 (14:29 +0000)]
Fix to_xml method of old_relation model.
Matt Amos [Mon, 13 Oct 2008 14:08:31 +0000 (14:08 +0000)]
Fixed node functional tests. A couple of changes to the old_node model and node controller for changesets.
Shaun McDonald [Mon, 13 Oct 2008 12:08:26 +0000 (12:08 +0000)]
fixing the data browser to be able to cope with the changeset change. changeset browsing still needs to be implemented. Also giving a nice error message for 404 not found instead of rendering nothing.
Shaun McDonald [Sun, 12 Oct 2008 22:32:51 +0000 (22:32 +0000)]
additional consistency checks. making the error message for the number of nodes use the configured number of nodes, rather than a hard coded number. minor improvements to the way controller functional tests. Not sure if they should be turned into integration tests.
Shaun McDonald [Fri, 10 Oct 2008 18:24:07 +0000 (18:24 +0000)]
fix indentation. Get teh api version from the constant, rather than hard coding it. Using right save method, so that exception is thrown. Some comment questions.
Shaun McDonald [Fri, 10 Oct 2008 13:27:21 +0000 (13:27 +0000)]
reverting the javascript change in changeset 10926, that needs to be specific to each rails setup (if run out of another dir), until we turn the file into an erb that can insert the rails root into the javascript file
Shaun McDonald [Fri, 10 Oct 2008 07:58:33 +0000 (07:58 +0000)]
Some comment about where to add code to get some more of the functional changesets working.
Shaun McDonald [Thu, 9 Oct 2008 16:22:05 +0000 (16:22 +0000)]
moving the conistency checks for updates and deletes to library, hopefully got the updates and deletes working now.
Matt Amos [Thu, 9 Oct 2008 10:19:16 +0000 (10:19 +0000)]
Small fixes to unit tests where user_id has become changeset_id.
Shaun McDonald [Wed, 8 Oct 2008 18:03:41 +0000 (18:03 +0000)]
adding the controller code to be able to get a specific version of a node, way or relation. Add some node checks on update. Some code indentation cleanup.
Shaun McDonald [Wed, 8 Oct 2008 15:42:42 +0000 (15:42 +0000)]
Fix the data config, so that the development database is not the same as the test database. Make a good stab at getting the creates and updates for relations working, adding some new error exceptions. Some code indentation cleanup.
Shaun McDonald [Tue, 7 Oct 2008 23:49:53 +0000 (23:49 +0000)]
some useful notes in code for ideas that require implementing.
Shaun McDonald [Tue, 7 Oct 2008 22:59:59 +0000 (22:59 +0000)]
Adding the classic_pagination to svn as the svn external is no longer working
Shaun McDonald [Tue, 7 Oct 2008 22:40:28 +0000 (22:40 +0000)]
Updating the fixtures for the new changesets
Shaun McDonald [Tue, 7 Oct 2008 22:11:05 +0000 (22:11 +0000)]
folder empty and components are dead and gone with rails 2 anyway, so deleting this folder.
Shaun McDonald [Fri, 3 Oct 2008 17:09:58 +0000 (17:09 +0000)]
Fixing a bug in my foreign keys. I can now upload and download nodes and ways using JOSM in the new API.
Shaun McDonald [Fri, 3 Oct 2008 13:57:20 +0000 (13:57 +0000)]
Changing if not to unless to make code more readable.
Shaun McDonald [Tue, 30 Sep 2008 18:21:56 +0000 (18:21 +0000)]
changing the belongs_to and has_many items in the models to reflect the new foriegn keys in the db and the fact that a (old)node/way/relation now belong to a changeset, which in turn has a user.
Shaun McDonald [Tue, 30 Sep 2008 15:52:54 +0000 (15:52 +0000)]
wrong foreign key command in the migration
Shaun McDonald [Tue, 30 Sep 2008 15:44:55 +0000 (15:44 +0000)]
wrong foreign key command in the migration
Shaun McDonald [Tue, 30 Sep 2008 15:24:25 +0000 (15:24 +0000)]
using the wrong field name in one of the migrations
Shaun McDonald [Tue, 30 Sep 2008 14:29:44 +0000 (14:29 +0000)]
changing the changesets migrations, so that the user id is now the changeset id for the nodes/ways/relations
Shaun McDonald [Mon, 29 Sep 2008 16:28:51 +0000 (16:28 +0000)]
adding some version reading for the nodes
Shaun McDonald [Fri, 26 Sep 2008 15:17:30 +0000 (15:17 +0000)]
fixing hard coded images/scripts, so that the site works better when deploy as a sub directory using passenger phusion.
Shaun McDonald [Thu, 25 Sep 2008 16:20:36 +0000 (16:20 +0000)]
fixing the test that was broken in the resync
Shaun McDonald [Thu, 25 Sep 2008 15:57:59 +0000 (15:57 +0000)]
Minor fix for the migration that was moved
Shaun McDonald [Thu, 25 Sep 2008 15:06:05 +0000 (15:06 +0000)]
Doing a resync from mainline 8633:10895. There was one simple to resolve conflict on app/models/node.rb. Also moving the migrations for API0.6 to new sequence numbers since there was some new migrations added to mainline, where the migration numbers would conflict if not moved.
Tom Hughes [Thu, 25 Sep 2008 03:58:18 +0000 (03:58 +0000)]
Get rails to do asset tagging for the SWF file.
Richard Fairhurst [Sat, 20 Sep 2008 12:07:48 +0000 (12:07 +0000)]
Potlatch 0.10c... part two
Richard Fairhurst [Thu, 18 Sep 2008 17:04:28 +0000 (17:04 +0000)]
Potlatch 0.10c
Tom Hughes [Tue, 9 Sep 2008 17:50:09 +0000 (17:50 +0000)]
Add the noname layer to the main map.
Tom Hughes [Sun, 7 Sep 2008 15:07:44 +0000 (15:07 +0000)]
Run web authorisation for all non-api requests. Closes #1152.
Tom Hughes [Thu, 28 Aug 2008 23:09:42 +0000 (23:09 +0000)]
Update for new cycle map location.
Tom Hughes [Sun, 24 Aug 2008 16:56:34 +0000 (16:56 +0000)]
Fix migration.
Tom Hughes [Sun, 24 Aug 2008 16:53:42 +0000 (16:53 +0000)]
Add basic support for logically deleting a user.
Tom Hughes [Sun, 24 Aug 2008 15:12:20 +0000 (15:12 +0000)]
Tidy up diary code a bit.