rails.git
11 years agoadd a comment about why the error handler is required, as per mail from TomH. Also...
Shaun McDonald [Wed, 29 Oct 2008 15:45:48 +0000 (15:45 +0000)]
add a comment about why the error handler is required, as per mail from TomH. Also adding the option so that we are using the old style of migrations, rather than the 2.1+ migrations.

11 years agoBetter error message and test for invalid UTF-8 sequences.
Matt Amos [Wed, 29 Oct 2008 15:33:23 +0000 (15:33 +0000)]
Better error message and test for invalid UTF-8 sequences.

11 years agoUpdating to use Rails 2.1.2. Moving the gem dependancies to the config/environment...
Shaun McDonald [Tue, 28 Oct 2008 20:42:48 +0000 (20:42 +0000)]
Updating to use Rails 2.1.2. Moving the gem dependancies to the config/environment.rb file. Moving the vendor/plugins externals into our svn.

11 years agomessage title shouldn't accept invalid utf-8 sequences - test currently fails
Andy Allan [Tue, 28 Oct 2008 18:34:05 +0000 (18:34 +0000)]
message title shouldn't accept invalid utf-8 sequences - test currently fails

11 years agoMade full test a bit more thorough.
Matt Amos [Tue, 28 Oct 2008 15:01:17 +0000 (15:01 +0000)]
Made full test a bit more thorough.

11 years agoAdded tests for relations for way/relation and a bit of DRYing up.
Matt Amos [Tue, 28 Oct 2008 14:49:51 +0000 (14:49 +0000)]
Added tests for relations for way/relation and a bit of DRYing up.

11 years agoAdding stub functional test files for all the controllers that should have tests...
Shaun McDonald [Tue, 28 Oct 2008 12:49:51 +0000 (12:49 +0000)]
Adding stub functional test files for all the controllers that should have tests written for them.

11 years agoMoving all the functional tests to the Rails 2 way, which uses less code by having...
Shaun McDonald [Tue, 28 Oct 2008 12:27:10 +0000 (12:27 +0000)]
Moving all the functional tests to the Rails 2 way, which uses less code by having an additional sub-class to take care of the duplicate code in every test. There is a bug in rails 2.0.2, which means that super doesn't get called in the setup method in the functional tests. This is fixed in Rails 2.1.2, thus a version bump should really be done.

11 years agoPrepare for Rails 2.1+, as we will no longer be able to use a symbol in the set_fixtu...
Shaun McDonald [Mon, 27 Oct 2008 18:45:28 +0000 (18:45 +0000)]
Prepare for Rails 2.1+, as we will no longer be able to use a symbol in the set_fixture_class method, instead we must use a Class. This change doesn't affect Rails 2.0.2, as currently used. All tests still work. :-)

11 years agoImplemented osmChange diff downloads for changesets and a couple of tests.
Matt Amos [Mon, 27 Oct 2008 17:50:28 +0000 (17:50 +0000)]
Implemented osmChange diff downloads for changesets and a couple of tests.

11 years agoUpdated comment to reflect implementation.
Matt Amos [Mon, 27 Oct 2008 16:48:09 +0000 (16:48 +0000)]
Updated comment to reflect implementation.

11 years agocover the other extreme in the map bounary sanitizeation. Ading some documentation...
Shaun McDonald [Sun, 26 Oct 2008 23:43:37 +0000 (23:43 +0000)]
cover the other extreme in the map bounary sanitizeation. Ading some documentation, which is parsed when running rake doc:app. Fixing up a couple of tests.

11 years agoAdded tests for changeset upload code. Refactored diff reading code and put it into...
Matt Amos [Thu, 23 Oct 2008 15:14:17 +0000 (15:14 +0000)]
Added tests for changeset upload code. Refactored diff reading code and put it into /lib. Changed the route of a changeset upload to explicitly refer to the changeset it applies to (i.e: resource).

11 years agoFixing the error messages
Shaun McDonald [Wed, 22 Oct 2008 09:40:16 +0000 (09:40 +0000)]
Fixing the error messages

11 years agoAdding new browse controller test, which is mostly stubs just now. Also adding the...
Shaun McDonald [Tue, 21 Oct 2008 16:18:18 +0000 (16:18 +0000)]
Adding new browse controller test, which is mostly stubs just now. Also adding the version number of the recently changed nodes in the data browser.

11 years agomaking it clearer when a test case fails, as to which test case it is that is failing...
Shaun McDonald [Tue, 21 Oct 2008 14:28:52 +0000 (14:28 +0000)]
making it clearer when a test case fails, as to which test case it is that is failing. Adding some more bboxes for testing.

11 years agoAdded min_lat > max_lat test.
Matt Amos [Tue, 21 Oct 2008 14:00:08 +0000 (14:00 +0000)]
Added min_lat > max_lat test.

11 years agoRefactored test a bit to make it nicer.
Matt Amos [Tue, 21 Oct 2008 11:40:06 +0000 (11:40 +0000)]
Refactored test a bit to make it nicer.

11 years agoAdded test for relations_for_node where the relation had been deleted.
Matt Amos [Tue, 21 Oct 2008 11:38:13 +0000 (11:38 +0000)]
Added test for relations_for_node where the relation had been deleted.

11 years agoAdded tests for ways_for_node. Altered behaviour to not return deleted ways. Fixed...
Matt Amos [Tue, 21 Oct 2008 10:52:52 +0000 (10:52 +0000)]
Added tests for ways_for_node. Altered behaviour to not return deleted ways. Fixed ways fixture where most recent history != current.

11 years agoRemoved debugging code.
Matt Amos [Tue, 21 Oct 2008 09:31:36 +0000 (09:31 +0000)]
Removed debugging code.

11 years agoMaking the capabilities api version indipendent
Shaun McDonald [Mon, 20 Oct 2008 20:40:06 +0000 (20:40 +0000)]
Making the capabilities api version indipendent

11 years agoAdding some api tests for both the map and trackpoints requests. Needs some better...
Shaun McDonald [Mon, 20 Oct 2008 15:05:12 +0000 (15:05 +0000)]
Adding some api tests for both the map and trackpoints requests. Needs some better bboxes. Adding new changeset controller fnctional tests.

11 years agomore testing of the api. Changing the generator so that it is a constant to come...
Shaun McDonald [Sun, 19 Oct 2008 07:09:04 +0000 (07:09 +0000)]
more testing of the api. Changing the generator so that it is a constant to come in line with the server url and the api version. Adding tracepoints per page to the capabilities api call. Better error message for api call.

11 years agoAltered a functional test on way_tags.
Matt Amos [Fri, 17 Oct 2008 11:21:40 +0000 (11:21 +0000)]
Altered a functional test on way_tags.

11 years agoMore functional tests, this time for way_tags.
Matt Amos [Fri, 17 Oct 2008 11:06:58 +0000 (11:06 +0000)]
More functional tests, this time for way_tags.

11 years agoFixed fixtures and added new tests for ways and way_nodes.
Matt Amos [Thu, 16 Oct 2008 13:02:09 +0000 (13:02 +0000)]
Fixed fixtures and added new tests for ways and way_nodes.

11 years agoadding the Last-Modified response header to the version action
Shaun McDonald [Thu, 16 Oct 2008 07:11:28 +0000 (07:11 +0000)]
adding the Last-Modified response header to the version action

11 years agoset the db encoding to utf-8, otherwise data is stored incorrectly in db. Can be...
Andy Allan [Wed, 15 Oct 2008 16:56:56 +0000 (16:56 +0000)]
set the db encoding to utf-8, otherwise data is stored incorrectly in db. Can be seen by roundtrip truncating at 255 bytes instead of 255 chars. Connection setting (here) is independant of mysql setup

11 years agoAdding a lower and upper length on various web site varchar fields. Fixes one test.
Shaun McDonald [Wed, 15 Oct 2008 16:20:43 +0000 (16:20 +0000)]
Adding a lower and upper length on various web site varchar fields. Fixes one test.

11 years agoChecking foreign key constraints on message recipients and senders
Andy Allan [Wed, 15 Oct 2008 15:23:56 +0000 (15:23 +0000)]
Checking foreign key constraints on message recipients and senders

11 years agoutf-8 wide-char testing of message title - this will come in useful for other things...
Andy Allan [Wed, 15 Oct 2008 13:17:10 +0000 (13:17 +0000)]
utf-8 wide-char testing of message title - this will come in useful for other things e.g. k/v pairs

11 years agoAdded more fixtures and tests for node versioning calls.
Matt Amos [Wed, 15 Oct 2008 11:12:26 +0000 (11:12 +0000)]
Added more fixtures and tests for node versioning calls.

11 years agomore work on the data browser to show the changesets. Also showing the version number...
Shaun McDonald [Tue, 14 Oct 2008 18:33:03 +0000 (18:33 +0000)]
more work on the data browser to show the changesets. Also showing the version number. Would be good to have an additional route for showing a specific version of the node/way/relation from the changeset.

11 years agoCleaned up some unreachable code. Added first test on the 'old' node controller.
Matt Amos [Tue, 14 Oct 2008 16:40:17 +0000 (16:40 +0000)]
Cleaned up some unreachable code. Added first test on the 'old' node controller.

11 years agoAdded some more functional tests for way and relation delete methods.
Matt Amos [Tue, 14 Oct 2008 14:34:17 +0000 (14:34 +0000)]
Added some more functional tests for way and relation delete methods.

11 years agoFixed up delete methods on nodes, ways and relations to return the new version number...
Matt Amos [Tue, 14 Oct 2008 14:27:12 +0000 (14:27 +0000)]
Fixed up delete methods on nodes, ways and relations to return the new version number and added some more tests.

11 years agoadding changeset stuff for the data browser
Shaun McDonald [Mon, 13 Oct 2008 20:48:58 +0000 (20:48 +0000)]
adding changeset stuff for the data browser

11 years agoAdded a bunch more tests on the API 0.6. Fixed node/way/relation from_xml code to...
Matt Amos [Mon, 13 Oct 2008 17:50:15 +0000 (17:50 +0000)]
Added a bunch more tests on the API 0.6. Fixed node/way/relation from_xml code to disallow duplicate tag keys.

11 years agonow you will actually save the changeset on updating ways. Showing the changeset...
Shaun McDonald [Mon, 13 Oct 2008 17:05:52 +0000 (17:05 +0000)]
now you will actually save the changeset on updating ways. Showing the changeset in the data browser detail.

11 years agofix so that changeset will be closed without an exception due to double validation
Shaun McDonald [Mon, 13 Oct 2008 16:11:57 +0000 (16:11 +0000)]
fix so that changeset will be closed without an exception due to double validation

11 years agoAll API 0.6 functional tests now pass.
Matt Amos [Mon, 13 Oct 2008 15:46:22 +0000 (15:46 +0000)]
All API 0.6 functional tests now pass.

11 years agoFixed up way controller tests for API 0.6.
Matt Amos [Mon, 13 Oct 2008 15:40:32 +0000 (15:40 +0000)]
Fixed up way controller tests for API 0.6.

11 years agoCreating consistency check for creation of nodes, way and relations. Moving some...
Shaun McDonald [Mon, 13 Oct 2008 15:39:21 +0000 (15:39 +0000)]
Creating consistency check for creation of nodes, way and relations. Moving some creation code from the controller to the model, and adding error handling on create errors.

11 years agoFixed problems with the relations functional tests.
Matt Amos [Mon, 13 Oct 2008 15:23:48 +0000 (15:23 +0000)]
Fixed problems with the relations functional tests.

11 years agoFixed xml method of old way model.
Matt Amos [Mon, 13 Oct 2008 14:38:32 +0000 (14:38 +0000)]
Fixed xml method of old way model.

11 years agomoving the check consistency to it's own file so that checks will be able to be loade...
Shaun McDonald [Mon, 13 Oct 2008 14:34:04 +0000 (14:34 +0000)]
moving the check consistency to it's own file so that checks will be able to be loaded into the way and relation models, without loading the node stuff.

11 years agoFix to_xml method of old_relation model.
Matt Amos [Mon, 13 Oct 2008 14:29:30 +0000 (14:29 +0000)]
Fix to_xml method of old_relation model.

11 years agoFixed node functional tests. A couple of changes to the old_node model and node contr...
Matt Amos [Mon, 13 Oct 2008 14:08:31 +0000 (14:08 +0000)]
Fixed node functional tests. A couple of changes to the old_node model and node controller for changesets.

11 years agofixing the data browser to be able to cope with the changeset change. changeset brows...
Shaun McDonald [Mon, 13 Oct 2008 12:08:26 +0000 (12:08 +0000)]
fixing the data browser to be able to cope with the changeset change. changeset browsing still needs to be implemented. Also giving a nice error message for 404 not found instead of rendering nothing.

11 years agoadditional consistency checks. making the error message for the number of nodes use...
Shaun McDonald [Sun, 12 Oct 2008 22:32:51 +0000 (22:32 +0000)]
additional consistency checks. making the error message for the number of nodes use the configured number of nodes, rather than a hard coded number. minor improvements to the way controller functional tests. Not sure if they should be turned into integration tests.

11 years agofix indentation. Get teh api version from the constant, rather than hard coding it...
Shaun McDonald [Fri, 10 Oct 2008 18:24:07 +0000 (18:24 +0000)]
fix indentation. Get teh api version from the constant, rather than hard coding it. Using right save method, so that exception is thrown. Some comment questions.

11 years agoreverting the javascript change in changeset 10926, that needs to be specific to...
Shaun McDonald [Fri, 10 Oct 2008 13:27:21 +0000 (13:27 +0000)]
reverting the javascript change in changeset 10926, that needs to be specific to each rails setup (if run out of another dir), until we turn the file into an erb that can insert the rails root into the javascript file

11 years agoSome comment about where to add code to get some more of the functional changesets...
Shaun McDonald [Fri, 10 Oct 2008 07:58:33 +0000 (07:58 +0000)]
Some comment about where to add code to get some more of the functional changesets working.

11 years agomoving the conistency checks for updates and deletes to library, hopefully got the...
Shaun McDonald [Thu, 9 Oct 2008 16:22:05 +0000 (16:22 +0000)]
moving the conistency checks for updates and deletes to library, hopefully got the updates and deletes working now.

11 years agoSmall fixes to unit tests where user_id has become changeset_id.
Matt Amos [Thu, 9 Oct 2008 10:19:16 +0000 (10:19 +0000)]
Small fixes to unit tests where user_id has become changeset_id.

11 years agoadding the controller code to be able to get a specific version of a node, way or...
Shaun McDonald [Wed, 8 Oct 2008 18:03:41 +0000 (18:03 +0000)]
adding the controller code to be able to get a specific version of a node, way or relation.  Add some node checks on update. Some code indentation cleanup.

11 years agoFix the data config, so that the development database is not the same as the test...
Shaun McDonald [Wed, 8 Oct 2008 15:42:42 +0000 (15:42 +0000)]
Fix the data config, so that the development database is not the same as the test database. Make a good stab at getting the creates and updates for relations working, adding some new error exceptions. Some code indentation cleanup.

11 years agosome useful notes in code for ideas that require implementing.
Shaun McDonald [Tue, 7 Oct 2008 23:49:53 +0000 (23:49 +0000)]
some useful notes in code for ideas that require implementing.

11 years agoAdding the classic_pagination to svn as the svn external is no longer working
Shaun McDonald [Tue, 7 Oct 2008 22:59:59 +0000 (22:59 +0000)]
Adding the classic_pagination to svn as the svn external is no longer working

11 years agoUpdating the fixtures for the new changesets
Shaun McDonald [Tue, 7 Oct 2008 22:40:28 +0000 (22:40 +0000)]
Updating the fixtures for the new changesets

11 years agofolder empty and components are dead and gone with rails 2 anyway, so deleting this...
Shaun McDonald [Tue, 7 Oct 2008 22:11:05 +0000 (22:11 +0000)]
folder empty and components are dead and gone with rails 2 anyway, so deleting this folder.

11 years agoFixing a bug in my foreign keys. I can now upload and download nodes and ways using...
Shaun McDonald [Fri, 3 Oct 2008 17:09:58 +0000 (17:09 +0000)]
Fixing a bug in my foreign keys. I can now upload and download nodes and ways using JOSM in the new API.

11 years agoChanging if not to unless to make code more readable.
Shaun McDonald [Fri, 3 Oct 2008 13:57:20 +0000 (13:57 +0000)]
Changing if not to unless to make code more readable.

12 years agochanging the belongs_to and has_many items in the models to reflect the new foriegn...
Shaun McDonald [Tue, 30 Sep 2008 18:21:56 +0000 (18:21 +0000)]
changing the belongs_to and has_many items in the models to reflect the new foriegn keys in the db and the fact that a (old)node/way/relation now belong to a changeset, which in turn has a user.

12 years agowrong foreign key command in the migration
Shaun McDonald [Tue, 30 Sep 2008 15:52:54 +0000 (15:52 +0000)]
wrong foreign key command in the migration

12 years agowrong foreign key command in the migration
Shaun McDonald [Tue, 30 Sep 2008 15:44:55 +0000 (15:44 +0000)]
wrong foreign key command in the migration

12 years agousing the wrong field name in one of the migrations
Shaun McDonald [Tue, 30 Sep 2008 15:24:25 +0000 (15:24 +0000)]
using the wrong field name in one of the migrations

12 years agochanging the changesets migrations, so that the user id is now the changeset id for...
Shaun McDonald [Tue, 30 Sep 2008 14:29:44 +0000 (14:29 +0000)]
changing the changesets migrations, so that the user id is now the changeset id for the nodes/ways/relations

12 years agoadding some version reading for the nodes
Shaun McDonald [Mon, 29 Sep 2008 16:28:51 +0000 (16:28 +0000)]
adding some version reading for the nodes

12 years agofixing hard coded images/scripts, so that the site works better when deploy as a...
Shaun McDonald [Fri, 26 Sep 2008 15:17:30 +0000 (15:17 +0000)]
fixing hard coded images/scripts, so that the site works better when deploy as a sub directory using passenger phusion.

12 years agofixing the test that was broken in the resync
Shaun McDonald [Thu, 25 Sep 2008 16:20:36 +0000 (16:20 +0000)]
fixing the test that was broken in the resync

12 years agoMinor fix for the migration that was moved
Shaun McDonald [Thu, 25 Sep 2008 15:57:59 +0000 (15:57 +0000)]
Minor fix for the migration that was moved

12 years agoDoing a resync from mainline 8633:10895. There was one simple to resolve conflict...
Shaun McDonald [Thu, 25 Sep 2008 15:06:05 +0000 (15:06 +0000)]
Doing a resync from mainline 8633:10895. There was one simple to resolve conflict on app/models/node.rb. Also moving the migrations for API0.6 to new sequence numbers since there was some new migrations added to mainline, where the migration numbers would conflict if not moved.

12 years agoGet rails to do asset tagging for the SWF file.
Tom Hughes [Thu, 25 Sep 2008 03:58:18 +0000 (03:58 +0000)]
Get rails to do asset tagging for the SWF file.

12 years agoPotlatch 0.10c... part two
Richard Fairhurst [Sat, 20 Sep 2008 12:07:48 +0000 (12:07 +0000)]
Potlatch 0.10c... part two

12 years agoPotlatch 0.10c
Richard Fairhurst [Thu, 18 Sep 2008 17:04:28 +0000 (17:04 +0000)]
Potlatch 0.10c

12 years agoAdd the noname layer to the main map.
Tom Hughes [Tue, 9 Sep 2008 17:50:09 +0000 (17:50 +0000)]
Add the noname layer to the main map.

12 years agoRun web authorisation for all non-api requests. Closes #1152.
Tom Hughes [Sun, 7 Sep 2008 15:07:44 +0000 (15:07 +0000)]
Run web authorisation for all non-api requests. Closes #1152.

12 years agoUpdate for new cycle map location.
Tom Hughes [Thu, 28 Aug 2008 23:09:42 +0000 (23:09 +0000)]
Update for new cycle map location.

12 years agoFix migration.
Tom Hughes [Sun, 24 Aug 2008 16:56:34 +0000 (16:56 +0000)]
Fix migration.

12 years agoAdd basic support for logically deleting a user.
Tom Hughes [Sun, 24 Aug 2008 16:53:42 +0000 (16:53 +0000)]
Add basic support for logically deleting a user.

12 years agoTidy up diary code a bit.
Tom Hughes [Sun, 24 Aug 2008 15:12:20 +0000 (15:12 +0000)]
Tidy up diary code a bit.

12 years agoedit diary entries
Richard Fairhurst [Thu, 21 Aug 2008 21:40:23 +0000 (21:40 +0000)]
edit diary entries

12 years agomore testing of node tags
Shaun McDonald [Mon, 18 Aug 2008 13:55:21 +0000 (13:55 +0000)]
more testing of node tags

12 years agoCommit new route for email confirmation changes.
Tom Hughes [Mon, 18 Aug 2008 07:28:26 +0000 (07:28 +0000)]
Commit new route for email confirmation changes.

12 years agoDon't user flash[:notice] when we're not redirecting as it will
Tom Hughes [Wed, 13 Aug 2008 11:44:53 +0000 (11:44 +0000)]
Don't user flash[:notice] when we're not redirecting as it will
persist to the next request and cause confusion.

12 years agoAllow users to change their email address. Closes #546.
Tom Hughes [Wed, 13 Aug 2008 11:39:33 +0000 (11:39 +0000)]
Allow users to change their email address. Closes #546.

12 years agoAllow a user's email address to be marked invalid, and suppress most
Tom Hughes [Wed, 13 Aug 2008 10:45:49 +0000 (10:45 +0000)]
Allow a user's email address to be marked invalid, and suppress most
notification mails for such users.

12 years agoAdd an administrator flag to the user table.
Tom Hughes [Wed, 13 Aug 2008 08:12:09 +0000 (08:12 +0000)]
Add an administrator flag to the user table.

12 years agoMake the cleanup script work a chunk at a time so we don't run out of
Tom Hughes [Fri, 8 Aug 2008 15:49:29 +0000 (15:49 +0000)]
Make the cleanup script work a chunk at a time so we don't run out of
memory when there are lots of sessions.

12 years agoImport the output_compression plugin as the SVN external never works.
Tom Hughes [Thu, 7 Aug 2008 17:59:27 +0000 (17:59 +0000)]
Import the output_compression plugin as the SVN external never works.

12 years agoImport the daemon generator as the SVN external never works.
Tom Hughes [Thu, 7 Aug 2008 17:46:34 +0000 (17:46 +0000)]
Import the daemon generator as the SVN external never works.

12 years agoMake the location of the GPX traces configurable.
Tom Hughes [Thu, 7 Aug 2008 11:31:42 +0000 (11:31 +0000)]
Make the location of the GPX traces configurable.

12 years agoLink to user pages.
Tom Hughes [Sun, 3 Aug 2008 20:58:58 +0000 (20:58 +0000)]
Link to user pages.

12 years agoPotlatch 0.10b
Richard Fairhurst [Thu, 31 Jul 2008 22:48:12 +0000 (22:48 +0000)]
Potlatch 0.10b

12 years agoIgnore any files in an __MACOSX folder in a zip file, as these are
Tom Hughes [Thu, 31 Jul 2008 08:06:09 +0000 (08:06 +0000)]
Ignore any files in an __MACOSX folder in a zip file, as these are
metadata files added by the MAC OS X zip tool.

12 years agoCorrect versions of z12/13 keys
Steve Chilton [Wed, 30 Jul 2008 14:37:55 +0000 (14:37 +0000)]
Correct versions of z12/13 keys

12 years agonew versions of map keys to z12 and z13
Steve Chilton [Wed, 30 Jul 2008 14:19:15 +0000 (14:19 +0000)]
new versions of map keys to z12 and z13

12 years agoadd "non-exclusively" to new user signup message
Frederik Ramm [Wed, 30 Jul 2008 13:20:33 +0000 (13:20 +0000)]
add "non-exclusively" to new user signup message