rails.git
2 years agoLocalisation updates from https://translatewiki.net.
Niklas Laxström [Thu, 16 Mar 2017 07:18:33 +0000 (08:18 +0100)]
Localisation updates from https://translatewiki.net.

2 years agoAdjust rubocop threshold
Tom Hughes [Wed, 15 Mar 2017 17:57:46 +0000 (17:57 +0000)]
Adjust rubocop threshold

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1491'
Tom Hughes [Wed, 15 Mar 2017 17:37:13 +0000 (17:37 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1491'

2 years agoRefactor the oauth integration test to avoid using user fixtures.
Andy Allan [Wed, 15 Mar 2017 16:13:04 +0000 (16:13 +0000)]
Refactor the oauth integration test to avoid using user fixtures.

2 years agoUse user factory for user_terms_seen integration test.
Andy Allan [Wed, 15 Mar 2017 15:53:47 +0000 (15:53 +0000)]
Use user factory for user_terms_seen integration test.

2 years agoUse user factories for some changeset_controller tests.
Andy Allan [Wed, 15 Mar 2017 15:41:42 +0000 (15:41 +0000)]
Use user factories for some changeset_controller tests.

Others are tightly interwoven with the fixtures and will be tackled seperately.

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1488'
Tom Hughes [Wed, 15 Mar 2017 14:22:59 +0000 (14:22 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1488'

2 years agoUse a pending user for testing password resets.
Andy Allan [Wed, 15 Mar 2017 14:22:04 +0000 (14:22 +0000)]
Use a pending user for testing password resets.

2 years agoUse users factory for user_controller tests.
Andy Allan [Wed, 15 Mar 2017 11:56:36 +0000 (11:56 +0000)]
Use users factory for user_controller tests.

2 years agoThrow an exception if adding a note comment fails
Tom Hughes [Mon, 13 Mar 2017 14:49:16 +0000 (14:49 +0000)]
Throw an exception if adding a note comment fails

2 years agoMake search use HTTPS automatically
Christian Stadelmann [Sun, 22 Mar 2015 19:26:33 +0000 (20:26 +0100)]
Make search use HTTPS automatically

Currently users end up having a HTTP search function even if they
install it to their browsers from the HTTPS site. This is a unexpected
reduction in privacy.

Since search requests are private data they should be sent via HTTPS.

Closes #936

2 years agoBuild pending users via factory
Andy Allan [Mon, 13 Mar 2017 10:20:06 +0000 (10:20 +0000)]
Build pending users via factory

2 years agoReturn maximum size of bounding box for note retrieval
Simon Poole [Mon, 13 Mar 2017 07:47:01 +0000 (08:47 +0100)]
Return maximum size of bounding box for note retrieval

2 years agoLocalisation updates from https://translatewiki.net.
Niklas Laxström [Mon, 13 Mar 2017 07:21:19 +0000 (08:21 +0100)]
Localisation updates from https://translatewiki.net.

2 years agoImprove styling of flash messages on the front page
Tom Hughes [Fri, 10 Mar 2017 16:46:29 +0000 (16:46 +0000)]
Improve styling of flash messages on the front page

2 years agoShow offline/readonly messages as normal flash messages
Tom Hughes [Fri, 10 Mar 2017 16:30:04 +0000 (16:30 +0000)]
Show offline/readonly messages as normal flash messages

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1484'
Tom Hughes [Fri, 10 Mar 2017 15:58:57 +0000 (15:58 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1484'

2 years agoAdd some whitespace
Tom Hughes [Fri, 10 Mar 2017 15:34:34 +0000 (15:34 +0000)]
Add some whitespace

2 years agoUse user factories for user_login integration tests.
Andy Allan [Fri, 10 Mar 2017 14:44:22 +0000 (14:44 +0000)]
Use user factories for user_login integration tests.

The display_name logins were reworked to use downcase since the
factories supply users with an already-title-cased display_name.

The tests were also renamed to align better with the purpose of the
test rather than the name of the fixture used.

2 years agoUse user factories for page_locale integration tests.
Andy Allan [Fri, 10 Mar 2017 14:53:19 +0000 (14:53 +0000)]
Use user factories for page_locale integration tests.

2 years agoUse user factories for user_block integration tests.
Andy Allan [Fri, 10 Mar 2017 14:48:29 +0000 (14:48 +0000)]
Use user factories for user_block integration tests.

2 years agoUse user factories for user_roles integration tests.
Andy Allan [Fri, 10 Mar 2017 11:02:40 +0000 (11:02 +0000)]
Use user factories for user_roles integration tests.

2 years agoUse user factory for user_creation test.
Andy Allan [Fri, 10 Mar 2017 10:57:46 +0000 (10:57 +0000)]
Use user factory for user_creation test.

2 years agoUse user factory for application_helper tests.
Andy Allan [Fri, 10 Mar 2017 10:53:00 +0000 (10:53 +0000)]
Use user factory for application_helper tests.

2 years agoUse user factory for note_helper tests.
Andy Allan [Fri, 10 Mar 2017 10:33:28 +0000 (10:33 +0000)]
Use user factory for note_helper tests.

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1483'
Tom Hughes [Thu, 9 Mar 2017 18:35:57 +0000 (18:35 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1483'

2 years agoImprove trace#api_data tests
Tom Hughes [Thu, 9 Mar 2017 18:28:46 +0000 (18:28 +0000)]
Improve trace#api_data tests

The api_data action doesn't actually take the username as an
arguement and should be modelled on api_read rather than the
actions that handle web views.

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1481'
Tom Hughes [Thu, 9 Mar 2017 18:14:34 +0000 (18:14 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1481'

2 years agoRemove redundant tests for deleted traces, and rearrange comments and factory calls...
Andy Allan [Thu, 9 Mar 2017 17:21:46 +0000 (17:21 +0000)]
Remove redundant tests for deleted traces, and rearrange comments and factory calls for consistency.

2 years agoUse user factory for user_roles_helper test
Andy Allan [Thu, 9 Mar 2017 16:59:44 +0000 (16:59 +0000)]
Use user factory for user_roles_helper test

2 years agoCreate a super_user factory.
Andy Allan [Thu, 9 Mar 2017 16:21:51 +0000 (16:21 +0000)]
Create a super_user factory.

2 years agoCreate a fresh user when requesting non-existent traces.
Andy Allan [Thu, 9 Mar 2017 14:50:02 +0000 (14:50 +0000)]
Create a fresh user when requesting non-existent traces.

2 years agoUse user factory for message model tests.
Andy Allan [Thu, 9 Mar 2017 11:52:31 +0000 (11:52 +0000)]
Use user factory for message model tests.

2 years agoTake the user from the node or changeset, rather than referring to the fixture.
Andy Allan [Thu, 9 Mar 2017 11:29:43 +0000 (11:29 +0000)]
Take the user from the node or changeset, rather than referring to the fixture.

2 years agoUse user factory for note model test.
Andy Allan [Thu, 9 Mar 2017 11:06:07 +0000 (11:06 +0000)]
Use user factory for note model test.

2 years agoUse user factory for oauth_token model test.
Andy Allan [Thu, 9 Mar 2017 11:04:29 +0000 (11:04 +0000)]
Use user factory for oauth_token model test.

2 years agoUse user factory for user_preference model tests.
Andy Allan [Thu, 9 Mar 2017 10:57:57 +0000 (10:57 +0000)]
Use user factory for user_preference model tests.

2 years agoUse user factory for trace model tests.
Andy Allan [Thu, 9 Mar 2017 10:53:11 +0000 (10:53 +0000)]
Use user factory for trace model tests.

2 years agoUse user factory for trace_controller tests
Andy Allan [Thu, 9 Mar 2017 10:13:18 +0000 (10:13 +0000)]
Use user factory for trace_controller tests

2 years agoRemove fake qqq locale
Tom Hughes [Thu, 9 Mar 2017 07:10:10 +0000 (07:10 +0000)]
Remove fake qqq locale

2 years agoLocalisation updates from https://translatewiki.net.
Niklas Laxström [Thu, 9 Mar 2017 07:01:16 +0000 (08:01 +0100)]
Localisation updates from https://translatewiki.net.

2 years agoDo more preloading in browse controller methods
Tom Hughes [Tue, 7 Mar 2017 09:10:24 +0000 (09:10 +0000)]
Do more preloading in browse controller methods

Fixes #1476

2 years agoFix accidental change in comments
Tom Hughes [Mon, 6 Mar 2017 18:01:26 +0000 (18:01 +0000)]
Fix accidental change in comments

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1477'
Tom Hughes [Mon, 6 Mar 2017 17:54:26 +0000 (17:54 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1477'

2 years agoDetect a timeout encapsulated in ActionView::Template::Error
Tom Hughes [Mon, 6 Mar 2017 17:50:09 +0000 (17:50 +0000)]
Detect a timeout encapsulated in ActionView::Template::Error

Fixes #1476

2 years agoUse user factory for swf_controller tests.
Andy Allan [Mon, 6 Mar 2017 17:28:06 +0000 (17:28 +0000)]
Use user factory for swf_controller tests.

2 years agoUse user factory for message_controller tests.
Andy Allan [Mon, 6 Mar 2017 17:25:55 +0000 (17:25 +0000)]
Use user factory for message_controller tests.

2 years agoUse user factory for user_roles_controller tests.
Andy Allan [Mon, 6 Mar 2017 16:55:05 +0000 (16:55 +0000)]
Use user factory for user_roles_controller tests.

2 years agoFix hiding of sidebar loading indicator
Tom Hughes [Mon, 6 Mar 2017 12:22:14 +0000 (12:22 +0000)]
Fix hiding of sidebar loading indicator

Fixes #1475

2 years agoRemove fake qqq locale
Tom Hughes [Mon, 6 Mar 2017 09:00:16 +0000 (09:00 +0000)]
Remove fake qqq locale

2 years agoLocalisation updates from https://translatewiki.net.
Niklas Laxström [Mon, 6 Mar 2017 08:03:14 +0000 (09:03 +0100)]
Localisation updates from https://translatewiki.net.

2 years agoRemove inline styles
Tom Hughes [Sun, 5 Mar 2017 19:51:01 +0000 (19:51 +0000)]
Remove inline styles

2 years agoUse users factory for user_preferences_controller tests.
Andy Allan [Sun, 5 Mar 2017 16:47:40 +0000 (16:47 +0000)]
Use users factory for user_preferences_controller tests.

2 years agoUse users factory for user_blocks_controller tests.
Andy Allan [Sun, 5 Mar 2017 16:34:59 +0000 (16:34 +0000)]
Use users factory for user_blocks_controller tests.

2 years agoUse users factory for redactions_controller tests.
Andy Allan [Sun, 5 Mar 2017 16:34:36 +0000 (16:34 +0000)]
Use users factory for redactions_controller tests.

2 years agoUse local api to export map.osm
Han Chao [Sun, 5 Mar 2017 10:37:25 +0000 (10:37 +0000)]
Use local api to export map.osm

Closes #1282

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1437'
Tom Hughes [Sun, 5 Mar 2017 10:34:23 +0000 (10:34 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1437'

2 years agoUpdate HSTS to publish a max-age=0 to disable it
Tom Hughes [Fri, 3 Mar 2017 11:34:39 +0000 (11:34 +0000)]
Update HSTS to publish a max-age=0 to disable it

2 years agoSilence remaining jshint warnings
Tom Hughes [Thu, 2 Mar 2017 10:44:18 +0000 (10:44 +0000)]
Silence remaining jshint warnings

2 years agoDon't try and modify policy if we don't have one
Tom Hughes [Thu, 2 Mar 2017 10:39:18 +0000 (10:39 +0000)]
Don't try and modify policy if we don't have one

2 years agoUpdate Potlatch 2 to 2.4-46-gea38865 build
Tom Hughes [Thu, 2 Mar 2017 10:33:49 +0000 (10:33 +0000)]
Update Potlatch 2 to 2.4-46-gea38865 build

2 years agoFix some jshint warnings
Tom Hughes [Thu, 2 Mar 2017 10:20:51 +0000 (10:20 +0000)]
Fix some jshint warnings

2 years agoImprove the content security policy
Tom Hughes [Wed, 1 Mar 2017 22:38:24 +0000 (22:38 +0000)]
Improve the content security policy

2 years agoRemove inline javascript from page header
Tom Hughes [Wed, 1 Mar 2017 21:19:32 +0000 (21:19 +0000)]
Remove inline javascript from page header

2 years agoRemove inline javascript from id views
Tom Hughes [Wed, 1 Mar 2017 18:07:22 +0000 (18:07 +0000)]
Remove inline javascript from id views

2 years agoCorrect name of zoom argument for Potlatch 2
Tom Hughes [Wed, 1 Mar 2017 14:06:05 +0000 (14:06 +0000)]
Correct name of zoom argument for Potlatch 2

Fixes #1471

2 years agoRemove inline javascript from potlatch2 view
Tom Hughes [Tue, 28 Feb 2017 20:37:23 +0000 (20:37 +0000)]
Remove inline javascript from potlatch2 view

2 years agoRemove inline javascript from potlatch view
Tom Hughes [Tue, 28 Feb 2017 18:27:14 +0000 (18:27 +0000)]
Remove inline javascript from potlatch view

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1469'
Tom Hughes [Tue, 28 Feb 2017 00:21:23 +0000 (00:21 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1469'

2 years agoRemove inline javascript from user views
Tom Hughes [Mon, 27 Feb 2017 22:48:36 +0000 (22:48 +0000)]
Remove inline javascript from user views

2 years agoAdded new I18N string: notifier.friend_notification.hi
Herve Saint-Amand [Mon, 27 Feb 2017 22:37:52 +0000 (22:37 +0000)]
Added new I18N string: notifier.friend_notification.hi

2 years agoIncluded greeting string in changeset_comment_notification email
Herve Saint-Amand [Mon, 27 Feb 2017 22:36:09 +0000 (22:36 +0000)]
Included greeting string in changeset_comment_notification email

2 years agoRevert "Update iD frame parameters if the parent URL changes"
Tom Hughes [Mon, 27 Feb 2017 14:31:56 +0000 (14:31 +0000)]
Revert "Update iD frame parameters if the parent URL changes"

This reverts commit a6fa8cc273017c2673d6d76dae7f5ac811c2027d.

2 years agoUpdate iD frame parameters if the parent URL changes
Tom Hughes [Mon, 27 Feb 2017 13:23:27 +0000 (13:23 +0000)]
Update iD frame parameters if the parent URL changes

Fixes #1468

2 years agoRemove fake qqq locale
Tom Hughes [Mon, 27 Feb 2017 13:00:43 +0000 (13:00 +0000)]
Remove fake qqq locale

2 years agoLocalisation updates from https://translatewiki.net.
Niklas Laxström [Mon, 27 Feb 2017 07:02:07 +0000 (08:02 +0100)]
Localisation updates from https://translatewiki.net.

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1467'
Tom Hughes [Sun, 26 Feb 2017 22:22:48 +0000 (22:22 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1467'

2 years agoExternalize message about missing OAuth capabilities/permissions and make it less...
Simon Poole [Sun, 26 Feb 2017 20:43:43 +0000 (21:43 +0100)]
Externalize message about missing OAuth capabilities/permissions and make it less technical

2 years agoAdd support for Content-Security-Policy
Tom Hughes [Sun, 26 Feb 2017 19:34:31 +0000 (19:34 +0000)]
Add support for Content-Security-Policy

Currently this is report only, and disabled unless a report URL has
been set in the application configuration.

2 years agoRemove explicit context menu width
Tom Hughes [Sat, 25 Feb 2017 10:57:00 +0000 (10:57 +0000)]
Remove explicit context menu width

Firefox and Chromium at least seem to autosize correctly based
on the actual text in use for a given locale.

2 years agoRename 'clickable' to 'interactive' per leaflet 1.x change
Tom Hughes [Fri, 24 Feb 2017 23:10:12 +0000 (23:10 +0000)]
Rename 'clickable' to 'interactive' per leaflet 1.x change

2 years agoUpdate to iD v2.1.3
Bryan Housel [Fri, 24 Feb 2017 21:01:32 +0000 (16:01 -0500)]
Update to iD v2.1.3

2 years agoRevert to nokogumbo 1.4.9
Tom Hughes [Fri, 24 Feb 2017 08:35:54 +0000 (08:35 +0000)]
Revert to nokogumbo 1.4.9

https://github.com/rubys/nokogumbo/issues/50

2 years agoUpdate to rails 4.2.8
Tom Hughes [Thu, 23 Feb 2017 21:18:57 +0000 (21:18 +0000)]
Update to rails 4.2.8

2 years agoBlacklist VWorld imagery
Tom Hughes [Thu, 23 Feb 2017 20:21:00 +0000 (20:21 +0000)]
Blacklist VWorld imagery

Fixes #1464

2 years agoUser factories for browse, oauth_clients and site controller tests.
Andy Allan [Thu, 23 Feb 2017 14:13:09 +0000 (14:13 +0000)]
User factories for browse, oauth_clients and site controller tests.

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1436'
Tom Hughes [Thu, 23 Feb 2017 10:06:42 +0000 (10:06 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1436'

2 years agoRemove fake qqq locale
Tom Hughes [Thu, 23 Feb 2017 08:26:49 +0000 (08:26 +0000)]
Remove fake qqq locale

2 years agoLocalisation updates from https://translatewiki.net.
Niklas Laxström [Thu, 23 Feb 2017 08:11:49 +0000 (09:11 +0100)]
Localisation updates from https://translatewiki.net.

2 years agoUser factory associations for all factories.
Andy Allan [Wed, 22 Feb 2017 18:51:45 +0000 (18:51 +0000)]
User factory associations for all factories.

2 years agoRemove a few unnecessary attributes from moderator users
Tom Hughes [Wed, 22 Feb 2017 18:30:47 +0000 (18:30 +0000)]
Remove a few unnecessary attributes from moderator users

2 years agoMake all factory-generated users 'normal'
Andy Allan [Wed, 22 Feb 2017 18:14:53 +0000 (18:14 +0000)]
Make all factory-generated users 'normal'

The use of create(:normal_user) makes the tests needlessly harder to
understand and reason about, particularly when we start using
associations in the factories.

2 years agoFix rubocop warning
Tom Hughes [Wed, 22 Feb 2017 17:54:50 +0000 (17:54 +0000)]
Fix rubocop warning

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1458'
Tom Hughes [Wed, 22 Feb 2017 17:55:37 +0000 (17:55 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1458'

2 years agoIndex oauth_tokens and client_applications by user_id
Tom Hughes [Wed, 22 Feb 2017 13:44:57 +0000 (13:44 +0000)]
Index oauth_tokens and client_applications by user_id

2 years agoMerge remote-tracking branch 'openstreetmap/pull/1457'
Tom Hughes [Wed, 22 Feb 2017 12:28:13 +0000 (12:28 +0000)]
Merge remote-tracking branch 'openstreetmap/pull/1457'

2 years agoConvert notes_controller tests to user factories.
Andy Allan [Wed, 22 Feb 2017 11:33:50 +0000 (11:33 +0000)]
Convert notes_controller tests to user factories.

2 years agoRevert changes where the user is a query parameter
Andy Allan [Wed, 22 Feb 2017 11:07:43 +0000 (11:07 +0000)]
Revert changes where the user is a query parameter

2 years agoRefactor api_controller tests to avoid users fixtures.
Andy Allan [Wed, 22 Feb 2017 11:03:39 +0000 (11:03 +0000)]
Refactor api_controller tests to avoid users fixtures.

2 years agoRefactor amf_controller tests to avoid users fixtures
Andy Allan [Wed, 22 Feb 2017 10:30:53 +0000 (10:30 +0000)]
Refactor amf_controller tests to avoid users fixtures

In all honesty I wouldn't be surprised if there are some semi-hidden
dependencies on the user fixtures here, given the number of magic numbers
all over the place. But this commit takes care of the explicit
dependencies for now.