rails.git
2 months agoRefactor more controller tests
Tom Hughes [Mon, 27 Apr 2020 21:24:28 +0000 (22:24 +0100)]
Refactor more controller tests

2 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 27 Apr 2020 14:53:21 +0000 (16:53 +0200)]
Localisation updates from https://translatewiki.net.

2 months agoRefactor more controller tests
Tom Hughes [Sun, 26 Apr 2020 21:56:18 +0000 (22:56 +0100)]
Refactor more controller tests

2 months agoRefactor more controller tests
Tom Hughes [Sun, 26 Apr 2020 19:33:06 +0000 (20:33 +0100)]
Refactor more controller tests

2 months agoFix deprecation warning
Tom Hughes [Thu, 23 Apr 2020 19:45:01 +0000 (20:45 +0100)]
Fix deprecation warning

2 months agoUpdate bundle
Tom Hughes [Thu, 23 Apr 2020 19:44:44 +0000 (20:44 +0100)]
Update bundle

2 months agoUpdate vagrant provision script for switch to selenium
Tom Hughes [Wed, 22 Apr 2020 15:44:53 +0000 (16:44 +0100)]
Update vagrant provision script for switch to selenium

2 months agoMerge remote-tracking branch 'upstream/pull/2598'
Tom Hughes [Wed, 22 Apr 2020 15:43:14 +0000 (16:43 +0100)]
Merge remote-tracking branch 'upstream/pull/2598'

2 months agoMerge remote-tracking branch 'upstream/pull/2600'
Tom Hughes [Wed, 22 Apr 2020 15:42:54 +0000 (16:42 +0100)]
Merge remote-tracking branch 'upstream/pull/2600'

2 months agoRefactor some more controller tests
Andy Allan [Wed, 22 Apr 2020 14:45:16 +0000 (16:45 +0200)]
Refactor some more controller tests

2 months agoMerge remote-tracking branch 'upstream/pull/2599'
Tom Hughes [Wed, 22 Apr 2020 13:42:27 +0000 (14:42 +0100)]
Merge remote-tracking branch 'upstream/pull/2599'

2 months agoRemove tempfile patch for trace data
Andy Allan [Wed, 22 Apr 2020 13:08:45 +0000 (15:08 +0200)]
Remove tempfile patch for trace data

Effectively reverts c0d2ad40c30e5a0837b6012d7b9067d69ce41dd0

This patch is no longer required, since we only use send_data in
combination with Tempfile.read and that all works fine.

2 months agoSwitch to using selenium for system tests
Tom Hughes [Wed, 22 Apr 2020 11:23:18 +0000 (12:23 +0100)]
Switch to using selenium for system tests

2 months agoMerge remote-tracking branch 'upstream/pull/2596'
Tom Hughes [Wed, 22 Apr 2020 12:44:17 +0000 (13:44 +0100)]
Merge remote-tracking branch 'upstream/pull/2596'

2 months agoMerge remote-tracking branch 'upstream/pull/2597'
Tom Hughes [Wed, 22 Apr 2020 12:34:19 +0000 (13:34 +0100)]
Merge remote-tracking branch 'upstream/pull/2597'

2 months agoUse Open3.capture2 instead of backticks, to avoid command line injection risks
Andy Allan [Wed, 22 Apr 2020 11:22:30 +0000 (13:22 +0200)]
Use Open3.capture2 instead of backticks, to avoid command line injection risks

In this situation, trace_name can be trivially checked as legitimate, but this
removes any lingering risks from interpolating into a command line instead of
passing parameters explicitly.

Refs #2229

2 months agoRedirect to the error page for non-existent issues
Tom Hughes [Wed, 22 Apr 2020 11:22:34 +0000 (12:22 +0100)]
Redirect to the error page for non-existent issues

2 months agoSend meta information with error pages
Tom Hughes [Wed, 22 Apr 2020 11:21:42 +0000 (12:21 +0100)]
Send meta information with error pages

2 months agoRefactor site controller tests to inherit from ActionDispatch::IntegrationTest
Andy Allan [Wed, 22 Apr 2020 09:02:41 +0000 (11:02 +0200)]
Refactor site controller tests to inherit from ActionDispatch::IntegrationTest

This is the modern way of writing controller tests, since it uses the
rails middleware (among other things) and leads to more realistic tests.

Refs #2563

2 months agoRemove last traces of konacha
Tom Hughes [Mon, 20 Apr 2020 18:14:25 +0000 (19:14 +0100)]
Remove last traces of konacha

2 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 20 Apr 2020 15:01:46 +0000 (17:01 +0200)]
Localisation updates from https://translatewiki.net.

2 months agoFix new rubocop warnings
Tom Hughes [Sun, 19 Apr 2020 18:06:07 +0000 (19:06 +0100)]
Fix new rubocop warnings

2 months agoEnable new cops by default
Tom Hughes [Sun, 19 Apr 2020 18:04:32 +0000 (19:04 +0100)]
Enable new cops by default

2 months agoUpdate bundle
Tom Hughes [Sun, 19 Apr 2020 17:59:28 +0000 (18:59 +0100)]
Update bundle

2 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 16 Apr 2020 15:14:59 +0000 (17:14 +0200)]
Localisation updates from https://translatewiki.net.

2 months agoCache OpenID provider names on a per-locale basis
Tom Hughes [Wed, 15 Apr 2020 21:48:28 +0000 (22:48 +0100)]
Cache OpenID provider names on a per-locale basis

Fixes #2591

2 months agoLocalise formatting of point count for traces
Tom Hughes [Wed, 15 Apr 2020 21:42:41 +0000 (22:42 +0100)]
Localise formatting of point count for traces

Fixes #2592

2 months agoUpdate bundle
Tom Hughes [Wed, 15 Apr 2020 18:23:16 +0000 (19:23 +0100)]
Update bundle

2 months agoMerge remote-tracking branch 'upstream/pull/2431'
Tom Hughes [Wed, 15 Apr 2020 18:18:10 +0000 (19:18 +0100)]
Merge remote-tracking branch 'upstream/pull/2431'

2 months agoFix rubocop-minitest warnings
Tom Hughes [Wed, 15 Apr 2020 18:06:03 +0000 (19:06 +0100)]
Fix rubocop-minitest warnings

2 months agoSort cops
Tom Hughes [Wed, 15 Apr 2020 14:51:55 +0000 (15:51 +0100)]
Sort cops

2 months agoFix erblint
Tom Hughes [Wed, 15 Apr 2020 14:51:43 +0000 (15:51 +0100)]
Fix erblint

2 months agoMerge pull request #2547 from bezdna/mobile-layout
Andy Allan [Wed, 15 Apr 2020 14:50:12 +0000 (16:50 +0200)]
Merge pull request #2547 from bezdna/mobile-layout

Trigger small screen layout based on the width of the screen, rather than the width of the menus.

2 months agoMerge remote-tracking branch 'upstream/pull/2579'
Tom Hughes [Wed, 15 Apr 2020 14:41:49 +0000 (15:41 +0100)]
Merge remote-tracking branch 'upstream/pull/2579'

2 months agoMerge remote-tracking branch 'upstream/pull/2590'
Tom Hughes [Wed, 15 Apr 2020 14:35:37 +0000 (15:35 +0100)]
Merge remote-tracking branch 'upstream/pull/2590'

2 months agoAdd rubocop-minitest
Andy Allan [Wed, 15 Apr 2020 14:15:52 +0000 (16:15 +0200)]
Add rubocop-minitest

2 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Tue, 14 Apr 2020 03:34:16 +0000 (05:34 +0200)]
Localisation updates from https://translatewiki.net.

2 months agoAdd tile.openstreetmap.org to security policy
Tom Hughes [Mon, 13 Apr 2020 23:03:55 +0000 (00:03 +0100)]
Add tile.openstreetmap.org to security policy

2 months agoUpdate leaflet.osm plugin
Tom Hughes [Mon, 13 Apr 2020 23:01:30 +0000 (00:01 +0100)]
Update leaflet.osm plugin

2 months agoUpdate leaflet.osm plugin
Tom Hughes [Fri, 10 Apr 2020 13:31:31 +0000 (14:31 +0100)]
Update leaflet.osm plugin

2 months agoRemove unsued bootstrap components from Vendorfile
Tom Hughes [Fri, 10 Apr 2020 13:30:54 +0000 (14:30 +0100)]
Remove unsued bootstrap components from Vendorfile

2 months agoRemove arabic strings from en-GB locale
Tom Hughes [Thu, 9 Apr 2020 20:21:09 +0000 (21:21 +0100)]
Remove arabic strings from en-GB locale

2 months agoAdd blob to frame-src in CSP for iD
Tom Hughes [Thu, 9 Apr 2020 17:42:17 +0000 (18:42 +0100)]
Add blob to frame-src in CSP for iD

Fixes #2582
Closes #2583

2 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 9 Apr 2020 14:10:03 +0000 (16:10 +0200)]
Localisation updates from https://translatewiki.net.

2 months agoUpdate bundle
Tom Hughes [Wed, 8 Apr 2020 08:48:42 +0000 (09:48 +0100)]
Update bundle

3 months agoEnsure that urls are only valid if the entire string is a url
Andy Allan [Wed, 1 Apr 2020 15:53:37 +0000 (17:53 +0200)]
Ensure that urls are only valid if the entire string is a url

This replaces our homegrown regexps (that didn't quite work) with
ruby built-in regexps, and uses the termination anchor to ensure
that the entire string, not just the first part, is validated.

3 months agoMerge remote-tracking branch 'upstream/pull/2577'
Tom Hughes [Wed, 1 Apr 2020 10:56:27 +0000 (11:56 +0100)]
Merge remote-tracking branch 'upstream/pull/2577'

3 months agoRemove custom table styling
Andy Allan [Wed, 1 Apr 2020 10:06:36 +0000 (12:06 +0200)]
Remove custom table styling

This removes the custom table styling code, and move to using bootstrap table styling for almost all remaining tables.

3 months agoUpdate leaflet plugins
Tom Hughes [Wed, 1 Apr 2020 08:24:44 +0000 (09:24 +0100)]
Update leaflet plugins

3 months agoMerge remote-tracking branch 'upstream/pull/2574'
Tom Hughes [Wed, 1 Apr 2020 08:18:24 +0000 (09:18 +0100)]
Merge remote-tracking branch 'upstream/pull/2574'

3 months agoFix typo in comment
Simon Legner [Tue, 31 Mar 2020 23:04:58 +0000 (01:04 +0200)]
Fix typo in comment

Closes #2576

3 months agoUpdate leaflet to 1.6.0
Simon Legner [Tue, 31 Mar 2020 22:28:25 +0000 (00:28 +0200)]
Update leaflet to 1.6.0

3 months agoFix new rubocop warnings
Tom Hughes [Tue, 31 Mar 2020 18:08:10 +0000 (19:08 +0100)]
Fix new rubocop warnings

3 months agoUpdate bundle
Tom Hughes [Tue, 31 Mar 2020 18:05:37 +0000 (19:05 +0100)]
Update bundle

3 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Tue, 31 Mar 2020 13:59:29 +0000 (15:59 +0200)]
Localisation updates from https://translatewiki.net.

3 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 26 Mar 2020 15:12:44 +0000 (16:12 +0100)]
Localisation updates from https://translatewiki.net.

3 months agoSet QT_QPA_PLATFORM=offscreen for Ubuntu etc
Tom Hughes [Wed, 25 Mar 2020 17:03:52 +0000 (17:03 +0000)]
Set QT_QPA_PLATFORM=offscreen for Ubuntu etc

Fixes #2569

3 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 23 Mar 2020 14:07:13 +0000 (15:07 +0100)]
Localisation updates from https://translatewiki.net.

3 months agoMake linkify return an HTML safe result for unsafe inputs
Tom Hughes [Sun, 22 Mar 2020 12:47:56 +0000 (12:47 +0000)]
Make linkify return an HTML safe result for unsafe inputs

Fixes #2567

3 months agoFix some untranslateable strings
Tom Hughes [Fri, 20 Mar 2020 17:22:23 +0000 (17:22 +0000)]
Fix some untranslateable strings

Fixes #2565

3 months agoPass I18n argument correctly
Tom Hughes [Fri, 20 Mar 2020 14:58:45 +0000 (14:58 +0000)]
Pass I18n argument correctly

3 months agoFix lego translation with locate control
Tom Hughes [Fri, 20 Mar 2020 14:28:51 +0000 (14:28 +0000)]
Fix lego translation with locate control

Fixes #2564

3 months agoUpdate javascript bundle
Tom Hughes [Thu, 19 Mar 2020 18:26:04 +0000 (18:26 +0000)]
Update javascript bundle

3 months agoUpdate to rails 6.0.2.2
Tom Hughes [Thu, 19 Mar 2020 18:20:26 +0000 (18:20 +0000)]
Update to rails 6.0.2.2

3 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 19 Mar 2020 14:12:49 +0000 (15:12 +0100)]
Localisation updates from https://translatewiki.net.

3 months agoMerge remote-tracking branch 'upstream/pull/2548'
Tom Hughes [Wed, 18 Mar 2020 20:15:06 +0000 (20:15 +0000)]
Merge remote-tracking branch 'upstream/pull/2548'

3 months agoMerge remote-tracking branch 'upstream/pull/2448'
Tom Hughes [Wed, 18 Mar 2020 14:58:06 +0000 (14:58 +0000)]
Merge remote-tracking branch 'upstream/pull/2448'

3 months agoMerge remote-tracking branch 'upstream/pull/2562'
Tom Hughes [Wed, 18 Mar 2020 14:51:15 +0000 (14:51 +0000)]
Merge remote-tracking branch 'upstream/pull/2562'

3 months agoCopy trace fixture files, rather than symlinking
Andy Allan [Wed, 18 Mar 2020 14:35:55 +0000 (15:35 +0100)]
Copy trace fixture files, rather than symlinking

Since we are using tmpdirs in order to enable parallel testing, we
can go the full hog and drop the fakefs too and just copy all the
files directly into the tmpdir. If a test makes changes (e.g.
changing the icon file during an import) the copy in the tmpdir is
thrown away at the end of the test anyway.

3 months agoRemove unused directories
Andy Allan [Wed, 4 Dec 2019 11:45:16 +0000 (12:45 +0100)]
Remove unused directories

3 months agoEnable parallel tests
Andy Allan [Wed, 27 Nov 2019 13:58:36 +0000 (14:58 +0100)]
Enable parallel tests

3 months agoUse unique test directories for each trace test
Andy Allan [Wed, 27 Nov 2019 13:57:49 +0000 (14:57 +0100)]
Use unique test directories for each trace test

This allows tests to be run in parallel, since it avoids deleting
some of the symlinks that other tests expect to be there.

3 months agoUse the settings for the destination of the gpx fixture symlinks
Andy Allan [Wed, 27 Nov 2019 13:01:40 +0000 (14:01 +0100)]
Use the settings for the destination of the gpx fixture symlinks

This lets us change the settings values and have the fixtures appear
in the right place.

3 months agoRemove unnecessary h() calls on model attributes
Andy Allan [Wed, 18 Mar 2020 13:33:30 +0000 (14:33 +0100)]
Remove unnecessary h() calls on model attributes

These were necessary in the rails 2.x era, but not now.

3 months agoMerge remote-tracking branch 'upstream/pull/2561'
Tom Hughes [Wed, 18 Mar 2020 11:15:01 +0000 (11:15 +0000)]
Merge remote-tracking branch 'upstream/pull/2561'

3 months agoUse bootstrap table striping to replace hand-cycled table stripes
Andy Allan [Wed, 18 Mar 2020 10:27:36 +0000 (11:27 +0100)]
Use bootstrap table striping to replace hand-cycled table stripes

This cuts down on the complexity of having to use the `cycle` function
and makes the templates easier to read. CSS-based striping has been
around for many years.

The CSS is in order to keep our custom colour for striped tables.

3 months agoMerge remote-tracking branch 'upstream/pull/2560'
Tom Hughes [Wed, 18 Mar 2020 11:02:07 +0000 (11:02 +0000)]
Merge remote-tracking branch 'upstream/pull/2560'

3 months agoEnable remaining bootstrap components
Andy Allan [Wed, 18 Mar 2020 10:16:03 +0000 (11:16 +0100)]
Enable remaining bootstrap components

Fixes #2511

3 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 16 Mar 2020 14:52:51 +0000 (15:52 +0100)]
Localisation updates from https://translatewiki.net.

3 months agoMerge remote-tracking branch 'upstream/pull/2558'
Tom Hughes [Sat, 14 Mar 2020 15:51:23 +0000 (15:51 +0000)]
Merge remote-tracking branch 'upstream/pull/2558'

3 months agoMoved CSS rule
hikemaniac [Sat, 14 Mar 2020 15:39:21 +0000 (16:39 +0100)]
Moved CSS rule

3 months agoFix border-radius for search query input field
hikemaniac [Sat, 14 Mar 2020 15:06:33 +0000 (16:06 +0100)]
Fix border-radius for search query input field

3 months agoUpdate javascript bundle
Tom Hughes [Sat, 14 Mar 2020 00:39:29 +0000 (00:39 +0000)]
Update javascript bundle

Closes #2557

3 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 12 Mar 2020 18:27:55 +0000 (19:27 +0100)]
Localisation updates from https://translatewiki.net.

3 months agoUpdate bundle
Tom Hughes [Wed, 11 Mar 2020 18:52:39 +0000 (18:52 +0000)]
Update bundle

3 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 9 Mar 2020 15:43:08 +0000 (16:43 +0100)]
Localisation updates from https://translatewiki.net.

4 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 5 Mar 2020 16:37:12 +0000 (17:37 +0100)]
Localisation updates from https://translatewiki.net.

4 months agoUpdate bundle
Tom Hughes [Wed, 4 Mar 2020 18:46:11 +0000 (18:46 +0000)]
Update bundle

4 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 2 Mar 2020 13:51:22 +0000 (14:51 +0100)]
Localisation updates from https://translatewiki.net.

4 months agoEnforce restrictions on issue visibility properly
Tom Hughes [Sun, 1 Mar 2020 19:08:40 +0000 (19:08 +0000)]
Enforce restrictions on issue visibility properly

4 months agoFix eslint warnings
Tom Hughes [Sat, 29 Feb 2020 17:52:55 +0000 (17:52 +0000)]
Fix eslint warnings

4 months agoFix highlight of changesets with no bounding box
Tom Hughes [Sat, 29 Feb 2020 17:43:19 +0000 (17:43 +0000)]
Fix highlight of changesets with no bounding box

A changeset with no bounding box has no map layer so trying to
set it's style throws an exception which means we don't get to
the code to set the style on the list entry.

Fixes #2541

4 months agoRework set_default_request_format ast set_request_formats
Tom Hughes [Sat, 29 Feb 2020 15:15:02 +0000 (15:15 +0000)]
Rework set_default_request_format ast set_request_formats

Instead of trying to work out the exact format, just figure
out the list of allowed formats and let rails do the rest.

4 months agoUpdate rubocop configuration
Tom Hughes [Fri, 28 Feb 2020 22:50:08 +0000 (22:50 +0000)]
Update rubocop configuration

4 months agoUpdate bundle
Tom Hughes [Fri, 28 Feb 2020 22:26:51 +0000 (22:26 +0000)]
Update bundle

4 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 27 Feb 2020 16:19:42 +0000 (17:19 +0100)]
Localisation updates from https://translatewiki.net.

4 months agocss layout change only in content block
Anton Melnichuk [Thu, 27 Feb 2020 08:29:37 +0000 (10:29 +0200)]
css layout change only in content block

4 months agoMerge branch 'master' of github.com:openstreetmap/openstreetmap-website into mobile...
Anton Melnichuk [Thu, 27 Feb 2020 08:15:37 +0000 (10:15 +0200)]
Merge branch 'master' of github.com:openstreetmap/openstreetmap-website into mobile-layout

4 months agorename internal variable
Holger Jeromin [Wed, 26 Feb 2020 19:27:52 +0000 (20:27 +0100)]
rename internal variable

4 months agoMerge pull request #2542 from boubascript/master
Andy Allan [Wed, 26 Feb 2020 16:09:27 +0000 (17:09 +0100)]
Merge pull request #2542 from boubascript/master

Show mailto: links for email values in browse