rails.git
23 months agoDefault to only showing open issues
Tom Hughes [Sun, 10 Jun 2018 18:11:25 +0000 (19:11 +0100)]
Default to only showing open issues

23 months agoImprove system tests for issues
Tom Hughes [Sun, 10 Jun 2018 18:03:33 +0000 (19:03 +0100)]
Improve system tests for issues

23 months agoImprove model tests for issues
Tom Hughes [Sun, 10 Jun 2018 16:59:15 +0000 (17:59 +0100)]
Improve model tests for issues

23 months agoImprove controller tests for issues
Tom Hughes [Sun, 10 Jun 2018 16:48:47 +0000 (17:48 +0100)]
Improve controller tests for issues

23 months agoMake report type a required field
Tom Hughes [Sun, 10 Jun 2018 16:16:33 +0000 (17:16 +0100)]
Make report type a required field

23 months agoMake reportable item titles translatable
Tom Hughes [Sun, 10 Jun 2018 16:05:21 +0000 (17:05 +0100)]
Make reportable item titles translatable

23 months agoMerge branch 'master' into next
Tom Hughes [Sun, 10 Jun 2018 16:02:12 +0000 (17:02 +0100)]
Merge branch 'master' into next

23 months agoUse lazy lookups for translations in issues
Tom Hughes [Sun, 10 Jun 2018 15:03:38 +0000 (16:03 +0100)]
Use lazy lookups for translations in issues

23 months agoAvoid losing filter settings when an invalid user is entered
Tom Hughes [Sun, 10 Jun 2018 14:42:35 +0000 (15:42 +0100)]
Avoid losing filter settings when an invalid user is entered

23 months agoUse select_tag for issue filter fields instead of abusing select
Tom Hughes [Sun, 10 Jun 2018 14:32:27 +0000 (15:32 +0100)]
Use select_tag for issue filter fields instead of abusing select

23 months agoAdd some extra indexes on issues
Tom Hughes [Sun, 10 Jun 2018 14:13:23 +0000 (15:13 +0100)]
Add some extra indexes on issues

23 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 7 Jun 2018 09:23:59 +0000 (11:23 +0200)]
Localisation updates from https://translatewiki.net.

23 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 7 Jun 2018 06:19:03 +0000 (08:19 +0200)]
Localisation updates from https://translatewiki.net.

23 months agoMerge remote-tracking branch 'upstream/pull/1892'
Tom Hughes [Wed, 6 Jun 2018 13:51:30 +0000 (14:51 +0100)]
Merge remote-tracking branch 'upstream/pull/1892'

23 months agoUpdate style for change of name for message controller
Tom Hughes [Wed, 6 Jun 2018 13:45:19 +0000 (14:45 +0100)]
Update style for change of name for message controller

23 months agoMerge remote-tracking branch 'upstream/pull/1893'
Tom Hughes [Wed, 6 Jun 2018 13:33:36 +0000 (14:33 +0100)]
Merge remote-tracking branch 'upstream/pull/1893'

23 months agoMerge remote-tracking branch 'upstream/pull/1894'
Tom Hughes [Wed, 6 Jun 2018 13:30:27 +0000 (14:30 +0100)]
Merge remote-tracking branch 'upstream/pull/1894'

23 months agoMerge remote-tracking branch 'upstream/pull/1895'
Tom Hughes [Wed, 6 Jun 2018 13:28:30 +0000 (14:28 +0100)]
Merge remote-tracking branch 'upstream/pull/1895'

23 months agoAllow iD to access ESRI imagery metadata
Tom Hughes [Wed, 6 Jun 2018 13:25:52 +0000 (14:25 +0100)]
Allow iD to access ESRI imagery metadata

23 months agoUpdate Potlatch 2 to 2.5-37-ga38498b2 build
Tom Hughes [Wed, 6 Jun 2018 13:17:49 +0000 (14:17 +0100)]
Update Potlatch 2 to 2.5-37-ga38498b2 build

23 months agoSpeed up tests by making fewer random changes
Andy Allan [Wed, 6 Jun 2018 05:54:09 +0000 (13:54 +0800)]
Speed up tests by making fewer random changes

The old_node_controller#test_version in particular was slow, since
it saves a huge number of tags when adding a tag 30 times over. Since
the tests are random and not based on the number of iterations, this
reduces the iteration counts.

23 months agoPrefer the helper in controllers
Andy Allan [Wed, 6 Jun 2018 05:34:34 +0000 (13:34 +0800)]
Prefer the  helper in controllers

This avoids future gotchas with conversion to lazy lookups.

23 months agoFix lazy i18n lookups for browse error pages
Andy Allan [Wed, 6 Jun 2018 05:24:01 +0000 (13:24 +0800)]
Fix lazy i18n lookups for browse error pages

`I18n.t` doesn't support lazy lookups, whereas the equivalent
rails `t` helper does. The code can also be simplified to avoid the
lookup table.

Fixes 1877

23 months agoFix missing message translation strings
Andy Allan [Wed, 6 Jun 2018 03:53:05 +0000 (11:53 +0800)]
Fix missing message translation strings

23 months agoRefactor messages show action to be resourceful
Andy Allan [Wed, 6 Jun 2018 03:51:52 +0000 (11:51 +0800)]
Refactor messages show action to be resourceful

23 months agoRefactor inbox and outbox paths to avoid display names in urls.
Andy Allan [Wed, 6 Jun 2018 03:27:27 +0000 (11:27 +0800)]
Refactor inbox and outbox paths to avoid display names in urls.

23 months agoRefactor trace creation pages
Andy Allan [Wed, 6 Jun 2018 02:22:42 +0000 (10:22 +0800)]
Refactor trace creation pages

Split the trace creation into new and create methods, with standard resourceful routing. Provide a redirect for external requests to the old url.

23 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 4 Jun 2018 06:05:07 +0000 (08:05 +0200)]
Localisation updates from https://translatewiki.net.

23 months agoRevert to using ubuntu/xenial64 with virtualbox
Tom Hughes [Fri, 1 Jun 2018 17:26:21 +0000 (18:26 +0100)]
Revert to using ubuntu/xenial64  with virtualbox

The generic/ubuntu1604 box doesn't support the vbox extensions.

23 months agoOnly set QT_QPA_PLATFORM if phantomjs fails without it
Tom Hughes [Thu, 31 May 2018 23:41:29 +0000 (00:41 +0100)]
Only set QT_QPA_PLATFORM if phantomjs fails without it

23 months agoUpdate vagrant configuration
Tom Hughes [Thu, 31 May 2018 21:47:49 +0000 (22:47 +0100)]
Update vagrant configuration

Use a common box for all platforms and fix up various
issues with the provisioning script.

23 months agoSet QT_QPA_PLATFORM to offscreen in the test environment
Tom Hughes [Thu, 31 May 2018 21:46:45 +0000 (22:46 +0100)]
Set QT_QPA_PLATFORM to offscreen in the test environment

Works around an issue with the weird way the debian/ubuntu
version of phantomjs is built:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817277
https://github.com/ariya/phantomjs/issues/14376

23 months agoQuote translations to stop them looking like numbers
Tom Hughes [Mon, 7 May 2018 14:21:50 +0000 (15:21 +0100)]
Quote translations to stop them looking like numbers

23 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 31 May 2018 06:32:14 +0000 (08:32 +0200)]
Localisation updates from https://translatewiki.net.

23 months agoAvoid using inline javascript to update message list
Tom Hughes [Wed, 30 May 2018 14:30:23 +0000 (15:30 +0100)]
Avoid using inline javascript to update message list

23 months agoConcept URIs for Wikidata entities
David Abián [Mon, 28 May 2018 10:29:29 +0000 (12:29 +0200)]
Concept URIs for Wikidata entities

Wikidata entities should be linked using concept URIs, which are
permanent. This is the right way of linking web resources according
to the Linked Data principles.

Closes #1884

23 months agoQuote translations to stop them looking like numbers
Tom Hughes [Mon, 7 May 2018 14:21:50 +0000 (15:21 +0100)]
Quote translations to stop them looking like numbers

23 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 28 May 2018 09:02:50 +0000 (11:02 +0200)]
Localisation updates from https://translatewiki.net.

23 months agoUpdate for final linear-gradient syntax
Tom Hughes [Sun, 27 May 2018 19:48:30 +0000 (20:48 +0100)]
Update for final linear-gradient syntax

23 months agoRemove include of Mixin.Events
Tom Hughes [Sun, 27 May 2018 19:33:54 +0000 (20:33 +0100)]
Remove include of Mixin.Events

The Events mixin has been replaced by inherting from Evented and
the Layer class already inherits from that.

23 months agoUpdate bundle
Tom Hughes [Sun, 27 May 2018 14:51:47 +0000 (15:51 +0100)]
Update bundle

23 months agoChange language immediately after updating settings
J Guthrie [Sun, 27 May 2018 14:12:34 +0000 (15:12 +0100)]
Change language immediately after updating settings

Closes #1883

23 months agoQuote translations to stop them looking like numbers
Tom Hughes [Mon, 7 May 2018 14:21:50 +0000 (15:21 +0100)]
Quote translations to stop them looking like numbers

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Fri, 25 May 2018 09:57:39 +0000 (11:57 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoImprove HOT layer attribution
Benoît [Fri, 25 May 2018 08:39:19 +0000 (10:39 +0200)]
Improve HOT layer attribution

The style is by HOT and the server is provided by OpenStreetMap France.

Closes #1882

2 years agoMerge remote-tracking branch 'upstream/pull/1880'
Tom Hughes [Thu, 24 May 2018 18:06:31 +0000 (19:06 +0100)]
Merge remote-tracking branch 'upstream/pull/1880'

2 years agoWrap the permission label with a <label> tag
Edward Betts [Thu, 24 May 2018 11:49:12 +0000 (12:49 +0100)]
Wrap the permission label with a <label> tag

Gives the user a larger target to toggle a permission.

2 years agoupdate New Zealand copyright based on current attribution instructions from LINZ
Andrew Harvey [Thu, 24 May 2018 09:45:05 +0000 (19:45 +1000)]
update New Zealand copyright based on current attribution instructions from LINZ

2 years agoMerge pull request #1871 from hikemaniac/browse-icon-typo
Andy Allan [Thu, 24 May 2018 03:39:22 +0000 (11:39 +0800)]
Merge pull request #1871 from hikemaniac/browse-icon-typo

Fix a browse icon typo

2 years agoDon't override non-existent policy
Tom Hughes [Wed, 23 May 2018 11:50:10 +0000 (12:50 +0100)]
Don't override non-existent policy

2 years agoUse an empty array for ruby 2.3 compatibility
Tom Hughes [Wed, 23 May 2018 11:21:24 +0000 (12:21 +0100)]
Use an empty array for ruby 2.3 compatibility

Apparently `false.dup` throws in ruby 2.3 and not in 2.5...

2 years agoCompletely remove form-action restrictions for OAuth callbacks
Tom Hughes [Wed, 23 May 2018 11:09:21 +0000 (12:09 +0100)]
Completely remove form-action restrictions for OAuth callbacks

The CSP3 draft only allows a * rule match network schemes and
mobile devices often use callbacks to custom URL schemes.

2 years agoQuote translations to stop them looking like numbers
Tom Hughes [Mon, 7 May 2018 14:21:50 +0000 (15:21 +0100)]
Quote translations to stop them looking like numbers

2 years agoAllow CSP to be put in enforcing mode
Tom Hughes [Tue, 22 May 2018 07:41:13 +0000 (08:41 +0100)]
Allow CSP to be put in enforcing mode

2 years agoUpdate swfobject to use uncompressed source
Tom Hughes [Tue, 22 May 2018 07:40:41 +0000 (08:40 +0100)]
Update swfobject to use uncompressed source

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 21 May 2018 14:16:17 +0000 (16:16 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoAdd missing dependencies
Tom Hughes [Sat, 19 May 2018 10:15:56 +0000 (11:15 +0100)]
Add missing dependencies

2 years agoAllow inline styles in iD
Tom Hughes [Fri, 18 May 2018 19:28:09 +0000 (20:28 +0100)]
Allow inline styles in iD

2 years agoRebase to current master
hikemaniac [Fri, 18 May 2018 11:59:59 +0000 (13:59 +0200)]
Rebase to current master

Merge openstreetmap/openstreetmap-website into hikemaniac/openstreetmap-website

2 years agoUse XHR instead of jsonp for GraphHopper
Peter Karich [Thu, 17 May 2018 19:47:58 +0000 (20:47 +0100)]
Use XHR instead of jsonp for GraphHopper

Closes #1872

2 years agoUpdate for rubocop 0.54.0
Tom Hughes [Thu, 17 May 2018 18:39:25 +0000 (19:39 +0100)]
Update for rubocop 0.54.0

2 years agoUpdate bundle
Tom Hughes [Thu, 17 May 2018 18:25:58 +0000 (19:25 +0100)]
Update bundle

2 years agoConfigure manifest-src and worker-src in security policy
Tom Hughes [Thu, 17 May 2018 18:10:39 +0000 (19:10 +0100)]
Configure manifest-src and worker-src in security policy

2 years agoPreserve schemes in security policy
Tom Hughes [Thu, 17 May 2018 18:10:23 +0000 (19:10 +0100)]
Preserve schemes in security policy

2 years agoQuote translations to stop them looking like numbers
Tom Hughes [Thu, 17 May 2018 17:37:52 +0000 (18:37 +0100)]
Quote translations to stop them looking like numbers

2 years agoQuote translations to stop them looking like numbers
Tom Hughes [Mon, 7 May 2018 14:21:50 +0000 (15:21 +0100)]
Quote translations to stop them looking like numbers

2 years agoConvert note view to use server side conditions
Tom Hughes [Thu, 17 May 2018 10:29:28 +0000 (11:29 +0100)]
Convert note view to use server side conditions

Fixes #1869

2 years agoAdd piwik to allowed URIs in connect-src
Tom Hughes [Thu, 17 May 2018 10:29:06 +0000 (11:29 +0100)]
Add piwik to allowed URIs in connect-src

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 17 May 2018 06:36:19 +0000 (08:36 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoRemove unsafe-inline form default style policy
Tom Hughes [Wed, 16 May 2018 19:40:55 +0000 (20:40 +0100)]
Remove unsafe-inline form default style policy

2 years agoRemove some inline styles
Tom Hughes [Wed, 16 May 2018 19:27:35 +0000 (20:27 +0100)]
Remove some inline styles

2 years agoMerge remote-tracking branch 'upstream/pull/1866'
Tom Hughes [Wed, 16 May 2018 17:57:34 +0000 (18:57 +0100)]
Merge remote-tracking branch 'upstream/pull/1866'

2 years agoAllow iD to access wikidata
Tom Hughes [Wed, 16 May 2018 10:36:46 +0000 (11:36 +0100)]
Allow iD to access wikidata

2 years agoRevert "Remove unused POST method for message replies"
Tom Hughes [Wed, 16 May 2018 09:43:26 +0000 (10:43 +0100)]
Revert "Remove unused POST method for message replies"

This reverts commit 40cab845fbabb3f0aa8131c16e48cd3d58b6dcb3.

2 years agoAllow iD to access wikipedia
Tom Hughes [Wed, 16 May 2018 07:48:38 +0000 (08:48 +0100)]
Allow iD to access wikipedia

2 years agoRemove if_user and similar methods
Andy Allan [Wed, 16 May 2018 05:05:20 +0000 (13:05 +0800)]
Remove if_user and similar methods

Rather than hiding features based on CSS, just avoid including them
in the output. Fixes #1862

2 years agoFix test which was accidentally testing as the entry user twice
Andy Allan [Wed, 16 May 2018 04:59:16 +0000 (12:59 +0800)]
Fix test which was accidentally testing as the entry user twice

2 years agoFix a browse icon typo.
hikemaniac [Tue, 15 May 2018 18:05:40 +0000 (20:05 +0200)]
Fix a browse icon typo.

2 years agoMerge remote-tracking branch 'upstream/pull/1863'
Tom Hughes [Tue, 15 May 2018 17:36:55 +0000 (18:36 +0100)]
Merge remote-tracking branch 'upstream/pull/1863'

2 years agoTell jshint about bowser
Tom Hughes [Tue, 15 May 2018 13:42:05 +0000 (14:42 +0100)]
Tell jshint about bowser

2 years agoUse https to launch the remote editor except for modern browsers
Tom Hughes [Tue, 15 May 2018 13:08:57 +0000 (14:08 +0100)]
Use https to launch the remote editor except for modern browsers

Currently only Chrome 53+ and Firefox 55+ are known to support loading
of http resources from localhost for an https page.

2 years agoDefault frame-src to self
Tom Hughes [Tue, 15 May 2018 13:08:44 +0000 (14:08 +0100)]
Default frame-src to self

2 years agoAdd frame-src to allow http://127.0.0.1:8111
Tom Hughes [Tue, 15 May 2018 11:43:37 +0000 (12:43 +0100)]
Add frame-src to allow http://127.0.0.1:8111

2 years agoEnsure database is writable before destroying a message
Andy Allan [Tue, 15 May 2018 10:28:33 +0000 (18:28 +0800)]
Ensure database is writable before destroying a message

2 years agoRename messages#read to #show
Andy Allan [Tue, 15 May 2018 10:25:54 +0000 (18:25 +0800)]
Rename messages#read to #show

Also rename the named path, to align with resourceful routing

2 years agoRename messages#delete to destroy
Andy Allan [Tue, 15 May 2018 10:03:15 +0000 (18:03 +0800)]
Rename messages#delete to destroy

This is a better fit for rails controller method conventions, paving
the way to resourceful routing. Keep user-facing strings as 'delete'
since that's more commonly used.

2 years agoRemove unused POST method for message replies
Andy Allan [Tue, 15 May 2018 09:33:40 +0000 (17:33 +0800)]
Remove unused POST method for message replies

This action just shows the pre-filled form, with the target for
the form being the same as for new messages.

2 years agoUpgrade community index to 0.4.3 to fix issue with tirana polygon
Bryan Housel [Tue, 15 May 2018 00:35:29 +0000 (20:35 -0400)]
Upgrade community index to 0.4.3 to fix issue with tirana polygon

2 years agoUpdate to iD v2.8.2
Bryan Housel [Mon, 14 May 2018 21:55:32 +0000 (17:55 -0400)]
Update to iD v2.8.2

2 years agoMerge remote-tracking branch 'upstream/pull/1858'
Tom Hughes [Mon, 14 May 2018 19:14:56 +0000 (20:14 +0100)]
Merge remote-tracking branch 'upstream/pull/1858'

2 years agoMerge remote-tracking branch 'upstream/pull/1857'
Tom Hughes [Mon, 14 May 2018 19:13:41 +0000 (20:13 +0100)]
Merge remote-tracking branch 'upstream/pull/1857'

2 years agoQuote translations to stop them looking like numbers
Tom Hughes [Mon, 7 May 2018 14:21:50 +0000 (15:21 +0100)]
Quote translations to stop them looking like numbers

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 14 May 2018 06:24:58 +0000 (08:24 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoMake CSP rule for the remote control explicitly allow http
Tom Hughes [Sun, 13 May 2018 15:01:39 +0000 (16:01 +0100)]
Make CSP rule for the remote control explicitly allow http

2 years agoMerge remote-tracking branch 'upstream/pull/1851'
Tom Hughes [Sun, 13 May 2018 14:24:44 +0000 (15:24 +0100)]
Merge remote-tracking branch 'upstream/pull/1851'

2 years agoMerge remote-tracking branch 'upstream/pull/1850'
Tom Hughes [Sun, 13 May 2018 14:23:54 +0000 (15:23 +0100)]
Merge remote-tracking branch 'upstream/pull/1850'

2 years agoQuote translations to stop them looking like numbers
Tom Hughes [Mon, 7 May 2018 14:21:50 +0000 (15:21 +0100)]
Quote translations to stop them looking like numbers

2 years agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 10 May 2018 08:28:45 +0000 (10:28 +0200)]
Localisation updates from https://translatewiki.net.

2 years agoRename message_controller to messages_controller
Andy Allan [Wed, 9 May 2018 08:38:37 +0000 (16:38 +0800)]
Rename message_controller to messages_controller

2 years agoLazy lookups for translations in message_controller.rb
Andy Allan [Wed, 9 May 2018 08:25:42 +0000 (16:25 +0800)]
Lazy lookups for translations in message_controller.rb